Re: [PATCH v3 3/6] can: c_can: fix control interface used by c_can_do_tx

2021-03-02 Thread Kurt Van Dijck
On Sun, 28 Feb 2021 11:38:52 +0100, Dario Binacchi wrote: > According to commit 640916db2bf7 ("can: c_can: Make it SMP safe") let RX use > IF1 (i.e. IF_RX) and TX use IF2 (i.e. IF_TX). > > Signed-off-by: Dario Binacchi > --- > > (no changes since v1) > > drivers/net/can/c_can/c_can.c | 2 +- >

Re: [PATCH v3 5/6] can: c_can: prepare to up the message objects number

2021-03-02 Thread Kurt Van Dijck
On Sun, 28 Feb 2021 11:38:54 +0100, Dario Binacchi wrote: > Date: Sun, 28 Feb 2021 11:38:54 +0100 > From: Dario Binacchi > To: linux-ker...@vger.kernel.org > Cc: Federico Vaga , Alexander Stein > , Dario Binacchi > , "David S. Miller" , Jakub > Kicinski , Marc Kleine-Budde , Oliver > Hartkop

Re: [PATCH] can: j1939: convert PGN structure to a table

2020-10-22 Thread Kurt Van Dijck
On Thu, 22 Oct 2020 12:33:45 +0200, Marc Kleine-Budde wrote: > On 10/22/20 12:29 PM, yegorsli...@googlemail.com wrote: > > From: Yegor Yefremov > > > > Use table markup to show the PGN structure. > > > > Signed-off-by: Yegor Yefremov > > --- > > Documentation/networking/j1939.rst | 12

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-22 Thread Kurt Van Dijck
On ma, 22 jun 2020 14:54:15 +0200, Marc Kleine-Budde wrote: > On 6/22/20 2:43 PM, Kurt Van Dijck wrote: > > I get RX-0: FIFO overflows in listen-only mode (back-to-back burst of > > the single other node). > > Single other node? Who's ACKing the CAN frames? he

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-22 Thread Kurt Van Dijck
arded against load. Kurt On ma, 22 jun 2020 14:30:31 +0200, Kurt Van Dijck wrote: > > On ma, 22 jun 2020 12:55:41 +0200, Marc Kleine-Budde wrote: > > On 6/22/20 12:25 PM, Kurt Van Dijck wrote: > > > I got my board up with a 5.7, despite device-tree problems completely > >

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-22 Thread Kurt Van Dijck
vger.kernel.org > Subject: Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 > Thunderbird/68.9.0 > > On 6/22/20 12:25 PM, Kurt Van Dijck wrote: > > I got my board up with a 5.7, despite device-tree problems comp

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-22 Thread Kurt Van Dijck
Hey Marc, On do, 18 jun 2020 14:35:28 +0200, Marc Kleine-Budde wrote: > On 6/18/20 2:30 PM, Kurt Van Dijck wrote: > > On do, 18 jun 2020 00:36:29 +0200, Marc Kleine-Budde wrote: > >> On 6/17/20 6:59 PM, Kurt Van Dijck wrote: > >>> I'm in the process of gettin

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-18 Thread Kurt Van Dijck
On do, 18 jun 2020 00:36:29 +0200, Marc Kleine-Budde wrote: > On 6/17/20 6:59 PM, Kurt Van Dijck wrote: > > I'm in the process of getting a Variscite imx8m mini SOM online, with > > Have your heard about the imx8m plus? It has CAN cores! We have a board in the &

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-17 Thread Kurt Van Dijck
On do, 11 jun 2020 18:26:19 +0200, Marc Kleine-Budde wrote: > On 6/10/20 9:44 AM, Manivannan Sadhasivam wrote: > > Hello, > > > > This series adds CAN network driver support for Microchip MCP25XXFD CAN > > Controller with MCP2517FD as the target controller version. This series is > > mostly inspir

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-08-01 Thread Kurt Van Dijck
> Hi Kurt, > > On 07/28/2017 09:41 PM, Kurt Van Dijck wrote: > > >>The transceiver is an analog device that needs to support faster > >>switching frequency (FETs) including minimizing delay to support CAN-FD > >>ie higher bitrate. From the transceiver pe

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-28 Thread Kurt Van Dijck
> > On 07/28/2017 01:33 PM, Oliver Hartkopp wrote: > > Hi Kurt, > > > > On 07/28/2017 03:02 PM, Kurt Van Dijck wrote: > > > >>>> The word 'max-arbitration-bitrate' makes the difference very clear. > >>> > >>> I thi

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-28 Thread Kurt Van Dijck
> > On 07/28/2017 06:57 AM, Kurt Van Dijck wrote: > > >So while _a_ transceiver may be spec'd to 1MBit during arbitration, > >CAN FD packets may IMHO exceed that speed during data phase. > > When the bitrate is limited to 1Mbit/s you are ONLY allowed to use 1

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-27 Thread Kurt Van Dijck
> > On 07/27/2017 01:47 PM, Oliver Hartkopp wrote: > > On 07/26/2017 08:29 PM, Franklin S Cooper Jr wrote: > >> > > > >> I'm fine with switching to using bitrate instead of speed. Kurk was > >> originally the one that suggested to use the term arbitration and data > >> since thats how the spec r

Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate

2017-07-26 Thread Kurt Van Dijck
looks way more clear to me. That's my opinion. The important things, like the contents of the functions, look good. Kind regards, Kurt Van Dijck

Re: CAN-FD Transceiver Limitations

2017-06-30 Thread Kurt Van Dijck
> On 06/29/2017 05:36 PM, Kurt Van Dijck wrote: > >>>> > >>>> mcan@0 { > >>>> ... > >>>> fixed-transceiver { > >>>>max-canfd-speed = <2000> > >>>> }; > >>>> ... > >&g

Re: CAN-FD Transceiver Limitations

2017-06-29 Thread Kurt Van Dijck
> >> > >> mcan@0 { > >>... > >>fixed-transceiver { > >> max-canfd-speed = <2000> > >>}; > >>... > >> }; Since when would a transceiver support different speeds for CAN & CANFD? No transceivers were available, but they are now. I see no datalink problem applying 2MBit for r

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-08 Thread Kurt Van Dijck
--- Original message --- > Date: Mon, 8 Aug 2016 14:28:39 +0200 > From: Wolfgang Grandegger > [...] > >>>+ > >>>+ if (!(cf->can_id & CAN_RTR_FLAG)) { > >>>+ writel(data[0], &cf_buf->data[0]); > >>>+ writel(data[1], &cf_buf->data[1]); > >> > >>Why do you not check cf->can_dlc h