> 200 checkpatch changes in one commit?
>
> imo it makes sense to fix coding style only if nearby lines are
> affected by meaningful changes.
> Just blank rewrites like these are more harmful than useful.
> They distort git blame, make backporting harder, etc.
I'll keep that in mind, thank you.
> From: Krzysztof Majzerowicz-Jaszcz
> Date: Tue, 15 Sep 2015 20:36:29 +0200
>
>> OK, sorry. I'll undo the comments then. Do you have any other
>> suggestions?
>
> I think even the non-comment changes make the code look less nice.
>
> Why don't you j
OK, sorry. I'll undo the comments then. Do you have any other suggestions?
KMJ
On 15/09/15 20:22, Eric W. Biederman wrote:
> Krzysztof Majzerowicz-Jaszcz writes:
>
>> Fixed most coding style issues reported by checkpatch.pl
>
> Ugh. At least in the matter of comments
Fixed most coding style issues reported by checkpatch.pl
Signed-off-by: Krzysztof Majzerowicz-Jaszcz
---
net/core/sock.c | 442 +---
1 file changed, 200 insertions(+), 242 deletions(-)
diff --git a/net/core/sock.c b/net/core/sock.c
index
Fixed coding style issues reported by checkpatch.pl
Signed-off-by: Krzysztof Majzerowicz-Jaszcz
---
net/core/stream.c | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/net/core/stream.c b/net/core/stream.c
index d70f77a..c089589 100644
--- a/net/core
Fixed coding style issues reported by checkpatch.pl
Signed-off-by: Krzysztof Majzerowicz-Jaszcz
---
net/core/stream.c | 29 -
1 file changed, 16 insertions(+), 13 deletions(-)
diff --git a/net/core/stream.c b/net/core/stream.c
index d70f77a..f169de8 100644
--- a/net
Fixed several coding style issues reported by checkpatch.pl
Signed-off-by: Krzysztof Majzerowicz-Jaszcz
---
net/core/datagram.c | 89 ++---
1 file changed, 51 insertions(+), 38 deletions(-)
diff --git a/net/core/datagram.c b/net/core/datagram.c
