[PATCH] Marvell Sky2 Ethernet adapter: fix warning messages.

sky2.c driver uses netdev_warn() before the net device is initialized. Fix it by using dev_warn() instead. Signed-off-by: Krzysztof Halasa --- a/drivers/net/ethernet/marvell/sky2.c +++ b/drivers/net/ethernet/marvell/sky2.c @@ -4806,12 +4806,11 @@ static struct net_device *sky2_init_netdev

Re: [PATCH v5 0/6] firmware_loader: cleanups for v4.18

nothing depends on it (nor the other way around), it's just (with the rest of the wanXL code) an old piece of a driver for an old card. The question is, what do we gain by messing with it? -- Krzysztof Halasa

Re: [PATCH v5 0/6] firmware_loader: cleanups for v4.18

iginal QUICC) processor. Maximum bit rate of 2 Mb/s on each sync serial port. It's more about delivering the .S source for the firmware, I guess. Nobody is expected to build it. The fw is about 2.5 KB and is directly linked with the driver. -- Krzysztof Halasa

Re: [PATCH] Carrier detect ok, don't turn off negotiation

I don't know. Perhaps I could look at this later, but no promises (this requires pulling on and setting up some legacy hardware). Anyway, since the patch is safe and can solve an existing problem: Acked-by: Krzysztof Halasa -- Krzysztof Halasa

Re: [PATCH] wanxl: use m68k-linux-gnu-as if available

. I don't have opinion on the patch. -- Krzysztof Halasa

Re: [PATCH 13/31] timer: Remove meaningless .data/.function assignments

Kees Cook writes: > Several timer users needlessly reset their .function/.data fields during > their timer callback, but nothing else changes them. Some users do not > use their .data field at all. Each instance is removed here. For *wan/hdlc* Acked-by: Krzysztof Halasa > --- a

Re: E1000 (PCI-E) doesn't work on nforce430, MSI issue.

"Kok, Auke" <[EMAIL PROTECTED]> writes: >>> Don't work by default. "pci=nomsi" fixes the problem. > > actually does not fix anything - it just works around it by falling > back to legacy interrupts. Actually it does, fixes the problem by working

E1000 (PCI-E) doesn't work on nforce430, MSI issue.

Corporation MCP51 Memory Controller 0 (rev a3) 00:10.0 PCI bridge: nVidia Corporation MCP51 PCI Bridge (rev a2) Additional details on request. -- Krzysztof Halasa -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majord

[PATCH 3/3] Generic HDLC - use random_ether_addr()

Generic HDLC now uses random_ether_addr() for generating MAC addresse for Ethernet-alike interfaces. Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/drivers/net/wan/hdlc_fr.c b/drivers/net/wan/hdlc_fr.c index 071a64c..7926842 100644 --- a/drivers/net/wan/hdlc_fr.c +++ b/d

[PATCH 2/3] Generic HDLC - remove now unneeded hdlc_device_desc

Removes now unneeded struct hdlc_device_desc Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/drivers/net/wan/hdlc.c b/drivers/net/wan/hdlc.c index d553e6f..39951d0 100644 --- a/drivers/net/wan/hdlc.c +++ b/drivers/net/wan/hdlc.c @@ -1,7 +1,7 @@ /* * Generic HDLC s

[PATCH 1/3] Generic HDLC - fix kernel panic

Fixes kernel panic in Frame Relay mode Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/drivers/net/wan/hdlc_fr.c b/drivers/net/wan/hdlc_fr.c index 7926842..327b218 100644 --- a/drivers/net/wan/hdlc_fr.c +++ b/drivers/net/wan/hdlc_fr.c @@ -135,6 +135,10 @@ typedef

[WAN] Generic HDLC - three patches

. PPP (hdlc_ppp using syncppp) is still broken (by the same change as FR), I guess the correct fix now is rewriting syncppp (for hdlc_ppp use). No ETA :-( Tested in action. -- Krzysztof Halasa -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message

Re: netdev->priv and netdev_priv(dev)

ed, that's it. I'm fine with its removal, is it ok? The trivial "return dev->priv" isn't worth it anyway. -- Krzysztof Halasa -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] netdev->priv and netdev_priv(dev)

ur. Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -584,7 +584,10 @@ struct net_device static inline void *netdev_priv(const struct net_device *dev) { - return dev->priv; + return (char *)dev + ((

netdev->priv and netdev_priv(dev)

) - & ~NETDEV_ALIGN_CONST); + return dev->priv; } This change caused some problems for drivers which used netdev_priv(dev) and dev->priv for different purposes. The following patch restores previous behaviour. Signed-off-by: Krzysztof Halasa <[EM

Re: [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice

64) (sys_ioctl+0x0/0x64) from (ret_fast_syscall+0x0/0x2c) The patch would make it deadlock. Please note that sister fr_add_pvc() uses register_netdevice(). The same applies to fr_destroy(). -- Krzysztof Halasa -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body

Re: [PATCH 34/59] drivers/net/wan: Add missing "space"

t) { > - printk(KERN_WARNING "wanXL %s: timeout while initializing card" > + printk(KERN_WARNING "wanXL %s: timeout while initializing card " > "firmware\n", pci_name(pdev)); > wanxl_pci_remove_one(pdev)

Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable of keeping it

y all packets as they are received (including tags) is a really nice thing. But maybe we should change the model? Making the ethX only carry untagged frames (even without hw VLAN acceleration)? -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable of keeping it

such packets on RX. Anyway we shouldn't forward them. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] wan: new driver retina

+ case 0x60: > + return 'M'; > + case 0xa0: > + return 'G'; > + default: > + return 0; > + } > +} Are you sure you really want this? > +int print_line_type(unsigned char type, char *buf, int pos) > +{

Ath5k panic fix

Ath5k panics on ath_open() because sc->pdev is never set, fixed. Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> --- a/drivers/net/wireless/ath5k_base.c +++ b/drivers/net/wireless/ath5k_base.c @@ -2295,6 +2295,7 @@ static int __devinit ath_pci_probe(struct pci_dev *pdev, hw-

Re: Fwd: That whole "Linux stealing our code" thing

rrent file] WRT Atheros driver I'd probably leave the thing as is (i.e., BSD/GPL = in fact BSD), unless something like 50+% of the code is rewritten - it's mostly their hard work after all, isn't it? Not legal requirement, though. -- Krzysztof Halasa - To unsubscribe from this list: s

Re: netdevice queueing / sendmsg issue?

hus run the scheduled > software interrupt. Problem solved, stupid user mistake. I was using netif_start_queue() instead of netif_wake_queue(). -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordo

Re: netdevice queueing / sendmsg issue?

ler, so the main suspect is soft IRQ processing. Should be easy now. Thanks. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

netdevice queueing / sendmsg issue?

"TX queue full" (IOW max 15 skb being transmitted), 25561 allows for "TX queue full". 25560 = 16 * 1597.5. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Linux, tcpdump and vlan

idging VLAN trunks is, of course, theoretically possible, but it's rather not a common operation when using .1Q. That is, with header reordering, of course. Anyway, -ENOPATCH from me for now. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe

Re: Linux, tcpdump and vlan

hat's trivial and minor. IOW: I think all Ethernet interfaces should always be VLAN-aware, stripping the tag (only one) early on RX and adding it late on TX. That means tcpdump would see packets with exactly one tag removed (unless there was no tag), in both RX and TX. Tcpdump would need

Re: Linux, tcpdump and vlan

. Anything different is crazy. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Linux, tcpdump and vlan

would have to be modified. Seems a bit of work, I know my message is missing the patch... -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Linux, tcpdump and vlan

ould certainly be useful. > > Only in promiscuous mode. In some sense tag is part of the mac address. Well, in "some sense" maybe, though the MAC address is rather strictly defined to be a 6-octet value. I can live with promiscous anyway, it's really minor issue. -- Krzysztof Hal

Re: Linux, tcpdump and vlan

ing unknown tags on master device (with tcpdump etc) would certainly be useful. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Linux, tcpdump and vlan

t only goes through logical interfaces and doesn't show up on master? Probably with exception of invalid VLANs, which could be injected back to master (because no logical device exists)? -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in t

Re: [PATCH 2.6.21.1] nfs-root: added possibility to override default MTU (for UDP jumbo frames)

Added a kernel parameter named 'ipmtu' which can be used to specify > initial MTU size when booting via nfsroot. Isn't the whole IP autoconfig and NFS root set to die? Why not do it in initramfs? -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netd

Re: forcedeth: Reside in 100Mbit Kconfig but also supports 1000Mbit cards

could check for PCI, ISA and what not. This way each driver has only one entry, but if you know you have, say, 1 Gb/s Ethernet card only you can select 1 Gb/s and don't worry about 100-Mbps NVidias. I'd include that Tulip thing, too - no need for a separate menu (the directory is a diff

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

point but I hope we can do that "data coherency mode" right. Personally I'd be pleased if I could run the board LE instead of BE, with no performance penalty. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

work with IXP4xx CPU and that's not the typical endianess problem cross-platform drivers sometimes have. There is different functionality required with LE mode, unless some other arch changes are implemented (which I'm now researching, if I have some time of course). -- Krzysztof Halasa -

Re: default y idiocy

James Bottomley <[EMAIL PROTECTED]> writes: > drivers/ata/Kconfig has a select SCSI at the top, so if you selected > modular ATA, you'll be forced to have modular SCSI. Or built-in. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev&quo

Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR

running on (which is a desirable property, IMHO), which is > something that you can't achieve with an allocator, as far as I can > see. I'd have to put SRAM address in the board code instead. Certainly not required at this point, and perhaps it will be never needed. -- Krzysztof Hal

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

t; about (LE vs BE; 30% performance hit on LE, more, or less)? Haven't checked yet but I'd expect something like that. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

that LE thing then, and (at best) put that trivial workaround? -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

FREE3_QUEUE 4 #define HSS1_PKT_TXDONE_QUEUE 9 >> Without them the code in question is hardly readable, > > You can read Polish, how can you complain about code readability. :-)) Well, you may have the point, but I also care about others :-) -- Krzysztof Halasa - To unsubscribe from thi

Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR

to compile in everything (perhaps as modules). > If you want that guarantee, then you > might as well determine the SRAM map at compile time. That would be most limiting with IMHO no visible advantage. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe n

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

tree and only then improve them. Doing all the work in a single step is just impossible, the target moves way too fast (at least for my limited time budget). -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PR

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

Debian as well. Simple automated process it seems, for most part at least. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

ts in the register you > are modifying might have side-effects. Without them the code in question is hardly readable, I pick the need to remember about non-atomicity and possible side effects instead :-) I've outlined the current versions in a separate mail, generally 2 patches are marked &q

Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR

even by Intel) - 7 queues * 128 entries each = ~ 3.5 KB. Add 2 long queues (RX) for HSS and something for TX, and then crypto, and maybe other things. Current allocator have its potential problems, but they can be solved internally (fragmentation, be we tend to use only 128-entry queues (RX a

Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR

ne QUEUE_IRQ_SRC_NOT_NEARLY_EMPTY 5 >> +#define QUEUE_IRQ_SRC_NOT_NEARLY_FULL 6 >> +#define QUEUE_IRQ_SRC_NOT_FULL 7 > > Here, unlike ixp4xx_npe.c defines are in qmgr.h - that seems a bit > more natural. Because they are public interface :-) -- Krzysztof

Re: [PATCH] Intel IXP4xx network drivers v.2 - NPE

ey are private to the .c file and I don't want to make them available to the public (but sure, I don't like them in .c either, I think nobody likes such definitions anywhere but they have to exist somewhere). -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubs

Re: [PATCH 3/3] Intel IXP4xx network drivers

Lennert Buytenhek <[EMAIL PROTECTED]> writes: > I have a couple of ixp23xx boards at home, but I'm not sure whether I > can give them away. I can give you remote access to them, though. Hmm, may be interesting some day. -- Krzysztof Halasa - To unsubscribe from this li

Re: [PATCH 0/3] Intel IXP4xx network drivers

eeds "fuses" patch [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS You guessed it, needs all of the above. The: [PATCH] Intel IXP4xx network drivers v.2 - QMGR was faulty, thus v.3. Fire again :-) -- Krzysztof Halasa - To unsubscribe from this list: send the lin

[PATCH] Intel IXP4xx network drivers v.3 - QMGR

Adds a driver for built-in IXP4xx hardware Queue Manager. Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/arch/arm/mach-ixp4xx/Kconfig b/arch/arm/mach-ixp4xx/Kconfig index 9715ef5..71ef55f 100644 --- a/arch/arm/mach-ixp4xx/Kconfig +++ b/arch/arm/mach-ixp4xx/Kconfig @@

[PATCH] Intel IXP4xx network drivers v.2 - NPE

Adds a driver for built-in IXP4xx Network Processor Engines. This patch requires IXP4xx Queue Manager driver and the "fuses" patch. Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/arch/arm/mach-ixp4xx/Kconfig b/arch/arm/mach-ixp4xx/Kconfig index 71ef55f..25f8

[PATCH] Intel IXP4xx network drivers v.2

Adds a driver for IXP4xx built-in hardware queue manager. Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/arch/arm/mach-ixp4xx/Kconfig b/arch/arm/mach-ixp4xx/Kconfig index 9715ef5..71ef55f 100644 --- a/arch/arm/mach-ixp4xx/Kconfig +++ b/arch/arm/mach-ixp4xx/Kconfig @@

[PATCH 1a/3] WAN Kconfig: change "depends on HDLC" to "select"

Allow enabling WAN drivers without selecting generic HDLC first, HDLC will be selected automatically. Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> --- linux/drivers/net/wan/Kconfig 2007-05-07 22:46:06.0 +0200 +++ linux/drivers/net/wan/Kconfig 2007-05-07

[PATCH] Use menuconfig objects II - netdev/wan

From: Jan Engelhardt <[EMAIL PROTECTED]> Change Kconfig objects from "menu, config" into "menuconfig" so that the user can disable the whole feature without having to enter the menu first. Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> Signed-off-by: Kr

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

get some coffee. There is still a very good reason for the select. CONFIG_HDLC _is_ a simple library, though probably not the most simple one. I really feel it's an improvement. Attaching two patches, hopefully the double check is enough. -- Krzysztof Halasa - To unsubscribe from this list:

Re: [PATCH 3/3] Intel IXP4xx network drivers

to make it a donation for science? :-) -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] Intel IXP4xx network drivers

to carry out the specific firmware-dependent > tasks. Actually, the NPE code does two things: a) initialized NPEs and downloades the firmware b) exchanges control messages with NPEs. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] Intel IXP4xx network drivers

still be exposed in arch/arm/mach- > ixp4xx/Kconfig Why exactly? They are network devices, who would expect them there? How about the dependency mess (NET_ETHERNET etc.) that would be created? -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev&qu

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

Roman Zippel <[EMAIL PROTECTED]> writes: > HDLC doesn't really look like simple library code, what's up with all the > HDLC_* options? Sub-modules. Anyway, what does the patch "screw" exactly? -- Krzysztof Halasa - To unsubscribe from this list: send the line

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

an have HDLC=y and driver=m (and it makes perfect sense). Actually I can't see any bad idea here. The original dependency was certainly, uhm, not the best one. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2a/3] Intel IXP4xx network drivers

Adds "fuse" functions to help determine installed IXP4xx CPU components and to reset/disable/enable them (only NPE - network coprocessors - can be reset and reenabled). Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/include/asm-arm/arch-ixp4xx/ixp4xx-regs.h b

Re: [PATCH 2/3] ARM: include IXP4xx "fuses" support

Hello, "Alexey Zaytsev" <[EMAIL PROTECTED]> writes: > #ifndef __ASSEMBLY__ > >> +static inline u32 ixp4xx_read_fuses(void) Oops. You're right, of course. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

Roman Zippel <[EMAIL PROTECTED]> writes: > What's the advantage? The HDLC option is directly before this? You don't have to know it's required, you can just select a driver for your hardware, without enabling HDLC first. -- Krzysztof Halasa - To unsubscribe from

[PATCH 2/3] ARM: include IXP4xx "fuses" support

Adds "fuse" functions to help determine installed IXP4xx CPU components and to reset/disable/enable them (only NPE - network coprocessors - can be reset and reenabled). Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/include/asm-arm/arch-ixp4xx/ixp4xx-regs.h b

[PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

Allow enabling WAN drivers without selecting generic HDLC first, HDLC will be selected automatically. Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig index 8897f53..3a2fe82 100644 --- a/drivers/net/wan/Kconfig +++ b/drive

[PATCH 0/3] Intel IXP4xx network drivers

ivers/net/ixp4xx/ixp4xx_npe.c | 731 + drivers/net/ixp4xx/ixp4xx_qmgr.c | 273 +++ drivers/net/ixp4xx/npe.h | 41 + drivers/net/ixp4xx/qmgr.h | 124 +++ drivers/net/wan/Kconfig | 10 include/asm-arm/a

Re: [PATCH 23/36] Use menuconfig objects II - netdev/wan

]> > > --- > drivers/net/wan/Kconfig | 34 +++++++--- Looks good. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [stable] 2.6.21 known regressions (v2) (for -stable team)

ur tty USB devices. I don't know how udev (or anything) could help here. AFAIK the converters have no serial numbers and no other means to differentiate. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTE

Generic HDLC sparse annotations

Sparse annotations, including two minor bugfixes. Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/drivers/net/wan/hdlc_cisco.c b/drivers/net/wan/hdlc_cisco.c index c9664fd..a7a12d6 100644 --- a/drivers/net/wan/hdlc_cisco.c +++ b/drivers/net/wan/hdlc_cisco.c @@ -37,16

Re: [Bugme-new] [Bug 8107] New: dev->header_cache_update has a random value

less EXPORT_SYMBOL(s). It would fix all such problems forever. Compile-tested only but it seems pretty obvious and of course I check if the packets still flow after regular kernel upgrades (and I run automatic tests checking all protos except X.25 from time to time as well). (the patch is in the next

Re: [Bugme-new] [Bug 8107] New: dev->header_cache_update has a random value

Switching HDLC devices from Ethernet-framing mode caused stale ethernet function assignments within net_device. Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/drivers/net/wan/hdlc.c b/drivers/net/wan/hdlc.c index db354e0..f6e6b63 100644 --- a/drivers/net/wan/hdlc.c

Re: [Bugme-new] [Bug 8107] New: dev->header_cache_update has a random value

F_NOARP; > dev->addr_len = 0; > _ ACK, I think it's the best place. Is it OK to leave this (and hard_header_cache) set to random value if dev->hard_header = NULL (as with other protocols)? -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net/wan/pc300too.c: pci_module_init to pci_register_driver

__init pc300_init_module(void) > > CLOCK_BASE = use_crystal_clock ? 24576000 : pci_clock_freq; > > - return pci_module_init(&pc300_pci_driver); > + return pci_register_driver(&pc300_pci_driver); > } > > > -- Krzysztof Halasa - To unsubscribe

Re: PC300too alternative WAN driver

Jeff Garzik <[EMAIL PROTECTED]> writes: > Please make sure to provides updates ensuring that it passes sparse > checks (see Documentation/sparse.txt) Ok. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

PC300too alternative WAN driver

The attached patch adds an alternative driver "pc300too" for PCI WAN cards PC300/RSV and PC300/X21 made by Cyclades Corp. (now Avocent Corp). Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig index 21f76f5..f07a

Re: [Fwd: Re: wan/pc300 bug found]

uld I? It supports (at least theoretically) multi line PPP and PC300 T1/E1, my drivers don't. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH -MM] e1000: rewrite hardware initialization code

rs/net/e1000/e1000_82571.c | 1132 > drivers/net/e1000/e1000_82571.h | 42 Perhaps the "e1000_" prefix could be dropped as redundant? -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTE

Re: Broken commit: [NETFILTER]: ipt_REJECT: remove largely duplicate route_reverse function

Krzysztof Halasa <[EMAIL PROTECTED]> writes: > I wound't care less btw. s/wound/couldn/, eh those foreign languages... -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More

Re: Broken commit: [NETFILTER]: ipt_REJECT: remove largely duplicate route_reverse function

Jarek Poplawski <[EMAIL PROTECTED]> writes: > And if we talk about names: > > + Spotted by Krzysztof Halasa. I wound't care less btw. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PRO

Re: Broken commit: [NETFILTER]: ipt_REJECT: remove largely duplicate route_reverse function

ing data to header space, perhaps tacking devices doesn't count as the skb is being linearized in dev->hard_start_xmit() or equivalent path? -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Broken commit: [NETFILTER]: ipt_REJECT: remove largely duplicate route_reverse function

didates are: -A INPUT -p tcp --tcp-flags SYN,RST,ACK SYN -j REJECT --reject-with tcp-reset -A INPUT -p udp -j REJECT --reject-with icmp-port-unreachable Other "REJECT" rules haven't fired yet. Could be some obscure problem with GRE/Speedtouch/PPP over ATM, triggered by this patch, thoug

Broken commit: [NETFILTER]: ipt_REJECT: remove largely duplicate route_reverse function

476fd64, len=512 Redzone: 0x5a2cf071/0x5a2cf071. Last user: [](kfree_skbmem+0x8/0x80) and so on. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [2.6 patch] make hdlc_setup() static again

Adrian Bunk <[EMAIL PROTECTED]> writes: > It's still not used... > > So let's unexport it again until some driver that actually uses it shows up. Fair enough. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the bo

Re: [Fwd: Re: wan/pc300 bug found]

ver to the tree, mark the old one as obsolete and look for angry reports from T1/E1 users? My driver(s) doesn't support MLPPP but that's probably easy to change if there is any interest. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev&qu

[PATCH] WAN: DSCC4 driver requires generic HDLC

s safe to apply. Thanks. Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig index b5d0d7f..d5ab9cf 100644 --- a/drivers/net/wan/Kconfig +++ b/drivers/net/wan/Kconfig @@ -57,44 +57,6 @@ config COSA The driver will be comp

Re: [PATCH 1/2] Modularize generic HDLC - now signed-off

Jeff Garzik <[EMAIL PROTECTED]> writes: > applied 1-2 Thanks. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Generic HDLC update

Jeff, The first patch renames drivers/net/wan/hdlc_generic.c file to hdlc.c. It has been generated with git-diff* -M. Please let me know if you need a "normal" patch. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

[PATCH 2/2] Make PC300 WAN driver compile again

This patch removes accesses to the HDLC-internal data structures from pc300 driver, thus enabling it to compile but breaking part of its functionality. Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/drivers/net/wan/pc300_drv.c b/drivers/net/wan/pc300_drv.c index 5

Generic HDLC update

ase apply both patches to Linux 2.6. Thanks. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: 2.6.18-rc5 with GRE, iptables and Speedtouch ADSL, PPP over ATM

{ > - netif_tx_lock_bh(dev); > __netdev_watchdog_up(dev); > - netif_tx_unlock_bh(dev); > } > > static void dev_watchdog_down(struct net_device *dev) Many thanks for looking into this. The lockdep warning is gone now. -- Krzysztof Halasa -- VGER BF report:

Re: 2.6.18-rc5 with GRE, iptables and Speedtouch ADSL, PPP over ATM

ile Celeron P3). I have to admit this machine has a history of mysterious hangs (black screen of death), though I think they are related to LAN and maybe disk activity, not GRE/PPP/ATM/ADSL (RAM tests ok, the hardware is rather common - i440BX etc. but who knows). -- Krzysztof Halasa -- VGER

2.6.18-rc5 with GRE, iptables and Speedtouch ADSL, PPP over ATM

[] netif_receive_skb+0x15e/0x1e0 [] process_backlog+0x82/0x110 [] net_rx_action+0x72/0x120 [] __do_softirq+0x55/0xc0 [] do_softirq+0x63/0xd0 === [] irq_exit+0x35/0x40 [] do_IRQ+0x8f/0xf0 [] common_interrupt+0x25/0x2c [] cpu_idle+0x39/0x50 [] rest_init+0x1e/0x30 [] start_ke

2.6.18-rc5 + pata-drivers on MSI K9N Ultra report, AMD64

Slot: Number 0, PowerLimit 0.00 Slot: Enabled AtnBtn- PwrFlt- MRL- PresDet- CmdCplt- HPIrq- Slot: AttnInd Off, PwrInd On, Power- Root: Correctable- Non-Fatal- Fatal- PME- -- Krzysztof Halasa -- VGER BF report: U 0.5 - To unsubscribe from this

Re: [PATCH][REPOST] WAN: fix C101 card carrier handling

or 2.6.18. Great, I somehow missed it. Thank you. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH][REPOST] WAN: fix C101 card carrier handling

Hi, One of my recent changes broke C101 carrier handling, this patch fixes it. Also fixes an old TX underrun checking bug. 2.6.18 material. Please apply. Thanks. Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/drivers/net/wan/c101.c b/drivers/net/wan/c101.c index 4

Re: [RFC][PATCH 50/75] net: drivers/net/wan/pci200syn.c pci_module_init to pci_register_driver conversion

Krzysztof Halasa <[EMAIL PROTECTED]> writes: > Ok. Rozumiem, ze Jeff zrobi to w jednym, duzym batchu? Oops, hit the wrong key. Ok WRT both patches and assume Jeff will apply this all-at-once. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev&q

Re: [RFC][PATCH 50/75] net: drivers/net/wan/pci200syn.c pci_module_init to pci_register_driver conversion

to w jednym, duzym batchu? -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] WAN: fix C101 card carrier handling

Hi, One of my recent changes broke C101 carrier handling, this patch fixes it. Also fixes an old TX underrun checking bug. 2.6.18 material. Please apply. Thanks. Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/drivers/net/wan/c101.c b/drivers/net/wan/c101.c index 4

Re: forcedeth gigabit detection

's a different version, something like A7N8X-E? -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

  1   2   >