Re: [PATCH net v2] drivers/net/wan/hdlc_fr: Add needed_headroom for PVC devices

Xie He writes: > The HDLC device is not actually prepending any header when it is used > with this driver. When the PVC device has prepended its header and > handed over the skb to the HDLC device, the HDLC device just hands it > over to the hardware driver for transmission without prepending any

Re: [PATCH net] drivers/net/wan/hdlc_cisco: Add hard_header_len

Hello Xie, Xie He writes: > This driver didn't set hard_header_len. This patch sets hard_header_len > for it according to its header_ops->create function. BTW it's 4 bytes long: struct hdlc_header { u8 address; u8 control; __be16 protocol; }__packed; OTOH hdlc_setup_de

Re: [PATCH] net: Use dma_pool_zalloc()

Souptick Joarder writes: > Any comment for this patch. I thought something like this was already aplied. Acked-by: Krzysztof Halasa > On Fri, Feb 16, 2018 at 9:58 PM, Souptick Joarder > wrote: >> Use dma_pool_zalloc() instead of dma_pool_alloc + memset >> >> Signed-off-by: Souptick Joarder

Re: [PATCH 4.9.0-rc5] AR9300 calibration problems with antenna selected

miaoq...@codeaurora.org writes: >> rmmod ath9k >> modprobe ath9k >> iw dev wlan0 set type ibss >> iw phy phyX set antenna 2 > > 2 is a bad mask. We use bitmap, the valid masks are 1, 3, 7. Thanks for your response. I have two antenna connections (and a single antenna). Is it possible to select t

[PATCH 4.9.0-rc5] AR9300 calibration problems with antenna selected

Hi, I recently tried to select a single antenna on AR9300 and it works for 30 seconds only. The subsequent calibration makes the RX signal level to drop from the usual -30/-40 dBm to -70/-80 dBm, and the transmission practically stops. With the attached patch it works, though selecting the antenn

Re: [PATCH net-next 3/6] net: use core MTU range checking in WAN drivers

Jarod Wilson writes: > - set min/max_mtu in all hdlc drivers, remove hdlc_change_mtu > - sent max_mtu in lec driver, remove lec_change_mtu > drivers/net/wan/c101.c| 1 - > drivers/net/wan/hdlc.c| 11 ++- > drivers/net/wan/hdlc_fr.c | 3 ++- > drivers/ne

Re: Aw: BUG: Wrong dma queue handling in ixp4 driver

Hi Lino, "Lino Sanfilippo" writes: >> maybe I miss something, but the ixp4 ethernet driver seems to handle dma >> pools >> in a wrong way: In init_queues() it creates a dma pool for descriptors and >> then >> only allocates a single descriptor from this pool. The author seems to >> assume t

Re: [PATCH] I.MX6: Fix Ethernet PHY mode on Ventana boards

David Miller writes: > Since this only touched DT files in the ARM platform code, maybe > the ARM tree is the best path for this patch rather than mine? I think so. Tim, would you like to handle this patch yourself, or should I send it to the ARM contacts? -- Krzysztof Halasa Industrial Resea

Re: [PATCH] I.MX6: Fix Ethernet PHY mode on Ventana boards

Tim Harvey writes: > It sounds like your saying this controls whether the phy is in charge > of delay vs the MAC. I have never needed to set this and haven't found > where its actually used (in at least 4.3). Is this caused by something > new in the kernel I haven't seen yet or is it possible you

[PATCH] I.MX6: Fix Ethernet PHY mode on Ventana boards

. This bug affects ARM Fedora 23. Signed-off-by: Krzysztof Hałasa diff --git a/arch/arm/boot/dts/imx6q-gw5400-a.dts b/arch/arm/boot/dts/imx6q-gw5400-a.dts index 822ffb2..6c168dc 100644 --- a/arch/arm/boot/dts/imx6q-gw5400-a.dts +++ b/arch/arm/boot/dts/imx6q-gw5400-a.dts @@ -154,7 +154,7 @@

Re: [PATCH] ixp4xx_hss: Delete an unnecessary check before the function call "dma_pool_destroy"

SF Markus Elfring writes: > The dma_pool_destroy() function tests whether its argument is NULL > and then returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > --- a/drivers/net/wan/ixp4xx_hss.c > +++ b/drivers/net/wan/i

Re: [PATCH] ixp4xx_eth: Delete an unnecessary check before the function call "dma_pool_destroy"

SF Markus Elfring writes: > The dma_pool_destroy() function tests whether its argument is NULL > and then returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > --- a/drivers/net/ethernet/xscale/ixp4xx_eth.c > +++ b/drive