Re: [Resend RFC PATCH V2 09/12] swiotlb: Add bounce buffer remap address setting function

2021-04-15 Thread Konrad Rzeszutek Wilk
On Wed, Apr 14, 2021 at 10:49:42AM -0400, Tianyu Lan wrote: > From: Tianyu Lan > > For Hyper-V isolation VM with AMD SEV SNP, the bounce buffer(shared memory) > needs to be accessed via extra address space(e.g address above bit39). > Hyper-V code may remap extra address space outside of swiotlb.

Re: [Resend RFC PATCH V2 07/12] HV/Vmbus: Initialize VMbus ring buffer for Isolation VM

2021-04-15 Thread Konrad Rzeszutek Wilk
On Wed, Apr 14, 2021 at 10:49:40AM -0400, Tianyu Lan wrote: > From: Tianyu Lan > > VMbus ring buffer are shared with host and it's need to > be accessed via extra address space of Isolation VM with > SNP support. This patch is to map the ring buffer > address in extra address space via ioremap().

Re: [Resend RFC PATCH V2 06/12] HV/Vmbus: Add SNP support for VMbus channel initiate message

2021-04-15 Thread Konrad Rzeszutek Wilk
On Wed, Apr 14, 2021 at 10:49:39AM -0400, Tianyu Lan wrote: > From: Tianyu Lan > > The physical address of monitor pages in the CHANNELMSG_INITIATE_CONTACT > msg should be in the extra address space for SNP support and these What is this 'extra address space'? Is that just normal virtual address

Re: [Resend RFC PATCH V2 04/12] HV: Add Write/Read MSR registers via ghcb

2021-04-15 Thread Konrad Rzeszutek Wilk
On Wed, Apr 14, 2021 at 10:49:37AM -0400, Tianyu Lan wrote: > From: Tianyu Lan > > Hyper-V provides GHCB protocol to write Synthetic Interrupt > Controller MSR registers and these registers are emulated by > Hypervisor rather than paravisor. What is paravisor? Is that the VMPL0 to borrow AMD spe

Re: [PATCH RFC UEK5 2/7] bpf: Restrict bpf when kernel lockdown is in confidentiality mode

2020-10-20 Thread Konrad Rzeszutek Wilk
On Tue, Oct 20, 2020 at 04:59:59PM -0400, Konrad Rzeszutek Wilk wrote: > bpf_read() and bpf_read_str() could potentially be abused to (eg) allow > private keys in kernel memory to be leaked. Disable them if the kernel > has been locked down in confidentiality mode. > > Sugge

[PATCH RFC UEK5 2/7] bpf: Restrict bpf when kernel lockdown is in confidentiality mode

2020-10-20 Thread Konrad Rzeszutek Wilk
it. If the default lockdown mode (confidentiality) is on then we don't allow it.] Signed-off-by: Konrad Rzeszutek Wilk --- security/lock_down.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/security/lock_down.c b/security/lock_down.c index 96ff1bad

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-06-11 Thread Konrad Rzeszutek Wilk
On Thu, Jun 11, 2020 at 07:34:19AM -0400, Michael S. Tsirkin wrote: > As testing shows no performance change, switch to that now. What kind of testing? 100GiB? Low latency?

Re: [PATCH net-next 3/3] vhost: access vq metadata through kernel virtual address

2018-12-13 Thread Konrad Rzeszutek Wilk
.giant snip.. > > + npinned = get_user_pages_fast(uaddr, npages, write, pages); > > + if (npinned != npages) > > + goto err; > > + > > As I said I have doubts about the whole approach, but this > implementation in particular isn't a good idea > as it keeps the page around forever. >

Re: [RFC V3 PATCH 0/8] Packed ring for vhost

2018-04-23 Thread Konrad Rzeszutek Wilk
On Mon, Apr 23, 2018 at 10:59:43PM +0300, Michael S. Tsirkin wrote: > On Mon, Apr 23, 2018 at 03:31:20PM -0400, Konrad Rzeszutek Wilk wrote: > > On Mon, Apr 23, 2018 at 01:34:52PM +0800, Jason Wang wrote: > > > Hi all: > > > > > > This RFC implement packed ri

Re: [RFC V3 PATCH 0/8] Packed ring for vhost

2018-04-23 Thread Konrad Rzeszutek Wilk
On Mon, Apr 23, 2018 at 01:34:52PM +0800, Jason Wang wrote: > Hi all: > > This RFC implement packed ring layout. The code were tested with > Tiwei's RFC V2 a thttps://lkml.org/lkml/2018/4/1/48. Some fixups and > tweaks were needed on top of Tiwei's code to make it run. TCP stream > and pktgen does

Re: [RFC PATCH V2 0/8] Packed ring for vhost

2018-03-26 Thread Konrad Rzeszutek Wilk
On Mon, Mar 26, 2018 at 11:38:45AM +0800, Jason Wang wrote: > Hi all: > > This RFC implement packed ring layout. The code were tested with pmd > implement by Jens at > http://dpdk.org/ml/archives/dev/2018-January/089417.html. Minor change > was needed for pmd codes to kick virtqueue since it assum

Re: [PATCH 08/44] xen-swiotlb: implement ->mapping_error

2017-06-10 Thread Konrad Rzeszutek Wilk
On Thu, Jun 08, 2017 at 03:25:33PM +0200, Christoph Hellwig wrote: > DMA_ERROR_CODE is going to go away, so don't rely on it. Reviewed-by: Konrad Rzeszutek Wilk

Re: [PATCH 07/44] xen-swiotlb: consolidate xen_swiotlb_dma_ops

2017-06-10 Thread Konrad Rzeszutek Wilk
--- > drivers/xen/swiotlb-xen.c | 93 > ++ > include/xen/swiotlb-xen.h | 62 +--- > 4 files changed, 49 insertions(+), 137 deletions(-) Yeeey! Reviewed-by: Konrad Rzeszutek Wilk

Re: [PATCH 16/22] xen-blkfront: Make use of the new sg_map helper function

2017-04-18 Thread Konrad Rzeszutek Wilk
On Tue, Apr 18, 2017 at 09:42:20AM -0600, Logan Gunthorpe wrote: > > > On 18/04/17 08:27 AM, Konrad Rzeszutek Wilk wrote: > > Interesting that you didn't CC any of the maintainers. Could you > > do that in the future please? > > Please read the cover lette

Re: [PATCH 16/22] xen-blkfront: Make use of the new sg_map helper function

2017-04-18 Thread Konrad Rzeszutek Wilk
On Tue, Apr 18, 2017 at 02:13:59PM +, David Laight wrote: > From: Logan Gunthorpe > > Sent: 13 April 2017 23:05 > > Straightforward conversion to the new helper, except due to > > the lack of error path, we have to warn if unmapable memory > > is ever present in the sgl. Interesting that you d

Re: [Xen-devel] xennet_start_xmit assumptions

2017-01-18 Thread Konrad Rzeszutek Wilk
On Wed, Jan 18, 2017 at 10:31:32AM -0500, Sowmini Varadhan wrote: > As I was playing around with pf_packet, I accidentally wrote > a buggy application program that bzero'ed the msghdr, then set > up the msg_name, msg_namelen correctly, and then did a sendmsg > on the pf_packet/SOCK_RAW fd. > > Thi

Re: [swiotlb PATCH v3 0/3] Add support for DMA writable pages being writable by the network stack.

2016-11-09 Thread Konrad Rzeszutek Wilk
On Wed, Nov 09, 2016 at 10:19:57AM -0500, Alexander Duyck wrote: > This patch series is a subset of the patches originally submitted with the > above patch title. Specifically all of these patches relate to the > swiotlb. > > I wasn't sure if I needed to resubmit this series or not. I see that v

Re: [mm PATCH v2 03/26] swiotlb: Add support for DMA_ATTR_SKIP_CPU_SYNC

2016-11-05 Thread Konrad Rzeszutek Wilk
.. snip.. > @@ -561,6 +565,7 @@ void swiotlb_tbl_unmap_single(struct device *hwdev, > phys_addr_t tlb_addr, >* First, sync the memory before unmapping the entry >*/ > if (orig_addr != INVALID_PHYS_ADDR && > + !(attrs & DMA_ATTR_SKIP_CPU_SYNC) && > ((dir == D

Re: [mm PATCH v2 01/26] swiotlb: Drop unused functions swiotlb_map_sg and swiotlb_unmap_sg

2016-11-03 Thread Konrad Rzeszutek Wilk
On Thu, Nov 03, 2016 at 07:14:46AM -0700, Christoph Hellwig wrote: > On Wed, Nov 02, 2016 at 07:12:31AM -0400, Alexander Duyck wrote: > > There are no users for swiotlb_map_sg or swiotlb_unmap_sg so we might as > > well just drop them. > > FYI, I sent the same patch already on Sep, 11 and Konrad a

Re: [net-next PATCH 02/27] swiotlb-xen: Enforce return of DMA_ERROR_CODE in mapping function

2016-10-28 Thread Konrad Rzeszutek Wilk
> > If we are returning DMA_ERROR_CODE as our error value we can drop the > function for checking the error code as the default is to compare the > return value against DMA_ERROR_CODE if no function is defined. > > Cc: Konrad Rzeszutek Wilk I am pretty sure I gave an Ack. Any particular

Re: [net-next PATCH 03/27] swiotlb: Add support for DMA_ATTR_SKIP_CPU_SYNC

2016-10-28 Thread Konrad Rzeszutek Wilk
> heavily makes use of the functionality. > > Cc: Konrad Rzeszutek Wilk I am pretty sure I acked it the RFC. Was there a particular reason (this is very different from the RFC?) you dropped my ACk? Thanks. > Signed-off-by: Alexander Duyck > --- > drivers/xen/swiotlb-xen.c |

Re: [net-next PATCH RFC 01/26] swiotlb: Drop unused function swiotlb_map_sg

2016-10-24 Thread Konrad Rzeszutek Wilk
On Mon, Oct 24, 2016 at 08:04:31AM -0400, Alexander Duyck wrote: > There are no users for swiotlb_map_sg so we might as well just drop it. > > Cc: Konrad Rzeszutek Wilk Acked-by: Konrad Rzeszutek Wilk Thought I swear I saw a familiar patch by Christopher Hellwig at some point.. but m

Re: [net-next PATCH RFC 02/26] swiotlb: Add support for DMA_ATTR_SKIP_CPU_SYNC

2016-10-24 Thread Konrad Rzeszutek Wilk
> heavily makes use of the functionality. > > Cc: Konrad Rzeszutek Wilk > Signed-off-by: Alexander Duyck > --- > drivers/xen/swiotlb-xen.c | 40 ++ > include/linux/swiotlb.h |6 -- >

Re: [Xen-devel] [PATCH v2 net-next 2/7] xen-netback: retire guest rx side prefix GSO feature

2016-10-04 Thread Konrad Rzeszutek Wilk
On Tue, Oct 04, 2016 at 01:35:41PM +, Paul Durrant wrote: > > -Original Message- > > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > > Sent: 04 October 2016 13:52 > > To: Paul Durrant ; annie...@oracle.com; > > joao.m.mart...@oracle.com >

Re: [Xen-devel] [PATCH v2 net-next 2/7] xen-netback: retire guest rx side prefix GSO feature

2016-10-04 Thread Konrad Rzeszutek Wilk
On Tue, Oct 04, 2016 at 10:29:13AM +0100, Paul Durrant wrote: > As far as I am aware only very old Windows network frontends make use of > this style of passing GSO packets from backend to frontend. These > frontends can easily be replaced by the freely available Xen Project > Windows PV network fr

Re: [Xen-devel] [PATCH v2 net-next 4/7] xen-netback: immediately wake tx queue when guest rx queue has space

2016-10-04 Thread Konrad Rzeszutek Wilk
On Tue, Oct 04, 2016 at 02:29:15AM -0700, Paul Durrant wrote: > From: David Vrabel > > When an skb is removed from the guest rx queue, immediately wake the > tx queue, instead of after processing them. Please, could the description explain why? > > Signed-off-by: David Vrabel > [re-based] > S

Re: [Xen-devel] [PATCH v2 net-next 5/7] xen-netback: process guest rx packets in batches

2016-10-04 Thread Konrad Rzeszutek Wilk
On Tue, Oct 04, 2016 at 10:29:16AM +0100, Paul Durrant wrote: > From: David Vrabel > > Instead of only placing one skb on the guest rx ring at a time, process > a batch of up-to 64. This improves performance by ~10% in some tests. And does it regress latency workloads? What are those 'some tes

Re: [Xen-devel] [PATCHv1 net] xen-netback: require fewer guest Rx slots when not using GSO

2015-09-09 Thread Konrad Rzeszutek Wilk
On Tue, Sep 08, 2015 at 02:25:14PM +0100, David Vrabel wrote: > Commit f48da8b14d04ca87ffcffe68829afd45f926ec6a (xen-netback: fix > unlimited guest Rx internal queue and carrier flapping) introduced a > regression. > > The PV frontend in IPXE only places 4 requests on the guest Rx ring. in IPXE ?

Re: [GIT] Networking

2015-09-08 Thread Konrad Rzeszutek Wilk
On Tue, Sep 8, 2015 at 10:14 PM, Konrad Rzeszutek Wilk wrote: > > (Removed Linus and Andrew from the To, added Corinna ..) and resending again without HTML (sorry, thought I had HTML-emails disabled by default) > > On Thu, Sep 3, 2015 at 1:35 AM, David Miller wrote: >> &

Re: [Xen-devel] [PATCH v2] xen-apic: Enable on domU as well

2015-08-07 Thread Konrad Rzeszutek Wilk
apic->send_IPI_self = xen_send_IPI_self; 959 #endif Anyhow, your patch seems to fix a regression my patch feb44f1f7a4ac299d1ab1c3606860e70b9b89d69 "x86/xen: Provide a "Xen PV" APIC driver to support >255 VCPUs" introdu

Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-17 Thread Konrad Rzeszutek Wilk
17af099e3cee2b219ab28ffc1e96b0564b213 Mon Sep 17 00:00:00 2001 From: Konrad Rzeszutek Wilk Date: Fri, 17 Apr 2015 14:55:47 -0400 Subject: [PATCH] config: Enable NEED_DMA_MAP_STATE when SWIOTLB is selected A huge amount of NIC drivers use the DMA API, however if compiled under 32-bit an very important par