[PATCH 5/5] ath10k: Removed unused 'dev' in ath10k_ahb_resource_init

h10k/ahb.c:449:17: warning: variable ‘dev’ set but not used [-Wunused-but-set-variable] This is a harmless warning, and is only being fixed to reduce the noise with W=1 in the kernel. Fixes: 704dc4e36769 ("ath10k: add resource init and deinit in ahb") Cc: Raja Mani Cc: Kalle Valo Si

[PATCH 3/5] ath10k: Remove unused wmi_p2p_noa_descriptor 'noa' in wmi-tlv

n function ‘ath10k_wmi_tlv_op_gen_vdev_start’: drivers/net/wireless/ath/ath10k/wmi-tlv.c:1647:33: warning: variable ‘noa’ set but not used [-Wunused-but-set-variable] Fixes: ca996ec56608 ("ath10k: implement wmi-tlv backend") Cc: Michal Kazior Cc: Kalle Valo Signed-off-by: Kirtika Ruchanda

[PATCH 2/5] ath10k: Remove unused 'num_vdev_stats' variable

warnings and are only being fixed to reduce the noise with W=1 in the kernel. Fixes: d15fb5200664 ("ath10k: split wmi stats parsing") Fixes: 20de2229c634 ("ath10k: fix 10.2 fw stats parsing") Cc: Michal Kazior Cc: Kalle Valo Signed-off-by: Kirtika Ruchandani --- drivers/net/wirel

[PATCH 4/5] ath10k: Removed unused 'dev' in ath10k_ahb_clock_enable()

/ahb.c:133:17: warning: variable ‘dev’ set but not used [-Wunused-but-set-variable] This is a harmless warning, and is only being fixed to reduce the noise with W=1 in the kernel. Fixes: 8beff219c528("ath10k: add clock ctrl related functions in ahb") Cc: Raja Mani Cc: Kalle Valo Si

[PATCH 0/5] Fix -Wunused-but-set-variable in ath10k/

This patchset is part of the effort led by Arnd Bergmann to clean up warnings in the kernel. This and following patchsets will focus on "-Wunused-but-set-variable" as it among the noisier ones. These were found compiling with W=1. Kirtika Ruchandani (5): ath10k: Remove unused 'bu

[PATCH 1/5] ath10k: Remove unused 'buf_len' variable

zior Cc: Kalle Valo Signed-off-by: Kirtika Ruchandani --- drivers/net/wireless/ath/ath10k/wmi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index 387c4ee..1f28187 100644 --- a/drivers/net/wireless/ath/ath10k/wmi

[PATCH] adm80211: Removed unused 'io_addr' 'mem_addr' variables

") Cc: Michael Wu Cc: John W. Linville Signed-off-by: Kirtika Ruchandani --- drivers/net/wireless/admtek/adm8211.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/admtek/adm8211.c b/drivers/net/wireless/admtek/adm8211.c index 70ecd82..70b4da0 10

[PATCH 3/4] mac80211: Removed unused 'struct ieee80211_supported_band*' variable

to reduce the noise with W=1 in the kernel. Fixes: b1bce14a7954 ("mac80211: update opmode when adding new station") Cc: Marek Kwaczynski Cc: Johannes Berg Signed-off-by: Kirtika Ruchandani --- net/mac80211/vht.c | 4 1 file changed, 4 deletions(-) diff --git a/net/mac80211/vht.c

[PATCH 4/4] mac80211: Remove unused 'beaconint_us' variable

7: warning: variable ‘beaconint_us’ set but not used [-Wunused-but-set-variable] iee80211_tu_to_usec has no side-effects and is safe to remove. Fixes: 4a733ef1bea7 ("mac80211: remove PM-QoS listener") Cc: Johannes Berg Signed-off-by: Kirtika Ruchandani --- net/mac80211/mlme.c | 4 ---

[PATCH 1/4] mac80211: Removed unused 'i' variable

c: Michal Kazior Cc: Johannes Berg Signed-off-by: Kirtika Ruchandani --- net/mac80211/chan.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/mac80211/chan.c b/net/mac80211/chan.c index e75cbf6..7550fd2 100644 --- a/net/mac80211/chan.c +++ b/net/mac80211/chan.c @@ -1270

[PATCH 2/4] mac80211: Remove unused 'len' variable

Bondar Cc: Johannes Berg Signed-off-by: Kirtika Ruchandani --- net/mac80211/scan.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/net/mac80211/scan.c b/net/mac80211/scan.c index 23d8ac8..faab3c4 100644 --- a/net/mac80211/scan.c +++ b/net/mac80211/scan.c @@ -1120,7 +112

[PATCH 0/4] Fix -Wunused-but-set-variable in net/mac80211/

This patchset is part of the effort led by Arnd Bergmann to clean up warnings in the kernel. This and following patchsets will focus on "-Wunused-but-set-variable" as it among the noisier ones. These were found compiling with W=1. Kirtika Ruchandani (4): mac80211: Removed unused &#

[PATCH] mac80211: Remove unused 'struct rate_control_ref' variable

‘ref’ set but not used [-Wunused-but-set-variable] Fixes: 3b17fbf87d5d ("mac80211: mesh: Add support for HW RC implementation") Cc: Johannes Berg Cc: Maxim Altshul Signed-off-by: Kirtika Ruchandani --- net/mac80211/sta_info.c | 4 1 file changed, 4 deletions(-) diff --git a/net

[PATCH] mac80211: Remove unused 'rates_idx' variable

unused-but-set-variable] This is a harmless warning, and is only being fixed to reduce the noise generated with W=1. Fixes: f027c2aca0cf ("mac80211: add ieee80211_tx_status_noskb") Cc: Johannes Berg Cc: Felix Fietkau Signed-off-by: Kirtika Ruchandani --- net/mac80211/status.c | 3 +-

[PATCH] mac80211: Remove unused 'struct ieee80211_rx_status' ptr

t not used [-Wunused-but-set-variable] Fixes: 554891e63a29 ("mac80211: move packet flags into packet") Cc: Johannes Berg Cc: John W. Linville Signed-off-by: Kirtika Ruchandani --- net/mac80211/rx.c | 4 1 file changed, 4 deletions(-) diff --git a/net/mac80211/rx.c b/net/mac8021

[PATCH] net/wireless: Fix 'multiple blank lines' check

This patch fixes the checkpatch.pl check "Please don't use multiple blank lines" for all files in net/wireless, except nl80211.c which is covered in a separated patch. Signed-off-by: Kirtika Ruchandani --- net/wireless/ap.c | 1 - net/wireless/chan.c| 3 --- net/

Re: [PATCH v2 03/10] nl80211: Prefer ether_addr_copy

> This looks right to me, but doesn't ether_addr_copy() have alignment > requirements? Could someone more familiar with that review these > changes to ensure they're met? Thanks for catching this. The requirement is to be __aligned(2). I've added 4 instances of ether_addr_copy with 8 addresses as

Re: [PATCH v2 06/10] nl80211: Various checkpatch.pl spacing fixes

> Adding the brackets around the & expression doesn't look spacing > related to me. What's the exact warning this is fixing? >From the commit message - "This patch also contains two hunks to fix 'line over 80 characters', that are spacing related". This is the second hunk, the first being the comm

[PATCH v2 08/10] nl80211: Fix spelling

Fix 'implementation' spelling, reported by checkpatch.pl Signed-off-by: Kirtika Ruchandani --- net/wireless/nl80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 6f8e2a7..c6d870e 100644 --- a/net/wireless

[PATCH v2 10/10] nl80211: Prefer kcalloc over kzalloc

This patch fixes the checkpatch.pl warning - "prefer kcalloc over kzalloc with multiply" Signed-off-by: Kirtika Ruchandani --- net/wireless/nl80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 46757af..2964

[PATCH v2 09/10] nl80211: Fix checkpatch.pl warning

This patch fixes the checkpatch.pl warning "foo * bar should be foo *bar" Signed-off-by: Kirtika Ruchandani --- net/wireless/nl80211.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index c6d870e..46757af 100644

[PATCH v2 07/10] nl80211: Avoid multiple assignments on same line

This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Kirtika Ruchandani --- net/wireless/nl80211.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index ad7cdce..6f8e

[PATCH v2 06/10] nl80211: Various checkpatch.pl spacing fixes

hunks to fix 'line over 80 characters', that are spacing related. All other instances of that warning have been ignored. Signed-off-by: Kirtika Ruchandani --- net/wireless/nl80211.c | 103 ++--- 1 file changed, 54 insertions(+), 49 deletions(-)

[PATCH v2 05/10] nl80211: Fix checkpatch.pl NULL comparison warning

This patch fixes the warning - "comparison to NULL (foo == NULL) could be written as (!foo)" Signed-off-by: Kirtika Ruchandani --- net/wireless/nl80211.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c ind

[PATCH v2 03/10] nl80211: Prefer ether_addr_copy

This patch fixes the checkpatch,pl to prefer ether_addr_copy over memcpy. Signed-off-by: Kirtika Ruchandani --- net/wireless/nl80211.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index cd422bd..34b8fbe 100644 --- a

[PATCH v2 04/10] nl80211: Fix checkpatch.pl warning about braces

This patch fixes the following checkpatch,pl warning - - braces {} should be used on all arms of this statement. Signed-off-by: Kirtika Ruchandani --- net/wireless/nl80211.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/net/wireless/nl80211.c b/net

[PATCH v2 02/10] nl80211: Fix checkpatch warnings about blank lines

This patch fixes the following checkpatch.pl issues - - Please don't use multiple blank lines - Blank lines aren't necessary before a close brace - Missing a blank line after declarations Reviewed-by: Julian Calaby Signed-off-by: Kirtika Ruchandani --- net/wireless/nl80

[PATCH v2 01/10] nl80211: Fix checkpatch warnings

This patch fixes the following checkpatch.pl warnings about comments in nl80211.c : - networking block comments don't use an empty '/*' line - block comments use a trailing '*/' on a separate line Reviewed-by: Julian Calaby Signed-off-by: Kirtika Ruchandani --- net

[PATCH v2 00/10] nl80211: Fix checkpatch.pl issues

ignment should match open parenthesis'. Some of them do not display correctly with git diff. This patch-set removes 3 errors, 66 warnings and 46 checks. Kirtika Ruchandani (10): nl80211: Fix checkpatch warnings nl80211: Fix checkpatch warnings about blank lines nl80211: Prefer ether_addr_cop

Re: [PATCH 3/3] nl80211: Various checkpatch.pl fixes

>> There's too much stuff here to quickly review, it'd be nice if you >> could split this up into patches that do the following: Is it preferable to resend the whole patch-set or just patch 3/3 in this one as a separate set?

Re: [PATCH 3/3] nl80211: Various checkpatch.pl fixes

> There's too much stuff here to quickly review, it'd be nice if you > could split this up into patches that do the following: Thanks, I will send out a v2 with the split you suggested.

[PATCH 3/3] nl80211: Various checkpatch.pl fixes

tabstop - multiple assignments should be avoided - prefer ether_addr_copy over memcpy - correct spelling - 'implementation' - comparison to NULL could be written as !foo - prefer kcalloc over kzalloc with multiply Signed-off-by: Kirtika Ruchandani --- net/wireless/nl802

[PATCH 1/3] nl80211: Fix checkpatch warnings

This patch fixes the following checkpatch.pl warnings about comments in nl80211.c : - networking block comments don't use an empty '/*' line - block comments use a trailing '*/' on a separate line Signed-off-by: Kirtika Ruchandani --- net

[PATCH 2/3] nl80211: Fix checkpatch warnings about blank lines

This patch fixes the following checkpatch.pl issues - - Please don't use multiple blank lines - Blank lines aren't necessary before a close brace - Missing a blank line after declarations Signed-off-by: Kirtika Ruchandani --- net/wireless/nl80211.c | 22 ++ 1 fi

[PATCH 0/3] nl80211: Fix checkpatch.pl issues

pen parenthesis'. Some of them do not display correctly with git diff. This patch-set removes 3 errors, 66 warnings and 46 checks. Kirtika Ruchandani (3): nl80211: Fix checkpatch warnings nl80211: Fix checkpatch warnings about blank lines nl80211: Various checkpatch.pl fixes

[PATCH] cfg80211: Fix checkpatch issues

dr_copy instead of memcpy - fix line over 80 chars - match alignment of function arguments to open parentheses Signed-off-by: Kirtika Ruchandani --- net/wireless/core.c | 73 +++-- net/wireless/core.h | 33 +--- 2 files chan

[PATCH] cfg80211: Fix checkpatch issues

dr_copy instead of memcpy - fix line over 80 chars - match alignment of function arguments to open parentheses Signed-off-by: Kirtika Ruchandani --- net/wireless/core.c | 73 +++-- net/wireless/core.h | 33 +--- 2 files chan