Martin Blumenstingl writes:
> While trying to add the Ethernet PHY interrupt on the X96 Max I found
> that the current reset line definition is incorrect. Patch #1 fixes
> this.
>
> Since the fix requires moving from the deprecated "snps,reset-gpio"
> property to the generic Ethernet PHY reset bi
Yixun Lan writes:
> Add DT info for the stmmac ethernet MAC which found in
> the Amlogic's Meson-AXG SoC, also describe the ethernet
> pinctrl & clock information here.
>
> Reviewed-by: Neil Armstrong
> Signed-off-by: Yixun Lan
Applied to v4.16/dt64,
Kevin
Yixun Lan writes:
> This is tested in the S400 dev board which use a RTL8211F PHY,
> and the pins connect to the 'eth_rgmii_y_pins' group.
>
> Reviewed-by: Neil Armstrong
> Signed-off-by: Yixun Lan
> ---
> arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 7 +++
> 1 file changed, 7 insertio
Yixun Lan writes:
> Add DT info for the stmmac ethernet MAC which found in
> the Amlogic's Meson-AXG SoC, also describe the ethernet
> pinctrl & clock information here.
>
> Reviewed-by: Neil Armstrong
> Signed-off-by: Yixun Lan
This patch does not apply, and dependencies are not described.
>
Yixun Lan writes:
> Add DT info for the stmmac ethernet MAC which found in
> the Amlogic's Meson-AXG SoC, also describe the ethernet
> pinctrl & clock information here.
>
> This is tested in the S400 dev board which use a RTL8211F PHY,
> and the pins connect to the 'eth_rgmii_y_pins' group.
>
> S
Johan Hovold writes:
> Make sure to disable clocks before returning on late probe errors.
>
> Fixes: 566e82516253 ("net: stmmac: add a glue driver for the Amlogic
> Meson 8b / GXBB DWMAC")
> Signed-off-by: Johan Hovold
Acked-by: Kevin Hilman
t;> Yours,
>> Linus Walleij
>>
>
> Hi Linus,
>
> I'm ok to have it applied as soon as possible, but I can send a clean non-rfc
> patch if needed.
>
Acked-by: Kevin Hilman
I was hoping to have a bit clearer info from the vendor, but based on
vendor BSP, I think we have most of the info, and can do the minor
fixups if/when we get detailed documentation.
Kevin
David Miller writes:
> From: Martin Blumenstingl
> Date: Tue, 30 Aug 2016 20:49:28 +0200
>
>> On Mon, Aug 29, 2016 at 5:40 AM, David Miller wrote:
>>> From: Martin Blumenstingl
>>> Date: Sun, 28 Aug 2016 18:16:32 +0200
>>>
This adds a DWMAC glue driver for the PRG_ETHERNET registers found
; + return ret;
> + }
> +
> + ret = clk_set_rate(dwmac->m25_div_clk, clk_rate);
> + if (ret) {
> + clk_disable_unprepare(dwmac->m25_div_clk);
> +
> + dev_err(&dwmac->pdev->dev, "failed to set PHY clock\n");
> + return ret;
> + }
In the case of success, the clock is never disabled/unprepared. You
probably need a .remove function which disables the clock and then calls
stmmac_pltfr_remove.
> + /* enable TX_CLK and PHY_REF_CLK generator */
> + meson8b_dwmac_mask_bits(dwmac, PRG_ETH0, PRG_ETH0_TX_AND_PHY_REF_CLK,
> + PRG_ETH0_TX_AND_PHY_REF_CLK);
> +
> + return 0;
> +}
[...]
Otherwise, this is looking good.
Also, I tested on meson-gxbb-odroidc2 and meson-gxbb-p200 by booting a debian
root filesystem over NFS and all was well.
Tested-by: Kevin Hilman
Kevin
Michael Turquette writes:
> Hi Martin,
>
> Quoting Martin Blumenstingl (2016-06-27 04:33:49)
>> On Mon, Jun 27, 2016 at 12:44 PM, Martin Blumenstingl
>> wrote:
>> > On Mon, Jun 27, 2016 at 11:24 AM, Carlo Caione wrote:
>> >> A syscon is a region containing a set of miscellaneous registers used
When using polling, smc_poll_controller() can call smc_interrupt()
when there are likely to be no real interrups. This will trigger the
"spurious interrupt" printk whenever the driver is being polled.
Instead, check for actual interrupts before calling smc_interrupt()
Signed-off
ning when in polling mode.
Signed-off-by: Kevin Hilman <[EMAIL PROTECTED]>
Signed-off-by: Nicolas Pitre <[EMAIL PROTECTED]>
---
drivers/net/smc91x.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c
index 7da7
ave() instead of a wrapped version of
spin_trylock.
Signed-off-by: Kevin Hilman <[EMAIL PROTECTED]>
Acked-by: Nicolas Pitre <[EMAIL PROTECTED]>
---
drivers/net/smc91x.c | 42 ++
1 files changed, 18 insertions(+), 24 deletions(-)
diff --git a/driv
13 matches
Mail list logo
