Re: [PATCH] net: bridge: Fix jump_label config

2021-03-16 Thread Kefeng Wang
On 2021/2/27 4:19, Cong Wang wrote: On Thu, Feb 25, 2021 at 5:39 PM Kefeng Wang wrote: On 2021/2/26 5:22, Cong Wang wrote: On Wed, Feb 24, 2021 at 8:03 AM Kefeng Wang wrote: HAVE_JUMP_LABLE is removed by commit e9666d10a567 ("jump_label: move 'asm goto' support test to

Re: [PATCH] net: bridge: Fix jump_label config

2021-02-26 Thread Kefeng Wang
On 2021/2/27 4:19, Cong Wang wrote: On Thu, Feb 25, 2021 at 5:39 PM Kefeng Wang wrote: On 2021/2/26 5:22, Cong Wang wrote: On Wed, Feb 24, 2021 at 8:03 AM Kefeng Wang wrote: HAVE_JUMP_LABLE is removed by commit e9666d10a567 ("jump_label: move 'asm goto' support test to

Re: [PATCH] net: bridge: Fix jump_label config

2021-02-25 Thread Kefeng Wang
On 2021/2/26 5:22, Cong Wang wrote: On Wed, Feb 24, 2021 at 8:03 AM Kefeng Wang wrote: HAVE_JUMP_LABLE is removed by commit e9666d10a567 ("jump_label: move 'asm goto' support test to Kconfig"), use CONFIG_JUMP_LABLE instead of HAVE_JUMP_LABLE. Fixes: 971502d77faa ("

Re: [PATCH] net: bridge: Fix jump_label config

2021-02-24 Thread Kefeng Wang
On 2021/2/25 2:54, Jakub Kicinski wrote: On Wed, 24 Feb 2021 23:38:03 +0800 Kefeng Wang wrote: HAVE_JUMP_LABLE is removed by commit e9666d10a567 ("jump_label: move 'asm goto' support test to Kconfig"), use CONFIG_JUMP_LABLE instead of HAVE_JUMP_LABLE. Fixes: 971502d77faa

[PATCH] net: bridge: Fix jump_label config

2021-02-24 Thread Kefeng Wang
HAVE_JUMP_LABLE is removed by commit e9666d10a567 ("jump_label: move 'asm goto' support test to Kconfig"), use CONFIG_JUMP_LABLE instead of HAVE_JUMP_LABLE. Fixes: 971502d77faa ("bridge: netfilter: unroll NF_HOOK helper in bridge input path") Signed-off-by

[PATCH next 19/25] net: calxedaxgmac: Use dev_get_drvdata()

2019-04-23 Thread Kefeng Wang
Using dev_get_drvdata directly. Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Kefeng Wang --- drivers/net/ethernet/calxeda/xgmac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethern

[PATCH net-next v2 0/3] ipv4/v6: icmp: small cleanup and update

2019-02-22 Thread Kefeng Wang
v2: - Add cover letter and user proper patch subject-prefix suggested-by Eric Dumazet This patch series contains some small cleanup and update, 1) use icmp/v6_sk_exit when icmp_sk_init fails instead of open-code 2) use new percpu allocation interface for the ipv6.icmp_sk Kefeng Wang (3): ipv4

[PATCH net-next v2 2/3] ipv6: icmp: use icmpv6_sk_exit()

2019-02-22 Thread Kefeng Wang
Simply use icmpv6_sk_exit() when inet_ctl_sock_create() fail in icmpv6_sk_init(). Signed-off-by: Kefeng Wang --- net/ipv6/icmp.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c index bbcdfd299692..af520014def5

[PATCH net-next v2 1/3] ipv4: icmp: use icmp_sk_exit()

2019-02-22 Thread Kefeng Wang
Simply use icmp_sk_exit() when inet_ctl_sock_create() fail in icmp_sk_init(). Signed-off-by: Kefeng Wang --- net/ipv4/icmp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c index 065997f414e6..364cfe5e414b 100644 --- a/net/ipv4/icmp.c

[PATCH net-next v2 3/3] ipv6: icmp: use percpu allocation

2019-02-22 Thread Kefeng Wang
Use percpu allocation for the ipv6.icmp_sk. Signed-off-by: Kefeng Wang --- include/net/netns/ipv6.h | 2 +- net/ipv6/icmp.c | 11 +-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/include/net/netns/ipv6.h b/include/net/netns/ipv6.h index ef1ed529f33c

[PATCH 1/3] ipv4: icmp: use icmp_sk_exit()

2019-02-21 Thread Kefeng Wang
Simply use icmp_sk_exit() when inet_ctl_sock_create() fail in icmp_sk_init(). Signed-off-by: Kefeng Wang --- net/ipv4/icmp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c index 065997f414e6..364cfe5e414b 100644 --- a/net/ipv4/icmp.c

[PATCH 3/3] ipv6: icmp: use percpu allocation

2019-02-21 Thread Kefeng Wang
Use percpu allocations for the ipv6.icmp_sk. Signed-off-by: Kefeng Wang --- include/net/netns/ipv6.h | 2 +- net/ipv6/icmp.c | 11 +-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/include/net/netns/ipv6.h b/include/net/netns/ipv6.h index ef1ed529f33c

[PATCH 2/3] ipv6: icmp: use icmpv6_sk_exit()

2019-02-21 Thread Kefeng Wang
Simply use icmpv6_sk_exit() when inet_ctl_sock_create() fail in icmpv6_sk_init(). Signed-off-by: Kefeng Wang --- net/ipv6/icmp.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c index bbcdfd299692..af520014def5

Re: [bonding] 86838ad7bd: BUG:sleeping_function_called_from_invalid_context_at_kernel/locking/mutex.c

2019-02-21 Thread Kefeng Wang
quot;) > url: > https://github.com/0day-ci/linux/commits/Kefeng-Wang/bonding-use-mutex-lock-in-bond_get_stats/20190216-030058 > > > in testcase: rcutorture > with following parameters: > > runtime: 300s > test: cpuhotplug > torture_type: srcu > > tes

Re: [RFC PATCH] bonding: use mutex lock in bond_get_stats()

2019-02-17 Thread Kefeng Wang
On 2019/2/17 2:18, Eric Dumazet wrote: > On Fri, Feb 15, 2019 at 9:36 PM Kefeng Wang > wrote: >> >> >> On 2019/2/15 21:57, Eric Dumazet wrote: >>> On Fri, Feb 15, 2019 at 5:37 AM Kefeng Wang >>> wrote: >>>> With CONFIG_DEBUG_SPINLOCK=y, w

Re: [RFC PATCH] bonding: use mutex lock in bond_get_stats()

2019-02-15 Thread Kefeng Wang
On 2019/2/15 21:57, Eric Dumazet wrote: > On Fri, Feb 15, 2019 at 5:37 AM Kefeng Wang > wrote: >> >> With CONFIG_DEBUG_SPINLOCK=y, we find following stack, >> >> BUG: spinlock wrong CPU on CPU#0, ip/16047 >> lock: 0x803f5febc998, .magic: dead4

[RFC PATCH] bonding: use mutex lock in bond_get_stats()

2019-02-15 Thread Kefeng Wang
/0xc and then lead to softlockup issue, fix this by using mutex lock instead of spin lock. Signed-off-by: Kefeng Wang --- Not sure if this is right fix, please correct me if I'm wrong. drivers/net/bonding/bond_main.c | 6 +++--- include/net/bonding.h | 2 +- 2 files chang

Re: [PATCH 7.x ubsan fix 3/6] net: sctp, forbid negative length

2017-11-16 Thread Kefeng Wang
sorry, please ignore... On 2017/11/17 10:33, Kefeng Wang wrote: > From: Jiri Slaby > > mainline inclusion > from mainline-4.9 > commit a4b8e71b05c27bae6bad3bdecddbc6b68a3ad8cf > category: bugfix > bugzilla: 3214 > DTS: NA > CVE: NA > > -

[PATCH 7.x ubsan fix 3/6] net: sctp, forbid negative length

2017-11-16 Thread Kefeng Wang
vid S. Miller" Cc: linux-s...@vger.kernel.org Cc: netdev@vger.kernel.org Acked-by: Neil Horman Signed-off-by: David S. Miller (cherry picked from commit a4b8e71b05c27bae6bad3bdecddbc6b68a3ad8cf) Signed-off-by: Kefeng Wang --- net/sctp/socket.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

[PATCH] bpf: fix return in bpf_skb_adjust_net

2017-07-12 Thread Kefeng Wang
The bpf_skb_adjust_net() ignores the return value of bpf_skb_net_shrink/grow, and always return 0, fix it by return 'ret'. Signed-off-by: Kefeng Wang --- net/core/filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/filter.c b/net/core/filter.c ind

[PATCH] ipv6: addrconf: Avoid addrconf_disable_change() using RCU read-side lock

2017-01-19 Thread Kefeng Wang
read-side critical section. Signed-off-by: Kefeng Wang --- net/ipv6/addrconf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index c1e124b..f60e88e 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -5540,8 +5540,7 @@ s

Re: [PATCH net-next] ixgbevf: fix 'Etherleak' in ixgbevf

2016-12-21 Thread Kefeng Wang
On 2016/12/21 10:20, Alexander Duyck wrote: > I find it curious that only the last 4 bytes have data in them. I'm > wondering if the NIC/driver in the Windows/Nessus system is > interpreting the 4 byte CRC on the end of the frame as padding instead > of stripping it. > > Is there any chance you

Re: [PATCH] net: hns: declare function as static

2016-09-06 Thread Kefeng Wang
On 2016/9/7 7:20, David Miller wrote: > From: Kefeng Wang > Date: Tue, 6 Sep 2016 19:53:11 +0800 > >> Declare function as static to kill warning about missing-prototypes. >> >> Cc: Yisen Zhuang >> Cc: Kejian Yan >> Signed-off-by: Kefeng Wang &g

[PATCH] net: hns: declare function as static

2016-09-06 Thread Kefeng Wang
Declare function as static to kill warning about missing-prototypes. Cc: Yisen Zhuang Cc: Kejian Yan Signed-off-by: Kefeng Wang --- The warning is shown when make with W=1. drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 22 +++--- drivers/net/ethernet/hisilicon/hns

[PATCH] ptp: ixp46x: use helpers for converting ns to timespec

2016-01-27 Thread Kefeng Wang
Convert the driver to use ns_to_timespec64() and timespec64_to_ns() instead of open coding the same logic. Signed-off-by: Kefeng Wang --- drivers/ptp/ptp_ixp46x.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/ptp/ptp_ixp46x.c b/drivers/ptp/ptp_ixp46x.c index

[PATCH] net: cavium: liquidio: use helpers ns_to_timespec64()

2016-01-27 Thread Kefeng Wang
Convert the driver to use ns_to_timespec64() to keep consistency with timespec64_to_ns() instead of open coding the same logic. Signed-off-by: Kefeng Wang --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net