Re: [PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning

2016-08-23 Thread Kedari Appana
HI, Thanks for the patch.. On Tue, Aug 23, 2016 at 8:36 PM, Wei Yongjun wrote: > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/net/phy/xilinx_gmii2rgmii.c:61:5: warning: > symbol 'xgmiitorgmii_probe' was not declared. Should it be static? > > Signed-off-by: Wei

Re: [PATCH -next v2] net: phy: Add missing of_node_put() in xgmiitorgmii_probe()

2016-08-22 Thread Kedari Appana
Hi , On Mon, Aug 22, 2016 at 4:16 AM, Wei Yongjun wrote: > This node pointer is returned by of_parse_phandle() with > refcount incremented in this function. of_node_put() on it > before exitting this function. > > This is detected by Coccinelle semantic patch. > > Signed-off-by: Wei Yongjun Re