m: don't lock mutex in RCU critical section
iwlwifi: warn on SKB free w/o op-mode
iwlwifi: trans/pcie: defer transport initialisation
iwlwifi: fw: print out trigger delay when collecting data
iwlwifi: pcie: don't enable BHs with IRQs disabled
Kalle Valo (2):
Lee Gibson writes:
> Function wl1251_cmd_scan calls memcpy without checking the length.
> A user could control that length and trigger a buffer overflow.
> Fix by checking the length is within the maximum allowed size.
>
> Signed-off-by: Lee Gibson
Please fix the commit log, the user cannot con
Jiapeng Chong wrote:
> Fix the following whitescan warning:
>
> An unsigned value can never be less than 0.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
Patch applied to wireless-drivers-next.git, thanks.
5e6087559e85 wil6210: wmi: Remove useless code
--
https://patchwork.k
Christophe JAILLET wrote:
> 'get_tid_h()' is the same as 'ieee80211_get_tid()'.
> So this function can be removed to save a few lines of code.
>
> Signed-off-by: Christophe JAILLET
> Acked-by: Christian Lamparter
Patch applied to wireless-drivers-next.git, thanks.
cf366b154704 carl9170: remo
Lv Yunlong wrote:
> In mwl8k_probe_hw, hw->priv->txq is freed at the first time by
> dma_free_coherent() in the call chain:
> if(!priv->ap_fw)->mwl8k_init_txqs(hw)->mwl8k_txq_init(hw, i).
>
> Then in err_free_queues of mwl8k_probe_hw, hw->priv->txq is freed
> at the second time by mwl8k_txq_dein
Wan Jiabing wrote:
> struct brcmf_bus is declared twice. One has been declared
> at 37th line. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing
2 patches applied to wireless-drivers-next.git, thanks.
d663bc3317c9 brcmfmac: Remove duplicate struct declaration
444a9af68b5c wilc1000: Remove
Eric Lin wrote:
> Signed-off-by: Eric Lin
> Reported-by: Gustavo A. R. Silva
Patch applied to wireless-drivers-next.git, thanks.
7f50ddc5d4fe wl3501: fix typo of 'Networks' in comment
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210331010418.1632816-2-dslin1...@gmail.com/
nterrupts in resume_noirq
> instead to prevent anything else from claiming the SDIO bus first.
>
> Fixes: 20db07332736 ("rsi: sdio suspend and resume support")
> Signed-off-by: Marek Vasut
> Cc: Amitkumar Karwar
> Cc: Angus Ainslie
> Cc: David S. Miller
> Cc:
Wan Jiabing wrote:
> struct lbs_private has been declared at 22nd line.
> Remove the duplicate.
>
> Signed-off-by: Wan Jiabing
Patch applied to wireless-drivers-next.git, thanks.
d3240418a662 libertas: struct lbs_private is declared duplicately
--
https://patchwork.kernel.org/project/linux-
Bhaskar Chowdhury wrote:
> s/revsion/revision/
>
> Signed-off-by: Bhaskar Chowdhury
Patch applied to wireless-drivers-next.git, thanks.
705b5cfab183 brcmfmac: A typo fix
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210323043657.1466296-1-unixbhas...@gmail.com/
https://wir
Aditya Srivastava wrote:
> The opening comment mark '/**' is used for highlighting the beginning of
> kernel-doc comments.
> There are some files in drivers/net/wireless/rsi which follow this syntax
> in their file headers, i.e. start with '/**' like comments, which causes
> unexpected warnings f
Dinghao Liu wrote:
> When prism2_hw_config() fails, we just return an error code
> without any resource release, which may lead to memleak.
>
> Signed-off-by: Dinghao Liu
Nobody reviewed this, so dropping the patch.
Patch set to Changes Requested.
--
https://patchwork.kernel.org/project/lin
Colin King wrote:
> From: Colin Ian King
>
> The calculation of offtune_val seems incorrect, the u16 value in
> pi->tx_rx_cal_radio_saveregs[2] is being masked with 0xf0 and then
> shifted 8 places right so that always ends up as a zero result. I
> believe the intended shift was 4 bits to the r
Jia-Ju Bai wrote:
> When kmemdup() returns NULL to ta_firmware, no error return code of
> rsi_load_9116_firmware() is assigned.
> To fix this bug, status is assigned with -ENOMEM in this case.
>
> Reported-by: TOTE Robot
> Signed-off-by: Jia-Ju Bai
Someone needs to review this.
Patch set to
Jia-Ju Bai wrote:
> When ieee80211_pspoll_get() returns NULL to skb, no error return code of
> wl1271_cmd_build_ps_poll() is assigned.
> To fix this bug, ret is assigned with -ENOMEM in this case.
>
> Reported-by: TOTE Robot
> Signed-off-by: Jia-Ju Bai
Someone needs to review this.
Patch set
Jia-Ju Bai wrote:
> When wl is NULL, no error return code of wl1271_suspend() is assigned.
> To fix this bug, ret is assigned with -EINVAL in this case.
>
> Reported-by: TOTE Robot
> Signed-off-by: Jia-Ju Bai
Someone needs to review this.
Patch set to Changes Requested.
--
https://patchwor
Jia-Ju Bai wrote:
> When check_fwfile_format() fails, no error return code of
> if_usb_prog_firmware() is assigned.
> To fix this bug, ret is assigned with -EINVAL as error return code.
>
> Reported-by: TOTE Robot
> Signed-off-by: Jia-Ju Bai
Someone needs to review this.
Patch set to Changes
Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> gcc-11 with KASAN on 32-bit arm produces a warning about a function
> that needs a lot of stack space:
>
> drivers/net/wireless/cisco/airo.c: In function 'setup_card.constprop':
> drivers/net/wireless/cisco/airo.c:3960:1: error: the frame size of
Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> gcc complains about undefined behavior in calling snprintf()
> with the same buffer as input and output:
>
> drivers/net/wireless/ti/wl18xx/debugfs.c: In function
> 'diversity_num_of_packets_per_ant_read':
> drivers/net/wireless/ti/wl18xx/../wlco
Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> Building without mesh supports shows a couple of warnings with
> 'make W=1':
>
> drivers/net/wireless/marvell/libertas/main.c: In function 'lbs_start_card':
> drivers/net/wireless/marvell/libertas/main.c:1068:37: error: suggest braces
> around em
Christophe JAILLET wrote:
> The 'c2hcmd_lock' spinlock is only used to protect some __skb_queue_tail()
> and __skb_dequeue() calls.
> Use the lock provided in the skb itself and call skb_queue_tail() and
> skb_dequeue(). These functions already include the correct locking.
>
> Signed-off-by: Chr
zuoqil...@163.com wrote:
> From: zuoqilin
>
> Remove unneeded variable: "ret"
>
> Signed-off-by: zuoqilin
Patch applied to wireless-drivers-next.git, thanks.
c81852a48e13 mwifiex: Remove unneeded variable: "ret"
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210317063353.10
"Gustavo A. R. Silva" wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix
> multiple warnings by replacing /* fall through */ comments with
> the new pseudo-keyword macro fallthrough; instead of letting the
> code fall through to the next case.
>
> Notice that Clang doesn't r
Huang Guobin wrote:
> From: Guobin Huang
>
> spinlock can be initialized automatically with DEFINE_SPINLOCK()
> rather than explicitly calling spin_lock_init().
>
> Reported-by: Hulk Robot
> Signed-off-by: Guobin Huang
Patch applied to wireless-drivers-next.git, thanks.
e9642be26a37 rtlwif
samirweng1979 wrote:
> From: wengjianfeng
>
> some function's label meaningless, the label statement follows
> the goto statement, no other statements, so just remove it.
>
> Reported-by: kernel test robot
> Signed-off-by: wengjianfeng
Patch applied to wireless-drivers-next.git, thanks.
fb
Christophe JAILLET wrote:
> The 'c2hcmd_lock' spinlock is only used to protect some __skb_queue_tail()
> and __skb_dequeue() calls.
> Use the lock provided in the skb itself and call skb_queue_tail() and
> skb_dequeue(). These functions already include the correct locking.
>
> Signed-off-by: Chr
Christophe JAILLET wrote:
> 'rtl_get_tid_h()' is the same as 'ieee80211_get_tid()'.
> So this function can be removed to save a line of code.
>
> Signed-off-by: Christophe JAILLET
Patch applied to wireless-drivers-next.git, thanks.
987e9bcdd0b7 rtlwifi: remove rtl_get_tid_h
--
https://patch
Yang Li wrote:
> Assigning value "3" to "rtlpriv->btcoexist.reg_bt_sco" here, but that
> stored value is overwritten before it can be used.
>
> Coverity reports this problem as
> CWE563: A value assigned to a variable is never used.
> drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c:
> rtl818
Colin King wrote:
> From: Colin Ian King
>
> Variable err is assigned -ENODEV followed by an error return path
> via label error_out that does not access the variable and returns
> with the -ENODEV error return code. The assignment to err is
> redundant and can be removed.
>
> Addresses-Coveri
Bhaskar Chowdhury wrote:
> s/resovle/resolve/
> s/broadcase/broadcast/
> s/sytem/system/
>
> Signed-off-by: Bhaskar Chowdhury
> Acked-by: Randy Dunlap
Patch applied to wireless-drivers-next.git, thanks.
2377b1c49d48 rtlwifi: Few mundane typo fixes
--
https://patchwork.kernel.org/project/li
samirweng1979 wrote:
> From: wengjianfeng
>
> some function's label meaningless, the return statement follows
> the goto statement, so just remove it.
>
> Signed-off-by: wengjianfeng
> Reviewed-by: Sergey Matyukevich
Patch applied to wireless-drivers-next.git, thanks.
a221d0afbf39 qtnfmac:
Chen Lin wrote:
> From: Chen Lin
>
> Remove the 'wsm_*' typedef as it is not used.
>
> Signed-off-by: Chen Lin
Patch applied to wireless-drivers-next.git, thanks.
9dc5fdc8c4f8 cw1200: Remove unused function pointer typedef wsm_*
--
https://patchwork.kernel.org/project/linux-wireless/patch
Chen Lin wrote:
> From: Chen Lin
>
> Remove the 'cw1200_wsm_handler' typedef as it is not used.
>
> Signed-off-by: Chen Lin
Patch applied to wireless-drivers-next.git, thanks.
1c22233a745e cw1200: Remove unused function pointer typedef cw1200_wsm_handler
--
https://patchwork.kernel.org/pr
Lee Gibson wrote:
> Function qtnf_event_handle_external_auth calls memcpy without
> checking the length.
> A user could control that length and trigger a buffer overflow.
> Fix by checking the length is within the maximum allowed size.
>
> Signed-off-by: Lee Gibson
Please use clamp_val() inste
Ramon Fontes writes:
> Advertise 60GHz channels to mac80211.
SoB missing:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#signed-off-by_missing
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documenta
"Gustavo A. R. Silva" writes:
> Friendly ping: could somebody give us some feedback or take
> this series, please?
First patch 2 comment needs to be resolved.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpa
s: Fix spelling mistake "Opportunies" -> "Opportunities"
mt7601u: fix always true expression
Dan Carpenter (1):
rtw88: Fix an error code in rtw_debugfs_set_rsvd_page()
David Mosberger-Tang (1):
wilc1000: Support chip sleep over SPI
Kalle Valo (4):
a
Shawn Guo writes:
> On Sun, Apr 11, 2021 at 10:57:54AM +0300, Kalle Valo wrote:
>> Shawn Guo writes:
>>
>> > Add optional brcm,ccode-map property to support translation from ISO3166
>> > country code to brcmfmac firmware country code and revision.
&
Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> There are a couple of warnings in this driver when building with W=1:
>
> drivers/net/wireless/intel/iwlegacy/common.c: In function 'il_power_set_mode':
> drivers/net/wireless/intel/iwlegacy/common.c:1195:60: error: suggest braces
> around empty
Colin King wrote:
> From: Colin Ian King
>
> Currently the expression ~nic_conf1 is always true because nic_conf1
> is a u16 and according to 6.5.3.3 of the C standard the ~ operator
> promotes the u16 to an integer before flipping all the bits. Thus
> the top 16 bits of the integer result are
Shawn Guo writes:
> Add optional brcm,ccode-map property to support translation from ISO3166
> country code to brcmfmac firmware country code and revision.
>
> Signed-off-by: Shawn Guo
> ---
> .../devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt | 7 +++
> 1 file changed, 7 insertions
Hi,
here's a pull request to net tree, more info below. Please let me know if there
are any problems.
Kalle
The following changes since commit 05a59d79793d482f628a31753c671f2e92178a21:
Merge git://git.kernel.org:/pub/scm/linux/kernel/git/netdev/net (2021-03-09
17:15:56 -0800)
are available
Ulf Hansson writes:
>> If I follow what has been done in other drivers I would write something
>> like:
>>
>> static int wfx_sdio_suspend(struct device *dev)
>> {
>> struct sdio_func *func = dev_to_sdio_func(dev);
>> struct wfx_sdio_priv *bus = sdio_get_drvdata(func);
>>
>
Dinghao Liu writes:
> When prism2_hw_config() fails, we just return an error code
> without any resource release, which may lead to memleak.
>
> Signed-off-by: Dinghao Liu
> ---
> drivers/net/wireless/intersil/hostap/hostap_cs.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>
Wan Jiabing writes:
> struct lbs_private has been declared at 22nd line.
> Remove the duplicate.
>
> Signed-off-by: Wan Jiabing
> ---
> drivers/net/wireless/marvell/libertas/decl.h | 1 -
> 1 file changed, 1 deletion(-)
The prefix should be "libertas:", I can fix that during commit.
--
https
Arnd Bergmann writes:
> From: Arnd Bergmann
>
> gcc complains about undefined behavior in calling snprintf()
> with the same buffer as input and output:
>
> drivers/net/wireless/ti/wl18xx/debugfs.c: In function
> 'diversity_num_of_packets_per_ant_read':
> drivers/net/wireless/ti/wl18xx/../wlcore
Colin King writes:
> From: Colin Ian King
>
> The calculation of offtune_val seems incorrect, the u16 value in
> pi->tx_rx_cal_radio_saveregs[2] is being masked with 0xf0 and then
> shifted 8 places right so that always ends up as a zero result. I
> believe the intended shift was 4 bits to the r
Qiheng Lin writes:
> Eliminate the following coccicheck warning:
> drivers/net/wireless/mediatek/mt76/mt7921/mac.c:1402:2-3: Unneeded semicolon
>
> Signed-off-by: Qiheng Lin
mt76 patches go to the mt76 tree maintained by Felix, not to net-next.
--
https://patchwork.kernel.org/project/linux-w
"Maciej S. Szmigiero" writes:
> On 29.03.2021 00:54, Maciej S. Szmigiero wrote:
>> Hi,
>>
>> It looks like rtlwifi/rtl8192cu AP mode is broken when a STA is using PS,
>> since the driver does not update its beacon to account for TIM changes,
>> so a station that is sleeping will never learn that
Lukas Bulwahn writes:
> On Sun, Mar 14, 2021 at 9:18 PM Aditya Srivastava
> wrote:
>>
>> The opening comment mark '/**' is used for highlighting the beginning of
>> kernel-doc comments.
>> There are files in drivers/net/wireless/rsi which follow this syntax in
>> their file headers, i.e. start
Marcus Folkesson wrote:
> Write the value instead of reading it twice.
>
> Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
> Signed-off-by: Marcus Folkesson
Patch applied to wireless-drivers-next.git, thanks.
e21b6e5a5462 wilc1000: write value to WILC_INTR2_ENABLE regist
samirweng1979 wrote:
> From: wengjianfeng
>
> The variable ret is defined at the beginning and initialized
> to 0 until the function returns ret, and the variable ret is
> not reassigned.Therefore, we do not need to define the variable
> ret, just return 0 directly at the end of the function.
>
Heiner Kallweit writes:
> Series includes smaller improvements.
>
> Heiner Kallweit (3):
> iwlwifi: use DECLARE_BITMAP macro
> iwlwifi: switch "index larger than supported by driver" warning to
> debug level
> iwlwifi: use dma_set_mask_and_coherent
iwlwifi patches go to iwlwifi-next, n
Jarod Wilson writes:
> Build currently fails with -Werror=maybe-uninitialized set:
>
> net/wireless/nl80211.c: In function '__cfg80211_wdev_from_attrs':
> net/wireless/nl80211.c:124:44: error: 'wdev_id' may be used
> uninitialized in this function [-Werror=maybe-uninitialized]
Really, build fail
Kees Cook writes:
> On Fri, Mar 05, 2021 at 03:40:33PM +0200, Kalle Valo wrote:
>> "Gustavo A. R. Silva" writes:
>>
>> > In preparation to enable -Wimplicit-fallthrough for Clang, fix
>> > multiple warnings by replacing /* fall through */ comm
oughandhar Chintala
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
018e3fa8e7ff ath10k: skip the wait for completion to recovery in shutdown path
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210223142908.23374-1-yough...@codeaurora.or
by: Sebastian Andrzej Siewior
> Signed-off-by: Thomas Gleixner
> Cc: ath9k-de...@qca.qualcomm.com
> Cc: Kalle Valo
> Cc: "David S. Miller"
> Cc: Jakub Kicinski
> Cc: linux-wirel...@vger.kernel.org
> Cc: netdev@vger.kernel.org
> ---
> drivers/net/wireless/ath/at
"Gustavo A. R. Silva" writes:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix
> multiple warnings by replacing /* fall through */ comments with
> the new pseudo-keyword macro fallthrough; instead of letting the
> code fall through to the next case.
>
> Notice that Clang doesn't r
Hi,
here's a pull request to net tree, more info below. Please let me know if there
are any problems.
Kalle
The following changes since commit c490492f15f656340b35cb9e36b9bfdea3539e19:
mt76: mt7915: fix unused 'mode' variable (2021-02-26 17:35:15 +0200)
are available in the git repository at
Jens Axboe writes:
> On 3/2/21 8:49 PM, Jens Axboe wrote:
>> On 3/2/21 11:34 AM, Coelho, Luciano wrote:
>>
>>> Thanks for the report and patch! And I'm sorry that we broke your
>>> laptop's boot...
>>>
>>> We already have a patch to fix this:
>>>
>>> https://patchwork.kernel.org/project/linux-wir
Pierre-Louis Bossart wrote:
> An unsigned long variable should rely on '%lu' format strings, not '%zd'
>
> Fixes: a1a6a4cf49ece ("iwlwifi: pnvm: implement reading PNVM from UEFI")
> Signed-off-by: Pierre-Louis Bossart
> Acked-by: Luca Coelho
Patch applied to wireless-drivers.git, thanks.
436
Wei Yongjun wrote:
> Make sure dmi_system_id tables are NULL terminated. This crashed when LTO was
> enabled:
>
> BUG: KASAN: global-out-of-bounds in dmi_check_system+0x5a/0x70
> Read of size 1 at addr c16af750 by task NetworkManager/1913
>
> CPU: 4 PID: 1913 Comm: NetworkManager Not t
Jakub Kicinski writes:
> On Tue, 2 Mar 2021 18:31:11 + Coelho, Luciano wrote:
>> On Sat, 2021-02-27 at 08:39 +0200, Kalle Valo wrote:
>> > Nathan Chancellor writes:
>> > > We received a report about a crash in iwlwifi when compiled with LTO and
>> > &g
"Coelho, Luciano" writes:
> On Tue, 2021-03-02 at 07:58 +0200, Kalle Valo wrote:
>> Pierre-Louis Bossart writes:
>>
>> > An unsigned long variable should rely on '%lu' format strings, not '%zd'
>> >
>> > Fixes: a1a6a4cf4
Pierre-Louis Bossart writes:
> An unsigned long variable should rely on '%lu' format strings, not '%zd'
>
> Fixes: a1a6a4cf49ece ("iwlwifi: pnvm: implement reading PNVM from UEFI")
> Signed-off-by: Pierre-Louis Bossart
> ---
> warnings found with v5.12-rc1 and next-20210301
Luca, can I take thi
Peter Zijlstra writes:
> On Mon, Mar 01, 2021 at 10:45:32AM +0200, Kalle Valo wrote:
>> Peter Zijlstra writes:
>>
>> > On Fri, Feb 26, 2021 at 05:06:57PM -0700, Shuah Khan wrote:
>> >> Shuah Khan (3):
>> >> lockdep: add lockdep_assert_no
Peter Zijlstra writes:
> On Fri, Feb 26, 2021 at 05:06:57PM -0700, Shuah Khan wrote:
>> Shuah Khan (3):
>> lockdep: add lockdep_assert_not_held()
>> lockdep: add lockdep lock state defines
>> ath10k: detect conf_mutex held ath10k_drain_tx() calls
>
> Thanks!
Via which tree should these go?
Nathan Chancellor writes:
> On Tue, Feb 23, 2021 at 02:00:39PM +, Wei Yongjun wrote:
>> Make sure dmi_system_id tables are NULL terminated.
>>
>> Fixes: a2ac0f48a07c ("iwlwifi: mvm: implement approved list for the PPAG
>> feature")
>> Reported-by: Hulk Robot
>> Signed-off-by: Wei Yongjun
buffer list after allocating tx token id
Geert Uytterhoeven (1):
ath11k: qmi: use %pad to format dma_addr_t
Johannes Berg (1):
iwlwifi: avoid crash on unsupported debug collection
Kalle Valo (2):
ath11k: fix AP mode for QCA6390
iwlwifi: pcie: fix iwl_so_trans_cfg li
Heiner Kallweit writes:
> On 26.02.2021 13:18, Kai-Heng Feng wrote:
>> On Fri, Feb 26, 2021 at 8:10 PM Heiner Kallweit wrote:
>>>
>>> On 26.02.2021 08:12, Kalle Valo wrote:
>>>> Kai-Heng Feng writes:
>>>>
>>>>> Now we have a ge
Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> clang points out a possible corner case in the mt7915_tm_set_tx_cont()
> function if called with invalid arguments:
>
> drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:593:2: warning: variable
> 'mode' is used uninitialized whenever switch d
Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> Clang points out a mistake in the error handling in
> mt7921_mcu_tx_rate_report(), which tries to dereference a pointer that
> cannot be initialized because of the error that is being handled:
>
> drivers/net/wireless/mediatek/mt76/mt7921/mcu.c:40
es changed, 6 insertions(+), 2 deletions(-)
It would have been nice to CC linux-wireless also on patches 1-2. I only
saw patch 3 and had to search the rest of patches from lkml.
I assume this goes via the PCI tree so:
Acked-by: Kalle Valo
--
https://patchwork.kernel.org/project/lin
Arnd Bergmann writes:
> From: Arnd Bergmann
>
> A runtime check that was introduced recently failed to
> check for the matching Kconfig symbol:
>
> ld.lld: error: undefined symbol: iwl_so_trans_cfg
referenced by drv.c
net/wireless/intel/iwlwifi/pcie/drv.o:(iwl_pci_probe)
Arnd Bergmann writes:
> From: Arnd Bergmann
>
> clang points out a possible corner case in the mt7915_tm_set_tx_cont()
> function if called with invalid arguments:
>
> drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:593:2: warning: variable
> 'mode' is used uninitialized whenever switch de
kernel test robot writes:
> Hi samirweng1979,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on wireless-drivers-next/master]
> [also build test ERROR on wireless-drivers/master sparc-next/master v5.11
> next-20210225]
> [If your patch is applied to the wrong g
writes:
> On 24/02/21 10:13 pm, Kalle Valo wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you
>> know the content is safe
>>
>> Marcus Folkesson writes:
>>
>>> Write the value instead of reading it twice.
>>>
>&g
Marcus Folkesson writes:
> Write the value instead of reading it twice.
>
> Fixes: 5e63a598441a ("staging: wilc1000: added 'wilc_' prefix for function in
> wilc_sdio.c file")
>
> Signed-off-by: Marcus Folkesson
> ---
> drivers/net/wireless/microchip/wilc1000/sdio.c | 2 +-
> 1 file changed, 1
Geert Uytterhoeven wrote:
> If CONFIG_ARCH_DMA_ADDR_T_64BIT=n:
>
> drivers/net/wireless/ath/ath11k/qmi.c: In function
> ‘ath11k_qmi_respond_fw_mem_request’:
> drivers/net/wireless/ath/ath11k/qmi.c:1690:8: warning: format ‘%llx’
> expects argument of type ‘long long unsigned int’, but a
Pkshih writes:
> On Tue, 2021-02-23 at 09:08 +0200, Kalle Valo wrote:
>> Pkshih writes:
>>
>> >> > --- a/drivers/net/wireless/realtek/rtw88/rtw8822ce.c
>> >> > +++ b/drivers/net/wireless/realtek/rtw88/rtw8822ce.c
>> >> >
Pkshih writes:
>> > --- a/drivers/net/wireless/realtek/rtw88/rtw8822ce.c
>> > +++ b/drivers/net/wireless/realtek/rtw88/rtw8822ce.c
>> > @@ -25,7 +25,6 @@ static struct pci_driver rtw_8822ce_driver = {
>> > .id_table = rtw_8822ce_id_table,
>> > .probe = rtw_pci_probe,
>> > .remove = rtw_p
Hao Chen writes:
> The laptop's wifi disconnect after the laptop HONOR MagicBook 14
> sleep to S3/S4 and wake up.
>
> The dmesg of kernel report:
> "[ 99.990168] pcieport :00:01.2: can't change power state from D3hot
> to D0 (config space inaccessible)
> [ 99.990176] ACPI: EC: interrupt u
x ath_tx_process_buffer() potential null ptr
> dereference")
> Signed-off-by: Shuah Khan
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
14ebaeeff8d0 Revert "ath9k: fix ath_tx_process_buffer() potential null ptr
dereference"
--
https://pat
陈浩 writes:
> By git blame command, I know that the assignment of .driver.pm =
> RTW_PM_OPS
>
> was in commit 44bc17f7f5b3b("rtw88: support wowlan feature for
> 8822c"),
>
> and another commit 7dc7c41607d19("avoid unused function warnings")
>
> pointed out rtw_pci_resume() and rtw_pci_suspend() ar
Hao Chen writes:
> When the laptop HONOR MagicBook 14 sleep to S3/S4, the laptop can't
> resume.
> The dmesg of kernel report:
> "[ 99.990168] pcieport :00:01.2: can't change power state
> from D3hot to D0 (config space inaccessible)
> [ 99.993334] rtw_pci :01:00.0: can't change power
Stephen Rothwell writes:
> Hi all,
>
> On Fri, 19 Feb 2021 07:52:56 +1100 Stephen Rothwell
> wrote:
>>
>> After merging the net-next tree, today's linux-next build (htmldocs)
>> produced these warnings:
>>
>> Documentation/networking/filter.rst:1053: WARNING: Inline emphasis
>> start-string w
x ath_tx_process_buffer() potential null ptr
> dereference")
> Signed-off-by: Shuah Khan
> Signed-off-by: Kalle Valo
Thanks. I added the commit id and Fixes tag to the commit log, see the new
version above.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210217211801.22540-1-sk...@linuxfoundation.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Srinivasan Raju writes:
> This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC
> and LiFi-XL USB devices.
>
> This driver implementation has been based on the zd1211rw driver.
>
> Driver is based on 802.11 softMAC Architecture and uses
> native 802.11 for configuration and management.
>
>
Kalle Valo writes:
> Srinivasan Raju writes:
>
>> This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC
>> and LiFi-XL USB devices.
>>
>> This driver implementation has been based on the zd1211rw driver.
>>
>> Driver is based on 802.11 softMAC
Srinivasan Raju writes:
> This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC
> and LiFi-XL USB devices.
>
> This driver implementation has been based on the zd1211rw driver.
>
> Driver is based on 802.11 softMAC Architecture and uses
> native 802.11 for configuration and management.
>
>
Johannes Berg writes:
>> +++ b/drivers/net/wireless/purelifi/Makefile
>> @@ -0,0 +1,2 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +obj-$(CONFIG_WLAN_VENDOR_PURELIFI) := plfxlc/
>
> Although this one doesn't do anything, so all you did was save a level
> of Kconfig inclusion I guess
Srinivasan Raju writes:
> This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC
> and LiFi-XL USB devices.
>
> This driver implementation has been based on the zd1211rw driver.
>
> Driver is based on 802.11 softMAC Architecture and uses
> native 802.11 for configuration and management.
>
>
Shuah Khan writes:
> On 2/16/21 12:53 AM, Felix Fietkau wrote:
>>
>> On 2021-02-16 08:03, Kalle Valo wrote:
>>> Shuah Khan wrote:
>>>
>>>> ath_tx_process_buffer() references ieee80211_find_sta_by_ifaddr()
>>>> return pointer (sta) outsi
Colin King wrote:
> There is a spelling mistake in some debug text, fix this.
>
> Signed-off-by: Colin Ian King
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
9c349dbd0752 ath11k: debugfs: Fix spelling mistake "Opportunies" ->
&
se_peer_stats_info() and a subsequent manual audit
> of other callers of ieee80211_find_sta_by_ifaddr() that don't hold
> RCU read lock.
>
> Signed-off-by: Shuah Khan
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
a56c14bb21b2 ath9k: fix ath_
worker routines try
> to call this routine.
>
> Link: https://lore.kernel.org/linux-wireless/871rdmu9z9@codeaurora.org/
> Signed-off-by: Shuah Khan
This can go via the same tree as patch 1:
Acked-by: Kalle Valo
But I can also take this to my ath tree, once patch 1 has reac
eless iwl_mvm_resume_d3() function
iwlwifi: api: clean up some documentation/bits
iwlwifi: remove flags argument for nic_access
iwlwifi: remove max_vht_ampdu_exponent config parameter
iwlwifi: remove max_ht_ampdu_exponent config parameter
Kalle Valo (8):
ath10k: remov
gt; Signed-off-by: Shuah Khan
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
09078368d516 ath10k: hold RCU lock when calling ieee80211_find_sta_by_ifaddr()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210210212107.40373-1-sk...@linuxfoundat
Shuah Khan writes:
> On 2/10/21 1:28 AM, Kalle Valo wrote:
>> Wen Gong writes:
>>
>>> On 2021-02-10 08:42, Shuah Khan wrote:
>>>> ath10k_mac_get_rate_flags_ht() floods dmesg with the following
>>>> messages,
>>&g
Shuah Khan writes:
> On 2/10/21 1:25 AM, Kalle Valo wrote:
>> Shuah Khan writes:
>>
>>> ath10k_drain_tx() must not be called with conf_mutex held as workers can
>>> use that also. Add check to detect conf_mutex held calls.
>>>
>>> Signed-off-b
1 - 100 of 1701 matches
Mail list logo