There are a couple of spelling mistakes in comment text. Fix these.
Signed-off-by: Kaige Li
---
drivers/net/phy/mscc/mscc_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/mscc/mscc_main.c b/drivers/net/phy/mscc/mscc_main.c
index a4fbf3a..6bc7406
On 06/25/2020 12:59 AM, Jakub Kicinski wrote:
On Wed, 24 Jun 2020 06:32:36 + Christian Benvenuti (benve) wrote:
We/Cisco will also look into it, hopefully a small code reorg will be
sufficient.
Hi, Christian:
I have seen some submissions and codes, and feel that spin_lock is unnecessar
On 06/24/2020 11:23 AM, David Miller wrote:
From: Kaige Li
Date: Wed, 24 Jun 2020 09:56:47 +0800
On 06/24/2020 06:26 AM, David Miller wrote:
From: David Miller
Date: Tue, 23 Jun 2020 14:33:11 -0700 (PDT)
Calling a NIC driver open function from a context holding a spinlock
is very much
On 06/24/2020 04:50 AM, Jakub Kicinski wrote:
On Tue, 23 Jun 2020 16:13:09 +0800 Kaige Li wrote:
The kernel module may sleep with holding a spinlock.
The function call paths (from bottom to top) are:
[FUNC] zalloc_cpumask_var(GFP_KERNEL)
drivers/net/ethernet/cisco/enic/enic_main.c, 125
On 06/24/2020 06:26 AM, David Miller wrote:
From: David Miller
Date: Tue, 23 Jun 2020 14:33:11 -0700 (PDT)
Calling a NIC driver open function from a context holding a spinlock
is very much the real problem, so many operations have to sleep and
in face that ->ndo_open() method is defined as b
: enic_init_affinity_hint in
enic_open
drivers/net/ethernet/cisco/enic/enic_main.c, 2348: enic_open in enic_reset
drivers/net/ethernet/cisco/enic/enic_main.c, 2341: spin_lock in enic_reset
To fix this bug, GFP_KERNEL is replaced with GFP_ATOMIC.
Signed-off-by: Kaige Li
---
+cc netdev@vger.kernel.org
