Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg

2015-06-02 Thread Junling Zheng
On 2015/6/2 14:52, Willy Tarreau wrote: > On Tue, Jun 02, 2015 at 02:43:54PM +0800, Junling Zheng wrote: >> On 2015/6/2 14:27, Greg KH wrote: >>> On Mon, Jun 01, 2015 at 10:23:57PM -0700, David Miller wrote: >>>> From: Junling Zheng >>>> Date: Tue, 2

Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg

2015-06-01 Thread Junling Zheng
On 2015/6/2 14:27, Greg KH wrote: > On Mon, Jun 01, 2015 at 10:23:57PM -0700, David Miller wrote: >> From: Junling Zheng >> Date: Tue, 2 Jun 2015 12:05:32 +0800 >> >>> So, the problem commit is 281c9c36 (net: compat: Update >>> get_compat_msghdr() to

Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg

2015-06-01 Thread Junling Zheng
On 2015/6/2 13:23, David Miller wrote: > From: Junling Zheng > Date: Tue, 2 Jun 2015 12:05:32 +0800 > >> So, the problem commit is 281c9c36 (net: compat: Update >> get_compat_msghdr() to match copy_msghdr_from_user() behaviour), >> which fixes db31c55a6fb2 and brings

Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg

2015-06-01 Thread Junling Zheng
On 2015/6/2 12:44, Greg KH wrote: > On Tue, Jun 02, 2015 at 12:05:32PM +0800, Junling Zheng wrote: >> On 2015/6/2 9:21, Greg KH wrote: >>> On Mon, Jun 01, 2015 at 09:28:00AM +0000, Junling Zheng wrote: >>>> Hi, Greg: >>>> >>>> We found t

Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg

2015-06-01 Thread Junling Zheng
On 2015/6/2 9:21, Greg KH wrote: > On Mon, Jun 01, 2015 at 09:28:00AM +0000, Junling Zheng wrote: >> Hi, Greg: >> >> We found that after v3.10.73, recvmsg might return -EFAULT while -EINVAL >> was expected. > > That means I messed up and applied something I should

[RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg

2015-06-01 Thread Junling Zheng
get_compat_msghdr() to match copy_msghdr_from_user() behaviour) Signed-off-by: Junling Zheng Signed-off-by: Hanbing Xu Cc: Li Zefan Cc: Al Viro Cc: David Miller --- net/socket.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/net/socket.c b/n