Re: [PATCH] b43: Remove redundant code

l a lot of places, like this, where placeholder comments were written until the actual code that would have been here was ready / reverse engineered. That said, I believe the driver works well enough for all it's users and has not seen any significant changes in a long time. Thanks, -- Julian Ca

Re: [PATCH] drivers: realtek: rtl8723be: Correct word presentation as defautly to de-faulty

e own may not Same comments here as the previous patches: "de-faultly" makes less sense than "defaultly". This comment needs to be re-written by someone who knows what's going on here. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] drivers: rtlwifi: rtl8723ae: Fix word association in trx.c

s sense than "defaultly". This comment needs to be re-written by someone who knows what's going on here. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] drivers: rtlwifi: rtl8821ae: defautly to de-faulty ,last in the series

es: "de-faultly" makes less sense than "defaultly". This comment needs to be re-written by someone who knows what's going on here. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] drivers: net: wireless: realtek: Fix the word association defautly de-faulty

Hi Bhaskar, On Tue, Jan 5, 2021 at 9:48 PM Bhaskar Chowdhury wrote: > > On 21:33 Tue 05 Jan 2021, Julian Calaby wrote: > >Hi Bhaskar, > > > >On Tue, Jan 5, 2021 at 9:19 PM Bhaskar Chowdhury > >wrote: > >> > >> s/defautly/de-faulty/p

Re: [PATCH] drivers: wireless: rtlwifi: rtl8192ce: Fix construction of word rtl8192ce/trx.c

n may not Same comments here as the previous patch: "de-faultly" makes less sense than "defaultly". This comment needs to be re-written by someone who knows what's going on here. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] drivers: net: wireless: realtek: Fix the word association defautly de-faulty

+*descriptor de-faulty,and the own may not Really? "de-faultly" isn't any better than "defaultly" and in fact it's even worse as it breaks up the word "default". This change doesn't make sense and the comment really needs to be completely re-written

Re: [PATCH 1/1] mwifiex: Fix possible buffer overflows in mwifiex_config_scan

;user_scan_in->ssid_list[i].ssid, ssid_len); Can ssid_len ever be 0 here? If it can't, should we just set ssid_len to 1 unconditionally? If it can, should we just skip the memcpy as it won't do anything? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH v2] ath10k: sdio: remove redundant check in for loop

check section size - from line 2315 skip_size = cur_section->start - prev_end; // check buffer size - from line 2339 - needs to account for the skip size too. // fill in the skip size amount - from line 2358 and 2304 // ath10k_sdio_read_mem - from line 2346 prev_end =

Re: [PATCH][next] ath11k: Use fallthrough pseudo-keyword

ing_num >= 3" comment is needed, how should this get formatted? Maybe something like: fallthrough; /* when ring_num >= 3 */ Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH net-next] sun: Add SPDX license tags to Sun network drivers

shouldn't the SPDX line _replace_ the usual "this program is free software" license paragraphs? My understanding is that the SPDX line is functionally equivalent to having the terms spelled out. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [linux-sunxi] [PATCH 1/3] net: stmmac: dwmac-sun8i: drop V3s compatible and add V3 one

s variant around for compatibility with existing device trees? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 5/5] wlcore: Use common error handling code in wl1271_op_suspend()

ning("couldn't prepare device to suspend"); "couldn't enable power saving"? > - return ret; > - } > + if (ret < 0) > + goto report_preparation_failure; > > /* flush any remaining work */ > wl1271_debug(DEBUG_MAC80211, "flushing remaining works"); Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 4/5] wlcore: Use common error handling code in wlcore_set_beacon_template()

using the Coccinelle software. > > Signed-off-by: Markus Elfring Reviewed-by: Julian Calaby However, > --- > drivers/net/wireless/ti/wlcore/main.c | 18 +++--- > 1 file changed, 7 insertions(+), 11 deletions(-) > > diff --git a/drivers/net/wireless/ti/wlcore/

Re: [PATCH 3/5] wlcore: Return directly after a failed ieee80211_beacon_get() in wlcore_set_beacon_template()

On Mon, Oct 30, 2017 at 7:13 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 29 Oct 2017 20:00:41 +0100 > > Return directly after a call of the function "ieee80211_beacon_get" > failed at the beginning. > > Signed-off-by: Markus Elfring Revi

Re: [PATCH 1/5] wlcore: Use common error handling code in wlcore_nvs_cb()

gt; complete_all(&wl->nvs_loading_complete); > + return; > + > +power_off: Name this "out_power_off" to match the other labels. > + wl1271_power_off(wl); > + goto out_free_nvs; Why not put this in front of the out_free_nvs label? It looks w

Re: [PATCH 2/5] wlcore: Delete an unnecessary check statement in wlcore_set_beacon_template()

e such unnecessary source code at the end of this function. > > Signed-off-by: Markus Elfring Looks good to me. Reviewed-by: Julian Calaby -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 28/44] sparc: remove arch specific dma_supported implementations

_sync_sg_for_cpu, > .sync_sg_for_device = sbus_sync_sg_for_device, > + .dma_supported = sbus_dma_supported, > }; > > static int __init sparc_register_ioport(void) Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] mwifiex: fix null pointer deference when adapter is null

null > pointer deference when accessing adapter->dev. This fix checks > for a null adapter at the start of the function and to exit > without the need to up the semaphore and we also skip the debug > to avoid the null pointer dereference. > > Signed-off-by: Colin Ian King

Re: [PATCH 2/2] mwifiex: simplify length computation for some memset

Hi All, On Mon, Aug 8, 2016 at 5:39 PM, Christophe JAILLET wrote: > This patch should be a no-op. It just simplifies code by using the name of > a variable instead of its type when calling 'sizeof'. > > Signed-off-by: Christophe JAILLET Reviewed-by: Julian Calaby Than

Re: [PATCH] ath10k: Spelling and miscellaneous neatening

t to me. I wish you'd put the code changes in a separate patch, however it's all noted in the commit log, so... Reviewed-by: Julian Calaby Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] rtl8xxxu: fix spelling mistake "firmare" -> "firmware"

Hi All, On Sun, Sep 4, 2016 at 2:43 AM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistakes in dev_dbg message. > > Signed-off-by: Colin Ian King Reviewed-by: Julian Calaby Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http:/

Re: [PATCH] ath10k: fix spelling mistake "montior" -> "monitor"

Hi All, On Sat, Aug 27, 2016 at 4:08 AM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in ath10k_warn message. > > Signed-off-by: Colin Ian King Reviewed-by: Julian Calaby Thanks, -- Julian Calaby Email: julian.cal...@gmail.co

Re: [PATCH] zd1211rw: fix spelling mistake "firmeware" -> "firmware"

Hi All, On Tue, Aug 23, 2016 at 4:35 AM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in dev_err message. > > Signed-off-by: Colin Ian King Looks right to me. Reviewed-by: Julian Calaby Thanks, -- Julian Calaby Email: julian.cal...@gmail.co

Re: [PATCH 2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

ret = 0; > } > > - out: Does this change make any difference to the compiled code? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback

;) > Signed-off-by: Javier Martinez Canillas Looks correct to me as Dan Carpenter submitted the same fix. Reviewed-by: Julian Calaby Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 0/4] Mesh mpm fixes and enhancements

t you send must be signed off by you, not ack'd by you. I.e. From: Random Developer . Signed-off-by: Random Developer Signed-off-by: Patch Sender Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] [linux-next] rtlwifi: Fix typo in printk

Hi All, On Wed, Jun 29, 2016 at 1:37 PM, Masanari Iida wrote: > This patch fix spelling typos found in drivers/net/wireless/realtek. > > Signed-off-by: Masanari Iida Looks right to me. Reviewed-by: Julian Calaby Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Prof

Re: [PATCH 7/8] mwifiex: don't print an error if an optional DT property is missing

Hi Javier, On Wed, Jun 1, 2016 at 11:51 PM, Javier Martinez Canillas wrote: > Hello Julian, > > Thanks a lot for your feedback and reviews. > > On 06/01/2016 12:20 AM, Julian Calaby wrote: >> Hi All, >> >> On Sat, May 28, 2016 at 12:18 AM, Javier Mar

Re: [PATCH 8/8] mwifiex: use better message and error code when OF node doesn't match

Signed-off-by: Javier Martinez Canillas This looks sensible to me. Reviewed-by: Julian Calaby > > --- > > drivers/net/wireless/marvell/mwifiex/sdio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 7/8] mwifiex: don't print an error if an optional DT property is missing

't be treated as an error. Have you checked whether it is truly optional? I.e. nothing else breaks if this property isn't set? > Signed-off-by: Javier Martinez Canillas Other than that, this looks sensible to me. Reviewed-by: Julian Calaby > --- > > drivers/net/wireles

Re: [PATCH 6/8] mwifiex: check if mwifiex_sdio_probe_of() fails and return error

d-by: Julian Calaby > --- > > drivers/net/wireless/marvell/mwifiex/sdio.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 4/8] mwifiex: consolidate mwifiex_sdio_probe() error paths

ide effect that the cleanup operations are made > in the inverse order of their counterparts, which was not the case for > the mwifiex_add_card() error path. > > Signed-off-by: Javier Martinez Canillas This looks sensible to me. Reviewed-by: Julian Calaby > --- > > drivers

Re: [PATCH 3/8] mwifiex: propagate mwifiex_add_card() errno code in mwifiex_sdio_probe()

hat failed. > > Signed-off-by: Javier Martinez Canillas This looks sensible to me. Reviewed-by: Julian Calaby > --- > > drivers/net/wireless/marvell/mwifiex/sdio.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Thanks, -- Julian Calaby Email: julian.cal...@gm

Re: [PATCH 5/8] mwifiex: use dev_err() instead of pr_err() in mwifiex_sdio_probe()

Hi All, On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas wrote: > It's better to have the device name prefixed in the error message. > > Signed-off-by: Javier Martinez Canillas This looks right to me. Reviewed-by: Julian Calaby > --- > > drivers/net/w

Re: [PATCH 2/8] mwifiex: propagate sdio_enable_func() errno code in mwifiex_sdio_probe()

ince the driver/device core prints the value returned by .probe in its > error message propagate what was returned by sdio_enable_func() at fail. > > Signed-off-by: Javier Martinez Canillas This looks sensible to me. Reviewed-by: Julian Calaby > --- > > drivers/net/wireless/marvel

Re: [PATCH 1/8] mwifiex: only call mwifiex_sdio_probe_of() if dev has an OF node

not available > > Signed-off-by: Javier Martinez Canillas This looks sensible to me. Reviewed-by: Julian Calaby > drivers/net/wireless/marvell/mwifiex/sdio.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] net/wireless: Fix 'multiple blank lines' check

ka Ruchandani Looks right to me. Reviewed-by: Julian Calaby > --- > net/wireless/ap.c | 1 - > net/wireless/chan.c| 3 --- > net/wireless/core.h| 2 -- > net/wireless/ibss.c| 1 - > net/wireless/mlme.c| 2 -- > net/wireless/rad

Re: [PATCH v2 06/10] nl80211: Various checkpatch.pl spacing fixes

With Kirtika's explanation, this is: Reviewed-by: Julian Calaby Thanks, Julian Calaby > --- > net/wireless/nl80211.c | 103 > ++--- > 1 file changed, 54 insertions(+), 49 deletions(-) > > diff --git a/net/wireless/nl8021

Re: [PATCH v2 06/10] nl80211: Various checkpatch.pl spacing fixes

ains two hunks to fix > 'line over 80 characters', > that are spacing related". This is the second hunk, the first being > the comments in the nl80211_fam > definition. Should I resend with these two hunks omitted, or fix my wording? That explains it, I missed that bit. Thanks,

Re: [PATCH v2 10/10] nl80211: Prefer kcalloc over kzalloc

Hi All, On Mon, May 30, 2016 at 12:54 PM, Kirtika Ruchandani wrote: > This patch fixes the checkpatch.pl warning - > "prefer kcalloc over kzalloc with multiply" > > Signed-off-by: Kirtika Ruchandani Looks right to me. Reviewed-by: Julian Calaby Thanks, Julian Calaby

Re: [PATCH v2 09/10] nl80211: Fix checkpatch.pl warning

Hi All, On Mon, May 30, 2016 at 12:54 PM, Kirtika Ruchandani wrote: > This patch fixes the checkpatch.pl warning "foo * bar should be > foo *bar" > > Signed-off-by: Kirtika Ruchandani Looks right to me. Reviewed-by: Julian Calaby Thanks, Julian Calaby > --- >

Re: [PATCH v2 08/10] nl80211: Fix spelling

Hi All, On Mon, May 30, 2016 at 12:54 PM, Kirtika Ruchandani wrote: > Fix 'implementation' spelling, reported by checkpatch.pl > > Signed-off-by: Kirtika Ruchandani Looks right to me. Reviewed-by: Julian Calaby Thanks, Julian Calaby > --- > net/wireless/n

Re: [PATCH v2 07/10] nl80211: Avoid multiple assignments on same line

Hi All, On Mon, May 30, 2016 at 12:53 PM, Kirtika Ruchandani wrote: > This patch fixes the checkpatch.pl warning "multiple assignments > should be avoided." > > Signed-off-by: Kirtika Ruchandani I'm not sure I agree with checkpatch here, but this looks right to me.

Re: [PATCH v2 06/10] nl80211: Various checkpatch.pl spacing fixes

Y_WIPHY_SELF_MANAGED) && > +nla_put_flag(msg, NL80211_ATTR_WIPHY_SELF_MANAGED_REG)) Adding the brackets around the & expression doesn't look spacing related to me. What's the exact warning this is fixing? > goto nla_put_fail

Re: [PATCH v2 05/10] nl80211: Fix checkpatch.pl NULL comparison warning

Hi All, On Mon, May 30, 2016 at 12:52 PM, Kirtika Ruchandani wrote: > This patch fixes the warning - "comparison to NULL (foo == NULL) > could be written as (!foo)" > > Signed-off-by: Kirtika Ruchandani Looks right to me. Reviewed-by: Julian Calaby Thanks, Julia

Re: [PATCH v2 04/10] nl80211: Fix checkpatch.pl warning about braces

Hi All, On Mon, May 30, 2016 at 12:52 PM, Kirtika Ruchandani wrote: > This patch fixes the following checkpatch,pl warning - > - braces {} should be used on all arms of this statement. > > Signed-off-by: Kirtika Ruchandani Looks right to me. Reviewed-by: Julian Calaby Thanks, J

Re: [PATCH v2 03/10] nl80211: Prefer ether_addr_copy

one more familiar with that review these changes to ensure they're met? Thanks, Julian Calaby > --- > net/wireless/nl80211.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c > index cd42

Re: [PATCH 3/3] nl80211: Various checkpatch.pl fixes

just patch 3/3 in > this one as a separate set? Re-send the entire set, make sure you mark it as v2, include a changelog in the cover letter or below the "---" in the patches themselves, and don't forget to include the reviewed-bys for any unchanged patches. Thanks, -- Julian

Re: [PATCH 3/3] nl80211: Various checkpatch.pl fixes

; - multiple assignments should be avoided ether_addr_copy: > - prefer ether_addr_copy over memcpy Spelling: > - correct spelling - 'implementation' NULL comparisons: > - comparison to NULL could be written as !foo kcalloc vs kzalloc: > - prefer kcalloc over kzalloc with

Re: [PATCH 2/3] nl80211: Fix checkpatch warnings about blank lines

> Signed-off-by: Kirtika Ruchandani Looks sensible to me Reviewed-by: Julian Calaby Thanks, Julian Calaby > --- > net/wireless/nl80211.c | 22 ++ > 1 file changed, 10 insertions(+), 12 deletions(-) > > diff --git a/net/wireless/nl80211.c b/net/wireless/nl8021

Re: [PATCH 1/3] nl80211: Fix checkpatch warnings

on a separate line > > Signed-off-by: Kirtika Ruchandani The change and logic behind it are sound, so it gets my: Reviewed-by: Julian Calaby however I'm concerned that this file is a deliberate exception to the networking comment rules. Johannes? Thanks, Julia

Re: [PATCH 2/2] rtlwifi: Fix reusable codes in core.c

erge. > Cannot fall back to three-way merge. > Patch failed at 0001 rtlwifi: Fix reusable codes in core.c > > Please rebase and resend. This one is already applied in some form. I thought I'd listed it in my big list of superseded patches, however I must have missed it. Thanks, -

Re: [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel()

Hi Kalle, On Fri, Apr 15, 2016 at 10:09 PM, Kalle Valo wrote: > Julian Calaby writes: > >> Hi Kalle, >> >> On Sat, Jan 2, 2016 at 5:25 AM, SF Markus Elfring >> wrote: >>> From: Markus Elfring >>> Date: Fri, 1 Jan 2016 19:09:32 +0100 >>

Re: [PATCH] ath9k: remove duplicate assignment of variable ah

Hi All, On Sun, Apr 10, 2016 at 9:25 PM, Colin King wrote: > From: Colin Ian King > > ah is written twice with the same value, remove one of the > redundant assignments to ah. > > Signed-off-by: Colin Ian King Looks right to me. Signed-off-by: Julian Calaby Thanks, &g

Re: [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel()

This looks sane to me. Reviewed-by: Julian Calaby Thanks, Julian Calaby > --- > drivers/net/wireless/ath/ath9k/htc_drv_main.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c > b/drivers/net/wi

Re: [PATCH] brcmfmac: sdio: remove unused variable retry_limit

Hi All, On Mon, Mar 21, 2016 at 4:34 AM, Colin King wrote: > From: Colin Ian King > > retry_limit has never been used during the life of this driver, so > we may as well remove it as it is redundant. > > Signed-off-by: Colin Ian King Looks right to me. Reviewed

Re: [PATCH][V3] mt7601u: do not free dma_buf when ivp allocation fails

> urb, buf and dma fields are free'd. Fix this by not free'ing the > dma_buf if the ivp allocation fails. > > Signed-off-by: Colin Ian King Looks right to me. Reviewed-by: Julian Calaby > --- > drivers/net/wireless/mediatek/mt7601u/mcu.c | 4 +++- > 1 file changed,

Re: [PATCH][V2] mt7601u: do not free dma_buf when ivp allocation fails

; > + if (!ivb) > + return -ENOMEM; > + if (mt7601u_usb_alloc_buf(dev, MCU_FW_URB_SIZE, &dma_buf)) > goto error; Are you sure this is right? Isn't ret unset here and consequently returned at the end of the error label? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] mwifiex: Use to_delayed_work()

/ > @@ > expression a; > symbol work; > @@ > - container_of(a, struct delayed_work, work) > + to_delayed_work(a) > // > > Signed-off-by: Amitoj Kaur Chawla Looks right to me. Reviewed-by: Julian Calaby Thanks, > --- > drivers/net/wireless/marvell/mwifiex/11h.c | 6

Re: [PATCH] ath10k: fix erroneous return value

Hi All, On Thu, Feb 11, 2016 at 3:58 AM, Anton Protopopov wrote: > The ath10k_pci_hif_exchange_bmi_msg() function may return the positive > value EIO instead of -EIO in case of error. > > Signed-off-by: Anton Protopopov This looks right to me. Reviewed-by: Julian Calaby > ---

Re: [PATCH 8/9] rfkill: Userspace control for airplane mode

> the caller has not acquired the airplane-mode control beforehand, the > operation fails. > > Signed-off-by: João Paulo Rechi Vita This looks sane to me. Reviewed-by: Julian Calaby Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 8/9] rfkill: Userspace control for airplane mode

cur; > + > + rfkill_apm_owned = false; > + data->is_apm_owner = false; > + rfkill_apm_led_trigger_event(state); Also, this code is duplicated from the _RELEASE op above. Would it make sense to factor it out into a separate function? > + } > + > list_del(&data->list); > + (extra line) > mutex_unlock(&rfkill_global_mutex); > > mutex_destroy(&data->mtx); Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 5/9] rfkill: Factor rfkill_global_states[].cur assignments

Hi João, On Tue, Feb 9, 2016 at 2:41 AM, João Paulo Rechi Vita wrote: > Factor all assignments to rfkill_global_states[].cur into a single > function rfkill_update_global_state(). > > Signed-off-by: João Paulo Rechi Vita Looks sane to me. Reviewed-by: Julian Calaby > --

Re: [PATCH 3/9] rfkill: Point to the correct deprecated doc location

Hi João, On Tue, Feb 9, 2016 at 2:41 AM, João Paulo Rechi Vita wrote: > The "claim" sysfs interface has been removed, so its documentation now > lives in the "removed" folder. > > Signed-off-by: João Paulo Rechi Vita Looks right to me. Reviewed-by: Julian Cal

Re: [PATCH 2/9] rfkill: Remove extra blank line

Hi João, On Tue, Feb 9, 2016 at 2:41 AM, João Paulo Rechi Vita wrote: > Signed-off-by: João Paulo Rechi Vita Looks sane to me. Reviewed-by: Julian Calaby > --- > net/rfkill/core.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/rfkill/core.c b/net/rfkill/core

Re: [PATCH 1/9] rfkill: Improve documentation language

Hi João, On Tue, Feb 9, 2016 at 2:41 AM, João Paulo Rechi Vita wrote: > Signed-off-by: João Paulo Rechi Vita Looks right to me. Reviewed-by: Julian Calaby > --- > net/rfkill/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/rfkill/c

Re: [PATCH 2/2] rtlwifi: Fix reusable codes in core.c

Hi Byeoungwook, On Wed, Feb 3, 2016 at 1:01 PM, Byeoungwook Kim wrote: > rtl_*_delay() functions were reused same codes about addr variable. > So i have converted to rtl_addr_delay() from code about addr variable. > > Signed-off-by: Byeoungwook Kim > Reviewed-by: Julian Calaby

Re: [PATCH 1/2] rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

Hi Byeounwook, On Wed, Feb 3, 2016 at 12:59 PM, Byeoungwook Kim wrote: > Conditional codes in rtl_addr_delay() were improved in readability and > performance by using switch codes. > > Signed-off-by: Byeoungwook Kim > Reported-by: Julian Calaby Reviewed-by: Julian Calaby

Re: [PATCH] rtlwifi: Fix reusable codes in core.c

nswers of some parts. I think that i should divide > into separate patch. > Thanks for your assists! Not a problem! Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] rtlwifi: Fix reusable codes in core.c

dr == 0xfa) { > - udelay(5); > - } else if (addr == 0xf9) { > - udelay(1); > + if (addr >= 0xf9 && addr <= 0xfe) { > + rtl_addr_delay(addr); > } else { > rtl_set_bbreg(hw, addr, MASKDWORD, data); > udelay(1); Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] mac80211: fix memory leak

Hi Sudip, On Mon, Feb 1, 2016 at 8:33 PM, Sudip Mukherjee wrote: > On Mon, Feb 01, 2016 at 11:28:37AM +0200, Kalle Valo wrote: >> Sudip Mukherjee writes: >> >> > On Mon, Feb 01, 2016 at 11:03:35AM +1100, Julian Calaby wrote: >> >> Hi Sudip, >> >&

Re: [PATCH] mac80211: fix memory leak

Hi Sudip, On Mon, Feb 1, 2016 at 3:25 PM, Sudip Mukherjee wrote: > On Mon, Feb 01, 2016 at 11:03:35AM +1100, Julian Calaby wrote: >> Hi Sudip, >> >> On Fri, Jan 29, 2016 at 8:49 PM, Sudip Mukherjee >> wrote: >> > On error we jumped to the error labe

Re: [PATCH] mac80211: fix memory leak

this is fixing is only in the mac80211-next tree. Fixes: 5fe74014172d ("mac80211: avoid excessive stack usage in sta_info") Reviewed-by: Julian Calaby Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH v2 net] nfc: use GFP_USER for user-controlled kmalloc

ter your patch), but having a way to > spill stack traces in the syslog. > > Acked-by: Eric Dumazet Reviewed-by: Julian Calaby Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH RESEND net] nfc: use GFP_USER for user-controlled kmalloc

Hi Cong, On Wed, Jan 27, 2016 at 10:12 AM, Cong Wang wrote: > On Tue, Jan 26, 2016 at 2:55 PM, Julian Calaby > wrote: >> Hi Cong, >> >> On Wed, Jan 27, 2016 at 4:53 AM, Cong Wang wrote: >> >> A commit message would be nice. A brief rundown of how this is ca

Re: [PATCH RESEND net] nfc: use GFP_USER for user-controlled kmalloc

ap, > if (local == NULL) > return -ENODEV; > > - msg_data = kzalloc(len, GFP_KERNEL); > + msg_data = kzalloc(len, GFP_USER | __GFP_NOWARN); > if (msg_data == NULL) > return -ENOMEM; Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] brcmfmac: sdio: Increase the default timeouts a bit

Hi Arend, On Tue, Jan 26, 2016 at 2:39 AM, Arend van Spriel wrote: > On 25-01-16 12:06, Julian Calaby wrote: >> Hi Sjoerd, >> >> On Mon, Jan 25, 2016 at 9:47 PM, Sjoerd Simons >> wrote: >>> On a Radxa Rock2 board with a Ampak AP6335 (Broadcom 4339 core)

Re: [PATCH] brcmfmac: sdio: Increase the default timeouts a bit

ore headroom allows the > card to initialize reliably. > > A quick search online after diagnosing/fixing this showed that Google > has a similar patch in their ChromeOS tree, so this doesn't seem > specific to the board I'm using. > > Signed-off-by: Sjoerd Simons Looks s

Re: rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

u sent late June last year, your patches to remove conditions before kfree() and friends, etc. You need to change you attitude: just because you can see some benefit from your patches doesn't mean others do and it doesn't mean that they're willing to accept them. Thanks, -- Julian Cala

Re: rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

27;ve proposed that have seen any discussion whatsoever fall into the latter category. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] wlcore: consolidate kmalloc + memset 0 into kzalloc

Hi Nicholas, On Tue, Dec 22, 2015 at 6:29 PM, Nicholas Mc Guire wrote: > On Tue, Dec 22, 2015 at 09:56:10AM +1100, Julian Calaby wrote: >> Hi, >> >> On Tue, Dec 22, 2015 at 3:47 AM, Nicholas Mc Guire wrote: >> > This is an API consolidation only. The use of

Re: [PATCH] wlcore: consolidate kmalloc + memset 0 into kzalloc

lock, > wl->fw_mem_block_size, false); > > -- > 2.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http:/