Re: [PATCHv3 bpf-next 1/5] bpf: Allow trampoline re-attach for tracing and lsm programs (fwd)

Please check the goto on line 2663. Is an unlock needed here? julia -- Forwarded message -- Date: Mon, 12 Apr 2021 01:28:54 +0800 From: kernel test robot To: kbu...@lists.01.org Cc: l...@intel.com, Julia Lawall Subject: Re: [PATCHv3 bpf-next 1/5] bpf: Allow trampoline re

Re: [PATCH net-next v8 2/2] net: Add Qcom WWAN control driver (fwd)

There is a clear use after free on line 213. julia -- Forwarded message -- Date: Sat, 3 Apr 2021 04:42:45 +0800 From: kernel test robot To: kbu...@lists.01.org Cc: l...@intel.com, Julia Lawall Subject: Re: [PATCH net-next v8 2/2] net: Add Qcom WWAN control driver CC: kbuild

[PATCH] sit: use min

From: kernel test robot Opportunity for min() Generated by: scripts/coccinelle/misc/minmax.cocci CC: Denis Efremov Reported-by: kernel test robot Signed-off-by: kernel test robot --- sit.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/ipv6/sit.c +++ b/net/ipv6/sit.c @

[PATCH v2] net: phy: mscc: fix excluded_middle.cocci warnings

kernel test robot Signed-off-by: Julia Lawall --- v2: add netdev mailing list tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e28c0d7c92c89016c12a677616668957351e7542 commit: b76f0ea013125358d1b4ca147a6f9b6883dd2493 coccinelle: misc: add excluded_m

[PATCH] forcedeth: fix excluded_middle.cocci warnings

From: kernel test robot Condition !A || A && B is equivalent to !A || B. Generated by: scripts/coccinelle/misc/excluded_middle.cocci Fixes: b76f0ea01312 ("coccinelle: misc: add excluded_middle.cocci script") CC: Denis Efremov Signed-off-by: kernel test robot Signed-of

[PATCH] cxgb4/ch_ktls: fix call_kern.cocci warnings

: kernel test robot Signed-off-by: Julia Lawall --- Hello, Please check on this. Normally, it relates to the call site of the function. julia url: https://github.com/0day-ci/linux/commits/Rohit-Maheshwari/cxgb4-ch_ktls-Fixes-in-nic-tls-code/20201023-133301 base: https://git.kernel.org/pub/scm

Re: [Cocci] [RFC] treewide: cleanup unreachable breaks

On Sat, 17 Oct 2020, Joe Perches wrote: > On Sat, 2020-10-17 at 09:09 -0700, t...@redhat.com wrote: > > From: Tom Rix > > > > This is a upcoming change to clean up a new warning treewide. > > I am wondering if the change could be one mega patch (see below) or > > normal patch per file about 10

Re: [PATCH 1/5] rxrpc: use semicolons rather than commas to separate statements

On Mon, 12 Oct 2020, David Howells wrote: > Julia Lawall wrote: > > > - call->completion = compl, > > + call->completion = compl; > > Looks good. Do you want me to pick up the patch or send it yourself? Please pick it up. Thanks. julia &

[PATCH 4/5] net/ipv6: use semicolons rather than commas to separate statements

-by: Julia Lawall --- net/ipv6/calipso.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/calipso.c b/net/ipv6/calipso.c index 8d3f66c310db..78f766019b7e 100644 --- a/net/ipv6/calipso.c +++ b/net/ipv6/calipso.c @@ -761,7 +761,7 @@ static int calipso_genopt(unsigned

[PATCH 3/5] tcp: use semicolons rather than commas to separate statements

-by: Julia Lawall --- net/ipv4/tcp_input.c |3 ++- net/ipv4/tcp_vegas.c |8 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 02d0e2fb77c0..7ff9be52c061 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c

[PATCH 5/5] net/tls: use semicolons rather than commas to separate statements

-by: Julia Lawall --- net/tls/tls_main.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tls/tls_main.c b/net/tls/tls_main.c index 002b0859fed5..8d93cea99f2c 100644 --- a/net/tls/tls_main.c +++ b/net/tls/tls_main.c @@ -869,7 +869,7 @@ static int __init tls_register(void

[PATCH 0/5] net: use semicolons rather than commas to separate statements

These patches replace commas by semicolons. Commas introduce unnecessary variability in the code structure and are hard to see. This was done using the Coccinelle semantic patch (http://coccinelle.lip6.fr/) shown below. This semantic patch ensures that commas inside for loop headers will not be t

[PATCH 1/5] rxrpc: use semicolons rather than commas to separate statements

-by: Julia Lawall --- net/rxrpc/recvmsg.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/recvmsg.c b/net/rxrpc/recvmsg.c index c4684dde1f16..acc4660cfa5b 100644 --- a/net/rxrpc/recvmsg.c +++ b/net/rxrpc/recvmsg.c @@ -69,7 +69,7 @@ bool __rxrpc_set_call_completion

[PATCH 2/5] mac80211: use semicolons rather than commas to separate statements

-by: Julia Lawall --- net/mac80211/debugfs_sta.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/debugfs_sta.c b/net/mac80211/debugfs_sta.c index 829dcad69c2c..6a51b8b58f9e 100644 --- a/net/mac80211/debugfs_sta.c +++ b/net/mac80211/debugfs_sta.c @@ -274,7

[PATCH 03/14] dpaa2-eth: drop double zeroing

flags) ... sg_init_table(x,n) // Signed-off-by: Julia Lawall --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -u -p a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c --- a/drivers/net/eth

[PATCH 10/14] iwlwifi: dbg_ini: drop double zeroing

e(x,n) // Signed-off-by: Julia Lawall --- drivers/net/wireless/intel/iwlwifi/fw/dbg.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -u -p a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c --- a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c

[PATCH 08/14] xprtrdma: drop double zeroing

e(x,n) // Signed-off-by: Julia Lawall --- net/sunrpc/xprtrdma/frwr_ops.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -u -p a/net/sunrpc/xprtrdma/frwr_ops.c b/net/sunrpc/xprtrdma/frwr_ops.c --- a/net/sunrpc/xprtrdma/frwr_ops.c +++ b/net/sunrpc/xprtrdma/frwr_ops.c @@ -124,7 +124,7 @

[PATCH 00/14] drop double zeroing

sg_init_table zeroes its first argument, so the allocation of that argument doesn't have to. --- block/bsg-lib.c |2 +- drivers/dma/sh/rcar-dmac.c |2 +- drivers/dma/sh/shdma-base.c |2 +- drivers/infiniband/

[PATCH 07/14] RDS: drop double zeroing

e(x,n) // Signed-off-by: Julia Lawall --- net/rds/rdma.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -u -p a/net/rds/rdma.c b/net/rds/rdma.c --- a/net/rds/rdma.c +++ b/net/rds/rdma.c @@ -269,7 +269,7 @@ static int __rds_rdma_map(struct rds_soc goto out; }

[PATCH 4/7] net/mlx5: drop unnecessary list_empty

(with another variant for the no brace case): (http://coccinelle.lip6.fr/) @@ expression x,e; iterator name list_for_each_entry; statement S; identifier i; @@ -if (!(list_empty(x))) { list_for_each_entry(i,x,...) S - } ... when != i ? i = e Signed-off-by: Julia Lawall --- drivers/net

[PATCH 2/7] sfc: drop unnecessary list_empty

x,e; iterator name list_for_each_safe; statement S; identifier i,j; @@ -if (!(list_empty(x))) { list_for_each_safe(i,j,x) S - } ... when != i when != j ( i = e; | ? j = e; ) Signed-off-by: Julia Lawall --- drivers/net/ethernet/sfc/ptp.c | 20 +--- 1 file changed

[PATCH 7/7] ath: drop unnecessary list_empty

change for the list_for_each_entry case is as follows: (http://coccinelle.lip6.fr/) @@ expression x,e; statement S; identifier i; @@ -if (!(list_empty(x))) list_for_each_entry(i,x,...) S ... when != i ? i = e Signed-off-by: Julia Lawall --- drivers/net/wireless/ath

[PATCH 0/7] drop unnecessary list_empty

The various list iterators are able to handle an empty list. The only effect of avoiding the loop is not initializing some index variables. Drop list_empty tests in cases where these variables are not used. The semantic patch that makes these changes is as follows: (http://coccinelle.lip6.fr/) @

Re: [PATCH] decnet: dn_dev: Remove an unnecessary label.

On Tue, 14 Jul 2020, Suraj Upadhyay wrote: > Remove the unnecessary label from dn_dev_ioctl() and make its error > handling simpler to read. > > Signed-off-by: Suraj Upadhyay > --- > net/decnet/dn_dev.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/net/decne

Re: [PATCH] net: sky2: switch from 'pci_' to 'dma_' API

On Sun, 12 Jul 2020, Christophe JAILLET wrote: > Le 12/07/2020 à 08:32, Joe Perches a écrit : > > On Sun, 2020-07-12 at 08:29 +0200, Christophe JAILLET wrote: > > > Le 11/07/2020 à 23:20, Joe Perches a écrit : > > > > On Sat, 2020-07-11 at 22:49 +0200, Christophe JAILLET wrote: > > > > > The wra

[PATCH] dp83640: reverse arguments to list_add_tail

as the second argument. Fixes: cb646e2b02b27 ("ptp: Added a clock driver for the National Semiconductor PHYTER.") Signed-off-by: Julia Lawall --- Not tested. drivers/net/phy/dp83640.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/dp83640.c b/dr

Re: [PATCH net-next v3 2/4] gve: Add transmit and receive support (fwd)

Please check on line 124. julia -- Forwarded message -- Date: Sat, 29 Jun 2019 22:06:06 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH net-next v3 2/4] gve: Add transmit and receive support CC: kbuild-...@01.org In-Reply-To

Re: [PATCH v2 net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe()

On Mon, 29 Apr 2019, YueHaibing wrote: > Change the call to PTR_ERR to access the value just tested by IS_ERR. I assume you didn't find the problem just looking through the code by hand. If you used a tool, it would be really good to acknowledge the tool that was used. The tools don't come f

[PATCH] ath11k: fix bugon.cocci warnings

From: kbuild test robot Use BUG_ON instead of if condition followed by BUG. Generated by: scripts/coccinelle/misc/bugon.cocci Fixes: c105b7abf400 ("ath11k: collect DDR dump after fw crash") CC: Venkateswara Naralasetty Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall

Re: [Outreachy kernel] [PATCH] net: ax25: Fix multiple blank lines warning

On Sat, 23 Feb 2019, Jules Irenge wrote: You need a commit message here. > Signed-off-by: Jules Irenge > --- > net/ax25/af_ax25.c | 2 -- This is the same file as in your previous patch, so they should be in a series. But please work on files in drivers/staging instead. julia > 1 file chang

Re: [PATCH v3] net: ns83820: code cleanup for ns83820_probe_phy()

On Tue, 19 Feb 2019, Mao Wenan wrote: > This patch is to do code cleanup for ns83820_probe_phy(). > It deletes unused variable 'first' and commented out code. > > Signed-off-by: Mao Wenan Acked-by: Julia Lawall > --- > v2->v3: delte unused variable '

Re: [PATCH v2] net: ns83820: drop pointless static qualifier in ns83820_probe_phy()

On Tue, 19 Feb 2019, Mao Wenan wrote: > There is no need to have the 'int first' static > since new value always be assigned before use it. > > This patch cleans up the codes in ns83820_probe_phy() as well. As mentioned previously, there is no use of first in the function at all, other than se

Re: [PATCH] net: ns83820: drop pointless static qualifier in ns83820_probe_phy()

On Tue, 19 Feb 2019, maowenan wrote: > > > On 2019/2/19 16:01, Julia Lawall wrote: > > > > > > On Tue, 19 Feb 2019, Mao Wenan wrote: > > > >> There is no need to have the 'int first' static > >> since new value always be assigned

Re: [PATCH] net: ns83820: drop pointless static qualifier in ns83820_probe_phy()

On Tue, 19 Feb 2019, Mao Wenan wrote: > There is no need to have the 'int first' static > since new value always be assigned before use it. > The old codes of first dereferencing this variable have > been commented out. So it is useless with 'static int first'. > /* > if (!first) { > ... > } >

Re: [PATCH 2/2] mac80211: Free mpath object when rhashtable insertion fails (fwd)

Perhaps a return is needed after line 436. julia -- Forwarded message -- Date: Wed, 13 Feb 2019 20:29:38 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH 2/2] mac80211: Free mpath object when rhashtable insertion fails CC: kbuild-...@01

Re: [PATCH 20/20] cw1200: drop useless LIST_HEAD

On Tue, 8 Jan 2019, Kalle Valo wrote: > Julia Lawall writes: > > > Drop LIST_HEAD where the variable it declares has never > > been used. > > > > The semantic patch that fixes this problem is as follows: > > (http://coccinelle.lip6.fr/)

[PATCH 3/8] i40e: increase indentation

Convert spaces to tabs to get correct alignment. Found with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/net/ethernet/intel/i40e/i40e_main.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net

[PATCH 0/8] reduce indentation

These patches fix cases where a subsequent statement is aligned with the right hand side of an assignment rather than the left hand side. This was done using the following semantic match (http://coccinelle.lip6.fr/). It has a lot of false positives, because Coccinelle doesn't record the differenc

[PATCH 2/8] net: ena: reduce indentation

Delete tab aligning a statement with the right hand side of a preceding assignment rather than the left hand side. Found with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/net/ethernet/amazon/ena/ena_eth_com.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [PATCH 00/20] drop useless LIST_HEAD

On Fri, 28 Dec 2018, Darrick J. Wong wrote: > On Thu, Dec 27, 2018 at 04:40:55PM +0300, Dan Carpenter wrote: > > On Tue, Dec 25, 2018 at 11:12:20PM +0100, Tom Psyborg wrote: > > > there was discussion about this just some days ago. CC 4-5 lists is > > > more than enough > > > > > > > I don't kn

Re: [PATCH 00/20] drop useless LIST_HEAD

ted files. julia > > On 23/12/2018, Julia Lawall wrote: > > Drop LIST_HEAD where the variable it declares is never used. > > > > --- > > > > drivers/dma/at_hdmac.c|5 - > > drivers/dma/dw/core.c

[PATCH 02/20] net/mlx5e: drop useless LIST_HEAD

when != x // Fixes: 244cd96adb5f ("net_sched: remove list_head from tc_action") Signed-off-by: Julia Lawall --- Successfully 0-day tested on 151 configurations. drivers/net/ethernet/mellanox/mlx5/core/en_tc.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/etherne

[PATCH 00/20] drop useless LIST_HEAD

Drop LIST_HEAD where the variable it declares is never used. --- drivers/dma/at_hdmac.c|5 - drivers/dma/dw/core.c |1 - drivers/dma/pl330.c |1 - drivers/dma/sa11x0-dma.c

[PATCH 19/20] net/mlx4_core: drop useless LIST_HEAD

ed by guests") Signed-off-by: Julia Lawall --- Successfully 0-day tested on 151 configurations. drivers/net/ethernet/mellanox/mlx4/resource_tracker.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mel

[PATCH 20/20] cw1200: drop useless LIST_HEAD

1200 WLAN chipsets") Signed-off-by: Julia Lawall --- Successfully 0-day tested on 151 configurations. drivers/net/wireless/st/cw1200/queue.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/st/cw1200/queue.c b/drivers/net/wireless/st/cw1200/queue.c index 7c31b63b8258

[PATCH 16/20] mlxsw: spectrum: drop useless LIST_HEAD

LIST_HEAD(x); ... when != x // Fixes: 244cd96adb5f ("net_sched: remove list_head from tc_action") Signed-off-by: Julia Lawall --- Successfully 0-day tested on 151 configurations. drivers/net/ethernet/mellanox/mlxsw/spectrum.c |1 - 1 file changed, 1 deletion(-) diff --git a/

Re: [PATCH net-next,v4 01/12] flow_offload: add flow_rule and flow_match structures and use them (fwd)

Hello, It looks like the kfree on line 1573 should be moved down a few lines. julia -- Forwarded message -- Date: Sat, 1 Dec 2018 11:11:55 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH net-next, v4 01/12] flow_offload: add flow_rule

Re: [PATCH] net: sched: Fix memory exposure from short TCA_U32_SEL

On Mon, 27 Aug 2018, Al Viro wrote: > On Sun, Aug 26, 2018 at 11:35:17PM -0400, Julia Lawall wrote: > > > * x = \(kmalloc\|kzalloc\|devm_kmalloc\|devm_kzalloc\)(...) > > I can name several you've missed right off the top of my head - > vmalloc, kvmalloc, kmem_cach

Re: [PATCH] net: sched: Fix memory exposure from short TCA_U32_SEL

On Mon, 27 Aug 2018, Al Viro wrote: > On Sun, Aug 26, 2018 at 10:00:46PM -0400, Julia Lawall wrote: > > > > > > On Sun, 26 Aug 2018, Al Viro wrote: > > > > > On Sun, Aug 26, 2018 at 03:26:54PM -0700, Joe Perches wrote: > > > > On Sun, 2018-08-26

Re: [PATCH] net: sched: Fix memory exposure from short TCA_U32_SEL

On Sun, 26 Aug 2018, Al Viro wrote: > On Sun, Aug 26, 2018 at 03:26:54PM -0700, Joe Perches wrote: > > On Sun, 2018-08-26 at 22:24 +0100, Al Viro wrote: > > > On Sun, Aug 26, 2018 at 11:57:57AM -0700, Joe Perches wrote: > > > > > > > > That, BTW, is why I hate the use of sizeof(*p) in kmalloc,

Re: [PATCH] net: sched: Fix memory exposure from short TCA_U32_SEL

On Sun, 26 Aug 2018, Joe Perches wrote: > On Sun, 2018-08-26 at 22:24 +0100, Al Viro wrote: > > On Sun, Aug 26, 2018 at 11:57:57AM -0700, Joe Perches wrote: > > > > > > That, BTW, is why I hate the use of sizeof(*p) in kmalloc, etc. > > > > arguments. typeof is even worse in that respect. > >

[PATCH] mwifiex: delete unneeded include

Nothing that is defined in 11ac.h is referenced in cmdevt.c. Signed-off-by: Julia Lawall --- drivers/net/wireless/marvell/mwifiex/cmdevt.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/cmdevt.c b/drivers/net/wireless/marvell/mwifiex/cmdevt.c index

Re: [PATCH V2] net/netlink: optimize seq_puts and seq_printf in af_netlink.c

On Thu, 3 May 2018, YU Bo wrote: > Before the patch, the command `cat /proc/net/netlink` will output like: > > https://clbin.com/BojZv > > After the patch: > > https://clbin.com/lnu4L > > The optimization will make convenience for using `cat /proc/net/netlink` > But,The checkpatch will give a wa

Re: [PATCH net-next 2/2] openvswitch: Support conntrack zone limit (fwd)

Line 1814 frees something that is dereferenced on the next line. julia -- Forwarded message -- Date: Tue, 17 Apr 2018 10:32:17 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH net-next 2/2] openvswitch: Support conntrack zone limit CC

Re: [PATCH 08/12] mmc: reduce use of block bounce buffers (fwd)

There is a duplicated test on line 360. julia -- Forwarded message -- Date: Mon, 16 Apr 2018 23:04:18 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH 08/12] mmc: reduce use of block bounce buffers CC: kbuild-...@01.org In-Reply-To

Re: [PATCH v11 crypto 01/12] tls: support for Inline tls record (fwd)

ctx is dereferenced on line 258 but has been freed on line 229. julia -- Forwarded message -- Date: Sun, 18 Mar 2018 18:05:25 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH v11 crypto 01/12] tls: support for Inline tls record CC: kbuild

Re: [PATCH v11 crypto 12/12] crypto: chtls - Makefile Kconfig (fwd)

Please check the indentation on line 1655. thanks, julia -- Forwarded message -- Date: Sun, 18 Mar 2018 18:15:36 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH v11 crypto 12/12] crypto: chtls - Makefile Kconfig CC: kbuild-...@01.org In

Re: [Outreachy kernel] Re: [PATCH v2] net: ethernet: Drop unnecessary continue

On Wed, 7 Mar 2018, Arushi Singhal wrote: > > > On Wed, Mar 7, 2018 at 9:09 PM, David Miller wrote: > From: Arushi Singhal > Date: Sat, 3 Mar 2018 21:44:56 +0530 > > > Continue at the bottom of a loop are removed. > > Issue found using drop_continue.cocci Coccinelle scr

Re: [Outreachy kernel] [PATCH v3] staging: ipx: Replace printk() with appropriate net_*macro_ratelimited()

On Mon, 5 Mar 2018, Arushi Singhal wrote: > Replace printk having a log level with the appropriate > net_*macro_ratelimited. > It's better to use actual device name as a prefix in error messages. > > Signed-off-by: Arushi Singhal > --- > changes in v2 > *In v1 printk was changed to pr_*macro(),

Re: [Outreachy kernel] [PATCH v2] staging: Replace printk() with appropriate net_*macro_ratelimited()

On Mon, 5 Mar 2018, Arushi Singhal wrote: > Replace printk having a log level with the appropriate > net_*macro_ratelimited. Why did you choose this function? > It's better to use actual device name as a prefix in error messages. What does this message relate to. > Indentation is also change

Re: [Outreachy kernel] [PATCH] net: ethernet: Drop unnecessary continue

On Sat, 3 Mar 2018, Arushi Singhal wrote: > Continue at the bottom of a loop are removed. > Issue found using drop_continue.cocci Coccinelle script. In each case you leave an if with a single statement in the branch. In that case the { } should be dropped too. julia > > Signed-off-by: Arushi

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

On Tue, 6 Feb 2018, Dan Carpenter wrote: > That found 4 that I think Wolfram's grep missed. > > arch/um/drivers/vector_user.h |2 -- > drivers/gpu/drm/mxsfb/mxsfb_regs.h|2 -- > drivers/video/fbdev/mxsfb.c |2 -- > include/drm/drm_scdc_helper.h

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

On Tue, 6 Feb 2018, Wolfram Sang wrote: > Hi Julia, > > > and got the results below. I can make a version for the kernel shortly. > > It should probably take care of right-shifting, too? I did that too but got no results. Perhaps right shifting constants is pretty uncommon. I can put that in

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

On Tue, 6 Feb 2018, Dan Carpenter wrote: > On Tue, Feb 06, 2018 at 02:15:51PM +0100, Julia Lawall wrote: > > > > > > On Tue, 6 Feb 2018, Dan Carpenter wrote: > > > > > On Mon, Feb 05, 2018 at 09:09:57PM +0100, Wolfram Sang wrote: > > > > In on

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

On Tue, 6 Feb 2018, Dan Carpenter wrote: > On Mon, Feb 05, 2018 at 09:09:57PM +0100, Wolfram Sang wrote: > > In one Renesas driver, I found a typo which turned an intended bit shift > > ('<<') > > into a comparison ('<'). Because this is a subtle issue, I looked tree wide > > for > > similar p

[PATCH] netfilter: nf_tables: fix odd_ptr_err.cocci warnings

tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: b4464bcab38d3f7fe995a7cb960eeac6889bec08 commit: 3b49e2e94e6ebb8b23d0955d9e898254455734f8 [8286/9035] netfilter: nf_tables: add flow table netlink frontend The following is a 0-day report generated by Coccinel

Re: [PATCH] ethernet: mlx4: Delete an error message for a failed memory allocation in five functions

On Wed, 3 Jan 2018, Tariq Toukan wrote: > > > On 01/01/2018 10:46 PM, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Mon, 1 Jan 2018 21:42:27 +0100 > > > > Omit an extra message for a memory allocation failure in these functions. > > > > This issue was detected by using the Coccine

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

On Tue, 2 Jan 2018, Bart Van Assche wrote: > On Tue, 2018-01-02 at 15:00 +0100, Julia Lawall wrote: > > On Tue, 2 Jan 2018, Bob Peterson wrote: > > > - Original Message - > > > > - Original Message - > > > > > > > Still, the G

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

On Tue, 2 Jan 2018, Bob Peterson wrote: > - Original Message - > | - Original Message - > | | Drop newline at the end of a message string when the printing function > adds > | | a newline. > | > | Hi Julia, > | > | NACK. > | > | As much as it's a pain when searching the source c

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

On Tue, 2 Jan 2018, Bob Peterson wrote: > - Original Message - > | Drop newline at the end of a message string when the printing function adds > | a newline. > > Hi Julia, > > NACK. > > As much as it's a pain when searching the source code for output strings, > this patch set goes agains

[PATCH 03/12] net: dccp: drop unneeded newline

DCCP_CRIT prints some other text and then a newline after the message string, so the message string does not need to include a newline explicitly. Done using Coccinelle. Signed-off-by: Julia Lawall --- net/dccp/ackvec.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 05/12] openvswitch: drop unneeded newline

OVS_NLERR prints a newline at the end of the message string, so the message string does not need to include a newline explicitly. Done using Coccinelle. Signed-off-by: Julia Lawall --- net/openvswitch/conntrack.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net

[PATCH 00/12] drop unneeded newline

Drop newline at the end of a message string when the printing function adds a newline. The complete semantic patch that detects this issue is as shown below (http://coccinelle.lip6.fr/). It works in two phases - the first phase counts how many uses of a function involve a newline and how many don

Pravin Shelar

The email address pshe...@nicira.com listed for Pravin Shelar in MAINTAINERS (OPENVSWITCH section) seems to bounce. julia

Re: [PATCH v4 net-next 6/6] ila: Route notify (fwd)

Hello, Another tab appears to be needed on line 358. julia -- Forwarded message -- Date: Sun, 17 Dec 2017 05:42:17 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH v4 net-next 6/6] ila: Route notify CC: kbuild-...@01.org In-Reply-To

Re: [PATCH v2 3/3] net: macb: change GFP_ATOMIC to GFP_KERNEL

On Tue, 5 Dec 2017, Julia Cartwright wrote: > Now that the rx_fs_lock is no longer held across allocation, it's safe > to use GFP_KERNEL for allocating new entries. > > This reverts commit 81da3bf6e3f88 ("net: macb: change GFP_KERNEL to > GFP_ATOMIC"). > &g

[PATCH v2] net: macb: change GFP_KERNEL to GFP_ATOMIC

Function gem_add_flow_filter called on line 2958 inside lock on line 2949 but uses GFP_KERNEL Generated by: scripts/coccinelle/locks/call_kern.cocci Fixes: ae8223de3df5 ("net: macb: Added support for RX filtering") CC: Rafal Ozieblo Signed-off-by: Julia Lawall Signed-off-by: Fe

Re: [Outreachy kernel] Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

On Thu, 23 Nov 2017, Greg Kroah-Hartman wrote: > On Wed, Nov 22, 2017 at 10:20:49PM +0100, Julia Lawall wrote: > > > > > > On Wed, 22 Nov 2017, Joe Perches wrote: > > > > > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > > > There

Re: [Outreachy kernel] Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

On Wed, 22 Nov 2017, Joe Perches wrote: > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > There is no need to #define the license of the driver, just put it in > > the MODULE_LICENSE() line directly as a text string. > > > > This allows tools that check that the module license m

Re: [Outreachy kernel] Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

On Wed, 22 Nov 2017, Joe Perches wrote: > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > There is no need to #define the license of the driver, just put it in > > the MODULE_LICENSE() line directly as a text string. > > > > This allows tools that check that the module license m

Re: [PATCH v2 02/15] usb: gadget: make config_item_type structures const

On Thu, 19 Oct 2017, Laurent Pinchart wrote: > Hi Christoph, > > On Thursday, 19 October 2017 17:06:57 EEST Christoph Hellwig wrote: > > > Now we have 9 const instances of the config_item_type structure that are > > > identical, with only the .ct_owner field set. Should they be all merged > > >

Re: [PATCH v2 00/15] make structure field, function arguments and structures const

On Tue, 17 Oct 2017, Greg KH wrote: > On Mon, Oct 16, 2017 at 05:18:39PM +0200, Bhumika Goyal wrote: > > Make the ci_type field and some function arguments as const. After this > > change, make config_item_type structures as const. > > > > * Changes in v2- Combine all the followup patches and th

Re: [PATCH] net: phy: DP83822 initial driver submission (fwd)

DP83822_WOL_CLR_INDICATION appears twice on line 136. Perhaps this is not what is wanted. julia -- Forwarded message -- Date: Thu, 5 Oct 2017 21:38:28 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH] net: phy: DP83822 initial driver

Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit

On Fri, 22 Sep 2017, Joe Perches wrote: > On Fri, 2017-09-22 at 12:06 +0200, Julia Lawall wrote: > > > > On Fri, 22 Sep 2017, Colin Ian King wrote: > > > > > On 22/09/17 11:03, Joe Perches wrote: > > > > On Fri, 2017-09-22 at 09:23 +0200, Julia Lawall

Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit

On Fri, 22 Sep 2017, Colin Ian King wrote: > On 22/09/17 11:03, Joe Perches wrote: > > On Fri, 2017-09-22 at 09:23 +0200, Julia Lawall wrote: > >> > >> On Thu, 21 Sep 2017, Colin King wrote: > >> > >>> From: Colin Ian King > >>> &g

Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit

On Thu, 21 Sep 2017, Colin King wrote: > From: Colin Ian King > > Don't populate const array ac_to_fifo on the stack in an inlined > function, instead make it static. Makes the object code smaller > by over 800 bytes: > >text data bss dec hex filename > 159029

Re: [Outreachy kernel] [PATCH] Staging: irda: Use !x instead of NULL comparison

kmalloc_array\|devm_ioremap\| > usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\)(...)); > > ( > if(!E) >S > | > -if(E==NULL) > +if(!E) > S > ) > > Signed-off-by: Srishti Sharma Acked-by: Julia Lawall > --- > drivers/staging/irda/net/discovery.c | 4 ++-

Re: [Outreachy kernel] Re: [PATCH 2/2] Staging: irda: Remove parentheses on the right of assignment

On Fri, 15 Sep 2017, Joe Perches wrote: > On Sat, 2017-09-16 at 02:36 +0530, Srishti Sharma wrote: > > Parentheses are not needed on the right hand side of assignment > > statement in most cases. Done using the following semantic > > patch by coccinelle. > [] > > @@ > > identifier E,F,G,f; > > e

Re: [Outreachy kernel] [PATCH v2] Staging: irda: Don't use assignment inside if statement

On Sat, 16 Sep 2017, Srishti Sharma wrote: > On Sat, Sep 16, 2017 at 1:30 AM, Julia Lawall wrote: > > > > > > On Sat, 16 Sep 2017, Srishti Sharma wrote: > > > >> Write assignment statement outside the if statement. Done using > >&g

Re: [Outreachy kernel] [PATCH v2] Staging: irda: Don't use assignment inside if statement

; S > > Signed-off-by: Srishti Sharma Acked-by: Julia Lawall > --- > Changes in v2: > -Semicolon was missing in one of the statements of the > semantic patch > > drivers/staging/irda/drivers/irda-usb.c | 4 ++-- > drivers/staging/irda/drivers/mcs7780.c | 9 +

Re: [Outreachy kernel] [PATCH] Staging: irda: Don't use assignment inside if statement

On Sat, 16 Sep 2017, Srishti Sharma wrote: > Write assignment statement outside the if statement. Done using > the following semantic patch by coccinelle. > > @@ > identifier E; > expression F; > statement S; > @@ > > -if((E = F)) > +E = F The line above would need to end in a ; This ends up w

Re: [Outreachy kernel] [PATCH] staging: irda: Remove typedef struct

edef > struct > + T2 > { ... } > -T > ; > > @r3@ > type r1.T; > identifier c1.T2; > @@ > -T > +struct T2 > > Signed-off-by: Haneen Mohammed Acked-by: Julia Lawall > --- > drivers/staging/irda/include/net/irda/qos.h | 20 ++-- > 1 fi

Re: [PATCH] Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile (fwd)

It is intentional that the code on lines 122 and 124 is the same? julia -- Forwarded message -- Date: Thu, 17 Aug 2017 09:18:50 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH] Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and

Re: [PATCH net-next 2/3] Add LAN743X to Kconfig and Makefile (fwd)

I don't think netdev_priv can return NULL, so lines 6641 to 6646 could just be dropped. julia -- Forwarded message -- Date: Mon, 14 Aug 2017 18:14:12 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH net-next 2/3] Add LAN743X to Kconfi

[PATCH] X25: constify null_x25_address

null_x25_address is only used to access the string it contains, so it can be const. Signed-off-by: Julia Lawall --- net/x25/af_x25.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c index 5a1a98d..ac09593 100644 --- a/net/x25/af_x25.c

[PATCH 1/2] Revert "ipv6: constify inet6_protocol structures"

This reverts commit 3a3a4e3054137c5ff5d4d306ec834f6d25d7f95b. inet6_add_protocol and inet6_del_protocol include casts that remove the effect of the const annotation on their parameter, leading to possible runtime crashes. Reported-by: Eric Dumazet Signed-off-by: Julia Lawall --- net/ipv6

[PATCH 2/2] Revert "l2tp: constify inet6_protocol structures"

This reverts commit d04916a48ad4a3db892b664fa9c3a2a693c378ad. inet6_add_protocol and inet6_del_protocol include casts that remove the effect of the const annotation on their parameter, leading to possible runtime crashes. Reported-by: Eric Dumazet Signed-off-by: Julia Lawall --- net/l2tp

[PATCH 0/2] Revert "ipv6: constify inet6_protocol structures"

inet6_add_protocol and inet6_del_protocol include casts that remove the effect of the const annotation on their parameter, leading to possible runtime crashes.

Re: [PATCH 1/2] ipv6: constify inet6_protocol structures

On Tue, 1 Aug 2017, David Ahern wrote: > On 7/31/17 11:59 PM, Julia Lawall wrote: > >> This change breaks the kernel if one of these sysctls are changed: > >> tcp_early_demux, udp_early_demux > > > > The other patch in the series has the same problem and should

[PATCH nf-next] netfilter: constify nf_loginfo structures

@@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct nf_loginfo i = { ... }; // Signed-off-by: Julia Lawall --- net/ipv4/netfilter/ip_tables.c |2 +- net/ipv4/netfilter/nf_log_arp.c |2 +- net/ipv4/netfilter/nf_log_ipv4.c |2 +- net/ipv6/n

  1   2   3   4   >