Hi Greg,
Acked-by: Jukka Rissanen
Cheers,
Jukka
On Fri, 2019-06-14 at 09:14 +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic
> should
> never do something differ
/nhc.c
> +++ b/net/6lowpan/nhc.c
> @@ -18,7 +18,7 @@
> #include "nhc.h"
>
> static struct rb_root rb_root = RB_ROOT;
> -static struct lowpan_nhc *lowpan_nexthdr_nhcs[NEXTHDR_MAX];
> +static struct lowpan_nhc *lowpan_nexthdr_nhcs[NEXTHDR_MAX + 1];
> static DEF
Hi Michael,
On Wed, 2017-04-26 at 10:55 -0400, Michael Richardson wrote:
> Alexander Aring wrote:
> >> In a classic SVR4 STREAMS works, it would have been just
> another
> >> module. (No, I'm not a fan of *STREAMS* or of SVR4 in
> general,
> >> although I liked some of the ideas).
>
return;
> }
> + new_netdev = true;
> }
>
> if (!try_module_get(THIS_MODULE))
> return;
>
> - add_peer_chan(chan, dev);
> + add_peer_chan(chan, dev, new_netdev);
> ifup(dev->netdev);
> }
>
Good catch!
Acked-by: Jukka Rissanen
Cheers,
Jukka
-
> - lowpan_cb(skb)->status = 0;
> + BT_DBG("chan %p resume", chan);
> }
>
> static long chan_get_sndtimeo_cb(struct l2cap_chan *chan)
Good catch! If we can avoid using the status variable, that is very
good. We could probably also remove the resume and suspend callbacks as
they are now empty functions (unless we need the debug info for
something).
Acked-by: Jukka Rissanen
Cheers,
Jukka
--+++
> +
>
> Because of this the code cannot figure out the address type from the
> IP
> address anymore thus it makes no sense to use peer_lookup_ba as it
> needs
> the peer address type.
>
> Signed-off-by: Luiz Augus
