Re: [PATCH 2/2] ARM: dts: imx6: tag boards that have the HW workaround for ERR006687

2016-06-07 Thread Joshua Clayton
On Thu, 02 Jun 2016 10:25:06 +0200 Lucas Stach wrote: > Am Mittwoch, den 01.06.2016, 17:17 +0100 schrieb Russell King - ARM > Linux: > > On Wed, Jun 01, 2016 at 05:29:43PM +0200, Lucas Stach wrote: > > > @@ -97,6 +97,7 @@ > > > phy-reset-gpios = <&gpio3 31 0>; > > > interrupts-extended = <&

Re: [PATCH net-next V2 00/16] net: fec: cleanup and fixes

2016-02-25 Thread Joshua Clayton
On Thu, 25 Feb 2016 09:05:34 -0700 Troy Kisky wrote: > On 2/24/2016 7:52 PM, Joshua Clayton wrote: > > Hello Troy, > > I'm replying here instead of to a particular commit because several > > of the commit messages seem inadequate. > > > > The first line

Re: [PATCH net-next V2 00/16] net: fec: cleanup and fixes

2016-02-24 Thread Joshua Clayton
Hello Troy, I'm replying here instead of to a particular commit because several of the commit messages seem inadequate. The first line summaries all look good. The descriptions should each also include the "user visible impact" of the patch and the justification for it (i.e. why you made the chan

Re: [PATCH net-next V2 7/8] net: fec: don't transfer ownership until descriptor write is complete

2016-02-05 Thread Joshua Clayton
On Fri, 5 Feb 2016 14:52:49 -0700 Troy Kisky wrote: > If you don't own it, you shouldn't write to it. > > Signed-off-by: Troy Kisky > --- > drivers/net/ethernet/freescale/fec_main.c | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/f