Apologies for taking a while to respond.
> -Original Message-
> From: Jesse Brandeburg
> Sent: 04 February 2021 20:43
>
> NB: I thought I'd have a close look at this since I thought I
> understand NAPI pretty well, but using NAPI to transmit frames as well
> as with a usb device has got
> -Original Message-
> From: Andrew Lunn
> Sent: 04 February 2021 13:48
>
> >
> > This was missed in the work to add the NAPI support.
>
> git rebase? Please squash it into the correct place.
Yes, will do.
John
> -Original Message-
> From: Andrew Lunn
> Sent: 04 February 2021 13:46
>
> On Thu, Feb 04, 2021 at 11:31:16AM +, John Efstathiades wrote:
> > Disable the station MAC address entry in the perfect address filter
> > table before updating the table e
> -Original Message-
> From: Andrew Lunn
> Sent: 04 February 2021 13:40
> Could you expand this comment a bit. Most people here are network
> people, and have not idea what U1/U2 is. I assume it is some USB term?
Yes, they refer to USB 3.0 power states.
> Some performance numbers woul
Apologies for taking a while to reply.
> This patch is big. Given your description, it sounds like it can be
> split up. That will make reviewing a lot easier.
The patch changes the way the driver works in a fundamental way so finding
ways to split out the modifications into self-contained parts
Fix setting of maximum MTU to support jumbo frames.
This was missed in the work to add the NAPI support.
Signed-off-by: John Efstathiades
---
drivers/net/usb/lan78xx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index
Incorporate changes from commit 06cd7c46b3ab ("net: usb: lan78xx:
Remove lots of set but unused 'ret' variables") that fixes kernel
build warnings.
Signed-off-by: John Efstathiades
---
drivers/net/usb/lan78xx.c | 107 +++---
1 file changed,
When the device is disconnected attempts to access device registers
via the control endpoint will fail. This can result in a stream
of warning messages in the kernel log.
Use net_ratelimit() to limit the number of warning messages emitted
following device disconnection.
Signed-off-by: John
n the driver's USB disconnect
handler is invoked.
Disconnect the PHY only after the network device has been unregistered
and all delayed work has been been cancelled.
Signed-off-by: John Efstathiades
---
drivers/net/usb/lan78xx.c | 39 ---
1 file c
to eliminate the race condition.
Signed-off-by: John Efstathiades
---
drivers/net/usb/lan78xx.c | 54 ++-
1 file changed, 48 insertions(+), 6 deletions(-)
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index 9bd21d17d6f1..0a6f4765f595
driver's static URB and buffer pools (introduced with
NAPI interface support) to suspend and resume handling.
Refactor suspend and resume handling to simplify lan78xx_suspend() and
lan78xx_resume() routines.
Signed-off-by: John Efstathiades
---
drivers/net/usb/lan78xx.c
Use macro DEFAULT_U1_U2_INIT_ENABLE to configure default behaviour
of U1/U2 link power state transitions (on/off).
Disable U1/U2 link power state transitions by default to reduce
URB processing latency and maximise throughput.
Signed-off-by: John Efstathiades
---
drivers/net/usb/lan78xx.c | 10
NAPI modifications.
John Efstathiades (9):
lan78xx: add NAPI interface support
lan78xx: disable U1/U2 power state transitions
lan78xx: fix USB errors and packet loss on suspend/resume
lan78xx: disable MAC address filter before updating entry
lan78xx: fix race condition in PHY handling
hard_header_len that prevents correct operation
of generic receive offload (GRO) handling of TCP connections.
Signed-off-by: John Efstathiades
---
drivers/net/usb/lan78xx.c | 1176 -
1 file changed, 775 insertions(+), 401 deletions(-)
diff --git a/drivers/net/usb
Disable the station MAC address entry in the perfect address filter
table before updating the table entry with a new MAC address.
Signed-off-by: John Efstathiades
---
drivers/net/usb/lan78xx.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/net/usb/lan78xx.c
15 matches
Mail list logo
