From: David Miller
Sent: Tuesday, April 25, 2017 7:42 AM
To: herb...@gondor.apana.org.au
Cc: Ghalam, Joe; Wichmann, Clifford; netdev@vger.kernel.org
Subject: Re: macvlan: Fix device ref leak when purging bc_queue
> Applied and queued up for -stable, thanks Herbert.
Herbert and David,
Glad to rep
> I'm waiting for this discussion to settle down before I apply the patch.
Thanks David. I will get some answers soon, and hopefully the change is a good
one.
> The only thing that can stop macvlan_process_broadcast from getting
> called is macvlan_port_destroy. Nothing else can stop the work
> queue, unless of course the work queue mechanism itself is broken.
> So if you're sure macvlan_port_destroy is never even called in
> your case, then you'll nee
> From: Mahesh Bandewar (महेश बंडेवार)
> Sent: Friday, April 21, 2017 12:23 PM
> To: Ghalam, Joe
> Cc: herb...@gondor.apana.org.au; David Miller; Wichmann, Clifford;
> linux-netdev
> Subject: Re: macvlan: Fix device ref leak when purging bc_queue
> May be
That's not true. macvlan_dellink() unregisters the queue, and
macvlan_process_broadcast() will never get called. Please note that I'm not
speculating. I have traced enabled on the dev_put and dev_hold, and I'm
reporting a real, reproducible issue.
Her is a sequence of calls logged, when the issu
Hi Herbert,
I agree with this change, but the same purge would be needed for the
macvlan_dellink() call also.
Thanks,
Joe
From: Herbert Xu
Sent: Thursday, April 20, 2017 5:55 AM
To: Ghalam, Joe
Cc: da...@davemloft.net; Wichmann, Clifford; netdev@vger.ker
