Re: [PATCH] geneve: fix max_mtu setting

2016-06-27 Thread Jesse Gross
On Mon, Jun 27, 2016 at 6:27 PM, 严海双 wrote: > > On Jun 28, 2016, at 12:10 AM, Jesse Gross wrote: > > On Sun, Jun 26, 2016 at 6:13 PM, Haishuang Yan > wrote: > > > On Jun 26, 2016, at 8:35 PM, zhuyj wrote: > > + if (geneve->remote.sa.sa_family == A

Re: [PATCH] geneve: fix max_mtu setting

2016-06-27 Thread Jesse Gross
On Sun, Jun 26, 2016 at 6:13 PM, 严海双 wrote: > >> On Jun 26, 2016, at 8:35 PM, zhuyj wrote: >> >> + if (geneve->remote.sa.sa_family == AF_INET) >> + max_mtu -= sizeof(struct iphdr); >> + else >> + max_mtu -= sizeof(struct ipv6hdr); >> >> Sorry, if sa_family

Re: [net-next PATCH v2 03/17] net: Merge VXLAN and GENEVE push notifiers into a single notifier

2016-06-15 Thread Jesse Gross
On Wed, Jun 15, 2016 at 3:07 PM, Alexander Duyck wrote: > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index d101e4d904ba..7f45e96967ce 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -1050,6 +1052,19 @@ struct tc_to_netdev { > * addres

Re: [net-next PATCH v2 02/17] net: Combine GENEVE and VXLAN port notifiers into single functions

2016-06-15 Thread Jesse Gross
On Wed, Jun 15, 2016 at 3:07 PM, Alexander Duyck wrote: > diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c > index e5e33cd01082..d12ee3a92fb5 100644 > --- a/drivers/net/geneve.c > +++ b/drivers/net/geneve.c > static void geneve_notify_del_rx_port(struct geneve_sock *gs) > { > - str

Re: [net-next PATCH 04/15] bnxt: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port

2016-06-13 Thread Jesse Gross
On Mon, Jun 13, 2016 at 10:48 AM, Alexander Duyck wrote: > This change replaces the network device operations for adding or removing a > VXLAN port with operations that are more generically defined to be used for > any UDP offload port but provide a type. As such by just adding a line to > verify

Re: [PATCH net 1/2] ovs/vxlan: fix rtnl notifications on iface deletion

2016-06-10 Thread Jesse Gross
On Fri, Jun 10, 2016 at 2:32 AM, Nicolas Dichtel wrote: > The function vxlan_dev_create() (only used by ovs) never calls > rtnl_configure_link(). The consequence is that dev->rtnl_link_state is > never set to RTNL_LINK_INITIALIZED. > During the deletion phase, the function rollback_registered_many

Re: [PATCH net-next 1/6] net: Make vxlan/geneve default udp ports public

2016-04-09 Thread Jesse Gross
On Sat, Apr 9, 2016 at 5:46 PM, Manish Chopra wrote: >> -Original Message- >> From: Jesse Gross [mailto:je...@kernel.org] >> Sent: Saturday, April 09, 2016 9:36 PM >> To: Manish Chopra >> Cc: David Miller ; netdev ; >> Ariel Elior ; Yuval Mintz >

Re: [PATCH net-next 3/6] qed/qede: Add VXLAN tunnel slowpath configuration support

2016-04-09 Thread Jesse Gross
On Sat, Apr 9, 2016 at 10:17 AM, Manish Chopra wrote: > diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c > b/drivers/net/ethernet/qlogic/qede/qede_main.c > index 518af32..9a82d42 100644 > --- a/drivers/net/ethernet/qlogic/qede/qede_main.c > +++ b/drivers/net/ethernet/qlogic/qede/qede_mai

Re: [PATCH net-next 1/6] net: Make vxlan/geneve default udp ports public

2016-04-09 Thread Jesse Gross
On Sat, Apr 9, 2016 at 10:17 AM, Manish Chopra wrote: > Rationale behind this change is that with some OVS configuration > UDP ports doesn't get notified to the driver using > .ndo_[add|del]_vxlan_port. So for the driver to work with > these specific ports in that environment we need to have them

Re: [RFC PATCH 07/11] GENEVE: Add option to mangle IP IDs on inner headers when using TSO

2016-04-09 Thread Jesse Gross
On Fri, Apr 8, 2016 at 7:04 PM, Alexander Duyck wrote: > On Fri, Apr 8, 2016 at 2:40 PM, Jesse Gross wrote: >> Maybe I missed it but I didn't see any checks for the DF bit being set >> when we transmit a packet with NETIF_F_TSO_MANGLEID. Even if I am >> comfortable mang

Re: [net-next PATCH 2/5] GSO: Add GSO type for fixed IPv4 ID

2016-04-08 Thread Jesse Gross
On Fri, Apr 8, 2016 at 5:33 PM, Alexander Duyck wrote: > This patch adds support for TSO using IPv4 headers with a fixed IP ID > field. This is meant to allow us to do a lossless GRO in the case of TCP > flows that use a fixed IP ID such as those that convert IPv6 header to IPv4 > headers. > > In

Re: [RFC PATCH 07/11] GENEVE: Add option to mangle IP IDs on inner headers when using TSO

2016-04-08 Thread Jesse Gross
On Thu, Apr 7, 2016 at 8:52 PM, Alexander Duyck wrote: > Just a thought. What if I replaced NETIF_F_TSO_FIXEDID with something > that meant we could mange the IP ID like a NETIF_F_TSO_IPID_MANGLE > (advice for better name welcome). Instead of the feature flag meaning > we are going to transmit p

Re: [RFC PATCH 07/11] GENEVE: Add option to mangle IP IDs on inner headers when using TSO

2016-04-07 Thread Jesse Gross
On Thu, Apr 7, 2016 at 7:32 PM, Alexander Duyck wrote: > This patch adds support for a feature I am calling IP ID mangling. It is > basically just another way of saying the IP IDs that are transmitted by the > tunnel may not match up with what would normally be expected. Specifically > what will

Re: [net PATCH] gro: Allow tunnel stacking in the case of FOU/GUE

2016-03-28 Thread Jesse Gross
On Mon, Mar 28, 2016 at 4:58 PM, Alexander Duyck wrote: > This patch should fix the issues seen with a recent fix to prevent > tunnel-in-tunnel frames from being generated with GRO. The fix itself is > correct for now as long as we do not add any devices that support > NETIF_F_GSO_GRE_CSUM. When

Re: [net PATCH] gro: Allow tunnel stacking in the case of FOU/GUE

2016-03-28 Thread Jesse Gross
On Mon, Mar 28, 2016 at 6:24 PM, Tom Herbert wrote: > On Mon, Mar 28, 2016 at 4:58 PM, Alexander Duyck wrote: >> This patch should fix the issues seen with a recent fix to prevent >> tunnel-in-tunnel frames from being generated with GRO. The fix itself is >> correct for now as long as we do not

Re: [PATCH net v2 2/3] tunnels: Don't apply GRO to multiple layers of encapsulation.

2016-03-28 Thread Jesse Gross
r 28, 2016 at 11:47 AM, Tom Herbert wrote: >>>>> On Mon, Mar 28, 2016 at 10:37 AM, Alexander Duyck >>>>> wrote: >>>>>> On Mon, Mar 28, 2016 at 9:31 AM, Tom Herbert >>>>>> wrote: >>>>>>> On Sun, Mar 27, 2016 at 9:3

Re: [RFC PATCH 7/9] GSO: Support partial segmentation offload

2016-03-27 Thread Jesse Gross
On Wed, Mar 23, 2016 at 7:53 PM, Alexander Duyck wrote: > On Wed, Mar 23, 2016 at 6:37 PM, Jesse Gross wrote: >> That being said, I actually think that it is good to have the DF bit >> on by default for encapsulation headers being added. Unintentional >> (and perha

Re: [RFC PATCH 7/9] GSO: Support partial segmentation offload

2016-03-27 Thread Jesse Gross
On Fri, Mar 18, 2016 at 4:25 PM, Alexander Duyck wrote: > diff --git a/net/core/dev.c b/net/core/dev.c > index edb7179bc051..666cf427898b 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -2711,6 +2711,19 @@ struct sk_buff *__skb_gso_segment(struct sk_buff *skb, [...] > + /* Only rep

Re: [RFC PATCH 1/9] ipv4/GRO: Allow multiple frames to use the same IP ID

2016-03-27 Thread Jesse Gross
On Wed, Mar 23, 2016 at 7:21 PM, Alexander Duyck wrote: > On Wed, Mar 23, 2016 at 6:43 PM, Jesse Gross wrote: >> On Fri, Mar 18, 2016 at 4:24 PM, Alexander Duyck wrote: >>> In RFC 6864 it is stated that we can essentially ignore the IPv4 ID field >>> if w

Re: [PATCH net v2 2/3] tunnels: Don't apply GRO to multiple layers of encapsulation.

2016-03-27 Thread Jesse Gross
On Sat, Mar 26, 2016 at 12:41 PM, Tom Herbert wrote: > On Sat, Mar 19, 2016 at 9:32 AM, Jesse Gross wrote: >> When drivers express support for TSO of encapsulated packets, they >> only mean that they can do it for one layer of encapsulation. >> Supporting additional level

Re: [RFC PATCH 1/9] ipv4/GRO: Allow multiple frames to use the same IP ID

2016-03-23 Thread Jesse Gross
On Fri, Mar 18, 2016 at 4:24 PM, Alexander Duyck wrote: > In RFC 6864 it is stated that we can essentially ignore the IPv4 ID field > if we have not and will not use fragmentation. Such a frame is defined > as having the DF flag set to 1, and the MF and frag_offset as 0. Currently > for GRO we w

Re: [RFC PATCH 7/9] GSO: Support partial segmentation offload

2016-03-23 Thread Jesse Gross
On Wed, Mar 23, 2016 at 11:19 AM, Alexander Duyck wrote: > On Wed, Mar 23, 2016 at 10:09 AM, Tom Herbert wrote: >> Can you add some description about strategy for dealing with ip_id? > > Yeah. I still need to add more documentation. I just didn't want to > get into details on it until we have f

Re: [RFC PATCH 8/9] i40e/i40evf: Add support for GSO partial with UDP_TUNNEL_CSUM and GRE_CSUM

2016-03-23 Thread Jesse Gross
On Fri, Mar 18, 2016 at 4:25 PM, Alexander Duyck wrote: > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c > b/drivers/net/ethernet/intel/i40e/i40e_main.c > index 39b0009253c2..ac3964a9f5c0 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c > +++ b/drivers/net/ethernet/intel/i40e/

Re: [RFC PATCH 7/9] GSO: Support partial segmentation offload

2016-03-22 Thread Jesse Gross
On Tue, Mar 22, 2016 at 12:40 PM, Edward Cree wrote: > On 22/03/16 17:47, Alexander Duyck wrote: >> On Tue, Mar 22, 2016 at 10:00 AM, Edward Cree wrote: >>> On 18/03/16 23:25, Alexander Duyck wrote: This patch adds support for something I am referring to as GSO partial. The basic idea i

Re: [RFC PATCH 0/9] RFC6864 compliant GRO and GSO partial offload

2016-03-21 Thread Jesse Gross
On Mon, Mar 21, 2016 at 12:46 PM, Alexander Duyck wrote: > On Mon, Mar 21, 2016 at 11:50 AM, David Miller wrote: >> From: Alexander Duyck >> Date: Fri, 18 Mar 2016 16:24:38 -0700 >> >>> This patch series addresses two things. >>> >>> First it enables what I am calling RFC6864 compliant GRO. Bas

[PATCH iproute2 2/2] geneve: Add support for configuring UDP checksums.

2016-03-20 Thread Jesse Gross
Enable support for configuring outer UDP checksums on Geneve tunnels: ip link add type geneve id 10 remote 10.0.0.2 udpcsum Signed-off-by: Jesse Gross --- ip/iplink_geneve.c | 48 1 file changed, 48 insertions(+) diff --git a/ip/iplink_geneve.c

[PATCH net 1/3] ipip: Properly mark ipip GRO packets as encapsulated.

2016-03-20 Thread Jesse Gross
IPv6 sit in feec0cb3 ("ipv6: gro: support sit protocol"). Reported-by: Patrick Boutilier Fixes: 9667e9bb ("ipip: Add gro callbacks to ipip offload") Signed-off-by: Jesse Gross --- net/ipv4/af_inet.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/

[PATCH net 3/3] tunnels: Remove encapsulation offloads on decap.

2016-03-19 Thread Jesse Gross
lated. Reported-by: Ramu Ramamurthy Fixes: 68c33163 ("v4 GRE: Add TCP segmentation offload for GRE") Signed-off-by: Jesse Gross --- include/net/ip_tunnels.h | 16 net/ipv4/fou.c| 13 +++-- net/ipv4/ip_tunnel_core.c | 3 ++- net/ipv6/sit.c

Re: [RFC PATCH 6/9] ethtool: Add support for toggling any of the GSO offloads

2016-03-19 Thread Jesse Gross
On Fri, Mar 18, 2016 at 6:42 PM, Ben Hutchings wrote: > On Fri, 2016-03-18 at 17:30 -0700, Alexander Duyck wrote: >> On Fri, Mar 18, 2016 at 5:18 PM, Ben Hutchings wrote: >> > On Fri, 2016-03-18 at 16:25 -0700, Alexander Duyck wrote: >> > > [NETIF_F_GSO_IPIP_BIT] = "tx-ipip-segmenta

[PATCH net 2/3] tunnels: Don't apply GRO to multiple layers of encapsulation.

2016-03-19 Thread Jesse Gross
DP tunnels stacked on top of each other. This generalizes that solution to prevent any kind of tunnel stacking that would cause problems. Fixes: bf5a755f ("net-gre-gro: Add GRE support to the GRO stack") Signed-off-by: Jesse Gross --- include/linux/netdevice.h | 4 ++-- net/core/dev.c

[PATCH iproute2 1/2] vxlan: Follow kernel defaults for outer UDP checksum.

2016-03-19 Thread Jesse Gross
ed to send an explicit netlink message - the kernel can just use its default behavior. Signed-off-by: Jesse Gross --- ip/iplink_vxlan.c | 35 +++ 1 file changed, 27 insertions(+), 8 deletions(-) diff --git a/ip/iplink_vxlan.c b/ip/iplink_vxlan.c index ede8482..be

Re: [PATCH net-next 0/2] ovs: refresh a flow via netlink

2016-03-19 Thread Jesse Gross
On Wed, Mar 16, 2016 at 8:07 AM, Samuel Gauthier wrote: > This patchset adds a netlink api to refresh an existing flow in > openvswitch. > > When a packet is sent in the openvswitch kernel datapath and no > flow is found, the packet is sent to the ovs-vswitchd daemon, > which will process the pack

Re: [PATCH net-next 0/2] ovs: refresh a flow via netlink

2016-03-19 Thread Jesse Gross
On Thu, Mar 17, 2016 at 9:24 AM, Samuel Gauthier wrote: > 2016-03-17 0:23 GMT+01:00 Jesse Gross : >> On Wed, Mar 16, 2016 at 8:07 AM, Samuel Gauthier >> wrote: >>> This patchset adds a netlink api to refresh an existing flow in >>> openvswitch. >>> &g

Re: Extreme slowness in IPIP tunnel when routing through kernel 3.18 and later

2016-03-19 Thread Jesse Gross
On Thu, Mar 17, 2016 at 2:13 PM, Patrick Boutilier wrote: > On 03/17/2016 03:27 PM, Jesse Gross wrote: >> >> On Thu, Mar 17, 2016 at 7:02 AM, Patrick Boutilier >> wrote: >>> >>> I have an IPIP tunnel setup between two hosts in different buildings. The >

Re: [PATCH net 1/3] ipip: Properly mark ipip GRO packets as encapsulated.

2016-03-19 Thread Jesse Gross
On Fri, Mar 18, 2016 at 8:12 PM, David Miller wrote: > > Jesse, can you repost this series with a patch introductory "PATCH > 0/3" email explaining things at a high level about what this series is > doing? > > Thanks. Sure, I just sent a v2 with a cover letter.

[PATCH net v2 1/3] ipip: Properly mark ipip GRO packets as encapsulated.

2016-03-19 Thread Jesse Gross
IPv6 sit in feec0cb3 ("ipv6: gro: support sit protocol"). Reported-by: Patrick Boutilier Fixes: 9667e9bb ("ipip: Add gro callbacks to ipip offload") Tested-by: Patrick Boutilier Acked-by: Eric Dumazet Signed-off-by: Jesse Gross --- v2: No change. --- net/ipv4/af_inet.c |

[PATCH net v2 3/3] tunnels: Remove encapsulation offloads on decap.

2016-03-19 Thread Jesse Gross
Reported-by: Ramu Ramamurthy Fixes: 68c33163 ("v4 GRE: Add TCP segmentation offload for GRE") Signed-off-by: Jesse Gross --- v2: Additional performance numbers in the commit message. --- include/net/ip_tunnels.h | 16 net/ipv4/fou.c| 13 +++-- ne

[PATCH net v2 2/3] tunnels: Don't apply GRO to multiple layers of encapsulation.

2016-03-19 Thread Jesse Gross
DP tunnels stacked on top of each other. This generalizes that solution to prevent any kind of tunnel stacking that would cause problems. Fixes: bf5a755f ("net-gre-gro: Add GRE support to the GRO stack") Signed-off-by: Jesse Gross --- v2: No change. --- include/linux/netdevice.h | 4

[PATCH net v2 0/3] Tunneling fixes

2016-03-19 Thread Jesse Gross
fixes. v2: No code changes, just additional information in commit messages and a new cover letter. Jesse Gross (3): ipip: Properly mark ipip GRO packets as encapsulated. tunnels: Don't apply GRO to multiple layers of encapsulation. tunnels: Remove encapsulation offloads on

Re: Extreme slowness in IPIP tunnel when routing through kernel 3.18 and later

2016-03-18 Thread Jesse Gross
On Thu, Mar 17, 2016 at 7:02 AM, Patrick Boutilier wrote: > I have an IPIP tunnel setup between two hosts in different buildings. The > Linux router they route through causes extreme slowness in the tunnel when > running kernels from 3.18 on . tcpdump shows many cksum errors which don't > show up

Re: [RFC PATCH 9/9] ixgbe/ixgbevf: Add support for GSO partial

2016-03-18 Thread Jesse Gross
On Fri, Mar 18, 2016 at 4:25 PM, Alexander Duyck wrote: > This patch adds support for partial GSO segmentation in the case of GRE or > UDP encapsulated frames. > > The one bit in this patch that is a bit controversial is the fact that we > are leaving the inner IPv4 IP ID as a static value in the

Re: [ovs-dev] [PATCH] openvswitch: reduce padding in struct sw_flow_key

2016-03-18 Thread Jesse Gross
On Fri, Mar 18, 2016 at 6:34 AM, Arnd Bergmann wrote: > This means it's still too large really, we just don't warn about it any more, > and will get the warning again once another member is added. My patch is a > band-aid at best, but more work is needed here. One problem is that > ovs_flow_cmd_ne

Re: [PATCH net-next repost] openvswitch: allow output of MPLS packets on tunnel vports

2016-03-15 Thread Jesse Gross
t; encapsulation occurs and the contention on the inner_protocol field of the > skb no longer occurs. > > Thus it is now safe to output MPLS to tunnel vports. > > Signed-off-by: Simon Horman Reviewed-by: Jesse Gross

Re: [PATCH net-next 5/5] vxlan: implement GPE in L3 mode

2016-03-08 Thread Jesse Gross
On Sat, Feb 27, 2016 at 11:44 AM, Jiri Benc wrote: > On Sat, 27 Feb 2016 20:21:59 +0100, Jiri Benc wrote: >> You mean returning ETH_P_TEB in skb->protocol? That's not much useful, >> unfortunately. You won't get such packet processed by the kernel IP >> stack, rendering the VXLAN-GPE device unusab

Re: [net-next PATCH 3/4] vxlan: Enforce IP ID verification on outer headers

2016-03-07 Thread Jesse Gross
On Mon, Mar 7, 2016 at 3:06 PM, Alex Duyck wrote: > On Mon, Mar 7, 2016 at 11:09 AM, David Miller wrote: >> From: Or Gerlitz >> Date: Mon, 7 Mar 2016 20:05:20 +0200 >> >>> On Mon, Mar 7, 2016 at 7:22 PM, Alexander Duyck wrote: This change enforces the IP ID verification on outer headers.

Re: [PATCH net-next 5/5] vxlan: implement GPE in L3 mode

2016-02-26 Thread Jesse Gross
On Thu, Feb 25, 2016 at 11:48 PM, Jiri Benc wrote: > diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h > index c2b2b7462731..ee4f7198aa21 100644 > --- a/include/uapi/linux/if_link.h > +++ b/include/uapi/linux/if_link.h > @@ -464,6 +464,7 @@ enum { > enum vxlan_gpe_mode { >

Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default

2016-02-23 Thread Jesse Gross
On Tue, Feb 23, 2016 at 8:47 AM, Tom Herbert wrote: > On Tue, Feb 23, 2016 at 7:18 AM, Edward Cree wrote: >> On 23/02/16 03:31, Jesse Gross wrote: >>> The only issue that I see is that making TSO completely unaware of >>> outer headers will likely cause performanc

Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default

2016-02-22 Thread Jesse Gross
On Sat, Feb 20, 2016 at 11:51 AM, Tom Herbert wrote: > On Fri, Feb 19, 2016 at 6:18 PM, Jesse Gross wrote: >> On Fri, Feb 19, 2016 at 4:14 PM, Tom Herbert wrote: >>> On Fri, Feb 19, 2016 at 4:08 PM, Jesse Gross wrote: >>>> On Fri, Feb 19, 2016 at 3:10 PM, Alex D

Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default

2016-02-19 Thread Jesse Gross
On Fri, Feb 19, 2016 at 4:14 PM, Tom Herbert wrote: > On Fri, Feb 19, 2016 at 4:08 PM, Jesse Gross wrote: >> On Fri, Feb 19, 2016 at 3:10 PM, Alex Duyck wrote: >>> On Fri, Feb 19, 2016 at 1:53 PM, Jesse Gross wrote: >>>> On Fri, Feb 19, 2016 at 11:26 AM

Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default

2016-02-19 Thread Jesse Gross
On Fri, Feb 19, 2016 at 3:10 PM, Alex Duyck wrote: > On Fri, Feb 19, 2016 at 1:53 PM, Jesse Gross wrote: >> On Fri, Feb 19, 2016 at 11:26 AM, Alexander Duyck >> wrote: >>> This patch series makes it so that we enable the outer Tx checksum for IPv4 >>> tu

Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default

2016-02-19 Thread Jesse Gross
On Fri, Feb 19, 2016 at 11:26 AM, Alexander Duyck wrote: > This patch series makes it so that we enable the outer Tx checksum for IPv4 > tunnels by default. This makes the behavior consistent with how we were > handling this for IPv6. In addition I have updated the internal flags for > these tun

Re: [net-next PATCH 2/2] VXLAN: Support outer IPv4 Tx checksums by default

2016-02-19 Thread Jesse Gross
On Fri, Feb 19, 2016 at 12:27 PM, Tom Herbert wrote: > I would also note RFC7348 specifies: > > UDP Checksum: It SHOULD be transmitted as zero. ... > > The RFC doesn't provide any rationale as to why this is a SHOULD > (neither is there any discussion as to whether this pertains to IPv6 > which ha

Re: [PATCH/RFC] openvswitch: loosen restriction of output of MPLS to tunnel vports

2016-02-19 Thread Jesse Gross
On Thu, Feb 18, 2016 at 11:59 PM, Simon Horman wrote: > On Tue, Feb 16, 2016 at 02:53:39PM -0800, Jesse Gross wrote: >> On Fri, Feb 12, 2016 at 11:25 AM, Simon Horman >> wrote: >> > If an skb was not MPLS initially then it may be GSO and in that case if it >> &

Re: [PATCH net v3] geneve: Refine MTU limit

2016-02-18 Thread Jesse Gross
ip_tunnel_change_mtu > - Exclude GENEVE options from max MTU calculation > > Signed-off-by: David Wragg Acked-by: Jesse Gross

Re: [PATCH net v2] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-18 Thread Jesse Gross
On Thu, Feb 18, 2016 at 1:42 AM, Paolo Abeni wrote: > On Wed, 2016-02-17 at 11:19 -0800, Jesse Gross wrote: >> On Wed, Feb 17, 2016 at 10:30 AM, Paolo Abeni wrote: >> > the commit 35e2d1152b22 ("tunnels: Allow IPv6 UDP checksums to be >> > correctly contro

Re: [PATCH net v2] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-17 Thread Jesse Gross
On Wed, Feb 17, 2016 at 10:30 AM, Paolo Abeni wrote: > the commit 35e2d1152b22 ("tunnels: Allow IPv6 UDP checksums to be > correctly controlled.") changed the default xmit checksum setting > for lwt vxlan/geneve ipv6 tunnels, so that now the checksum is not > set into external UDP header. > This c

Re: [PATCH net] vxlan: clear IFF_TX_SKB_SHARING

2016-02-16 Thread Jesse Gross
On Tue, Feb 16, 2016 at 1:16 PM, Jiri Benc wrote: > ether_setup sets IFF_TX_SKB_SHARING but this is not supported by vxlan as it > modifies the skb on xmit. > > Signed-off-by: Jiri Benc Presumably this is something that should be done on all tunnels that can carry Ethernet frames, right?

Re: [PATCH/RFC] openvswitch: loosen restriction of output of MPLS to tunnel vports

2016-02-16 Thread Jesse Gross
On Fri, Feb 12, 2016 at 11:25 AM, Simon Horman wrote: > If an skb was not MPLS initially then it may be GSO and in that case if it > became MPLS then GSO can't be performed because both MPLS and tunnels make > use of the inner_protocol field of struct skbuff in order to allow GSO to > be performed

Re: [PATCH net-next] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-16 Thread Jesse Gross
On Tue, Feb 16, 2016 at 11:47 AM, David Miller wrote: > From: Jesse Gross > Date: Tue, 16 Feb 2016 10:22:38 -0800 > >> On Thu, Feb 11, 2016 at 2:41 AM, Jiri Benc wrote: >> There's a bigger problem here, not really related to lightweight tunnels or >> OVS. >&g

Re: [PATCH net] geneve: Refine MTU limit

2016-02-16 Thread Jesse Gross
On Tue, Feb 16, 2016 at 4:33 AM, David Wragg wrote: > diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c > index 028e387..f57f9bc 100644 > --- a/drivers/net/geneve.c > +++ b/drivers/net/geneve.c > @@ -37,6 +37,9 @@ MODULE_PARM_DESC(log_ecn_error, "Log packets received with > corrupted ECN")

Re: [PATCH net-next] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-16 Thread Jesse Gross
On Thu, Feb 11, 2016 at 2:41 AM, Jiri Benc wrote: > On Wed, 10 Feb 2016 16:47:21 +0100, Paolo Abeni wrote: >> --- a/drivers/net/geneve.c >> +++ b/drivers/net/geneve.c >> @@ -1441,7 +1441,8 @@ struct net_device *geneve_dev_create_fb(struct net >> *net, const char *name, >> return dev

Re: [PATCH net v2 2/3] geneve: Relax MTU constraints

2016-02-10 Thread Jesse Gross
On Wed, Feb 10, 2016 at 3:21 PM, Tom Herbert wrote: > On Wed, Feb 10, 2016 at 12:59 PM, Jesse Gross wrote: >> On Wed, Feb 10, 2016 at 12:41 PM, David Wragg wrote: >>> Tom Herbert writes: >>>> The correct thing to do is determine the maximum amount of >>>

Re: gro: Make GRO aware of lightweight tunnels.

2016-02-10 Thread Jesse Gross
9d4a2a > > Parent: 5f2f3cad8b878b23f17a11dd5af4f4a2cc41c797 > > Refname:refs/heads/master > > Author: Jesse Gross > > AuthorDate: Wed Jan 20 17:59:49 2016 -0800 > > Committer: David S. Miller > > CommitDate: Wed Jan 20 18:48:38 2016 -0800 > > > >

Re: [PATCH net v2 2/3] geneve: Relax MTU constraints

2016-02-10 Thread Jesse Gross
On Wed, Feb 10, 2016 at 12:41 PM, David Wragg wrote: > Tom Herbert writes: >> The correct thing to do is determine the maximum amount of >> encapsulation overhead that can ever be set in a packet and use for >> setting the MTU. For instance, when RCO is enable in GUE, the size of >> the option is

Re: [PATCH net] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Jesse Gross
On Wed, Jan 20, 2016 at 6:31 PM, Thomas Graf wrote: > On 01/20/16 at 05:47pm, Jesse Gross wrote: >> Just to merge the two threads together, all of protocols that would be >> affected by this also have "normal" GRO handlers that will run when >> the packet is firs

[PATCH net v2] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Jesse Gross
the tunnel information before merging, similar to how we handle other metadata (such as vlan tags), and releasing any state when we are done. Reported-by: John Fixes: 2e15ea39 ("ip_gre: Add support to collect tunnel metadata.") Signed-off-by: Jesse Gross --- v2: Remove branches to op

Re: [PATCH net] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Jesse Gross
On Wed, Jan 20, 2016 at 4:48 PM, Eric Dumazet wrote: > On Wed, 2016-01-20 at 16:27 -0800, Jesse Gross wrote: >> GRO is currently not aware of tunnel metadata generated by lightweight >> tunnels and stored in the dst. This leads to two possible problems: >> * Incorrectly me

[PATCH net] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Jesse Gross
the tunnel information before merging, similar to how we handle other metadata (such as vlan tags), and releasing any state when we are done. Reported-by: John Fixes: 2e15ea39 ("ip_gre: Add support to collect tunnel metadata.") Signed-off-by: Jesse Gross --- include/net/dst_metad

[PATCH net] tunnels: Allow IPv6 UDP checksums to be correctly controlled.

2016-01-20 Thread Jesse Gross
appropriately. Fixes: a725e514 ("vxlan: metadata based tunneling for IPv6") Fixes: abe492b4 ("geneve: UDP checksum configuration via netlink") Signed-off-by: Jesse Gross --- drivers/net/geneve.c | 4 ++-- drivers/net/vxlan.c | 23 --- 2 files changed,

Re: Kernel memory leak in bnx2x driver with vxlan tunnel

2016-01-20 Thread Jesse Gross
On Wed, Jan 20, 2016 at 4:07 PM, Eric Dumazet wrote: > On Wed, 2016-01-20 at 16:43 -0700, John wrote: >> >> On 01/19/2016 06:31 PM, Thomas Graf wrote: >> > On 01/19/16 at 04:51pm, Jesse Gross wrote: >> >> On Tue, Jan 19, 2016 at 4:17 PM, Eric Dumazet >&g

Re: [ovs-dev] [PATCH net 0/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-06 Thread Jesse Gross
On Wed, Jan 6, 2016 at 4:29 PM, David Wragg wrote: > Jesse Gross writes: >> On Wed, Jan 6, 2016 at 3:25 PM, David Wragg wrote: >>> I'm certainly open to suggestions of better ways to solve the problem. >> >> One option is to simply set the MTU on the device f

Re: [ovs-dev] [PATCH net 0/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-06 Thread Jesse Gross
On Wed, Jan 6, 2016 at 4:14 PM, Hannes Frederic Sowa wrote: > Hi, > > > On 07.01.2016 00:57, Jesse Gross wrote: >> >> On Wed, Jan 6, 2016 at 3:25 PM, David Wragg wrote: >>> >>> David Miller writes: >>>>> >>>>> Prior to 4.3,

Re: [PATCH net-next v3 8/8] geneve: break dependency to network drivers

2016-01-06 Thread Jesse Gross
On Wed, Jan 6, 2016 at 3:39 PM, Hannes Frederic Sowa wrote: > Signed-off-by: Hannes Frederic Sowa > --- > drivers/net/geneve.c | 30 +++--- > include/net/geneve.h | 7 +++ > 2 files changed, 30 insertions(+), 7 deletions(-) Thanks a lot for going through all the dri

Re: [ovs-dev] [PATCH net 0/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-06 Thread Jesse Gross
On Wed, Jan 6, 2016 at 3:25 PM, David Wragg wrote: > David Miller writes: >>> Prior to 4.3, openvswitch vxlan vports could transmit vxlan packets of >>> any size, constrained only by the ability to transmit the resulting >>> UDP packets. 4.3 introduced vxlan netdevs corresponding to vxlan >>> vp

Re: [PATCH net 0/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-06 Thread Jesse Gross
On Wed, Jan 6, 2016 at 12:59 PM, David Miller wrote: > From: David Wragg > Date: Wed, 6 Jan 2016 13:33:04 + > >> Prior to 4.3, openvswitch vxlan vports could transmit vxlan packets of >> any size, constrained only by the ability to transmit the resulting >> UDP packets. 4.3 introduced vxlan

Re: [PATCH net-next 2/2] geneve: break dependency to network drivers

2016-01-06 Thread Jesse Gross
On Wed, Jan 6, 2016 at 12:25 PM, Hannes Frederic Sowa wrote: > On 06.01.2016 20:52, Jesse Gross wrote: >> On Wed, Jan 6, 2016 at 10:48 AM, Hannes Frederic Sowa >> wrote: >>> On 06.01.2016 19:00, Jesse Gross wrote: >>>> Unfortunately, I don't think that

Re: [PATCH net-next 2/2] geneve: break dependency to network drivers

2016-01-06 Thread Jesse Gross
On Wed, Jan 6, 2016 at 10:48 AM, Hannes Frederic Sowa wrote: > On 06.01.2016 19:00, Jesse Gross wrote: >> >> On Wed, Jan 6, 2016 at 7:41 AM, Hannes Frederic Sowa >> wrote: >>> >>> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c >>> index

Re: [PATCH net-next 2/2] geneve: break dependency to network drivers

2016-01-06 Thread Jesse Gross
On Wed, Jan 6, 2016 at 7:41 AM, Hannes Frederic Sowa wrote: > diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c > index 24b077a32c1c9c..548925d1571cb1 100644 > --- a/drivers/net/geneve.c > +++ b/drivers/net/geneve.c > +static int geneve_notifier(struct notifier_block *unused, > +

Re: [PATCH net-next v3 3/3] geneve: Remote Checksum Offload support

2015-12-16 Thread Jesse Gross
On Wed, Dec 16, 2015 at 8:41 AM, Tom Herbert wrote: > On Thu, Dec 10, 2015 at 1:17 PM, Jesse Gross wrote: >> On Thu, Dec 10, 2015 at 12:37 PM, Tom Herbert wrote: >>> Add support for remote checksum offload in both the normal and GRO >>> paths. netlinks command are us

Re: [PATCH net-next v3 3/3] geneve: Remote Checksum Offload support

2015-12-10 Thread Jesse Gross
On Thu, Dec 10, 2015 at 12:37 PM, Tom Herbert wrote: > Add support for remote checksum offload in both the normal and GRO > paths. netlinks command are used to enable sending of the Remote > Checksum Data, and allow processing of it on receive. > > Signed-off-by: Tom Herbert Tom, can you please

Re: [PATCH net-next 3/3] geneve: Remote Checksum Offload support

2015-12-08 Thread Jesse Gross
On Tue, Dec 8, 2015 at 4:11 PM, Tom Herbert wrote: > On Tue, Dec 8, 2015 at 3:58 PM, Jesse Gross wrote: >> On Tue, Dec 8, 2015 at 11:59 AM, Tom Herbert wrote: >>> On Tue, Dec 8, 2015 at 11:31 AM, John W. Linville >>>> Jesse is going to have to comment on your (ab)u

Re: [PATCH net-next 3/3] geneve: Remote Checksum Offload support

2015-12-08 Thread Jesse Gross
On Tue, Dec 8, 2015 at 11:59 AM, Tom Herbert wrote: > On Tue, Dec 8, 2015 at 11:31 AM, John W. Linville > wrote: >> On Tue, Dec 08, 2015 at 10:27:18AM -0800, Tom Herbert wrote: >>> Add support for remote checksum offload in both the normal and GRO >>> paths. netlink command are used to enable sen

Re: [PATCH v3 2/4] i40e: geneve tunnel offload support

2015-12-08 Thread Jesse Gross
On Tue, Dec 8, 2015 at 10:20 AM, Alexei Starovoitov wrote: > On Tue, Dec 08, 2015 at 10:12:12AM -0800, Anjali Singhai Jain wrote: >> +/** >> + * i40e_add_geneve_port - Get notifications about GENEVE ports that come up >> + * @netdev: This physical port's netdev >> + * @sa_family: Socket Family tha

Re: [PATCH v1 1/6] net: Generalize udp based tunnel offload

2015-12-07 Thread Jesse Gross
On Sun, Dec 6, 2015 at 7:02 PM, David Ahern wrote: > On 12/6/15 6:20 PM, Alexander Duyck wrote: >> >> That works for Linux to Linux, but what about the cases where you have >> a non-Linux endpoint on the other end such as something like a Cisco >> switch? > > > Why does is matter what kind of swit

Re: [PATCH v1 1/6] net: Generalize udp based tunnel offload

2015-12-04 Thread Jesse Gross
On Fri, Dec 4, 2015 at 12:26 PM, Hannes Frederic Sowa wrote: > Hi Dave, > > On Fri, Dec 4, 2015, at 21:06, David Miller wrote: >> From: Hannes Frederic Sowa >> Date: Fri, 04 Dec 2015 20:59:05 +0100 >> >> > Yes, I agree, I am totally with you here. If generic offloading can be >> > realized by NIC

Re: OVS VXLAN decap rule has full match on TTL for the outer headers?

2015-12-02 Thread Jesse Gross
On Wed, Dec 2, 2015 at 9:52 AM, Joe Stringer wrote: > On 29 November 2015 at 05:06, Haggai Eran wrote: >> On 14/11/2015 08:45, Joe Stringer wrote: >>> On 13 November 2015 at 06:46, Or Gerlitz wrote: > On Fri, Nov 13, 2015 at 10:14 AM, Joe Stringer > wrote: > > >> I don't fol

Re: [PATCH v1 1/6] net: Generalize udp based tunnel offload

2015-11-30 Thread Jesse Gross
On Mon, Nov 30, 2015 at 5:02 PM, Tom Herbert wrote: > On Mon, Nov 30, 2015 at 4:25 PM, Jesse Gross wrote: >> On Sun, Nov 29, 2015 at 7:21 PM, David Miller wrote: >>> From: Tom Herbert >>> Date: Mon, 23 Nov 2015 13:53:44 -0800 >>> >>>> The bad

Re: [PATCH v1 1/6] net: Generalize udp based tunnel offload

2015-11-30 Thread Jesse Gross
On Sun, Nov 29, 2015 at 7:21 PM, David Miller wrote: > From: Tom Herbert > Date: Mon, 23 Nov 2015 13:53:44 -0800 > >> The bad effect of this model is that it is encourages HW vendors to >> continue implement HW protocol specific support for encapsulations, we >> get so much more benefit if they i

Re: [PATCH v1 1/6] net: Generalize udp based tunnel offload

2015-11-23 Thread Jesse Gross
On Mon, Nov 23, 2015 at 1:53 PM, Tom Herbert wrote: >> diff --git a/include/net/udp_tunnel.h b/include/net/udp_tunnel.h >> index cb2f89f..72415aa 100644 >> --- a/include/net/udp_tunnel.h >> +++ b/include/net/udp_tunnel.h >> @@ -9,6 +9,12 @@ >> #include >> #endif >> >> +enum udp_tunnel_type { >>

Re: OVS VXLAN decap rule has full match on TTL for the outer headers?

2015-11-11 Thread Jesse Gross
On Wed, Nov 11, 2015 at 6:47 AM, Or Gerlitz wrote: > Hi Joe/Jesse, > > We've noticed that VXLAN decap rules set by OVS in the below trivial VXLAN > config contain full match on TTL=64 for the outer headers, can you explain > the reasoning behind it? is that justa typo in dumping the flow? Looking

Re: [PATCH v8 3/3] geneve: add IPv6 bits to geneve_fill_metadata_dst

2015-10-27 Thread Jesse Gross
On Tue, Oct 27, 2015 at 9:49 PM, John W. Linville wrote: > Signed-off-by: John W. Linville > --- > v7 -- initial version (numbered to match earlier patches in series) > v8 -- fixup of bracing on an "else { return -EINVAL; }" Reviewed-by: Jesse Gross -- To unsubscribe fr

Re: [PATCH v6 1/2] geneve: implement support for IPv6-based tunnels

2015-10-25 Thread Jesse Gross
On Fri, Oct 23, 2015 at 10:40 PM, John W. Linville wrote: > NOTE: Link-local IPv6 addresses for remote endpoints are not supported, > since the driver currently has no capacity for binding a geneve > interface to a specific link. > > Signed-off-by: John W. Linville Reviewed-

Re: [PATCH 2/2] geneve: handle ipv6 priority like ipv4 tos

2015-10-20 Thread Jesse Gross
On Tue, Oct 20, 2015 at 11:11 PM, John W. Linville wrote: > Other callers of udp_tunnel6_xmit_skb just pass 0 for the prio > argument. Jesse Gross suggested that prio is really > the same as IPv4's tos and should be handled the same, so this is my > interpretation of that sugge

Re: [PATCH v4 1/2] geneve: implement support for IPv6-based tunnels

2015-10-20 Thread Jesse Gross
All of this looks pretty good to me, I just have a few last things that I noticed: On Tue, Oct 20, 2015 at 11:11 PM, John W. Linville wrote: > diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c > index 8f5c02eed47d..217b472ab9e7 100644 > --- a/drivers/net/geneve.c > +++ b/drivers/net/geneve

[PATCH net] tunnels: Don't require remote endpoint or ID during creation.

2015-10-16 Thread Jesse Gross
GRE), just dropping the restrictions seems the most consistent across tunnels and with the existing configuration. CC: John Linville Signed-off-by: Jesse Gross --- drivers/net/geneve.c | 12 ++-- drivers/net/vxlan.c | 7 +++ 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/d

Re: [PATCH] - gre: add eth_p_teb gro-handler for OVS with gre tunnels

2015-10-12 Thread Jesse Gross
yer (only ETH_P_IP, ETH_P_IPV6, and mpls related > protocols are registered). Hence, GRO is skipped. Why doesn't this work? commit 9b174d88c257150562b0101fcc6cb6c3cb74275c Author: Jesse Gross Date: Tue Dec 30 19:10:15 2014 -0800 net: Add Transparent Ethernet Bridging GRO support.

Re: [ovs-dev] [PATCH] ovs: do not allocate memory from offline numa node

2015-10-09 Thread Jesse Gross
On Fri, Oct 9, 2015 at 8:54 AM, Jarno Rajahalme wrote: > > On Oct 8, 2015, at 4:03 PM, Jesse Gross wrote: > > On Wed, Oct 7, 2015 at 10:47 AM, Jarno Rajahalme > wrote: > > > On Oct 6, 2015, at 6:01 PM, Jesse Gross wrote: > > On Mon, Oct 5, 2015 at 1:25 PM, Alexa

Re: [PATCH net-next] openvswitch: report features supported by the kernel datapath

2015-10-09 Thread Jesse Gross
On Fri, Oct 9, 2015 at 2:46 AM, Jiri Benc wrote: > On Fri, 9 Oct 2015 11:24:53 +0200, Thomas Graf wrote: >> On 10/08/15 at 03:40pm, Jesse Gross wrote: >> > I have similar concerns as were expressed in the other thread. The >> > features listed here aren't OVS comp

Re: [ovs-dev] [PATCH] ovs: do not allocate memory from offline numa node

2015-10-08 Thread Jesse Gross
On Wed, Oct 7, 2015 at 10:47 AM, Jarno Rajahalme wrote: > >> On Oct 6, 2015, at 6:01 PM, Jesse Gross wrote: >> >> On Mon, Oct 5, 2015 at 1:25 PM, Alexander Duyck >> wrote: >>> On 10/05/2015 06:59 AM, Vlastimil Babka wrote: >>>> >>

Re: [PATCH net-next] openvswitch: report features supported by the kernel datapath

2015-10-08 Thread Jesse Gross
On Thu, Oct 8, 2015 at 6:53 AM, Jiri Benc wrote: > Allow the user space to query what features are supported by the openvswitch > module. This will be used to allow or disallow certain configurations and/or > switch between newer and older APIs depending on what the kernel supports. > > Two featur

  1   2   >