Hello Vincent,
On 1/10/21 11:35 AM, Vincent Mailhol wrote:
Call skb_tx_timestamp() within can_put_echo_skb() so that a software
tx timestamp gets attached on the skb.
[..]
diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c
index 3486704c8a95..3904e0874543 100644
--- a/drivers/net/can
Hello Oliver,
On 12/2/20 5:22 PM, Oliver Hartkopp wrote:
[...]
Aborting the current transmission in non single shot mode
will get you there and incorrectly report the message as
transmitted, but that is not implemented afaik.
Ahem, no. If you get there the echo_skb is deleted and the tx_error
Hello Oliver,
On 12/2/20 3:35 PM, Oliver Hartkopp wrote:
On 27.11.20 12:09, Jeroen Hofstee wrote:
On 11/27/20 11:30 AM, Marc Kleine-Budde wrote:
On 11/27/20 10:59 AM, Jeroen Hofstee wrote:
Losing arbitration is normal in a CAN-bus network, it means that a
higher priority frame is being
Hello Oliver,
On 11/28/20 6:23 PM, Oliver Hartkopp wrote:
On 27.11.20 12:09, Jeroen Hofstee wrote:
Hi,
On 11/27/20 11:30 AM, Marc Kleine-Budde wrote:
On 11/27/20 10:59 AM, Jeroen Hofstee wrote:
Losing arbitration is normal in a CAN-bus network, it means that a
higher priority frame is
Hello Marc,
[...]
What about one shot mode on the sja1000 cores?
That is a good question. I guess it will be counted as error by:
if (isrc & IRQ_TI) {
/* transmission buffer released */
if (priv->can.ctrlmode & CAN_CTRLMODE_ONE_SHOT &&
!(
Hi,
On 11/27/20 11:30 AM, Marc Kleine-Budde wrote:
On 11/27/20 10:59 AM, Jeroen Hofstee wrote:
Losing arbitration is normal in a CAN-bus network, it means that a
higher priority frame is being send and the pending message will be
retried later. Hence most driver only increment arbitration_lost
normal functioning CAN-bus. So stop counting them
as errors.
For completeness, the Kvaser USB hybra also increments the tx_error
on arbitration lose, but it does so in single shot. Since in that
case the message is not retried, that behaviour is kept.
Signed-off-by: Jeroen Hofstee
---
drivers/net
Attempt 2, now as plain text... (vger doesn't like html)
On 10/10/19 5:52 PM, Marc Kleine-Budde wrote:
> On 10/10/19 2:17 PM, Marc Kleine-Budde wrote:
>> From: Jeroen Hofstee
>>
>> When the rx fifo overflows the ti_hecc would silently drop them since
>> the ove
cf->can_id = (data & CAN_EFF_MASK) | CAN_EFF_FLAG;
>
>
Indeed, mbx_mask is no longer used after including
"can: ti_hecc: use timestamp based rx-offloading".
Reviewed-by: Jeroen Hofstee
Hello,
I posted below RFC to the linux-can ML, but it might be actually
more appropriate for netdev (since it involves napi). This driver
is lying a bit about the amount of work done. Changing that (always
look at work done instead of the hw state) seems to solve the issue,
but I have no clear un
has a
check for netif_running it returns 0 and doesn't call napi_complete and hence
violates the napi its expectation.
So remove this check, so either napi_complete is called or quota is returned.
Signed-off-by: Jeroen Hofstee
---
drivers/net/can/ti_hecc.c | 3 ---
1 file changed, 3 dele
Hello Tony,
On 28-10-16 17:52, Tony Lindgren wrote:
* Jeroen Hofstee [161028 08:33]:
Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
id to common file") did not only move the code for an am3517, it also
added the slave parameter, resulting in an invalid (all
Hello Tony,
On 21-10-16 09:53, Tony Lindgren wrote:
* Jeroen Hofstee [161021 00:37]:
Hello Tony,
On 21-10-16 08:38, Tony Lindgren wrote:
* Jeroen Hofstee [161020 12:57]:
Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
id to common file") did not onl
Hello Tony,
On 21-10-16 08:38, Tony Lindgren wrote:
* Jeroen Hofstee [161020 12:57]:
Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
id to common file") did not only move the code for an am3517, it also
added the slave parameter, resulting in a invalid (all
Hi,
On 20-10-16 14:41, Tony Lindgren wrote:
* Jeroen Hofstee [161019 12:39]:
commit 9120bd6e9f77 ("net: davinci_emac: Get device dm816x MAC address
using the cpsw code") sets the mac address to the one stored in the chip
unconditionally, overwritten the one already set from the d
15 matches
Mail list logo
