Jeff,
this series of 5 patches by Ishizaki-san runs fine on the blade, I tested it
for a few days. Besides it fixes a nasty bug in spidernet RX descriptor
handling.
Can you please consider it for 2.6.25 ?
Thanks !
Jens
On Wednesday 23 January 2008, Jens Osterkamp wrote:
> On Friday
to see the link result, and we think it should be displayed.
>
> Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Jens Osterkamp <[EMAIL PROTECTED]>
> ---
>
> Index: linux-powerpc-git/drivers/net/spider_net.c
> ==
y: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Jens Osterkamp <[EMAIL PROTECTED]>
>
> Index: linux-powerpc-git/drivers/net/spider_net.c
> ===
> --- linux-powerpc-git.orig/drivers/net/spider_net.c
> +++ linux
-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Jens Osterkamp <[EMAIL PROTECTED]>
> ---
>
> Index: linux-powerpc-git/drivers/net/spider_net.h
> ===
> --- linux-powerpc-git.orig/drivers/net/spider_net.h
On Friday 11 January 2008, Ishizaki Kou wrote:
> This patch fixes initialization of "aneg_count" and "medium" fields in
> spider_net_card to make spidernet driver correctly sets "link status".
>
> Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]
On Friday 11 January 2008, Ishizaki Kou wrote:
> This patch extends the timeout for spidernet auto-negotiation.
> Auto-negotiation often fails to finish in 2 seconds.
>
> Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Jens Osterkamp <[EMAIL PROTECTED]>
> --
Ishizaki,
Linas has left the company and is no longer doing kernel related stuff,
so I suggest, given Jeff is ok with that, that the two of us take over
spidernet maintainership.
Jens
---
Change maintainership for spidernet.
Signed-off-by: Jens Osterkamp &
On Wednesday 07 February 2007, Ishizaki Kou wrote:
> This is a revised spidernet patch set based on
> netdev-2.6.git#upstream.
>
> This patch set is merged Jens-san's spidernet patch and works on
> Toshiba Cell reference set (aka Celleb).
> It requires Jens-san's phy patch
> (http://ozlabs.org/pi
This moves the medium variable into the spidernet card structure.
It renames the GMII_ variables to BCM54XX specific ones.
Signed-off-by: Jens Osterkamp <[EMAIL PROTECTED]>
---
Index: linux-2.6.20/drivers/net/spider
ard declarations.
Signed-off-by: Jens Osterkamp <[EMAIL PROTECTED]>
Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]>
Index: linux-2.6.20/drivers/net/sungem_phy.c
===
--- linux-2.6.20.orig/drivers/net/sungem_phy.c
+++ linux-2.6
> PHY patch is mostly Ok except I don't like that "medium" variable Jens
> added which isn't used anywhere in sungem_phy. Jens, can you resend a
> version without that ? If you need that variable in spidernet itself,
> then put it there :-)
That was the idea I had first, I'll change that.
> Also
On Thursday 01 February 2007 6:36 pm, Linas Vepstas wrote:
>
> A variant of this patch is queued up for 2.6.21,
> as a part of the patch
> http://www.mail-archive.com/netdev@vger.kernel.org/msg28213.html
>
> I beleive its in the -mm tree, I have not checked.
Ah, good ! I knew that you had severa
We forget to call spider_net_free_rx_chain_contents which does the
actual dev_kfree_skb. New skbs are allocated from skbuff_head_cache
on each "ifconfig up" letting the cache grow infinitely.
This patch fixes it.
Signed-off-by: Jens Osterkamp <[EMAIL PROTECTED]>
Index: linux-2.
Ishizaki-san,
> This patch partially works on celleb but remains
> following several problems.
> 1. It doesn't recover once an ethernet cable which is
>connected to a spider_net card is unpluged.
My understanding is that you are using the LINK interrupt to detect this.
For the blade this i
declarations.
Signed-off-by: Jens Osterkamp <[EMAIL PROTECTED]>
Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]>
Index: linux-2.6.20-rc6/drivers/net/sungem_phy.c
===
--- linux-2.6.20-rc6.orig/drivers/net/sungem_phy.c
+++ lin
On Tuesday 30 January 2007 11:30 pm, Linas Vepstas wrote:
> Shifting to the right by 5 bits has no effect on the result
> of this conditional. Either the bit is set, or its not.
> There is no need to shift.
>
> > + if ( (phy_reg & 0x0020) >> 7 ) {
You are right, I corrected this.
> The result
Francois,
thank you for your comments. I'll send a revised patch soon.
> +#define BCM5421_MODE_MASK1 << 5
>
> Please add parenthesis.
Done.
> "&" is fine despite the lack of parenthesis above but it is error-prone.
Corrected.
>
> +
> + if ( mode == GMII_COPPER) {
>^^^
>
On Friday 26 January 2007 9:21 pm, Benjamin Herrenschmidt wrote:
> Can't we have a device-tree property indicating wether to use fiber or
> copper ?
Well, yes, I am sure we could, but what would be the benefit of doing so
if we can get the same information dynamically ?
Jens
-
To unsubscribe fr
save the medium
with which the phy is currently used.
The patch moves the genmii_* functions around to avoid foreward declarations.
Signed-off-by: Jens Osterkamp <[EMAIL PROTECTED]>
Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]>
Index: linux-2.6.20-
the
user. Hardcoded values for the timeout are moved to #defines. I put in a
few comments to make the code more readable.
Signed-off-by: Jens Osterkamp <[EMAIL PROTECTED]>
Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]>
Index: linux-2.6/driv
declarations.
Signed-off-by: Jens Osterkamp <[EMAIL PROTECTED]>
Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]>
Index: linux-2.6.20-rc5/drivers/net/sungem_phy.c
===
--- linux-2.6.20-rc5.orig/drivers/net/sungem_phy.c
+++ lin
> > This is a revised version of the patch set for spider_net driver
> > that works on Toshiba Cell Refererence Set (aka Celleb).
> >
> > This patch set is based on netdev-2.6.git#upstream.
>
> Jens, can you give that a go on our blades see if it doesn't break
> anything ? We are all at LCA here s
> On my Cell blade this failed on the latest build (be0646). Running with
> the changes to sungem_phy does not allow the interfaces to ping anything.
> I went back to the original and everything works again. All I did was
> change sungem_phy and force it to be reloaded, let me know if I missed a
> There was a patch from Ishizaki Kou recently, to set up autonegotiate
> and other things, see http://patchwork.ozlabs.org/linuxppc/patch?id=8121 .
>
> Are you sure that you don't need any of those changes as well?
Thanks for pointing me to this, I must have overlooked it. Some of it seems
only
experimented with the same configuration,
feel free to comment.
This patch is not meant for inclusion into mainline.
Signed-off-by: Jens Osterkamp <[EMAIL PROTECTED]>
Index: linux-2.6.19-rc6/drivers/net/spider_net.c
===
--- linux-2.6.
This patchset contains two bugfixes, one fixes a bug in the
code clearing out the sequencer ram at startup. The other is
a fix for the tx queue stopping to send packets in heavy load
situations.
Please consider these for inclusion into 2.6.18.
--
-
To unsubscribe from this list: send the line "u
descriptor
but for a TXDMAENABLED flag in Spider's register.
Signed-off-by: Maxim Shchetynin <[EMAIL PROTECTED]>
Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]>
Signed-off-by: Jens Osterkamp <[EMAIL PROTECTED]>
Index: git/d
We want to intitialize addr instead of data register first.
Signed-off-by: Jens Osterkamp <[EMAIL PROTECTED]>
Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]>
Index: git/drivers/net/spider_net.c
===
--- git.orig
From: Jens Osterkamp <[EMAIL PROTECTED]>
The original patch was using whitespaces instead of tabs.
Signed-off-by: Jens Osterkamp <[EMAIL PROTECTED]>
Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]>
Index: linux-2.6.17-rc4/driver
Jeff Garzik <[EMAIL PROTECTED]> wrote on 05/24/2006 07:29:24 AM:
> NAK, failed to apply. Also, the whitespace above is borked.
I think the patch is already in 2.6.17-rc4. I will send send a patch to
turn the whitespaces into
tabs.
Jens
-
To unsubscribe from this list: send the line "unsubscrib
From: Jens Osterkamp <[EMAIL PROTECTED]>
A newer board revision changed the type of ethernet phy.
Moreover, this generalizes the way that a phy gets switched
into fiber mode when autodetection is not available.
Signed-off-by: Jens Osterkamp <[EMAIL PROTECTED]>
Signed-off-by: A
From: Jens Osterkamp <[EMAIL PROTECTED]>
We found a new chip setting that we need in order
to make the driver work more reliable.
Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]>
Index: linux-2.6.17-rc3/drivers/net/
The first patch introduces a new PHY BCM5461 as the BCM5421 will be no
longer produced. Besides that it generalizes the way, PHYs are
switched into fiber mode.
The second introduces a new setting that we need to make the driver
work more reliable.
Please apply.
Jens
-
To unsubscribe from this li
Hi,
the BCM5421 and (now) 5461 chips that we use on our boards contain a
serdes/fiber
interface in addition to the copper interface.
Up to now we were using the generic init code in drivers/net/sungem_phy.c and
some
additional code to set up the serdes/fiber mode in our driver
(drivers/net/sp
This patch reduces the message level of the RX ram full messages
from err to debug to prevent spamming the console leaving it in the
logfiles though.
Please apply.
From: Jens Osterkamp <[EMAIL PROTECTED]>
Index: linux-2.6.16/drivers/net/spider
This enables TX checksum offloading for the spidernet driver by default.
Signed-off-by: Jens Osterkamp <[EMAIL PROTECTED]>
Index: linux-2.6.16-rc5/drivers/net/spider_net.c
===
--- linux-2.6.16-rc5.orig/drivers/net/spider
This patch fixes a spidernet build issue found in 2.6.16-rc5-mm2.
Signed-off-by: Jens Osterkamp <[EMAIL PROTECTED]>
Index: linux-2.6.16-rc5/drivers/net/Makefile
===
--- linux-2.6.16-rc5.orig/drivers/net/Makefile
+++ linux-
Which kernel version was this in ? 2.6.16-rc5 builds ok for me.
drivers/net/spider_net.c:421: multiple definition of `mii_phy_probe'
drivers/net/sungem_phy.o(.opd+0x160):drivers/net/sungem_phy.c:95: first
defined here -
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the
Christoph Hellwig <[EMAIL PROTECTED]> wrote on 12/15/2005 02:40:06 PM:
> On Thu, Dec 15, 2005 at 01:47:25PM +0100, Jens Osterkamp wrote:
> >
> > The driver incorrectly used dma_addr_t to describe
> > HW structures and consequently broke when that type
> > was c
Performance optimizations, changes in these areas:
- RX and TX checksum offload
- correct maximum MTU
- don't use TX interrupts anymore, use a timer instead
- remove some superfluous barriers
- improve RX RAM full handling
From: Utz Bacher <[EMAIL PROTECTED]>
From: Jen
request_firmware() is sometimes problematic, especially
in initramfs, reading the firmware from Open Firmware
is much preferrable.
We still try to get the firmware from the file system
first, in order to support old SLOF releases and to allow
updates of the spidernet firmware without reflashing
t
Arnd Bergmann <[EMAIL PROTECTED]> wrote on 12/06/2005 11:23:39 AM:
> On Dinsdag 06 Dezember 2005 01:59, Paul Mackerras wrote:
> > Arnd Bergmann writes:
> >
> > > Uploading the device firmware may fail if wrong input data
> > > was provided by the user. This checks for the condition.
> > >
> > > Fr
42 matches
Mail list logo
