Christoph Hellwig writes:
> On Tue, Mar 20, 2018 at 11:30:29AM -0400, Jeff Moyer wrote:
>> > In this commit:
>> >
>> > http://git.infradead.org/users/hch/libaio.git/commitdiff/49f77d595210393ce7b125cb00233cf737402f56
>>
>> BTW, the man pages
Christoph Hellwig writes:
> On Mon, Mar 19, 2018 at 07:12:41PM -0700, Darrick J. Wong wrote:
>> > Note that unlike many other signal related calls we do not pass a sigmask
>> > size, as that would get us to 7 arguments, which aren't easily supported
>> > by the syscall infrastructure. It seems a
of the iocb.
>
> Unlike poll or epoll without EPOLLONESHOT this interface always works
> in one shot mode, that is once the iocb is completed, it will have to be
> resubmitted.
>
> Signed-off-by: Christoph Hellwig
Also acked this one in the last posting.
Acked-by: J
, which aren't easily supported
> by the syscall infrastructure. It seems a lot less painful to just add a
> new syscall variant in the unlikely case we're going to increase the
> sigset size.
>
> Signed-off-by: Christoph Hellwig
I acked this in the last set, so...
Ack
, which aren't easily supported
> by the syscall infrastructure. It seems a lot less painful to just add a
> new syscall variant in the unlikely case we're going to increase the
> sigset size.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Jeff Moyer
I assume other
of the iocb.
>
> Unlike poll or epoll without EPOLLONESHOT this interface always works
> in one shot mode, that is once the iocb is completed, it will have to be
> resubmitted.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Jeff Moyer
Christoph Hellwig writes:
> On Thu, Jan 18, 2018 at 11:44:03AM -0500, Jeff Moyer wrote:
>> Jeff Moyer writes:
>>
>> > FYI, this kernel has issues. It will boot up, but I don't have
>> > networking, and even rebooting doesn't succeed. I'm lo
Avi Kivity writes:
> On 01/18/2018 05:46 PM, Jeff Moyer wrote:
>> FYI, this kernel has issues. It will boot up, but I don't have
>> networking, and even rebooting doesn't succeed. I'm looking into it.
>
> FWIW, I'm running an older version of this pat
Jeff Moyer writes:
> FYI, this kernel has issues. It will boot up, but I don't have
> networking, and even rebooting doesn't succeed. I'm looking into it.
A bisect lands on: eventfd: switch to ->poll_mask. That's not super
helpful, though. I did run the ltp even
FYI, this kernel has issues. It will boot up, but I don't have
networking, and even rebooting doesn't succeed. I'm looking into it.
-Jeff
Christoph Hellwig writes:
> Hi all,
>
> this series adds support for the IOCB_CMD_POLL operation to poll for the
> readyness of file descriptors using the
Christoph Hellwig writes:
> On Tue, Jan 16, 2018 at 07:41:24PM -0500, Jeff Moyer wrote:
>> I'd be willing to bet the issue is in your io_syscall6 implementation.
>> You pass in arg5 where arg6 should be used. Don't feel bad, it took me
>> the better p
Christoph Hellwig writes:
> On Wed, Jan 17, 2018 at 04:27:21AM +, Al Viro wrote:
>> On Tue, Jan 16, 2018 at 07:41:24PM -0500, Jeff Moyer wrote:
>> >if (sigmask) {
>> > - if (copy_from_user(&ksigmask, sigmask, sizeof(ksigmask)))
>> > +
Hi, Christoph,
Christoph Hellwig writes:
> On Mon, Jan 15, 2018 at 09:53:10AM +0100, Christoph Hellwig wrote:
>> > pselect, as an example, crams the sigmask and size together. Why not
>> > just do that? libaio can take care of setting that up.
>>
>> Yes, I could try that. It's just another d
Christoph Hellwig writes:
> This is the io_getevents equivalent of ppoll/pselect and allows to
> properly mix signals and aio completions (especially with IOCB_CMD_POLL)
> and atomically executes the following sequence:
>
> sigset_t origmask;
>
> pthread_sigmask(SIG_SETMASK, &sigmask,
Christoph Hellwig writes:
> On Wed, Jan 10, 2018 at 06:26:39PM -0500, Jeff Moyer wrote:
>> >> The upcoming aio poll support would like to be able to complete the
>> >> iocb inline from the cancellation context, but that would cause
>> >> a lock order rever
"Michael Kerrisk (man-pages)" writes:
Hi, Michael,
> Are there some man pages patches already for these changes?
https://patchwork.kernel.org/patch/10144129/
Cheers,
Jeff
Jeff Moyer writes:
> Christoph Hellwig writes:
>
>> The upcoming aio poll support would like to be able to complete the
>> iocb inline from the cancellation context, but that would cause
>> a lock order reversal. Add support for optionally moving the cancelation
>&g
his reversal.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Jeff Moyer
Christoph Hellwig writes:
> One we cancel an iocb there is no reason to keep it on the active_reqs
> list, given that the list is only used to look for cancelation candidates.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Jeff Moyer
path or the
cancellation path delivered the completion event. Now, the completion
is always delivered via aio_complete.
So yeah, we can get rid of this.
Acked-by: Jeff Moyer
;
>
> + spin_lock_irqsave(&ctx->ctx_lock, flags);
> + list_add_tail(&req->ki_list, &ctx->active_reqs);
> req->ki_cancel = cancel;
So, this changes behavior from quietly overwriting the prior cancel
function to not doing it. I don't think it matters one bit, though.
Callers shouldn't do that.
Acked-by: Jeff Moyer
b->aio_fildes);
> + if (unlikely(!req->ki_filp))
> + return -EBADF;
> + req->ki_complete = aio_complete_rw;
> + req->ki_flags = 0;
The above assignment seems superfluous...
> + req->ki_pos = iocb->aio_offset;
> + req->ki_flags = iocb_flags(req->ki_filp);
because of this.
Acked-by: Jeff Moyer
ld have been part of commit 599bd19bdc4c6 ("fs: don't
allow to complete sync iocbs through aio_complete").
Reviewed-by: Jeff Moyer
> ---
> fs/aio.c | 11 ++-
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/fs/aio.c b/fs/aio.c
> index 03d59
Christoph Hellwig writes:
> The page size is in no way related to the aio code, and printing it in
> the (debug) dmesg at every boot serves no purpose.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Jeff Moyer
Christoph Hellwig writes:
> + p = fork();
> + switch (p) {
[snip]
> + default:
> + close(pipe1[0]);
> + close(pipe2[1]);
> +
> + io_prep_poll(&iocb, pipe2[0], POLLIN);
> +
> + ret = io_setup(1, &ctx);
> + if (ret) {
> +
Christoph Hellwig writes:
> Hi all,
>
> this series resurrects IOCB_CMD_POLL support and adds support for the
> new io_pgetevents system call, as well as adding a test case.
This looks good to me. There may be a couple of changes to the syscall
bits, but I can take care of that. I'll review th
Hi, Ben,
Thanks for the quick reply.
Benjamin LaHaise writes:
> On Fri, Jan 05, 2018 at 11:25:17AM -0500, Jeff Moyer wrote:
>> Christoph Hellwig writes:
>>
>> > This way it can be used for the fallback 6-argument version on
>> > all architectures.
>>
Christoph Hellwig writes:
> This way it can be used for the fallback 6-argument version on
> all architectures.
>
> Signed-off-by: Christoph Hellwig
This is a strange way to do things. However, I was never really sold on
libaio having to implement its own system call wrappers. That decision
d
==> Regarding Re: [PATCH 1/2] e1000: fix netpoll with NAPI; Mitch Williams
<[EMAIL PROTECTED]> adds:
mitch.a.williams> On Wed, 2006-06-07 at 11:44 -0700, Jeff Moyer wrote:
>> That patch locks around the tx clean routine. As such, it doesn't
>> prevent the problem.
==> Regarding Re: [PATCH 1/2] e1000: fix netpoll with NAPI; Auke Kok <[EMAIL
PROTECTED]> adds:
auke-jan.h.kok> Hi,
auke-jan.h.kok> we're not too happy with this as it puts a branch right in
auke-jan.h.kok> the regular receive path. We haven't ran the numbers on it
auke-jan.h.kok> yet but it is l
==> Regarding Re: [PATCH 1/2] e1000: fix netpoll with NAPI; Auke Kok <[EMAIL
PROTECTED]> adds:
auke-jan.h.kok> Jeff Moyer wrote:
>> ==> Regarding Re: [PATCH 1/2] e1000: fix netpoll with NAPI; Auke Kok <[EMAIL
>> PROTECTED]> adds:
auke-jan.h.kok> Neil Horman
==> Regarding Re: [PATCH 1/2] e1000: fix netpoll with NAPI; Mitch Williams
<[EMAIL PROTECTED]> adds:
mitch> On Tue, 2006-06-06 at 09:52 -0400, Neil Horman wrote:
>> I've been speaking about this fix with a Jeff Moyer, and we've come up with
>> some
>&g
==> Regarding Re: [PATCH 1/2] e1000: fix netpoll with NAPI; Auke Kok <[EMAIL
PROTECTED]> adds:
auke-jan.h.kok> Neil Horman wrote:
>> On Tue, Jun 06, 2006 at 09:39:25AM -0700, Mitch Williams wrote:
>>> On Tue, 2006-06-06 at 09:52 -0400, Neil Horman wrote:
auke-jan.h.kok> [snip]
>>> However, ju
33 matches
Mail list logo
