Re: UDP wierdness around skb_copy_and_csum_datagram_msg()

2016-10-17 Thread Jay Smith
Trying to revive this thread. To review: skb_copy_and_csum_datagram_msg() pretty clearly doesn't do the right thing since it started using an iov_iter to copy into the user's iovec. In particular, if it encounters a datagram that fails the checksum, the iov_iter continues to point to the end of

Re: UDP wierdness around skb_copy_and_csum_datagram_msg()

2016-09-30 Thread Jay Smith
Christian Lamparter writes: > On Wednesday, September 28, 2016 7:20:39 PM CEST Jay Smith wrote: >> Actually, on a little more searching of this list's archives, I think >> that this discussion: https://patchwork.kernel.org/patch/9260733/ is >> about exactly the sam

Re: UDP wierdness around skb_copy_and_csum_datagram_msg()

2016-09-28 Thread Jay Smith
yield to someone with stronger feelings about where it should go... On Wed, Sep 28, 2016 at 6:24 PM, Eric Dumazet wrote: > On Wed, 2016-09-28 at 17:18 -0700, Jay Smith wrote: >> I've spent the last week or so trying to track down a recurring >> problem I'm seeing with UDP

UDP wierdness around skb_copy_and_csum_datagram_msg()

2016-09-28 Thread Jay Smith
I've spent the last week or so trying to track down a recurring problem I'm seeing with UDP datagram handling. I'm new to the internals of the Linux network stack, but it appears to me that there's a substantial error in recent kernels' handling of UDP checksum errors. The behavior I'm seeing: I