Re: ip_auto_config() prevents network device to be registered

Hello, On 01/31/2017 02:49 PM, Javier Martinez Canillas wrote: > > The kernelci folks pointed out that a Samsung Exynos based board was failing > to boot when trying to mount the rootfs via NFS, due a networking issue [0]. > > I looked at the issue and it turned out to be

ip_auto_config() prevents network device to be registered

http://lxr.free-electrons.com/source/net/ipv4/ipconfig.c#L1368 [2]: http://lxr.free-electrons.com/source/net/ipv4/ipconfig.c#L202 [3]: http://lxr.free-electrons.com/source/net/core/rtnetlink.c#L68 [4]: http://lxr.free-electrons.com/source/net/core/dev.c#L7326 Best regards, -- Javier Martinez Canil

Re: [PATCH -next] net: wan: slic_ds26522: Remove .owner field for driver

@@ static struct spi_driver slic_ds26522_driver = { > .driver = { > .name = "ds26522", > .bus = &spi_bus_type, > -.owner = THIS_MODULE, > .of_match_table = slic_ds26522_match, > }, >

Re: [PATCH -next] net: wan: slic_ds26522: Use module_spi_driver to simplify the code

(&slic_ds26522_driver); > -} > - > -module_init(slic_ds26522_init); > -module_exit(slic_ds26522_exit); > +module_spi_driver(slic_ds26522_driver); > Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

[PATCH 4/7] net: qcom/emac: Fix module autoload for OF registration

om,fsm9900-emac Signed-off-by: Javier Martinez Canillas --- drivers/net/ethernet/qualcomm/emac/emac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/qualcomm/emac/emac.c b/drivers/net/ethernet/qualcomm/emac/emac.c index 9bf3b2b82e95..4fede4b86538 100644 --- a/drivers/ne

[PATCH 6/7] net: dsa: b53: Fix module autoload

368-switch alias: of:N*T*Cbrcm,bcm6328-switchC* alias: of:N*T*Cbrcm,bcm6328-switch alias: of:N*T*Cbrcm,bcm3384-switchC* alias: of:N*T*Cbrcm,bcm3384-switch Signed-off-by: Javier Martinez Canillas --- drivers/net/dsa/b53/b53_mmap.c | 1 + 1 file changed, 1

[PATCH 7/7] net: dsa: bcm_sf2: Fix module autoload for OF registration

by: Javier Martinez Canillas --- drivers/net/dsa/bcm_sf2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c index e218887f18b7..0427009bc924 100644 --- a/drivers/net/dsa/bcm_sf2.c +++ b/drivers/net/dsa/bcm_sf2.c @@ -1158,6 +1158,7 @@ static co

[PATCH 3/7] net: hns: Fix hns_dsaf module autoload for OF registration

of:N*T*Chisilicon,hns-dsaf-v2C* alias: of:N*T*Chisilicon,hns-dsaf-v2 alias: of:N*T*Chisilicon,hns-dsaf-v1C* alias: of:N*T*Chisilicon,hns-dsaf-v1 Signed-off-by: Javier Martinez Canillas --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 1 + 1 file changed, 1

[PATCH 1/7] net: nps_enet: Fix module autoload

$ modinfo drivers/net/ethernet/ezchip/nps_enet.ko | grep alias $ After this patch: $ modinfo drivers/net/ethernet/ezchip/nps_enet.ko | grep alias alias: of:N*T*Cezchip,nps-mgt-enetC* alias: of:N*T*Cezchip,nps-mgt-enet Signed-off-by: Javier Martinez Canillas --- drivers/net/ether

[PATCH 5/7] net: hisilicon: Fix hns_mdio module autoload for OF registration

ioC* alias: of:N*T*Chisilicon,hns-mdio alias: of:N*T*Chisilicon,mdioC* alias: of:N*T*Chisilicon,mdio alias: acpi*:HISI0141:* Signed-off-by: Javier Martinez Canillas --- drivers/net/ethernet/hisilicon/hns_mdio.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 2/7] net: ethernet: nb8800: Fix module autoload

of:N*T*Csigma,smp8642-ethernet alias: of:N*T*Caurora,nb8800C* alias: of:N*T*Caurora,nb8800 Signed-off-by: Javier Martinez Canillas --- drivers/net/ethernet/aurora/nb8800.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/ne

[PATCH 0/7] net: Fix module autoload for several platform drivers

Hello David, I noticed that module autoload won't be working in a bunch of platform drivers in the net subsystem and this patch series contains the fixes. Best regards, Javier Javier Martinez Canillas (7): net: nps_enet: Fix module autoload net: ethernet: nb8800: Fix module autoload

[PATCH] net: wan: slic_ds26522: Allow driver to built if COMPILE_TEST is enabled

cause build regressions. Signed-off-by: Javier Martinez Canillas --- drivers/net/wan/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig index 33ab3345d333..4e9fe75d7067 100644 --- a/drivers/net/wan/Kconfig +++ b/drivers/net

[PATCH 1/2] net: wan: slic_ds26522: add SPI device ID table to fix module autoload

grep alias $ After this patch: $ modinfo drivers/net/wan/slic_ds26522.ko | grep alias alias: spi:ds26522 Signed-off-by: Javier Martinez Canillas --- drivers/net/wan/slic_ds26522.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/wan/slic_ds26522.c b/drive

[PATCH 2/2] net: wan: slic_ds26522: Export OF module alias information

one, but that could change so it's better to always export it. Signed-off-by: Javier Martinez Canillas --- drivers/net/wan/slic_ds26522.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wan/slic_ds26522.c b/drivers/net/wan/slic_ds26522.c index 53366a2232f0..b776a0ab106c 1

[PATCH 12/15] sis900: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- drivers/net/ethernet/sis/sis900.c | 4 ++-- drivers/net/ethernet/sis/sis900.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c index 95001ee408ab..6f85276376e8 100644 --- a/drivers

[PATCH 06/15] net/fsl_pq_mdio: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- drivers/net/ethernet/freescale/fsl_pq_mdio.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c index f3c63dce1e30..446c7b374ff5 100644 --- a/drivers/net

[PATCH 02/15] starfire: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- drivers/net/ethernet/adaptec/starfire.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/adaptec/starfire.c b/drivers/net/ethernet/adaptec/starfire.c index 1d1069641d81..8af2c88d5b33 100644 --- a/drivers/net/ethernet/adaptec/starfire.c

[PATCH 04/15] bnx2: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- drivers/net/ethernet/broadcom/bnx2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnx2.c b/drivers/net/ethernet/broadcom/bnx2.c index 8fc3f3c137f8..ecd357dbb1d4 100644 --- a/drivers/net/ethernet/broadcom/bnx2.c +++ b

[PATCH 05/15] sundance: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- drivers/net/ethernet/dlink/sundance.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/dlink/sundance.c b/drivers/net/ethernet/dlink/sundance.c index 58c6338a839e..79d80090eac8 100644 --- a/drivers/net/ethernet/dlink/sundance.c +++ b

[PATCH 08/15] ixgbe: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h index 33c025055011..b06e32d0d22a 100644 --- a/drivers/net/ethernet/intel/ixgbe

[PATCH 03/15] ethernet: amd: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- drivers/net/ethernet/amd/7990.c | 6 +++--- drivers/net/ethernet/amd/amd8111e.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/amd/7990.c b/drivers/net/ethernet/amd/7990.c index dcf2a1f3643d..dc57f2759f44 100644 --- a/drivers

[PATCH 00/15] drivers: net: use IS_ENABLED() instead of checking for built-in or module

helping abstract away some of the Kconfig built-in and module enable details. [0]: https://lkml.org/lkml/2016/9/9/323 Best regards, Javier Javier Martinez Canillas (15): 3c59x: use IS_ENABLED() instead of checking for built-in or module starfire: use IS_ENABLED() instead of checking for built-in

[PATCH 07/15] i825xx: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- drivers/net/ethernet/i825xx/82596.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/i825xx/82596.c b/drivers/net/ethernet/i825xx/82596.c index befb4ac3e2b0..ce235b776793 100644 --- a/drivers/net/ethernet/i825xx/82596.c +++ b

[PATCH 09/15] net: mvneta: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- drivers/net/ethernet/marvell/mvneta_bm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvneta_bm.h b/drivers/net/ethernet/marvell/mvneta_bm.h index e74fd44a92f7..a32de432800c 100644 --- a/drivers/net/ethernet/marvell

[PATCH 11/15] sfc: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- drivers/net/ethernet/sfc/falcon_boards.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sfc/falcon_boards.c b/drivers/net/ethernet/sfc/falcon_boards.c index 1736f4b806af..f6883b2b5da3 100644 --- a/drivers/net/ethernet/sfc

[PATCH 13/15] stmmac: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- drivers/net/ethernet/stmicro/stmmac/common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers/net/ethernet/stmicro/stmmac/common.h index 2533b91f1421..d3292c4a6eda 100644 --- a/drivers/net/ethernet

[PATCH 15/15] iwlegacy: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- drivers/net/wireless/intel/iwlegacy/common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlegacy/common.h b/drivers/net/wireless/intel/iwlegacy/common.h index 726ede391cb9..3bba521d2cd9 100644 --- a/drivers/net

[PATCH 14/15] hamradio: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- drivers/net/hamradio/bpqether.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hamradio/bpqether.c b/drivers/net/hamradio/bpqether.c index d95a50ae996d..622ab3ab9e93 100644 --- a/drivers/net/hamradio/bpqether.c +++ b/drivers/net/hamradio

[PATCH 10/15] natsemi: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- drivers/net/ethernet/natsemi/ns83820.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/natsemi/ns83820.c b/drivers/net/ethernet/natsemi/ns83820.c index eb807b0dc72a..569ade6cf85c 100644 --- a/drivers/net/ethernet/natsemi/ns83820.c

[PATCH 01/15] 3c59x: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- drivers/net/ethernet/3com/3c59x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/3com/3c59x.c b/drivers/net/ethernet/3com/3c59x.c index 25c55ab05c7d..9133e7926da5 100644 --- a/drivers/net/ethernet/3com/3c59x.c +++ b/drivers/net

[PATCH 2/8] lec: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- net/atm/lec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/atm/lec.c b/net/atm/lec.c index e574a7e9db6f..5d2693826afb 100644 --- a/net/atm/lec.c +++ b/net/atm/lec.c @@ -31,7 +31,7 @@ #include /* Proxy LEC knows about bridging

[PATCH 1/8] appletalk: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- net/appletalk/ddp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c index f066781be3c8..10d2bdce686e 100644 --- a/net/appletalk/ddp.c +++ b/net/appletalk/ddp.c @@ -1278,7 +1278,7 @@ out: return err

[PATCH 4/8] ipv4: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- net/ipv4/ip_output.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c index 65569274efb8..b913f5bf0757 100644 --- a/net/ipv4/ip_output.c +++ b/net/ipv4/ip_output.c @@ -490,7 +490,7 @@ static void ip_copy_metadata

[PATCH 0/8] net: use IS_ENABLED() instead of checking for built-in or module

regards, Javier Javier Martinez Canillas (8): appletalk: use IS_ENABLED() instead of checking for built-in or module lec: use IS_ENABLED() instead of checking for built-in or module net: use IS_ENABLED() instead of checking for built-in or module ipv4: use IS_ENABLED() instead of checking for

[PATCH 8/8] xfrm: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- net/xfrm/xfrm_algo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/xfrm/xfrm_algo.c b/net/xfrm/xfrm_algo.c index 250e567ba3d6..44ac85fe2bc9 100644 --- a/net/xfrm/xfrm_algo.c +++ b/net/xfrm/xfrm_algo.c @@ -17,7 +17,7 @@ #include #include

[PATCH 5/8] l2tp: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- net/l2tp/l2tp_core.h | 2 +- net/l2tp/l2tp_eth.c | 4 ++-- net/l2tp/l2tp_ppp.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/net/l2tp/l2tp_core.h b/net/l2tp/l2tp_core.h index 5871537af387..2599af6378e4 100644 --- a/net/l2tp/l2tp_core.h +++ b/net

[PATCH 7/8] sctp: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- net/sctp/auth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/auth.c b/net/sctp/auth.c index 912eb1685a5d..f99d4855d3de 100644 --- a/net/sctp/auth.c +++ b/net/sctp/auth.c @@ -48,7 +48,7 @@ static struct sctp_hmac sctp_hmac_list

[PATCH 6/8] net: sched: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- net/sched/cls_flow.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/sched/cls_flow.c b/net/sched/cls_flow.c index 2c1ae549edbf..a379bae1d74e 100644 --- a/net/sched/cls_flow.c +++ b/net/sched/cls_flow.c @@ -29,7 +29,7 @@ #include #include

[PATCH 3/8] net: use IS_ENABLED() instead of checking for built-in or module

Martinez Canillas --- net/core/dev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index c7d7db49826d..9e76d4df6ca0 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -3904,8 +3904,7 @@ static __latent_entropy void net_tx_action(struct

Re: mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

Hello Amitkumar, On 09/08/2016 11:55 AM, Amitkumar Karwar wrote: > Hi Javier, > >> From: Javier Martinez Canillas [mailto:jav...@osg.samsung.com] >> Sent: Tuesday, September 06, 2016 5:43 PM >> To: Kalle Valo >> Cc: linux-ker...@vger.kernel.org; Amitkumar Karwar; &g

Re: mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

Hello Kalle, On 09/03/2016 12:35 PM, Kalle Valo wrote: > Javier Martinez Canillas wrote: >> If request_irq() fails in mwifiex_sdio_probe_of(), only an error message >> is printed but the actual error is not propagated to the caller function. >> >> Signed-off-b

Re: [PATCH] mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

Hello Arend, On 08/18/2016 03:49 PM, Arend van Spriel wrote: > > > On 18-08-16 21:29, Javier Martinez Canillas wrote: >> Hello Arend, >> >> Thanks a lot for your feedback. >> >> On 08/18/2016 03:14 PM, Arend van Spriel wrote: >>> On 18-08-1

Re: [PATCH] mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

Hello Arend, Thanks a lot for your feedback. On 08/18/2016 03:14 PM, Arend van Spriel wrote: > On 18-08-16 16:17, Javier Martinez Canillas wrote: >> If request_irq() fails in mwifiex_sdio_probe_of(), only an error message >> is printed but the actual error is not propagate

[PATCH] mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

If request_irq() fails in mwifiex_sdio_probe_of(), only an error message is printed but the actual error is not propagated to the caller function. Signed-off-by: Javier Martinez Canillas --- drivers/net/wireless/marvell/mwifiex/sdio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

Re: [PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback

Hello Kalle, On 07/05/2016 09:09 AM, Kalle Valo wrote: > Javier Martinez Canillas writes: > >> The commit 7311ea850079 ("mwifiex: fix AP start problem for newly added >> interface") attempted to fix an issue when a new AP interface is added. >> >> But th

[PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback

n't fail. This prevents the network device to be registered properly, so fix it. Fixes: commit 7311ea850079 ("mwifiex: fix AP start problem for newly added interface") Signed-off-by: Javier Martinez Canillas --- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 2 ++ 1 file changed,

Re: [PATCH v2 2/3] mwifiex: move .get_tx_power logic to station ioctl file

Hello Kalle, On 06/22/2016 02:17 AM, Kalle Valo wrote: > Javier Martinez Canillas writes: > >>>> Patch 3/3 applies cleanly even after dropping patch 2/3. >>>> Is that Ok for you or do you want me to re-resend a v3 >>>> with only patches 1/3 and 3/3? >

Re: [PATCH v2 2/3] mwifiex: move .get_tx_power logic to station ioctl file

Hello Kalle, On 06/10/2016 03:54 PM, Kalle Valo wrote: > Javier Martinez Canillas writes: > >>> This patch (2/3) is only for code rearrangement and adds an >>> unnecessary wrapper function. We can simply drop the patch. >> >> Agreed. >> >> K

Re: [PATCH v2 2/3] mwifiex: move .get_tx_power logic to station ioctl file

Hello Amitkumar, On 06/10/2016 12:26 PM, Amitkumar Karwar wrote: > Hi Kalle/Javier, > >> From: Javier Martinez Canillas [mailto:jav...@osg.samsung.com] >> Sent: Friday, June 10, 2016 8:07 PM >> To: Kalle Valo >> Cc: linux-ker...@vger.kernel.org; Julian Calaby; She

Re: [PATCH v2 2/3] mwifiex: move .get_tx_power logic to station ioctl file

Hello Kalle, On 06/10/2016 10:30 AM, Kalle Valo wrote: > Javier Martinez Canillas writes: > >> From: Shengzhen Li >> >> Most cfg80211 operations are just a wrappers to functions defined in the >> sta_ioctl.c file, so for consistency move the .get_tx_power lo

[PATCH v2 3/3] mwifiex: add get_antenna support for cfg80211

and: $ iw phy phy0 info | grep Antennas Available Antennas: TX 0x3 RX 0x3 Configured Antennas: TX 0x3 RX 0x3 Signed-off-by: Shengzhen Li Signed-off-by: Amitkumar Karwar [javier: expand the commit message] Signed-off-by: Javier Martinez Canillas --- drivers/net/wireless/marvel

[PATCH v2 0/3] mwifiex: add .get_tx_power and .get_antenna cfg80211 operations

logic to sta_ioctl.c file. [0]: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1160119.html Best regards, Javier Javier Martinez Canillas (1): mwifiex: add a cfg80211 .get_tx_power operation callback Shengzhen Li (2): mwifiex: move .get_tx_power logic to station ioctl file mwif

[PATCH v2 2/3] mwifiex: move .get_tx_power logic to station ioctl file

: Javier Martinez Canillas --- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 14 +++--- drivers/net/wireless/marvell/mwifiex/main.h | 2 ++ drivers/net/wireless/marvell/mwifiex/sta_ioctl.c | 18 ++ 3 files changed, 23 insertions(+), 11 deletions(-) diff --git a

[PATCH v2 1/3] mwifiex: add a cfg80211 .get_tx_power operation callback

_func+0x30/0x58) [] (request_firmware_work_func) from [] (process_one_work+0x124/0x338) [] (process_one_work) from [] (worker_thread+0x38/0x4d4) [] (worker_thread) from [] (kthread+0xdc/0xf4) [] (kthread) from [] (ret_from_fork+0x14/0x3c) Signed-off-by: Javier Martinez Canillas --- drivers/net/wireless/marvell/mwifiex/

[PATCH 1/2] mwifiex: add a cfg80211 .get_tx_power operation callback

_func+0x30/0x58) [] (request_firmware_work_func) from [] (process_one_work+0x124/0x338) [] (process_one_work) from [] (worker_thread+0x38/0x4d4) [] (worker_thread) from [] (kthread+0xdc/0xf4) [] (kthread) from [] (ret_from_fork+0x14/0x3c) Signed-off-by: Javier Martinez Canillas --- drivers/net/wireless/marvell/mwifiex/

[PATCH 0/2] mwifiex: add .get_tx_power and .get_antenna cfg80211 operations

owup by someone with access to the docs, if this is supported. Best regards, Javier Javier Martinez Canillas (2): mwifiex: add a cfg80211 .get_tx_power operation callback mwifiex: add a cfg80211 .get_antenna operation callback drivers/net/wireless/marvell/mwifiex/cfg80211.c | 50 ++

[PATCH 2/2] mwifiex: add a cfg80211 .get_antenna operation callback

igured Antennas: TX 0x1 RX 0x1 Signed-off-by: Javier Martinez Canillas --- Hello, Even though this approach prevents the warning and allows to reports the antenna values, it would be better if instead of caching the set values, these are asked to the firmware for each .get_antenna callback.

Re: [PATCH 7/8] mwifiex: don't print an error if an optional DT property is missing

Hello Julian, Thanks a lot for your feedback and reviews. On 06/01/2016 12:20 AM, Julian Calaby wrote: > Hi All, > > On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas > wrote: >> The Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt DT >> bindi

[PATCH 2/8] mwifiex: propagate sdio_enable_func() errno code in mwifiex_sdio_probe()

returned by sdio_enable_func() at fail. Signed-off-by: Javier Martinez Canillas --- drivers/net/wireless/marvell/mwifiex/sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c index

[PATCH 3/8] mwifiex: propagate mwifiex_add_card() errno code in mwifiex_sdio_probe()

Patch also removes the assignment of sdio_disable_func() returned value since it was overwritten anyways and what matters is to know the error value returned by the first function that failed. Signed-off-by: Javier Martinez Canillas --- drivers/net/wireless/marvell/mwifiex/sdio.c | 8 1

[PATCH 1/8] mwifiex: only call mwifiex_sdio_probe_of() if dev has an OF node

esn't have a node for a SDIO dev, the following misleading error message will be printed: [ 12.480042] mwifiex_sdio mmc2:0001:1: sdio platform data not available Signed-off-by: Javier Martinez Canillas --- drivers/net/wireless/marvell/mwifiex/sdio.c | 6 +++--- 1 file changed, 3 i

[PATCH 0/8] mwifiex: Fix some error handling issues in mwifiex_sdio_probe() function

en in platforms that don't have a child node defined. So this series fixes this issue and others I found in the .probe function (mostly related to error handling and the error path) while looking at it. Best regards, Javier Javier Martinez Canillas (8): mwifiex: only call mwifiex_sdio_pro

[PATCH 4/8] mwifiex: consolidate mwifiex_sdio_probe() error paths

was not the case for the mwifiex_add_card() error path. Signed-off-by: Javier Martinez Canillas --- drivers/net/wireless/marvell/mwifiex/sdio.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless

[PATCH 8/8] mwifiex: use better message and error code when OF node doesn't match

r one that makes clear what the error really is. Also, returning a -1 as errno code is not correct since that's -EPERM. A -EINVAL seems to be a more appropriate one. Signed-off-by: Javier Martinez Canillas --- drivers/net/wireless/marvell/mwifiex/sdio.c | 4 ++-- 1 file changed, 2 insert

[PATCH 5/8] mwifiex: use dev_err() instead of pr_err() in mwifiex_sdio_probe()

It's better to have the device name prefixed in the error message. Signed-off-by: Javier Martinez Canillas --- drivers/net/wireless/marvell/mwifiex/sdio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wir

[PATCH 7/8] mwifiex: don't print an error if an optional DT property is missing

The Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt DT binding document say that the "interrupts" property in the child node is optional. So the property being missed shouldn't be treated as an error. Signed-off-by: Javier Martinez Canillas --- drivers/net/w

[PATCH 6/8] mwifiex: check if mwifiex_sdio_probe_of() fails and return error

The function can fail so the returned value should be checked and the error propagated to the caller in case of a failure. Signed-off-by: Javier Martinez Canillas --- drivers/net/wireless/marvell/mwifiex/sdio.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a

Re: [RFC] Reset pins of phys and their representation in a device tree

Hello ChenYu On Thu, May 12, 2016 at 9:49 AM, Chen-Yu Tsai wrote: > Hi, > > On Thu, May 12, 2016 at 9:40 PM, Javier Martinez Canillas > wrote: >> [adding Krzysztof as cc] >> >> On Thu, May 12, 2016 at 8:25 AM, Sergei Shtylyov >> wrote: >>> Hello.

Re: [RFC] Reset pins of phys and their representation in a device tree

[adding Krzysztof as cc] On Thu, May 12, 2016 at 8:25 AM, Sergei Shtylyov wrote: > Hello. > > > On 5/12/2016 10:15 AM, Uwe Kleine-König wrote: > >> I have a machine here where the reset pin of the phy is connected to a >> GPIO. >> >> There are different possibilities available today to handle thi

[PATCH 0/2] net: encx24j600: Fix SPI driver module autoload

n be built as a module. But also the SPI id table is not correctly defined so this series fixes both issues. The patches have been applied on top of the next-next tree master branch: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master Best regards, Javier Javier Martinez C

[PATCH 1/2] net: encx24j600: Fix SPI id table definition

e the struct spi_device_id .name[0] is not NULL, so not having a sentinel can cause a NULL pointer deference error. This patch defines the SPI id table correctly as all other SPI drivers do. Signed-off-by: Javier Martinez Canillas --- drivers/net/ethernet/microchip/encx24j600.c | 7 --- 1

[PATCH 2/2] net: encx24j600: Export missing SPI module alias information

The driver Kconfig symbol is tristate which means that it can be built as a module but the module alias information is not added to the module info so module autoload won't work since user-space won't have the information. Signed-off-by: Javier Martinez Canillas --- drivers/ne

[RESEND PATCH] net: ks8851: Export OF module alias information

Drivers needs to export the OF id table and this be built into the module or udev won't have the necessary information to autoload the driver module when the device is registered via OF. Signed-off-by: Javier Martinez Canillas --- drivers/net/ethernet/micrel/ks8851.c | 1 + 1 file chang

Re: [PATCH 00/18] Export SPI and OF module aliases in missing drivers

Hello Brian, On 08/20/2015 11:11 PM, Brian Norris wrote: > On Thu, Aug 20, 2015 at 09:07:13AM +0200, Javier Martinez Canillas wrote: >> Patches #1 and #2 solves a), patches #3 to #8 solves b) and patches > > ^^^ I'm dying to know how this sentence ends :) > Sigh,

[PATCH 00/18] Export SPI and OF module aliases in missing drivers

first applying all the other patches in this series, will break module autoloading for the drivers of devices registered using OF but that lacks an of_match_table. I'll repost patch #18 once all the patches in this series have landed. [0]: https://lkml.org/lkml/2015/7/30/519 Best regards, Jav

[PATCH 07/18] net: ks8851: Export OF module alias information

So, it's better to also export the OF table even when is unused now to prevent breaking module loading when the core changes. Signed-off-by: Javier Martinez Canillas --- drivers/net/ethernet/micrel/ks8851.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/micrel/ks8