Re: [PATCH] MAINTAINERS: update netsec driver

2019-07-18 Thread Jassi Brar
On Thu, 18 Jul 2019 at 09:38, Ilias Apalodimas wrote: > > Add myself to maintainers since i provided the XDP and page_pool > implementation > Yes, please. Acked-by: Jassi Brar > Signed-off-by: Ilias Apalodimas

Re: [PATCH] net: socionext: replace napi_alloc_frag with the netdev variant on init

2019-04-19 Thread Jassi Brar
ng, since *what* you do is usually obvious from the patch > itself, but why you do it isn't. > > With the above clarification added: > > Acked-by: Ard Biesheuvel > Fine by me too. Acked-by: Jassi Brar Thanks.

Re: [net-next, PATCH 2/2] net: socionext: remove mmio reads on Tx

2018-12-14 Thread Jassi Brar
On Fri, 14 Dec 2018 at 08:33, Ilias Apalodimas wrote: > > Hi Ard, > > > > > > > > So shouldn't we do this *after* processing Rx, and only if there is > > > > budget left? > > > > > > I am not really sure, this would drown Tx processing if you had a bunch of > > > received packets that exhausted t

Re: [PATCH 1/2] net: netsec: enable tx-irq during open callback

2018-08-22 Thread Jassi Brar
Hi Dave, This patch (1/2) seems to have fallen through the cracks. The other one (2/2), you already picked. Thanks On Mon, Apr 16, 2018 at 1:08 PM wrote: > > From: Jassi Brar > > Enable TX-irq as well during ndo_open() as we can not count upon > RX to arrive early enough to t

Re: [PATCH 1/2] net: netsec: enable tx-irq during open callback

2018-07-18 Thread Jassi Brar
Hi David, On Wed, Apr 18, 2018 at 11:00 PM, David Miller wrote: > From: Jassi Brar > Date: Wed, 18 Apr 2018 18:27:59 +0530 > >> Just to make sure, let me please mention that c009f413b79de52 and >> 9a00b697ce31e are very much needed in stable kernel. Without these we >&

Re: [PATCH] net: netsec: reduce DMA mask to 40 bits

2018-05-26 Thread Jassi Brar
On 26 May 2018 at 11:46, Ard Biesheuvel wrote: > On 26 May 2018 at 05:44, Jassi Brar wrote: >> On 26 May 2018 at 08:56, Jassi Brar wrote: >>> On 26 May 2018 at 01:07, Robin Murphy wrote: >>>> On Sat, 26 May 2018 00:33:05 +0530 >>>> Jassi Brar wrot

Re: [PATCH] net: netsec: reduce DMA mask to 40 bits

2018-05-25 Thread Jassi Brar
On 26 May 2018 at 08:56, Jassi Brar wrote: > On 26 May 2018 at 01:07, Robin Murphy wrote: >> On Sat, 26 May 2018 00:33:05 +0530 >> Jassi Brar wrote: >> >>> On 25 May 2018 at 18:20, Ard Biesheuvel >>> wrote: >>> > The netsec network controller

Re: [PATCH] net: netsec: reduce DMA mask to 40 bits

2018-05-25 Thread Jassi Brar
On 26 May 2018 at 01:07, Robin Murphy wrote: > On Sat, 26 May 2018 00:33:05 +0530 > Jassi Brar wrote: > >> On 25 May 2018 at 18:20, Ard Biesheuvel >> wrote: >> > The netsec network controller IP can drive 64 address bits for DMA, >> > and the DMA mask is

Re: [PATCH] net: netsec: reduce DMA mask to 40 bits

2018-05-25 Thread Jassi Brar
On 25 May 2018 at 18:20, Ard Biesheuvel wrote: > The netsec network controller IP can drive 64 address bits for DMA, and > the DMA mask is set accordingly in the driver. However, the SynQuacer > SoC, which is the only silicon incorporating this IP at the moment, > integrates this IP in a manner th

Re: [PATCH 1/2] net: netsec: enable tx-irq during open callback

2018-04-18 Thread Jassi Brar
Hi Dave, On Mon, Apr 16, 2018 at 11:16 PM, David Miller wrote: > From: jassisinghb...@gmail.com > Date: Mon, 16 Apr 2018 12:52:16 +0530 > >> From: Jassi Brar >> >> Enable TX-irq as well during ndo_open() as we can not count upon >> RX to arrive early enough t

Re: [PATCHv5 2/3] net: socionext: Add Synquacer NetSec driver

2018-01-05 Thread Jassi Brar
On 3 January 2018 at 21:05, David Miller wrote: > From: jassisinghb...@gmail.com > Date: Mon, 1 Jan 2018 10:44:49 +0530 > >> +#define DRING_TAIL(r)((r)->tail) >> + >> +#define DRING_HEAD(r)((r)->head) > > These macros do not help readability at all. > >> +#define M

Re: [PATCHv5 1/3] dt-bindings: net: Add DT bindings for Socionext Netsec

2018-01-05 Thread Jassi Brar
Hi Ard, On Thu, Jan 4, 2018 at 3:07 AM, Ard Biesheuvel wrote: > Hi Jassi, > > On 1 January 2018 at 05:14, wrote: >> From: Jassi Brar >> >> This patch adds documentation for Device-Tree bindings for the >> Socionext NetSec Controller driver. >> >>

Re: [PATCHv4 2/3] net: socionext: Add Synquacer NetSec driver

2017-12-23 Thread Jassi Brar
On Sat, Dec 23, 2017 at 4:09 PM, Ard Biesheuvel wrote: > On 23 December 2017 at 05:45, wrote: >> From: Jassi Brar >> >> This driver adds support for Socionext "netsec" IP Gigabit >> Ethernet + PHY IP used in the Synquacer SC2A11 SoC. >> >> Signe

Re: [PATCHv2 1/3] dt-bindings: net: Add DT bindings for Socionext Netsec

2017-12-20 Thread Jassi Brar
On 13 December 2017 at 02:07, Andrew Lunn wrote: > On Tue, Dec 12, 2017 at 10:45:21PM +0530, jassisinghb...@gmail.com wrote: >> From: Jassi Brar >> >> This patch adds documentation for Device-Tree bindings for the >> Socionext NetSec Controller driver. >>

Re: [PATCHv2 1/3] dt-bindings: net: Add DT bindings for Socionext Netsec

2017-12-20 Thread Jassi Brar
Hi Mark, On Tue, Dec 12, 2017 at 10:59 PM, Mark Rutland wrote: > Hi, > > On Tue, Dec 12, 2017 at 10:45:21PM +0530, jassisinghb...@gmail.com wrote: >> From: Jassi Brar >> >> This patch adds documentation for Device-Tree bindings for the >> Socionext NetSec Contr

Re: [PATCHv2 2/3] net: socionext: Add Synquacer NetSec driver

2017-12-13 Thread Jassi Brar
On Wed, Dec 13, 2017 at 2:18 AM, Andrew Lunn wrote: >> > +static int netsec_mac_update_to_phy_state(struct netsec_priv *priv) >> > +{ >> > + struct phy_device *phydev = priv->ndev->phydev; >> > + u32 value = 0; >> > + >> > + value = phydev->duplex ? NETSEC_GMAC_MCR_REG_FULL_DUPLE

Re: [PATCHv2 2/3] net: socionext: Add Synquacer NetSec driver

2017-12-13 Thread Jassi Brar
On Tue, Dec 12, 2017 at 10:54 PM, Ard Biesheuvel wrote: > On 12 December 2017 at 17:15, wrote: >> + >> +static int netsec_netdev_load_microcode(struct netsec_priv *priv) >> +{ >> + int err; >> + >> + err = netsec_netdev_load_ucode_region( >> + priv, NETSEC_REG_DMAC

Re: [PATCH 1/3] dt-bindings: net: Add DT bindings for Socionext Netsec

2017-12-03 Thread Jassi Brar
On Fri, Dec 1, 2017 at 2:42 PM, Ard Biesheuvel wrote: > Hi Jassi, > > On 30 November 2017 at 16:12, wrote: >> From: Jassi Brar >> >> This patch adds documentation for Device-Tree bindings for the >> Socionext NetSec Controller driver. >> >> Sig

Re: [PATCH net-next 3/3] net: phy: realtek: add RTL8201F phy-id and functions

2017-09-08 Thread Jassi Brar
On 9 September 2017 at 00:21, Florian Fainelli wrote: > On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote: >> From: Jassi Brar >> >> Add RTL8201F phy-id and the related functions to the driver. >> >> The original patch is as follows: >> https://patchwork.ker

Re: [net-next PATCHv6 2/2] net: socionext: Add NetSec driver

2017-08-30 Thread Jassi Brar
On Wed, Aug 30, 2017 at 10:47 PM, Andrew Lunn wrote: >> +static int netsec_mac_update_to_phy_state(struct netsec_priv *priv) >> +{ >> + struct phy_device *phydev = priv->ndev->phydev; >> + u32 value = 0; >> + >> + value = phydev->duplex ? NETSEC_GMAC_MCR_REG_FULL_DUPLEX_COMMON : >> +

Re: [net-next PATCHv6 0/2] net: ethernet: Socionext Netsec

2017-08-30 Thread Jassi Brar
On Thu, Aug 31, 2017 at 9:36 AM, Florian Fainelli wrote: > On August 30, 2017 3:24:17 AM PDT, Jassi Brar > wrote: >>Hello, >> >>The OGMA/Netsec controller is used in latest SoC from >>Socionext/Fujitsu. >> >>I am refreshing the patchset by basically

Re: [net-next PATCHv6 1/2] dt-bindings: net: Add DT bindings for Socionext Netsec

2017-08-30 Thread Jassi Brar
On Wed, Aug 30, 2017 at 8:49 PM, Andrew Lunn wrote: > On Wed, Aug 30, 2017 at 03:55:52PM +0530, Jassi Brar wrote: >> This patch adds documentation for Device-Tree bindings for the >> Socionext NetSec Controller driver. >> >> Signed-off-by: Jassi Brar >> --

[net-next PATCHv6 2/2] net: socionext: Add NetSec driver

2017-08-30 Thread Jassi Brar
This driver adds support for Socionext "netsec" IP Gigabit Ethernet + PHY IP used in a variety of their ARM-based ASICs. Signed-off-by: Jassi Brar --- drivers/net/ethernet/Kconfig | 1 + drivers/net/ethernet/Makefile | 1 + drivers/ne

[net-next PATCHv6 1/2] dt-bindings: net: Add DT bindings for Socionext Netsec

2017-08-30 Thread Jassi Brar
This patch adds documentation for Device-Tree bindings for the Socionext NetSec Controller driver. Signed-off-by: Jassi Brar --- .../devicetree/bindings/net/socionext-netsec.txt | 46 ++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings

[net-next PATCHv6 0/2] net: ethernet: Socionext Netsec

2017-08-30 Thread Jassi Brar
e addressed comments (that could be) on the last revision --> https://patchwork.kernel.org/patch/4540651/ Of course, I have scanned changes to the drivers/net/ethernet since last submission and integrated whichever applicable and rebased the driver on top of last rc. Thanks. Jassi Brar (2):