[PATCH net-next] net: ethernet: ti: cpsw: use true,false for bool variables

2020-09-19 Thread Jason Yan
This addresses the following coccinelle warning: drivers/net/ethernet/ti/cpsw.c:1599:2-17: WARNING: Assignment of 0/1 to bool variable drivers/net/ethernet/ti/cpsw.c:1300:2-17: WARNING: Assignment of 0/1 to bool variable Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/net

[PATCH net-next] 8139too: use true,false for bool variables

2020-09-19 Thread Jason Yan
This addresses the following coccinelle warning: drivers/net/ethernet/realtek/8139too.c:981:2-8: WARNING: Assignment of 0/1 to bool variable Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/net/ethernet/realtek/8139too.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH net-next] net: b44: use true,false for bool variables

2020-09-19 Thread Jason Yan
of 0/1 to bool variable drivers/net/ethernet/broadcom/b44.c:2230:3-17: WARNING: Assignment of 0/1 to bool variable Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/net/ethernet/broadcom/b44.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net

[PATCH net-next] bnx2x: use true,false for bool variables

2020-09-19 Thread Jason Yan
/bnx2x_main.c:15497:2-27: WARNING: Assignment of 0/1 to bool variable Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b

[PATCH net-next] net: qed: use true,false for bool variables

2020-09-19 Thread Jason Yan
: WARNING: Assignment of 0/1 to bool variable drivers/net/ethernet/qlogic/qed/qed_rdma.c:1472:2-14: WARNING: Assignment of 0/1 to bool variable Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/net/ethernet/qlogic/qed/qed_rdma.c | 8 1 file changed, 4 insertions(+), 4

[PATCH] rtlwifi: rtl8192ee: use true,false for bool variable large_cfo_hit

2020-09-19 Thread Jason Yan
/rtlwifi/rtl8192ee/dm.c:725:2-22: WARNING: Assignment of 0/1 to bool variable Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/net/wireless/realtek/rtlwifi/rtl8192ee/dm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee

[PATCH] rtlwifi: rtl8821ae: use true,false for bool variable large_cfo_hit

2020-09-19 Thread Jason Yan
/rtlwifi/rtl8821ae/dm.c:2686:3-23: WARNING: Assignment of 0/1 to bool variable Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi

[PATCH] rtlwifi: rtl8723be: use true,false for bool variable large_cfo_hit

2020-09-19 Thread Jason Yan
/rtlwifi/rtl8723be/dm.c:1159:3-23: WARNING: Assignment of 0/1 to bool variable Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi

[PATCH] brcmsmac: phytbl_lcn: Eliminate defined but not used 'dot11lcn_gain_tbl_rev1'

2020-09-10 Thread Jason Yan
n_tbl_rev1[] = { | ^~ Reported-by: Hulk Robot Signed-off-by: Jason Yan --- .../brcm80211/brcmsmac/phy/phytbl_lcn.c | 99 --- 1 file changed, 99 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_lcn.c b/drivers/net/wireles

[PATCH] brcmsmac: phy_lcn: Eliminate defined but not used 'lcnphy_rx_iqcomp_table_rev0'

2020-09-10 Thread Jason Yan
table_rev0[] = { | ^~~ Reported-by: Hulk Robot Signed-off-by: Jason Yan --- .../broadcom/brcm80211/brcmsmac/phy/phy_lcn.c | 55 --- 1 file changed, 55 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c b/d

[PATCH] brcmsmac: main: Eliminate empty brcms_c_down_del_timer()

2020-09-10 Thread Jason Yan
This function does nothing so remove it. This addresses the following coccicheck warning: drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c:5103:6-15: Unneeded variable: "callbacks". Return "0" on line 5105 Reported-by: Hulk Robot Signed-off-by: Jason Yan ---

[PATCH] ath6kl: wmi: remove set but not used 'rate'

2020-08-31 Thread Jason Yan
^~~~ The variable 'sgi' is alse removed because after 'rate' is removed, it is not used too. Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/net/wireless/ath/ath6kl/wmi.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/ne

[PATCH v2] brcmfmac: remove Comparison to bool in brcmf_p2p_send_action_frame()

2020-05-08 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1785:5-8: WARNING: Comparison to bool Signed-off-by: Jason Yan Reviewed-by: Chi-hsien Lin --- v2: Rebased on top of wireless-drivers-next and drop one already fixed line. drivers/net/wireless

[PATCH net-next] igb: make igb_set_fc_watermarks() return void

2020-05-07 Thread Jason Yan
This function always return 0 now, we can make it return void to simplify the code. This fixes the following coccicheck warning: drivers/net/ethernet/intel/igb/e1000_mac.c:728:5-12: Unneeded variable: "ret_val". Return "0" on line 751 Signed-off-by: Jason Yan --- drivers/ne

[PATCH net-next] net: encx24j600: make encx24j600_hw_init() return void

2020-05-07 Thread Jason Yan
This function always return 0 now, we can make it return void to simplify the code. This fixes the following coccicheck warning: drivers/net/ethernet/microchip/encx24j600.c:609:5-8: Unneeded variable: "ret". Return "0" on line 653 Signed-off-by: Jason Yan --- drivers/ne

[PATCH net-next] net: tulip: de4x5: make PCI_signature() return void

2020-05-07 Thread Jason Yan
This function always return 0 now, we can make it return void to simplify the code. This fixes the following coccicheck warning: drivers/net/ethernet/dec/tulip/de4x5.c:3908:11-17: Unneeded variable: "status". Return "0" on line 3912 Signed-off-by: Jason Yan --- drivers/ne

[PATCH net-next] net: atheros: remove dead code in atl1c_resume()

2020-05-07 Thread Jason Yan
This code has been marked dead for nearly 10 years. Remove it. Signed-off-by: Jason Yan --- drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c

[PATCH net-next] net: mlx4: remove unneeded variable "err" in mlx4_en_ethtool_add_mac_rule()

2020-05-07 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/ethernet/mellanox/mlx4/en_ethtool.c:1396:5-8: Unneeded variable: "err". Return "0" on line 1411 Signed-off-by: Jason Yan --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 3 +-- 1 file changed, 1 insertion(+), 2 deleti

[PATCH] b43: remove dead function b43_rssinoise_postprocess()

2020-05-07 Thread Jason Yan
This function is dead for more than 10 years. Remove it. Signed-off-by: Jason Yan --- drivers/net/wireless/broadcom/b43/xmit.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/net/wireless/broadcom/b43/xmit.c b/drivers/net/wireless/broadcom/b43/xmit.c index

[PATCH v2] bpf, i386: remove unneeded conversion to bool

2020-05-06 Thread Jason Yan
re Signed-off-by: Jason Yan --- v2: change the name 'x32' to 'i386'. arch/x86/net/bpf_jit_comp32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/net/bpf_jit_comp32.c b/arch/x86/net/bpf_jit_comp32.c index 66cd150b7e54..96fde03a

[PATCH net-next] i40e: Make i40e_shutdown_adminq() return void

2020-05-05 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/ethernet/intel/i40e/i40e_adminq.c:699:13-21: Unneeded variable: "ret_code". Return "0" on line 710 Signed-off-by: Jason Yan --- drivers/net/ethernet/intel/i40e/i40e_adminq.c| 6 +- drivers/net/ethernet/intel/i40e/

[PATCH net-next] net: mlx4: remove unneeded variable "err" in mlx4_en_get_rxfh()

2020-05-05 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/ethernet/mellanox/mlx4/en_ethtool.c:1238:5-8: Unneeded variable: "err". Return "0" on line 1252 Signed-off-by: Jason Yan --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 3 +-- 1 file changed, 1 insertion(+), 2 deleti

[PATCH net-next] net: bridge: return false in br_mrp_enabled()

2020-05-05 Thread Jason Yan
Fix the following coccicheck warning: net/bridge/br_private.h:1334:8-9: WARNING: return of 0/1 in function 'br_mrp_enabled' with return type bool Signed-off-by: Jason Yan --- net/bridge/br_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/br_p

[PATCH net-next] net: ethernet: ti: use true,false for bool variables in cpsw_new.c

2020-05-05 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/ethernet/ti/cpsw_new.c:1924:2-17: WARNING: Assignment of 0/1 to bool variable drivers/net/ethernet/ti/cpsw_new.c:1231:1-16: WARNING: Assignment of 0/1 to bool variable Signed-off-by: Jason Yan --- drivers/net/ethernet/ti/cpsw_new.c | 4 ++-- 1

[PATCH net-next] net: atheros: remove conversion to bool in atl1c_start_mac()

2020-05-05 Thread Jason Yan
No need to convert '==' expression to bool. This fixes the following coccicheck warning: drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1189:63-68: WARNING: conversion to bool not needed here Signed-off-by: Jason Yan --- drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 2 +- 1 fi

[PATCH net-next] net: bnxt: Remove Comparison to bool in bnxt_ethtool.c

2020-05-05 Thread Jason Yan
to bool Signed-off-by: Jason Yan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c index 34046a6286e8..75f60aea8dec

[PATCH net-next] net: agere: use true,false for bool variable

2020-05-05 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/ethernet/agere/et131x.c:717:3-22: WARNING: Assignment of 0/1 to bool variable drivers/net/ethernet/agere/et131x.c:721:1-20: WARNING: Assignment of 0/1 to bool variable Signed-off-by: Jason Yan --- drivers/net/ethernet/agere/et131x.c | 4 ++-- 1

[PATCH net-next] net: qede: Use true for bool variable in qede_init_fp()

2020-05-05 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/ethernet/qlogic/qede/qede_main.c:1717:5-19: WARNING: Assignment of 0/1 to bool variable Signed-off-by: Jason Yan --- drivers/net/ethernet/qlogic/qede/qede_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net

[PATCH net-next] bnx2x: Remove Comparison to bool in bnx2x_dcb.c

2020-05-05 Thread Jason Yan
bool Signed-off-by: Jason Yan --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c index 2c6ba046d2a8..17ae6df90723 100644

[PATCH net-next] qlcnic: use true,false for bool variable in qlcnic_sriov_common.c

2020-05-05 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c:1585:3-25: WARNING: Assignment of 0/1 to bool variable drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c:1588:3-25: WARNING: Assignment of 0/1 to bool variable Signed-off-by: Jason Yan

[PATCH net-next] ixgbe: Use true,false for bool variable in __ixgbe_enable_sriov()

2020-05-05 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c:105:2-38: WARNING: Assignment of 0/1 to bool variable Signed-off-by: Jason Yan --- drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net

[PATCH net-next] ixgbe: Remove conversion to bool in ixgbe_device_supports_autoneg_fc()

2020-05-05 Thread Jason Yan
No need to convert '==' expression to bool. This fixes the following coccicheck warning: drivers/net/ethernet/intel/ixgbe/ixgbe_common.c:68:11-16: WARNING: conversion to bool not needed here Signed-off-by: Jason Yan --- drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 3 +-- 1 file

[PATCH] ath11k: use true,false for bool variables

2020-05-04 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/wireless/ath/ath11k/dp_rx.c:2964:1-39: WARNING: Assignment of 0/1 to bool variable drivers/net/wireless/ath/ath11k/dp_rx.c:2965:1-38: WARNING: Assignment of 0/1 to bool variable Signed-off-by: Jason Yan --- drivers/net/wireless/ath/ath11k

[PATCH] brcmsmac: remove Comparison to bool in brcms_b_txstatus()

2020-05-04 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c:1060:6-12: WARNING: Comparison to bool Signed-off-by: Jason Yan --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] brcmfmac: remove Comparison to bool in brcmf_p2p_send_action_frame()

2020-05-04 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1781:9-12: WARNING: Comparison to bool drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1785:5-8: WARNING: Comparison to bool Signed-off-by: Jason Yan --- drivers/net/wireless/broadcom/brcm80211

[PATCH] rtlwifi: rtl8188ee: remove Comparison to bool in rf.c

2020-05-04 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/wireless/realtek/rtlwifi/rtl8188ee/rf.c:476:6-14: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8188ee/rf.c:54:5-22: WARNING: Comparison to bool Signed-off-by: Jason Yan --- drivers/net/wireless/realtek/rtlwifi/rtl8188ee

[PATCH] b43: remove Comparison of 0/1 to bool variable in phy_n.c

2020-05-04 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/wireless/broadcom/b43/phy_n.c:5510:19-32: WARNING: Comparison of 0/1 to bool variable Signed-off-by: Jason Yan --- drivers/net/wireless/broadcom/b43/phy_n.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net

[PATCH] b43: remove Comparison of 0/1 to bool variable in pio.c

2020-05-04 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/wireless/broadcom/b43/pio.c:768:10-25: WARNING: Comparison of 0/1 to bool variable Signed-off-by: Jason Yan --- drivers/net/wireless/broadcom/b43/pio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless

[PATCH] net: dsa: mv88e6xxx: remove duplicate assignment of struct members

2020-04-29 Thread Jason Yan
xx/chip.c:4184:48-49: phylink_validate: first occurrence line 4238, second occurrence line 4242 Signed-off-by: Jason Yan --- drivers/net/dsa/mv88e6xxx/chip.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index dd8a5666a584.

[PATCH] rtlwifi: remove comparison of 0/1 to bool variable

2020-04-29 Thread Jason Yan
The variable 'rtlpriv->rfkill.rfkill_state' is bool and can directly assigned to bool values. Fix the following coccicheck warning: drivers/net/wireless/realtek/rtlwifi/core.c:1725:14-42: WARNING: Comparison of 0/1 to bool variable Signed-off-by: Jason Yan --- drivers/net/wir

Re: 979d63d50c0c0f7bc537bf821e056cc9fe5abd38 bpf: prevent out of bounds speculation on pointer arithmetic

2019-03-14 Thread Jason Yan
On 2019/3/14 22:57, Greg KH wrote: On Thu, Mar 14, 2019 at 10:41:57PM +0800, Jason Yan wrote: On 2019/3/13 0:22, Greg KH wrote: On Tue, Mar 12, 2019 at 10:58:39PM +0800, Jason Yan wrote: On 2019/3/12 19:52, Greg KH wrote: On Mon, Mar 11, 2019 at 05:18:33PM +0800, Jason Yan wrote: Hi

Re: 979d63d50c0c0f7bc537bf821e056cc9fe5abd38 bpf: prevent out of bounds speculation on pointer arithmetic

2019-03-14 Thread Jason Yan
On 2019/3/13 0:22, Greg KH wrote: On Tue, Mar 12, 2019 at 10:58:39PM +0800, Jason Yan wrote: On 2019/3/12 19:52, Greg KH wrote: On Mon, Mar 11, 2019 at 05:18:33PM +0800, Jason Yan wrote: Hi, Daniel & Greg This patch (979d63d50c0c bpf: prevent out of bounds speculation on poi

Re: 979d63d50c0c0f7bc537bf821e056cc9fe5abd38 bpf: prevent out of bounds speculation on pointer arithmetic

2019-03-12 Thread Jason Yan
On 2019/3/12 19:52, Greg KH wrote: On Mon, Mar 11, 2019 at 05:18:33PM +0800, Jason Yan wrote: Hi, Daniel & Greg This patch (979d63d50c0c bpf: prevent out of bounds speculation on pointer arithmetic) was assigned a CVE (CVE-2019-7308) with a high score: CVSS v3.0 Severity and Metrics:

Re: 979d63d50c0c0f7bc537bf821e056cc9fe5abd38 bpf: prevent out of bounds speculation on pointer arithmetic

2019-03-11 Thread Jason Yan
On 2019/3/12 2:54, Greg KH wrote: On Mon, Mar 11, 2019 at 07:13:14PM +0800, Jason Yan wrote: On 2019/3/11 17:41, Daniel Borkmann wrote: Hi Jason, On 03/11/2019 10:18 AM, Jason Yan wrote: Hi, Daniel & Greg This patch (979d63d50c0c bpf: prevent out of bounds speculation on poi

Re: 979d63d50c0c0f7bc537bf821e056cc9fe5abd38 bpf: prevent out of bounds speculation on pointer arithmetic

2019-03-11 Thread Jason Yan
On 2019/3/11 17:41, Daniel Borkmann wrote: Hi Jason, On 03/11/2019 10:18 AM, Jason Yan wrote: Hi, Daniel & Greg This patch (979d63d50c0c bpf: prevent out of bounds speculation on pointer arithmetic) was assigned a CVE (CVE-2019-7308) with a high score: CVSS v3.0 Severity and Met

979d63d50c0c0f7bc537bf821e056cc9fe5abd38 bpf: prevent out of bounds speculation on pointer arithmetic

2019-03-11 Thread Jason Yan
Hi, Daniel & Greg This patch (979d63d50c0c bpf: prevent out of bounds speculation on pointer arithmetic) was assigned a CVE (CVE-2019-7308) with a high score: CVSS v3.0 Severity and Metrics: Base Score: 9.8 CRITICAL And this patch is not in stable-4.4, would you please backport this patch to