Re: [PATCH net-next v2] virtio_net: add support for Byte Queue Limits

2024-06-17 Thread Jason Xing
-p $i -H [ip addr] -l 60 -t TCP_RR -- -r 64,64 > /dev/null 2>&1 & > >done > > > >The results are around 30423.62 txkB/s. If I remove '-r 64 64', they > >are still the same/similar. > > You have to stress the line by parallel TCP_STREAM instances (50 in my > case). For consistent results, use -p portnum,locport to specify the > local port. Thanks. Even though the results of TCP_RR mode vary sometimes, I can see a big improvement in the total value of those results under such circumstances. With BQL, the throughput is 2159.17 Without BQL, it's 1099.33 Please feel free to add the tag: Tested-by: Jason Xing Thanks, Jason

Re: [PATCH net-next v2] virtio_net: add support for Byte Queue Limits

2024-06-14 Thread Jason Xing
Hello Jiri, On Thu, Jun 13, 2024 at 1:08 AM Jiri Pirko wrote: > > From: Jiri Pirko > > Add support for Byte Queue Limits (BQL). > > Tested on qemu emulated virtio_net device with 1, 2 and 4 queues. > Tested with fq_codel and pfifo_fast. Super netperf with 50 threads is > running in background. N

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-06-10 Thread Jason Xing
On Tue, Jun 11, 2024 at 1:57 AM Jakub Kicinski wrote: > > On Sat, 8 Jun 2024 08:41:44 +0800 Jason Xing wrote: > > > > Sorry to revive this thread. I wonder why not use this patch like mlnx > > > > driver > > > > does instead of adding stati

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-06-07 Thread Jason Xing
On Fri, Jun 7, 2024 at 8:37 PM Dan Jurgens wrote: > > > From: Jason Xing > > Sent: Friday, June 7, 2024 4:16 AM > > To: Dan Jurgens > > Cc: Jakub Kicinski ; Michael S. Tsirkin ; > > netdev@vger.kernel.org; jasow...@redhat.com; > > xuanz...@linux.alib

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-06-07 Thread Jason Xing
On Fri, Jun 7, 2024 at 5:57 PM Jiri Pirko wrote: > > Fri, Jun 07, 2024 at 08:47:43AM CEST, jasow...@redhat.com wrote: > >On Fri, Jun 7, 2024 at 2:39 PM Jiri Pirko wrote: > >> > >> Fri, Jun 07, 2024 at 08:25:19AM CEST, jasow...@redhat.com wrote: > >> >On Thu, Jun 6, 2024 at 9:45 PM Jiri Pirko wro

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-06-07 Thread Jason Xing
On Sat, Feb 3, 2024 at 12:46 AM Daniel Jurgens wrote: > > > From: Jakub Kicinski > > Sent: Friday, February 2, 2024 10:01 AM > > Subject: Re: [PATCH net-next] virtio_net: Add TX stop and wake counters > > > > On Fri, 2 Feb 2024 14:52:59 +0800 Jason Xing wro

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-06-06 Thread Jason Xing
On Thu, Jun 6, 2024 at 12:25 PM Jason Wang wrote: > > On Thu, Jun 6, 2024 at 10:59 AM Jason Xing wrote: > > > > Hello Jason, > > > > On Thu, Jun 6, 2024 at 8:21 AM Jason Wang wrote: > > > > > > On Wed, Jun 5, 2024 at 7:51 PM Heng Qi wrote: &

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-06-05 Thread Jason Xing
Hello Jason, On Thu, Jun 6, 2024 at 8:21 AM Jason Wang wrote: > > On Wed, Jun 5, 2024 at 7:51 PM Heng Qi wrote: > > > > On Wed, 5 Jun 2024 13:30:51 +0200, Jiri Pirko wrote: > > > Mon, May 20, 2024 at 02:48:15PM CEST, j...@resnulli.us wrote: > > > >Fri, May 10, 2024 at 09:11:16AM CEST, hen...@li

Re: [PATCH net-next v2 2/2] virtio_net: Add TX stopped and wake counters

2024-05-10 Thread Jason Xing
'queue-id': 1, > 'queue-type': 'tx', > 'tx-bytes': 18167675008, > 'tx-packets': 278660, > 'tx-stop': 8632, > 'tx-wake': 8632}] > > Signed-off-by: Daniel Jurgens > Reviewed-by: Jiri Pirko

Re: [PATCH net-next v2 1/2] netdev: Add queue stats for TX stop and wake

2024-05-10 Thread Jason Xing
On Sat, May 11, 2024 at 4:20 AM Daniel Jurgens wrote: > > TX queue stop and wake are counted by some drivers. > Support reporting these via netdev-genl queue stats. > > Signed-off-by: Daniel Jurgens > Reviewed-by: Jiri Pirko Good to see this finally :) Revie

Re: [PATCH net-next v8 0/4] ethtool: provide the dim profile fine-tuning channel

2024-04-16 Thread Jason Xing
On Wed, Apr 17, 2024 at 2:35 PM Heng Qi wrote: > > > > 在 2024/4/17 上午10:53, Jason Xing 写道: > > Hello Jakub, > > > > On Wed, Apr 17, 2024 at 10:30 AM Jakub Kicinski wrote: > >> On Wed, 17 Apr 2024 10:22:52 +0800 Heng Qi wrote: > >>> Have y

Re: [PATCH net-next v8 0/4] ethtool: provide the dim profile fine-tuning channel

2024-04-16 Thread Jason Xing
Hello Jakub, On Wed, Apr 17, 2024 at 10:30 AM Jakub Kicinski wrote: > > On Wed, 17 Apr 2024 10:22:52 +0800 Heng Qi wrote: > > Have you encountered compilation problems in v8? > > Yes, please try building allmodconfig: > > make allmodconfig > make .. > > there's many drivers using this API, you go

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-02-01 Thread Jason Xing
On Fri, Feb 2, 2024 at 12:21 PM Jakub Kicinski wrote: > > On Wed, 31 Jan 2024 10:54:33 +0800 Jason Xing wrote: > > > [danielj@sw-mtx-051 upstream]$ ethtool -S ens2f1np1 | grep 'stop\|wake' > > > tx_queue_stopped: 0 > > > tx_queue_wake: 0 >

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-01-30 Thread Jason Xing
On Wed, Jan 31, 2024 at 1:53 AM Daniel Jurgens wrote: > > > From: Michael S. Tsirkin > > Sent: Tuesday, January 30, 2024 9:53 AM > > On Tue, Jan 30, 2024 at 03:50:29PM +, Daniel Jurgens wrote: > > > > From: Michael S. Tsirkin > > > > Sent: Tuesday, January 30, 2024 9:42 AM On Tue, Jan 30, 20

Re: [PATCH net-next] virtio-net: switch napi_tx without downing nic

2023-12-24 Thread Jason Xing
On Mon, Dec 25, 2023 at 2:45 PM Jason Wang wrote: > > On Mon, Dec 25, 2023 at 2:34 PM Jason Xing wrote: > > > > On Mon, Dec 25, 2023 at 12:14 PM Jason Wang wrote: > > > > > > On Mon, Dec 25, 2023 at 10:25 AM Jason Xing > > > wrote: > > >

Re: [PATCH net-next] virtio-net: switch napi_tx without downing nic

2023-12-24 Thread Jason Xing
On Mon, Dec 25, 2023 at 12:14 PM Jason Wang wrote: > > On Mon, Dec 25, 2023 at 10:25 AM Jason Xing wrote: > > > > Hello Jason, > > On Fri, Dec 22, 2023 at 10:36 AM Jason Wang wrote: > > > > > > On Thu, Dec 21, 2023 at 11:06 PM Willem de Bruijn &

Re: [PATCH net-next] virtio-net: switch napi_tx without downing nic

2023-12-24 Thread Jason Xing
Hello Jason, On Fri, Dec 22, 2023 at 10:36 AM Jason Wang wrote: > > On Thu, Dec 21, 2023 at 11:06 PM Willem de Bruijn > wrote: > > > > Heng Qi wrote: > > > > > > > > > 在 2023/12/20 下午10:45, Willem de Bruijn 写道: > > > > Heng Qi wrote: > > > >> virtio-net has two ways to switch napi_tx: one is thro

Re: [PATCH net v2] i40e: fix the panic when running bpf in xdpdrv mode

2021-04-14 Thread Jason Xing
On Thu, Apr 15, 2021 at 10:08 AM Jesse Brandeburg wrote: > > Jason Xing wrote: > > > On Wed, Apr 14, 2021 at 12:27 AM Jesse Brandeburg > > wrote: > > > > > > kerneljasonx...@gmail.com wrote: > > > > > > > From: Jason Xing > > &g

Re: [PATCH net v2] i40e: fix the panic when running bpf in xdpdrv mode

2021-04-14 Thread Jason Xing
On Wed, Apr 14, 2021 at 12:27 AM Jesse Brandeburg wrote: > > kerneljasonx...@gmail.com wrote: > > > From: Jason Xing > > Hi Jason, > > Sorry, I missed this on the first time: Added intel-wired-lan, > please include on any future submissions for Intel drivers. >

Re: [PATCH net v2] i40e: fix the panic when running bpf in xdpdrv mode

2021-04-13 Thread Jason Xing
On Wed, Apr 14, 2021 at 12:27 AM Jesse Brandeburg wrote: > > kerneljasonx...@gmail.com wrote: > > > From: Jason Xing > > Hi Jason, > > Sorry, I missed this on the first time: Added intel-wired-lan, > please include on any future submissions for Intel drivers. >

Re: [PATCH] i40e: fix the panic when running bpf in xdpdrv mode

2021-04-12 Thread Jason Xing
On Tue, Apr 13, 2021 at 5:52 AM Jesse Brandeburg wrote: > > kerneljasonx...@gmail.com wrote: > > > From: Jason Xing > > > > Re: [PATCH] i40e: fix the panic when running bpf in xdpdrv mode > > Please use netdev style subject lines when patching net kernel to >

Re: [PATCH v2 4.19] tcp: fix TCP socks unreleased in BBR mode

2020-08-11 Thread Jason Xing
Hi everyone, Could anyone take a look at this issue? I believe it is of high-importance. Though Eric gave the proper patch a few months ago, the stable branch still hasn't applied or merged this fix. It seems this patch was forgotten :( Thanks, Jason On Thu, Jun 4, 2020 at 9:47 PM Jason

Re: [PATCH v2 4.19] tcp: fix TCP socks unreleased in BBR mode

2020-06-04 Thread Jason Xing
On Thu, Jun 4, 2020 at 9:10 PM Eric Dumazet wrote: > > On Thu, Jun 4, 2020 at 2:01 AM wrote: > > > > From: Jason Xing > > > > When using BBR mode, too many tcp socks cannot be released because of > > duplicate use of the sock_hold() in the manner of tcp_in

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-04 Thread Jason Xing
On Wed, Jun 3, 2020 at 10:08 PM Neal Cardwell wrote: > > On Wed, Jun 3, 2020 at 9:55 AM Eric Dumazet wrote: > > > > On Wed, Jun 3, 2020 at 5:02 AM Neal Cardwell wrote: > > > > > > On Wed, Jun 3, 2020 at 1:44 AM Eric Dumazet wrote: > > > > &g

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-03 Thread Jason Xing
On Wed, Jun 3, 2020 at 8:02 PM Neal Cardwell wrote: > > On Wed, Jun 3, 2020 at 1:44 AM Eric Dumazet wrote: > > > > On Tue, Jun 2, 2020 at 10:05 PM Jason Xing > > wrote: > > > > > > Hi Eric, > > > > > > I'm still trying to un

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-02 Thread Jason Xing
On Wed, Jun 3, 2020 at 1:44 PM Eric Dumazet wrote: > > On Tue, Jun 2, 2020 at 10:05 PM Jason Xing wrote: > > > > Hi Eric, > > > > I'm still trying to understand what you're saying before. Would this > > be better as following: > > 1) disca

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-02 Thread Jason Xing
give up pacing'. Meanwhile, should we introduce the tcp_wstamp_ns socket field as commit (864e5c090749) does? Thanks, Jason On Wed, Jun 3, 2020 at 10:44 AM Eric Dumazet wrote: > > On Tue, Jun 2, 2020 at 7:42 PM Jason Xing wrote: > > > > I agree with you. The upstream

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-02 Thread Jason Xing
Thanks for reminding me. I will test the cases through using sch_fq. Jason On Wed, Jun 3, 2020 at 10:44 AM Eric Dumazet wrote: > > On Tue, Jun 2, 2020 at 7:42 PM Jason Xing wrote: > > > > I agree with you. The upstream has already dropped and optimized this > > part (

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-02 Thread Jason Xing
fix to the correct tree soon :) Thanks again, Jason On Wed, Jun 3, 2020 at 10:29 AM Eric Dumazet wrote: > > On Tue, Jun 2, 2020 at 6:53 PM Jason Xing wrote: > > > > Hi Eric, > > > > I'm sorry that I didn't write enough clearly. We're running the >

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-02 Thread Jason Xing
headline and cc Greg. Thanks, Jason On Tue, Jun 2, 2020 at 9:05 PM Eric Dumazet wrote: > > On Tue, Jun 2, 2020 at 1:05 AM wrote: > > > > From: Jason Xing > > > > TCP socks cannot be released because of the sock_hold() increasing the > > sk_refcnt in the manner