Re: [PATCH net-next v3 0/7] Microsemi Ocelot Ethernet switch support

2018-05-14 Thread James Hogan
On Mon, May 14, 2018 at 10:58:44PM +0200, Andrew Lunn wrote: > Hi Alexandre > > > > The ocelot dts changes are here for reference and should probably go > > through the MIPS tree once the bindings are accepted. > > For your next version, you probably want to drop those patches, so > that David ca

Re: [PATCH AUTOSEL for 4.9 160/293] MIPS: Give __secure_computing() access to syscall arguments.

2018-04-09 Thread James Hogan
On Mon, Apr 09, 2018 at 12:24:58AM +, Sasha Levin wrote: > From: David Daney > > [ Upstream commit 669c4092225f0ed5df12ebee654581b558a5e3ed ] > > KProbes of __seccomp_filter() are not very useful without access to > the syscall arguments. > > Do what x86 does, and populate a struct seccomp_

Re: [PATCH v2] FIRMWARE: bcm47xx_nvram: Replace mac address parsing

2018-03-08 Thread James Hogan
On Thu, Jan 18, 2018 at 03:40:57PM +0200, Andy Shevchenko wrote: > On Thu, 2017-12-21 at 17:42 +0100, Hauke Mehrtens wrote: > > > > On 12/21/2017 03:40 PM, Andy Shevchenko wrote: > > > Replace sscanf() with mac_pton(). > > > > > > Signed-off-by: Andy Shevchenko > > > > Acked-by: Hauke Mehrtens

Re: [PATCH v8 4/4] MIPS: Octeon: Add a global resource manager.

2018-03-02 Thread James Hogan
; > Signed-off-by: Carlos Munoz > Signed-off-by: Steven J. Hill > Signed-off-by: David Daney Acked-by: James Hogan Cheers James signature.asc Description: Digital signature

Re: [PATCH v8 2/4] MIPS: Octeon: Automatically provision CVMSEG space.

2018-03-02 Thread James Hogan
On Thu, Feb 22, 2018 at 03:07:14PM -0800, David Daney wrote: > diff --git a/arch/mips/cavium-octeon/Kconfig b/arch/mips/cavium-octeon/Kconfig > index b5eee1a57d6c..a283b73b7fc6 100644 > --- a/arch/mips/cavium-octeon/Kconfig > +++ b/arch/mips/cavium-octeon/Kconfig > @@ -11,21 +11,26 @@ config CAVIUM

Re: [net-next,06/15] i40e: change flags to use 64 bits

2018-02-07 Thread James Hogan
On Fri, Jan 26, 2018 at 01:24:50PM -0800, Jeff Kirsher wrote: > From: Alice Michael > > As we have added more flags, we need to now use more > bits and have over flooded the 32 bit size. So > make it 64. > > Also change all the existing bits to unsigned long long > bits. > > Signed-off-by: Ali

[PATCH] impr: Fix ptrdiff_t print formatting

2018-01-30 Thread James Hogan
). Signed-off-by: James Hogan Cc: Alexey Kuznetsov Cc: "David S. Miller" Cc: Hideaki YOSHIFUJI Cc: netdev@vger.kernel.org --- net/ipv4/ipmr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c index fd5f19c988e4..0a279d99a532 1

Re: [PATCH v4 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-11-30 Thread James Hogan
On Thu, Nov 30, 2017 at 03:09:33PM -0800, David Daney wrote: > On 11/30/2017 02:56 PM, James Hogan wrote: > > On Thu, Nov 30, 2017 at 01:49:43PM -0800, David Daney wrote: > >> On 11/30/2017 01:36 PM, James Hogan wrote: > >>> On Tue, Nov 28, 2017 at 04:55

Re: [PATCH v4 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-11-30 Thread James Hogan
On Thu, Nov 30, 2017 at 01:49:43PM -0800, David Daney wrote: > On 11/30/2017 01:36 PM, James Hogan wrote: > > On Tue, Nov 28, 2017 at 04:55:34PM -0800, David Daney wrote: > >> Signed-off-by: Carlos Munoz > >> Signed-off-by: Steven J. Hill > >> Signed-off-b

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

2017-11-30 Thread James Hogan
On Tue, Nov 28, 2017 at 04:55:35PM -0800, David Daney wrote: > From: Carlos Munoz > > Add a global resource manager to manage tagged pointers within > bootmem allocated memory. This is used by various functional > blocks in the Octeon core like the FPA, Ethernet nexus, etc. > > Signed-off-by: Ca

Re: [PATCH v4 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-11-30 Thread James Hogan
eon_cvmemctl { > /* R/W Size of local memory in cache blocks, 54 (6912 >* bytes) is max legal value. */ > __BITFIELD_FIELD(uint64_t lmemsz:6, > - ;) > + ; > } s; > }; Regardless, the patch looks good to me. Reviewed-by: James Hogan Cheers James signature.asc Description: Digital signature

Re: [net-next,1/3] netem: convert to qdisc_watchdog_schedule_ns

2017-11-14 Thread James Hogan
On Tue, Nov 14, 2017 at 09:11:12PM +, James Hogan wrote: > On Tue, Nov 07, 2017 at 12:59:34PM -0800, Dave Taht wrote: > > diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c > > index db0228a..443a75d 100644 > > --- a/net/sched/sch_netem.c > >

Re: [net-next,v2,0/2] netem: fix compilation on 32 bit

2017-11-14 Thread James Hogan
+-- > 1 file changed, 7 insertions(+), 10 deletions(-) > Acked-by: Randy Dunlap > Acked-by: Dave Taht These appears to fix the MIPS build, so Tested-by: James Hogan Thanks James signature.asc Description: Digital signature

Re: [net-next,1/3] netem: convert to qdisc_watchdog_schedule_ns

2017-11-14 Thread James Hogan
On Tue, Nov 07, 2017 at 12:59:34PM -0800, Dave Taht wrote: > diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c > index db0228a..443a75d 100644 > --- a/net/sched/sch_netem.c > +++ b/net/sched/sch_netem.c ... > @@ -305,11 +305,11 @@ static bool loss_event(struct netem_sched_data *q) > *

Re: [PATCH 4/7] MIPS: Octeon: Add Free Pointer Unit (FPA) support.

2017-11-02 Thread James Hogan
On Wed, Nov 01, 2017 at 05:36:03PM -0700, David Daney wrote: > diff --git a/arch/mips/cavium-octeon/Kconfig b/arch/mips/cavium-octeon/Kconfig > index 5c0b56203bae..211ef5b57214 100644 > --- a/arch/mips/cavium-octeon/Kconfig > +++ b/arch/mips/cavium-octeon/Kconfig > @@ -86,4 +86,14 @@ config OCTEON_

Re: [RFC PATCH 2/2] bpf: Initialise mod[] in bpf_trace_printk

2017-08-14 Thread James Hogan
On Fri, Aug 11, 2017 at 06:47:04PM +0200, Daniel Borkmann wrote: > Hi James, > > On 08/09/2017 10:34 PM, Daniel Borkmann wrote: > > On 08/09/2017 09:39 AM, James Hogan wrote: > > [...] > >> time (but please consider looking at the other patch which is ce

[PATCH 0/4] MIPS: syscall tracing fixes

2017-08-11 Thread James Hogan
Daney Cc: Kees Cook Cc: Andy Lutomirski Cc: Will Drewry Cc: Oleg Nesterov Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Lars Persson Cc: netdev@vger.kernel.org Cc: linux-ker...@vger.kernel.org Cc: linux-m...@linux-mips.org James Hogan (4): MIPS/seccomp: Fix indirect syscall args MIP

[PATCH 1/4] MIPS/seccomp: Fix indirect syscall args

2017-08-11 Thread James Hogan
the stack can't be loaded). Reported-by: James Cowgill Fixes: 669c4092225f ("MIPS: Give __secure_computing() access to syscall arguments.") Signed-off-by: James Hogan Cc: Ralf Baechle Cc: David Daney Cc: Kees Cook Cc: Andy Lutomirski Cc: Will Drewry Cc: Oleg Nesterov Cc:

Re: [RFC PATCH 2/2] bpf: Initialise mod[] in bpf_trace_printk

2017-08-09 Thread James Hogan
On Tue, Aug 08, 2017 at 02:54:33PM -0700, David Miller wrote: > From: James Hogan > Date: Tue, 08 Aug 2017 22:20:05 +0100 > > > cool, i hadn't realised unmentioned elements in an initialiser are > > always zeroed, even when non-global/static, so had interpre

Re: [RFC PATCH 2/2] bpf: Initialise mod[] in bpf_trace_printk

2017-08-08 Thread James Hogan
On 8 August 2017 17:48:57 BST, David Miller wrote: >From: Daniel Borkmann >Date: Tue, 08 Aug 2017 10:46:52 +0200 > >> On 08/08/2017 12:25 AM, James Hogan wrote: >>> In bpf_trace_printk(), the elements in mod[] are left uninitialised, >>> but >>> they

[RFC PATCH 0/2] bpf_trace_printk() fixes

2017-08-07 Thread James Hogan
A couple of RFC fixes for bpf_trace_printk(). The first affects 32-bit architectures in particular, the second is a theoretical uninitialised variable fix. Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Steven Rostedt Cc: Ingo Molnar Cc: netdev@vger.kernel.org James Hogan (2): bpf: Fix

[RFC PATCH 1/2] bpf: Fix bpf_trace_printk on 32-bit architectures

2017-08-07 Thread James Hogan
82 ("tracing: Allow BPF programs to call bpf_trace_printk()") Signed-off-by: James Hogan Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Steven Rostedt Cc: Ingo Molnar Cc: netdev@vger.kernel.org --- I'm open to nicer ways of fixing this. This is tested with samples/bpf/tracex5 on MIPS3

[RFC PATCH 2/2] bpf: Initialise mod[] in bpf_trace_printk

2017-08-07 Thread James Hogan
rintk()") Signed-off-by: James Hogan Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Steven Rostedt Cc: Ingo Molnar Cc: netdev@vger.kernel.org --- When I checked (on MIPS32), the elements tended to have the value zero anyway (does BPF zero the stack or something clever?), so this is a purely t

Re: [PATCH] MIPS: BPF: Add support for SKF_AD_HATYPE

2017-03-13 Thread James Hogan
On Fri, Mar 10, 2017 at 02:14:05PM -0800, David Daney wrote: > This let's us pass some additional "modprobe test-bpf" tests. > > Reuse the code for SKF_AD_IFINDEX, but substitute the offset and size > of the "type" field. > > Signed-off-by: David Daney I think the BPF maintainers should probabl