Re: [PATCH] ppp: don't use 0 in pointer context

2006-02-09 Thread James Carlson
re nowhere near as lucid for those maintaining the code. I think that if this patch is "important," then something other than just clarity is valued. In that case, just ignore me, and do what you will. -- James Carlson 42.703N 71.076W <[EMAIL PROTECTED]> - To unsubscrib

Re: [PATCH] ppp: don't use 0 in pointer context

2006-02-08 Thread James Carlson
Alexey Dobriyan writes: > - if (ap == 0) > + if (!ap) And the solution is to treat it as a boolean instead?! I'm not sure which is more ugly. Why wouldn't explicit comparison against NULL be the preferred fix? -- James Carlson 42.703N 71.076W <[EMA