Re: [PATCH net] sctp: fix pr_warn max_data argument type mismatch

2018-12-06 Thread Jakub Audykowicz
On 2018-12-06 09:03, David Miller wrote: > From: Jakub Audykowicz > Date: Thu, 6 Dec 2018 08:58:37 +0100 > >> My previous patch introduced a compilation warning regarding a type >> mismatch (int vs size_t). This is a one-letter fix for good housekeeping. >> >>

[PATCH net] sctp: fix pr_warn max_data argument type mismatch

2018-12-05 Thread Jakub Audykowicz
My previous patch introduced a compilation warning regarding a type mismatch (int vs size_t). This is a one-letter fix for good housekeeping. Signed-off-by: Jakub Audykowicz --- net/sctp/chunk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/chunk.c b/net/sctp

Re: [PATCH net] sctp: always set frag_point on pmtu change

2018-12-04 Thread Jakub Audykowicz
On 2018-12-04 19:58, Marcelo Ricardo Leitner wrote: > On Tue, Dec 04, 2018 at 07:51:54PM +0100, Jakub Audykowicz wrote: > ... >> Thanks, I've taken your remarks into account and ended up with this >> simple solution: > LGTM! Thanks > >> diff --git a/include

[PATCH net] sctp: frag_point sanity check

2018-12-04 Thread Jakub Audykowicz
re as reported. I propose to add this simple last-ditch sanity check due to the severity of the potential consequences. Signed-off-by: Jakub Audykowicz --- include/net/sctp/sctp.h | 5 + net/sctp/chunk.c| 6 ++ net/sctp/socket.c | 3 +-- 3 files changed, 12 insertions(+), 2 dele

Re: [PATCH net] sctp: always set frag_point on pmtu change

2018-12-04 Thread Jakub Audykowicz
On 2018-12-04 18:45, Marcelo Ricardo Leitner wrote: > On Tue, Dec 04, 2018 at 06:00:51PM +0100, Jakub Audykowicz wrote: > ... >> OK, let's forget about that "if" :) >> Coming back to the sanity check, I came up with something like below, >> based on the cod

Re: [PATCH net] sctp: always set frag_point on pmtu change

2018-12-04 Thread Jakub Audykowicz
On 2018-11-28 12:26, Marcelo Ricardo Leitner wrote: > On Wed, Nov 28, 2018 at 12:08:38AM -0200, Marcelo Ricardo Leitner wrote: >> On Tue, Nov 27, 2018 at 11:18:02PM +0100, Jakub Audykowicz wrote: >>> On 2018-11-19 08:20, Xin Long wrote: >>> >>>> On Mon, N

Re: [PATCH net] sctp: always set frag_point on pmtu change

2018-11-27 Thread Jakub Audykowicz
On 2018-11-19 08:20, Xin Long wrote: > On Mon, Nov 19, 2018 at 5:49 AM Jakub Audykowicz > wrote: >> Calling send on a connected SCTP socket results in kernel panic if >> spp_pathmtu was configured manually before an association is established >> and it was not reconfigur

Re: [PATCHv2 net] sctp: update frag_point when stream_interleave is set

2018-11-27 Thread Jakub Audykowicz
oint when stream->si may be changed in > sctp_process_init(). > > v1->v2: > - call sctp_assoc_update_frag_point() separately in sctp_process_init > and sctp_association_init, per Marcelo's suggestion. > > Fixes: 2f5e3c9df693 ("sctp: introduce sctp_as

[PATCH net] sctp: always set frag_point on pmtu change

2018-11-18 Thread Jakub Audykowicz
ual panic). Fixes: 2f5e3c9df693 ("sctp: introduce sctp_assoc_update_frag_point") Signed-off-by: Jakub Audykowicz --- include/net/sctp/constants.h | 3 +++ net/sctp/associola.c | 13 +++-- net/sctp/chunk.c | 6 ++ 3 files changed, 16 insertions(+), 6 d