Re: [PATCH 3/5] net/mlx4: fix some error handling in mlx4_multi_func_init()

2016-02-11 Thread Jack Morgenstein
ith post-increment) or the post-value (with pre-increment)). In that case, my comment below regarding the double-free is also not correct. Setting the freed pointer to NULL is not needed. My bad. We should go with your format: while (i--) -Jack On Thu, 11 Feb 2016 11:29:43 +0200 Jack Morgenst

Re: [PATCH 3/5] net/mlx4: fix some error handling in mlx4_multi_func_init()

2016-02-11 Thread Jack Morgenstein
On Wed, 10 Feb 2016 19:15:20 +0100 Rasmus Villemoes wrote: > On Wed, Feb 10 2016, Yishai Hadas wrote: > > >> @@ -2429,7 +2429,7 @@ err_thread: > >>flush_workqueue(priv->mfunc.master.comm_wq); > >>destroy_workqueue(priv->mfunc.master.comm_wq); > >> err_slaves: > >> - while (--i) { > >

Re: [PATCH 02/25] IB/mthca, net/mlx4: remove counting semaphores

2015-10-29 Thread Jack Morgenstein
On Wed, 28 Oct 2015 03:45:50 +0100 Arnd Bergmann wrote: > As far as I can tell, there is a preexisting race condition > regarding the cmd->use_events flag, which is not protected > by any lock. When this flag is toggled while another command > is being started, that command gets stuck until the m

Re: [PATCH] net/mlx4: Memcpy at slave_event should copy sizeof mlx4_eqe

2015-10-25 Thread Jack Morgenstein
Hi Carol, Good catch! Need to add an additional chunk to your fix -- see below. On Sun, 25 Oct 2015 10:26:07 +0200 Or Gerlitz wrote: > > > --- > > drivers/net/ethernet/mellanox/mlx4/eq.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/mell

Re: [PATCH]mlx4-core: fix possible use after free in cq_completion

2015-07-26 Thread Jack Morgenstein
On Fri, 24 Jul 2015 10:18:48 +0200 Jinpu Wang wrote: > Hi all, > > I hit bug in OFED, I report to link below: > > http://marc.info/?l=linux-rdma&m=143634872328553&w=2 > I checked latest mainline Linux 4.2-rc3, it has similar bug. > Here is the patch against Linux 4.2-rc3, compile test only. >

Re: [ofa-general] InfiniBand/RDMA merge plans for 2.6.24

2007-09-18 Thread Jack Morgenstein
On Thursday 13 September 2007 20:57, Roland Dreier wrote: > HW specific: > >  - I already merged patches to enable MSI-X by default for mthca and >    mlx4.  I hope there aren't too many systems that get hosed if a >    MSI-X interrupt is generated. > >  - Jack and Michael's mlx4 FMR support.  Wi