Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-22 Thread Jürgen Groß
On 22.03.21 07:48, Leon Romanovsky wrote: On Mon, Mar 22, 2021 at 06:58:34AM +0100, Jürgen Groß wrote: On 22.03.21 06:39, Leon Romanovsky wrote: On Sun, Mar 21, 2021 at 06:54:52PM +0100, Hsu, Chiahao wrote: <...> Typically there should be one VM running netback on each host, and

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-21 Thread Jürgen Groß
On 22.03.21 06:39, Leon Romanovsky wrote: On Sun, Mar 21, 2021 at 06:54:52PM +0100, Hsu, Chiahao wrote: <...> Typically there should be one VM running netback on each host, and having control over what interfaces or features it exposes is also important for stability. How about we create a

Re: [PATCH 0/7] xen/events: bug fixes and some diagnostic aids

2021-02-08 Thread Jürgen Groß
On 08.02.21 15:20, Julien Grall wrote: Hi Juergen, On 08/02/2021 13:58, Jürgen Groß wrote: On 08.02.21 14:09, Julien Grall wrote: Hi Juergen, On 08/02/2021 12:31, Jürgen Groß wrote: On 08.02.21 13:16, Julien Grall wrote: On 08/02/2021 12:14, Jürgen Groß wrote: On 08.02.21 11:40, Julien

Re: [PATCH 0/7] xen/events: bug fixes and some diagnostic aids

2021-02-08 Thread Jürgen Groß
On 08.02.21 14:09, Julien Grall wrote: Hi Juergen, On 08/02/2021 12:31, Jürgen Groß wrote: On 08.02.21 13:16, Julien Grall wrote: On 08/02/2021 12:14, Jürgen Groß wrote: On 08.02.21 11:40, Julien Grall wrote: Hi Juergen, On 08/02/2021 10:22, Jürgen Groß wrote: On 08.02.21 10:54, Julien

Re: [PATCH 0/7] xen/events: bug fixes and some diagnostic aids

2021-02-08 Thread Jürgen Groß
On 08.02.21 13:16, Julien Grall wrote: On 08/02/2021 12:14, Jürgen Groß wrote: On 08.02.21 11:40, Julien Grall wrote: Hi Juergen, On 08/02/2021 10:22, Jürgen Groß wrote: On 08.02.21 10:54, Julien Grall wrote: ... I don't really see how the difference matter here. The idea is to r

Re: [PATCH 0/7] xen/events: bug fixes and some diagnostic aids

2021-02-08 Thread Jürgen Groß
On 08.02.21 11:40, Julien Grall wrote: Hi Juergen, On 08/02/2021 10:22, Jürgen Groß wrote: On 08.02.21 10:54, Julien Grall wrote: ... I don't really see how the difference matter here. The idea is to re-use what's already existing rather than trying to re-invent the wheel with an

Re: [PATCH 0/7] xen/events: bug fixes and some diagnostic aids

2021-02-08 Thread Jürgen Groß
On 08.02.21 10:54, Julien Grall wrote: On 08/02/2021 09:41, Jürgen Groß wrote: On 08.02.21 10:11, Julien Grall wrote: Hi Juergen, On 07/02/2021 12:58, Jürgen Groß wrote: On 06.02.21 19:46, Julien Grall wrote: Hi Juergen, On 06/02/2021 10:49, Juergen Gross wrote: The first three patches

Re: [PATCH 0/7] xen/events: bug fixes and some diagnostic aids

2021-02-08 Thread Jürgen Groß
On 08.02.21 10:11, Julien Grall wrote: Hi Juergen, On 07/02/2021 12:58, Jürgen Groß wrote: On 06.02.21 19:46, Julien Grall wrote: Hi Juergen, On 06/02/2021 10:49, Juergen Gross wrote: The first three patches are fixes for XSA-332. The avoid WARN splats and a performance issue with

Re: [PATCH 0/7] xen/events: bug fixes and some diagnostic aids

2021-02-07 Thread Jürgen Groß
On 06.02.21 19:46, Julien Grall wrote: Hi Juergen, On 06/02/2021 10:49, Juergen Gross wrote: The first three patches are fixes for XSA-332. The avoid WARN splats and a performance issue with interdomain events. Thanks for helping to figure out the problem. Unfortunately, I still see reliably

Re: [PATCH] drivers: net: xen-netfront: Simplify the calculation of variables

2021-02-04 Thread Jürgen Groß
On 02.02.21 11:17, Jiapeng Chong wrote: Fix the following coccicheck warnings: ./drivers/net/xen-netfront.c:1816:52-54: WARNING !A || A && B is equivalent to !A || B. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc

Re: [PATCH] xen/netback: avoid race in xenvif_rx_ring_slots_available()

2021-02-03 Thread Jürgen Groß
On 04.02.21 00:48, Jakub Kicinski wrote: On Tue, 2 Feb 2021 08:09:38 +0100 Juergen Gross wrote: Since commit 23025393dbeb3b8b3 ("xen/netback: use lateeoi irq binding") xenvif_rx_ring_slots_available() is no longer called only from the rx queue kernel thread, so it needs to access the rx queue w

Re: [PATCH] xen/netback: avoid race in xenvif_rx_ring_slots_available()

2021-02-02 Thread Jürgen Groß
On 02.02.21 16:26, Igor Druzhinin wrote: On 02/02/2021 07:09, Juergen Gross wrote: Since commit 23025393dbeb3b8b3 ("xen/netback: use lateeoi irq binding") xenvif_rx_ring_slots_available() is no longer called only from the rx queue kernel thread, so it needs to access the rx queue with the associ

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-11 Thread Jürgen Groß
On 11.12.20 00:20, boris.ostrov...@oracle.com wrote: On 12/10/20 2:26 PM, Thomas Gleixner wrote: All event channel setups bind the interrupt on CPU0 or the target CPU for percpu interrupts and overwrite the affinity mask with the corresponding cpumask. That does not make sense. The XEN impleme

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-11 Thread Jürgen Groß
On 11.12.20 11:13, Thomas Gleixner wrote: On Fri, Dec 11 2020 at 07:17, Jürgen Groß wrote: On 11.12.20 00:20, boris.ostrov...@oracle.com wrote: On 12/10/20 2:26 PM, Thomas Gleixner wrote: All event channel setups bind the interrupt on CPU0 or the target CPU for percpu interrupts and

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-10 Thread Jürgen Groß
On 11.12.20 00:20, boris.ostrov...@oracle.com wrote: On 12/10/20 2:26 PM, Thomas Gleixner wrote: All event channel setups bind the interrupt on CPU0 or the target CPU for percpu interrupts and overwrite the affinity mask with the corresponding cpumask. That does not make sense. The XEN impleme

Re: [PATCH 08/12] net: xen-netfront: Demote non-kernel-doc headers to standard comment blocks

2020-11-04 Thread Jürgen Groß
On 04.11.20 10:06, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/net/xen-netfront.c: In function ‘store_rxbuf’: drivers/net/xen-netfront.c:2416:16: warning: variable ‘target’ set but not used [-Wunused-but-set-variable] Those two warnings are not fixed by the p

Re: [PATCH net-next v9 1/2] xen networking: add basic XDP support for xen-netfront

2020-05-12 Thread Jürgen Groß
On 12.05.20 15:21, Denis Kirjanov wrote: On 5/12/20, Jürgen Groß wrote: On 12.05.20 14:27, Denis Kirjanov wrote: On 5/12/20, Jürgen Groß wrote: On 11.05.20 19:27, Denis Kirjanov wrote: On 5/11/20, Jürgen Groß wrote: On 11.05.20 12:22, Denis Kirjanov wrote: The patch adds a basic XDP

Re: [PATCH net-next v9 1/2] xen networking: add basic XDP support for xen-netfront

2020-05-12 Thread Jürgen Groß
On 12.05.20 14:27, Denis Kirjanov wrote: On 5/12/20, Jürgen Groß wrote: On 11.05.20 19:27, Denis Kirjanov wrote: On 5/11/20, Jürgen Groß wrote: On 11.05.20 12:22, Denis Kirjanov wrote: The patch adds a basic XDP processing to xen-netfront driver. We ran an XDP program for an RX response

Re: [PATCH net-next v9 1/2] xen networking: add basic XDP support for xen-netfront

2020-05-11 Thread Jürgen Groß
On 11.05.20 19:27, Denis Kirjanov wrote: On 5/11/20, Jürgen Groß wrote: On 11.05.20 12:22, Denis Kirjanov wrote: The patch adds a basic XDP processing to xen-netfront driver. We ran an XDP program for an RX response received from netback driver. Also we request xen-netback to adjust data

Re: [PATCH net-next v9 1/2] xen networking: add basic XDP support for xen-netfront

2020-05-11 Thread Jürgen Groß
On 11.05.20 12:22, Denis Kirjanov wrote: The patch adds a basic XDP processing to xen-netfront driver. We ran an XDP program for an RX response received from netback driver. Also we request xen-netback to adjust data offset for bpf_xdp_adjust_head() header space for custom headers. synchronizat