commit 183db4 ("drivers: net: xgene: Correct probe sequence handling")
changed the return type of xgene_enet_check_phy_handle() to void.
This patch, removes the return statement from the last line.
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/xgene_enet_
This patch fixes reading tx/rx delay values for ACPI.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Quan Nguyen
---
drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
b
This patch set fixes bugs related to handling the case for ACPI for,
reading and programming tx/rx delay values.
Signed-off-by: Iyappan Subramanian
---
Iyappan Subramanian (2):
drivers: net: xgene: Read tx/rx delay for ACPI
drivers: net: xgene: Remove return statement from void function
From: Quan Nguyen
This patch fixes configuring tx/rx delay values for ACPI.
Signed-off-by: Quan Nguyen
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/apm
: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 27
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
index 1d307f2..6e253d9 100644
Hi Andrew,
On Fri, Aug 25, 2017 at 4:10 PM, Andrew Lunn wrote:
> On Fri, Aug 25, 2017 at 03:23:30PM -0700, Iyappan Subramanian wrote:
>> When xgene_enet is rmmod'd and there are still outstanding tx descriptors
>> that have been setup but have not completed, it is
: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 27
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
index 1d307f2..6e253d9 100644
This patch set,
1. Adds call to PHY disconnect in the case of error
2. Cleans up all outstanding TX descriptors when the driver is
being rmmod'd
Signed-off-by: Iyappan Subramanian
---
Iyappan Subramanian (1):
drivers: net: xgene: Clean up all outstanding tx descri
any() from
xgene_enet_setup_tx_desc(). The only caller of xgene_enet_setup_tx_desc()
will call dev_kfree_skb_any() upon return of an error. Nothing is gained by
calling it twice in a row.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Dean Nelson
Tested-by: Quan Nguyen
---
drivers/net/ethernet
etrived. Always abort if the clock is missing on
> * DT system as the driver can't cope with this case.
>
> --
Thanks for the patch.
Acked-by: Iyappan Subramanian
> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea.[ RFC1925, 2.3 ]
On Thu, May 18, 2017 at 3:19 PM, Florian Fainelli wrote:
> On 05/18/2017 03:13 PM, Iyappan Subramanian wrote:
>> Added helper function that checks phy_mode is RGMII (all variants)
>> 'bool phy_interface_mode_is_rgmii(phy_interface_t mode)'
>>
>> Changed the
This patch addresses the review comment from the previous patch set,
by using phy_interface_mode_is_rgmii() helper function to address
all RGMII phy mode variants.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Quan Nguyen
---
Review comment reference:
http://www.spinics.net/lists/netdev
Added helper function that checks phy_mode is RGMII (all variants)
'bool phy_interface_mode_is_rgmii(phy_interface_t mode)'
Changed the following function, to use the above.
'bool phy_interface_is_rgmii(struct phy_device *phydev)'
Signed-off-by: Iyappan Subramanian
S
This patch set,
- adds phy_interface_mode_is_rgmii() helper function
- addresses review comment from previous patch set, by calling
phy_interface_mode_is_rgmii() to address all RGMII variants
Signed-off-by: Iyappan Subramanian
---
v2: Address review comments from v1
- adds
On Wed, May 17, 2017 at 1:26 PM, Andrew Lunn wrote:
>> +bool is_xgene_enet_phy_mode_rgmii(struct net_device *ndev)
>> +{
>> + struct xgene_enet_pdata *pdata = netdev_priv(ndev);
>> + int phy_mode = pdata->phy_mode;
>> + bool ret;
>> +
>> + ret = phy_mode == PHY_INTERFACE_MODE_RGMII
This patch addresses the review comment from the previous patch set,
by adding a helper function to address all RGMII phy mode variants.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Quan Nguyen
---
Review comment reference:
http://www.spinics.net/lists/netdev/msg434649.html
---
.../net
From: Quan Nguyen
This patch adds extended ethtool statistics support.
Signed-off-by: Quan Nguyen
Signed-off-by: Iyappan Subramanian
---
.../net/ethernet/apm/xgene/xgene_enet_ethtool.c| 89 +-
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 29 +++
drivers
From: Quan Nguyen
This patch cleans up unused macros to improve readability.
Signed-off-by: Quan Nguyen
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/xgene_enet_hw.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/net/ethernet/apm/xgene
This patch set,
- adds ethtool extended statistics support
- addresses errata workarounds
- fixes bugs related to statistics
Signed-off-by: Iyappan Subramanian
Signed-off-by: Quan Nguyen
---
v2: Address review comments from v1
- Adds lock to protect mdio-xgene indirect MAC access
ing port_ops->shutdown() after delete_rings()
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 21 -
drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 2 +-
drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.
This patch,
- refactors mac read/write functions
- adds lock to protect indirect mac access
Signed-off-by: Iyappan Subramanian
Signed-off-by: Quan Nguyen
---
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 119 +-
drivers/net/ethernet/apm/xgene
uan Nguyen
Signed-off-by: Iyappan Subramanian
---
.../net/ethernet/apm/xgene/xgene_enet_ethtool.c| 33 ++
drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 20 +++--
drivers/net/ethernet/apm/xgene/xgene_enet_main.h | 2 ++
3 files changed, 46 insertions(+), 9
From: Quan Nguyen
This patch,
- refactors mac access routine
- adds lock to protect mac indirect access
Signed-off-by: Quan Nguyen
Signed-off-by: Iyappan Subramanian
---
drivers/net/phy/mdio-xgene.c | 74 ++--
drivers/net/phy/mdio-xgene.h | 3 ++
2
This patch adds rx_overrun and tx_underrun ethtool statistic counters.
Signed-off-by: Quan Nguyen
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/xgene_enet_ethtool.c | 16 +---
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 11 +++
drivers/net
From: Quan Nguyen
This patch switches to use rgmii mdio mac access routines if available,
as they share the same HW.
Signed-off-by: Quan Nguyen
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 14 ++
1 file changed, 14 insertions(+)
diff
From: Quan Nguyen
This patch adds statistic counter for frames recovered from HW errata
10GE_8 and ENET_11:
"HW reports Length error for valid 64 byte frames with len <46 bytes".
Signed-off-by: Quan Nguyen
Signed-off-by: Iyappan Subramanian
---
drivers/net/ether
From: Quan Nguyen
This patch fixes the tx error counters and adds more rx error counters.
Signed-off-by: Quan Nguyen
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 6 --
drivers/net/ethernet/apm/xgene/xgene_enet_hw.h | 2 --
drivers/net
From: Quan Nguyen
Commit 5944701df90d ("net: remove useless memset's in drivers get_stats64")
makes the pdata->stats redundant. This patch removes pdata->stats and
updates get_stats64() callback accordingly.
Signed-off-by: Quan Nguyen
Signed-off-by: Iyappan Subraman
From: Quan Nguyen
This patch adds workaround for HW errata 10GE_4:
"XGENET_ICM_ECM_DROP_COUNT_REG_0 reg not clear on read".
Signed-off-by: Quan Nguyen
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 2 ++
drivers/net/ethernet
On Wed, Apr 26, 2017 at 5:06 PM, Florian Fainelli wrote:
> On 04/26/2017 04:38 PM, Iyappan Subramanian wrote:
>> From: Quan Nguyen
>>
>> This patch adds lock to protect indirect mac access sequence.
>>
>> Signed-off-by: Quan Nguyen
>> Signed-off-by: Iyap
From: Quan Nguyen
This patch adds workaround for HW errata 10GE_4:
"XGENET_ICM_ECM_DROP_COUNT_REG_0 reg not clear on read".
Signed-off-by: Quan Nguyen
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 2 ++
drivers/net/ethernet
uan Nguyen
Signed-off-by: Iyappan Subramanian
---
.../net/ethernet/apm/xgene/xgene_enet_ethtool.c| 30 ++
drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 20 ---
drivers/net/ethernet/apm/xgene/xgene_enet_main.h | 2 ++
3 files changed, 44 insertions(+), 8
From: Quan Nguyen
This patch adds rx_overrun and tx_underrun ethtool statistic counters.
Signed-off-by: Quan Nguyen
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/xgene_enet_ethtool.c | 16 +---
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 11
From: Quan Nguyen
This patch adds extended ethtool statistics support.
Signed-off-by: Quan Nguyen
Signed-off-by: Iyappan Subramanian
---
.../net/ethernet/apm/xgene/xgene_enet_ethtool.c| 90 +-
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 20 +
drivers/net
From: Quan Nguyen
This patch adds statistic counter for frames recovered from HW errata
10GE_8 and ENET_11:
"HW reports Length error for valid 64 byte frames with len <46 bytes".
Signed-off-by: Quan Nguyen
Signed-off-by: Iyappan Subramanian
---
drivers/net/ether
From: Quan Nguyen
This patch fixes the tx error counters and adds more rx error counters.
Signed-off-by: Quan Nguyen
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 6 --
drivers/net/ethernet/apm/xgene/xgene_enet_hw.h | 2 --
drivers/net
From: Quan Nguyen
This patch adds lock to protect indirect mac access sequence.
Signed-off-by: Quan Nguyen
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 2 ++
drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 1 +
drivers/net/ethernet/apm/xgene
From: Quan Nguyen
Commit 5944701df90d ("net: remove useless memset's in drivers get_stats64")
makes the pdata->stats redundant. This patch removes pdata->stats and
updates get_stats64() callback accordingly.
Signed-off-by: Quan Nguyen
Signed-off-by: Iyappan Subraman
From: Quan Nguyen
This patch cleans up unused macros to improve readability.
Signed-off-by: Quan Nguyen
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/xgene_enet_hw.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/net/ethernet/apm/xgene
This patch set,
- adds ethtool extended statistics support
- addresses errata workarounds
- fixes bugs related to statistics
Signed-off-by: Iyappan Subramanian
Signed-off-by: Quan Nguyen
---
Quan Nguyen (9):
drivers: net: xgene: Protect indirect MAC access
drivers: net: xgene: Remove
tool_stats() accordingly
- moves 'struct xge_gstrings_stats' to ethtool.h
Signed-off-by: Iyappan Subramanian
---
v2: Address review comments from v1
- removed duplicate statistics counters that were reported by
xge_get_stats64()
v1:
- Initial version
---
drivers/ne
tool_stats() accordingly
- moves 'struct xge_gstrings_stats' to ethtool.h
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene-v2/ethtool.c | 82 ++---
drivers/net/ethernet/apm/xgene-v2/ethtool.h | 82 +
drivers/net/etherne
Added phy management support by using phy abstraction layer APIs.
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene-v2/Makefile | 2 +-
drivers/net/ethernet/apm/xgene-v2/mac.c| 2 +-
drivers/net/ethernet/apm/xgene-v2/mac.h| 1 +
drivers/net/ethernet/apm/xgene
This patch set,
- adds phy management and ethtool support
- fixes ethernet reset
- addresses review comments from previous patch set
Signed-off-by: Iyappan Subramanian
---
v2: Address review comments from v1
- removed mdio_lock, since there is a top level lock in mdio_bus.c
v1
Added basic ethtool support.
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene-v2/Makefile | 2 +-
drivers/net/ethernet/apm/xgene-v2/ethtool.c | 121
drivers/net/ethernet/apm/xgene-v2/main.c| 1 +
drivers/net/ethernet/apm/xgene-v2/main.h
ced indentation on tx_timeout()
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene-v2/main.c | 55 +++-
1 file changed, 26 insertions(+), 29 deletions(-)
diff --git a/drivers/net/ethernet/apm/xgene-v2/main.c
b/drivers/net/ethernet/apm/xgene-v2/main.c
in
Fixed port reset sequence by adding ECC init.
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene-v2/enet.c | 24 ++--
drivers/net/ethernet/apm/xgene-v2/enet.h | 2 ++
drivers/net/ethernet/apm/xgene-v2/mac.h | 1 -
3 files changed, 20 insertions(+), 7
On Tue, Mar 21, 2017 at 1:35 PM, Andrew Lunn wrote:
>> @@ -511,9 +512,9 @@ static int xge_close(struct net_device *ndev)
>> {
>> struct xge_pdata *pdata = netdev_priv(ndev);
>>
>> - netif_carrier_off(ndev);
>> netif_stop_queue(ndev);
>> xge_mac_disable(pdata);
>> + phy_s
ced indentation on tx_timeout()
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene-v2/main.c | 55 +++-
1 file changed, 26 insertions(+), 29 deletions(-)
diff --git a/drivers/net/ethernet/apm/xgene-v2/main.c
b/drivers/net/ethernet/apm/xgene-v2/main.c
in
Fixed port reset sequence by adding ECC init.
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene-v2/enet.c | 24 ++--
drivers/net/ethernet/apm/xgene-v2/enet.h | 2 ++
drivers/net/ethernet/apm/xgene-v2/mac.h | 1 -
3 files changed, 20 insertions(+), 7
Added basic ethtool support.
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene-v2/Makefile | 2 +-
drivers/net/ethernet/apm/xgene-v2/ethtool.c | 121
drivers/net/ethernet/apm/xgene-v2/main.c| 1 +
drivers/net/ethernet/apm/xgene-v2/main.h
This patch set,
- adds phy management and ethtool support
- fixes ethernet reset
- addresses review comments from previous patch set
Signed-off-by: Iyappan Subramanian
---
Iyappan Subramanian (4):
drivers: net: xgene-v2: Add MDIO support
drivers: net: xgene-v2: Add ethtool support
Added phy management support by using phy abstraction layer APIs.
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene-v2/Makefile | 2 +-
drivers/net/ethernet/apm/xgene-v2/mac.c| 2 +-
drivers/net/ethernet/apm/xgene-v2/mac.h| 1 +
drivers/net/ethernet/apm/xgene
From: Quan Nguyen
This patch implements workaround for errata 10GE_1:
10Gb Ethernet port FIFO threshold default values are incorrect.
Signed-off-by: Quan Nguyen
Signed-off-by: Toan Le
Signed-off-by: Iyappan Subramanian
Tested-by: Fushen Chen
---
drivers/net/ethernet/apm/xgene
This patch fixes Rx checksum validation logic and
adds NETIF_F_RXCSUM flag.
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 27 +++-
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/apm/xgene
This patch implements workaround for errata 10GE_8 and ENET_11:
"HW reports length error for valid 64 byte frames with len <46 bytes"
by recovering them from error.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Quan Nguyen
Signed-off-by: Toan Le
Tested-by: Fushen Chen
---
From: Quan Nguyen
This patch fixes the wrong logical OR operation by changing it to
bit-wise OR operation.
Fixes: 3bb502f83080 ("drivers: net: xgene: fix statistics counters race
condition")
Signed-off-by: Iyappan Subramanian
Signed-off-by: Quan Nguyen
---
drivers/net/ethernet
This patch set addresses bug fixes and errata workarounds.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Quan Nguyen
---
Iyappan Subramanian (3):
drivers: net: xgene: Fix Rx checksum validation logic
drivers: net: xgene: Add workaround for errata 10GE_8/ENET_11
MAINTAINERS: Update X
From: Quan Nguyen
This patch fixes the hardware checksum settings by properly program
the classifier. Otherwise, packet may be received with checksum error
on X-Gene1 SoC.
Signed-off-by: Quan Nguyen
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 1
From: Quan Nguyen
This patches fixes a typo in the argument to xgene_enet_wr_mdio_csr().
Signed-off-by: Quan Nguyen
Signed-off-by: Iyappan Subramanian
---
drivers/net/phy/mdio-xgene.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/mdio-xgene.c b/drivers
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
Signed-off-by: Quan Nguyen
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index cefda30..632e762 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -896,6 +896,7 @@ F: arch/arm64/boot/dts
This patch adds,
- Transmit
- Transmit completion poll
- Receive poll
- NAPI handler
and enables the driver.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
drivers/net/ethernet/apm/Kconfig | 1 +
drivers/net/ethernet/apm/Makefile | 1
This patch set adds support for RGMII based 1GbE hardware which uses a linked
list of DMA descriptor architecture (v2) for APM X-Gene SoCs.
Signed-off-by: Iyappan Subramanian
---
v4: Address review comments from v3
- fixed local variable declarations to reverse christmas tree order
v3
This patch adds,
- probe, remove, shutdown
- open, close and stats
- create and delete ring
- request and delete irq
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
drivers/net/ethernet/apm/xgene-v2/main.c | 510 +++
1 file
This patch adds a MAINTAINERS entry for the ethernet driver for
the on-chip ethernet interface which uses a linked list of DMA
descriptor architecture (v2) for APM X-Gene SoCs.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
MAINTAINERS | 6
This patch adds functions to configure ethernet hardware.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
drivers/net/ethernet/apm/xgene-v2/enet.c | 71
drivers/net/ethernet/apm/xgene-v2/enet.h | 43 +++
2 files changed, 114
This patch adds functions to configure and control mac. This
patch also adds helper functions to get/set registers.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
drivers/net/ethernet/apm/xgene-v2/mac.c | 116
drivers/net/ethernet/apm
This patch adds DMA descriptor setup and interrupt enable/disable
functions.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
drivers/net/ethernet/apm/xgene-v2/main.h | 74 +++
drivers/net/ethernet/apm/xgene-v2/ring.c | 81 +
drivers/net
This patch adds a MAINTAINERS entry for the ethernet driver for
the on-chip ethernet interface which uses a linked list of DMA
descriptor architecture (v2) for APM X-Gene SoCs.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
MAINTAINERS | 6 ++
1 file changed, 6
This patch adds,
- probe, remove, shutdown
- open, close and stats
- create and delete ring
- request and delete irq
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
drivers/net/ethernet/apm/xgene-v2/main.c | 510 +++
1 file
This patch adds functions to configure ethernet hardware.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
drivers/net/ethernet/apm/xgene-v2/enet.c | 71
drivers/net/ethernet/apm/xgene-v2/enet.h | 43 +++
2 files changed, 114
This patch adds DMA descriptor setup and interrupt enable/disable
functions.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
drivers/net/ethernet/apm/xgene-v2/main.h | 74 +++
drivers/net/ethernet/apm/xgene-v2/ring.c | 81 +
drivers/net
This patch adds functions to configure and control mac. This
patch also adds helper functions to get/set registers.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
drivers/net/ethernet/apm/xgene-v2/mac.c | 116
drivers/net/ethernet/apm
This patch set adds support for RGMII based 1GbE hardware which uses a linked
list of DMA descriptor architecture (v2) for APM X-Gene SoCs.
Signed-off-by: Iyappan Subramanian
---
v3: Address review comments from v2
- fix kbuild warnings (this 'if' clause does not guard)
v
This patch adds,
- Transmit
- Transmit completion poll
- Receive poll
- NAPI handler
and enables the driver.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
drivers/net/ethernet/apm/Kconfig | 1 +
drivers/net/ethernet/apm/Makefile | 1
* the driver can't cope with this case.
> +*/
> + if (PTR_ERR(pdata->clk) != -ENOENT || dev->of_node)
> + return PTR_ERR(pdata->clk);
> /* Firmware may have set up the clock already. */
> dev_info(dev, "clocks have been setup already\n");
> }
> --
> 2.11.0
>
Thanks, Alban.
Acked-by: Iyappan Subramanian
This patch adds,
- probe, remove, shutdown
- open, close and stats
- create and delete ring
- request and delete irq
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
drivers/net/ethernet/apm/xgene-v2/main.c | 510 +++
1 file
This patch set adds support for RGMII based 1GbE hardware which uses a linked
list of DMA descriptor architecture (v2) for APM X-Gene SoCs.
Signed-off-by: Iyappan Subramanian
---
v2: Address review comments from v1
- moved create_desc_ring and delete_desc_ring to open() and close
This patch adds,
- Transmit
- Transmit completion poll
- Receive poll
- NAPI handler
and enables the driver.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
drivers/net/ethernet/apm/Kconfig | 1 +
drivers/net/ethernet/apm/Makefile | 1
This patch adds DMA descriptor setup and interrupt enable/disable
functions.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
drivers/net/ethernet/apm/xgene-v2/main.h | 74 +++
drivers/net/ethernet/apm/xgene-v2/ring.c | 81 +
drivers/net
This patch adds functions to configure and control mac. This
patch also adds helper functions to get/set registers.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
drivers/net/ethernet/apm/xgene-v2/mac.c | 116
drivers/net/ethernet/apm
This patch adds a MAINTAINERS entry for the ethernet driver for
the on-chip ethernet interface which uses a linked list of DMA
descriptor architecture (v2) for APM X-Gene SoCs.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
MAINTAINERS | 6 ++
1 file changed, 6
Hi Andrew,
On Tue, Jan 31, 2017 at 12:01 PM, Andrew Lunn wrote:
>> + phy_mode = device_get_phy_mode(dev);
>> + if (phy_mode < 0) {
>> + dev_err(dev, "Unable to get phy-connection-type\n");
>> + return phy_mode;
>> + }
>> + pdata->resources.phy_mode = phy_mo
Hi Florian,
On Tue, Jan 31, 2017 at 12:31 PM, Florian Fainelli wrote:
> On 01/31/2017 11:03 AM, Iyappan Subramanian wrote:
>> This patch adds,
>>
>> - probe, remove, shutdown
>> - open, close and stats
>> - create and delete ring
>> -
Hi Florian,
On Tue, Jan 31, 2017 at 12:33 PM, Florian Fainelli wrote:
> On 01/31/2017 11:03 AM, Iyappan Subramanian wrote:
>> This patch adds,
>> - Transmit
>> - Transmit completion poll
>> - Receive poll
>> - NAPI handler
>>
>>
This patch adds functions to configure ethernet hardware.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
drivers/net/ethernet/apm/xgene-v2/enet.c | 71
drivers/net/ethernet/apm/xgene-v2/enet.h | 43 +++
2 files changed, 114
On Wed, Feb 1, 2017 at 3:09 AM, David Laight wrote:
> From Florian Fainelli
>> Sent: 31 January 2017 20:33
>> On 01/31/2017 11:03 AM, Iyappan Subramanian wrote:
>> > This patch adds,
>> > - Transmit
>> > - Transmit completion poll
>&
s[i] = mss;
> mss_index = i;
> - mss_index_found = true;
> }
> }
>
> - /* No slots with ref_count = 0 available, return busy */
> - if (!mss_index_found)
> - mss_index = -EBUSY;
> -
> spin_unlock(&pdata->mss_lock);
>
> return mss_index;
> --
> 2.7.4
>
Thanks.
Acked-by: Iyappan Subramanian
This patch adds functions to configure ethernet hardware.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
drivers/net/ethernet/apm/xgene-v2/enet.c | 71
drivers/net/ethernet/apm/xgene-v2/enet.h | 43 +++
2 files changed, 114
This patch adds DMA descriptor setup and interrupt enable/disable
functions.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
drivers/net/ethernet/apm/xgene-v2/main.h | 88
drivers/net/ethernet/apm/xgene-v2/ring.c | 73
This patch adds functions to configure and control mac. This
patch also adds helper functions to get/set registers.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
drivers/net/ethernet/apm/xgene-v2/mac.c | 116
drivers/net/ethernet/apm/xgene-v2
This patch adds a MAINTAINERS entry for the ethernet driver for
the on-chip ethernet interface which uses a linked list of DMA
descriptor architecture (v2) for APM X-Gene SoCs.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
MAINTAINERS | 6 ++
1 file changed, 6
This patch adds,
- Transmit
- Transmit completion poll
- Receive poll
- NAPI handler
and enables the driver.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
drivers/net/ethernet/apm/Kconfig | 1 +
drivers/net/ethernet/apm/Makefile | 1
This patch adds,
- probe, remove, shutdown
- open, close and stats
- create and delete ring
- request and delete irq
Signed-off-by: Iyappan Subramanian
Signed-off-by: Keyur Chudgar
---
drivers/net/ethernet/apm/xgene-v2/main.c | 459 +++
1 file
This patch set adds support for RGMII based 1GbE hardware which uses a linked
list of DMA descriptor architecture (v2) for APM X-Gene SoCs.
Signed-off-by: Iyappan Subramanian
---
Iyappan Subramanian (6):
drivers: net: xgene-v2: Add DMA descriptor
drivers: net: xgene-v2: Add mac
On Thu, Dec 8, 2016 at 3:17 AM, Colin King wrote:
> From: Colin Ian King
>
> static analysis using cppcheck detected that slots was uninitialized.
> Fix this by initializing it to buf_pool->slots - 1
>
> Found using static analysis with CoverityScan, CID #1387620
>
> Fixes: a9380b0f7be818 ("drive
net/ethernet/apm/xgene/xgene_enet_main.c
> @@ -635,6 +635,7 @@ static void xgene_enet_free_pagepool(struct
> xgene_enet_desc_ring *buf_pool,
> return;
>
> dev = ndev_to_dev(buf_pool->ndev);
> + slots = buf_pool->slots - 1;
> head = buf_pool->head;
>
> for (i = 0; i < 4; i++) {
Thanks.
Acked-by: Iyappan Subramanian
This patch configures classifier with the pagepool information.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Quan Nguyen
---
drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 16 ++--
drivers/net/ethernet/apm/xgene/xgene_enet_cle.h | 2 ++
drivers/net/ethernet/apm/xgene
This patch fixes RSS feature, for non-TCP/UDP packets.
Signed-off-by: Khuong Dinh
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 90 -
drivers/net/ethernet/apm/xgene/xgene_enet_cle.h | 1 +
2 files changed, 89 insertions(+), 2
This patch adds flow control/pause frame initialization and
advertising capabilities.
Signed-off-by: Iyappan Subramanian
Signed-off-by: Quan Nguyen
---
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 57 +++
drivers/net/ethernet/apm/xgene/xgene_enet_hw.h| 7
1 - 100 of 289 matches
Mail list logo
