Re: [EXT] [PATCH v1] bnx2x: Fix NULL pointer dereference in bnx2x_del_all_vlans() on some hw

2018-12-24 Thread Ivan Mironov
On Mon, 2018-12-24 at 14:26 +, Sudarsana Reddy Kalluru wrote: > Thanks a lot for root-causing the issue and the patch. > Another (simpler) way to address this would be to invoke > bnx2x_del_all_vlans() only for the newer chips, e.g., > + if (!CHIP_IS_E1(bp)) { > /* Remove all curr

[PATCH v2] bnx2x: Fix NULL pointer dereference in bnx2x_del_all_vlans() on some hw

2018-12-24 Thread Ivan Mironov
in bnx2x_sp_objs.vlan_obj or not. This regression was introduced after v4.20-rc7, and still exists in v4.20 release. Fixes: 04f05230c5c13 ("bnx2x: Remove configured vlans as part of unload sequence.") Signed-off-by: Ivan Mironov --- v2: - As suggested by Sudarsana Reddy Kalluru, d

[PATCH v1] bnx2x: Fix NULL pointer dereference in bnx2x_del_all_vlans() on some hw

2018-12-24 Thread Ivan Mironov
in bnx2x_sp_objs.vlan_obj or not. This regression was introduced after v4.20-rc7, and still exists in v4.20 release. Fixes: 04f05230c5c13 ("bnx2x: Remove configured vlans as part of unload sequence.") Signed-off-by: Ivan Mironov --- v1: - Check for chip num instead of (vlan_obj->de

Re: [PATCH] bnx2x: Fix NULL pointer dereference in bnx2x_del_all_vlans() on some hw

2018-12-24 Thread Ivan Mironov
4.20 release is affected too. On Sun, 2018-12-23 at 20:29 +0500, Ivan Mironov wrote: > This happened when I tried to boot normal Fedora 29 system with latest > available kernel (from fedora rawhide, plus some unrelated custom > patches): > > BUG: unable to handle kern

[PATCH] bnx2x: Fix NULL pointer dereference in bnx2x_del_all_vlans() on some hw

2018-12-23 Thread Ivan Mironov
emove configured vlans as part of unload sequence.") Signed-off-by: Ivan Mironov --- .../net/ethernet/broadcom/bnx2x/bnx2x_main.c | 22 +-- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broa