[PATCH iproute2] json: fix backslash escape typo in jsonw_puts

2019-07-17 Thread Ivan Delalande
Fixes: fcc16c22 ("provide common json output formatter") Signed-off-by: Ivan Delalande --- lib/json_writer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/json_writer.c b/lib/json_writer.c index 5004c181..88c5eb88 100644 --- a/lib/json_writer.c +++ b/lib/jso

Re: [PATCH] ipv6: fix icmp6_send() route lookup

2019-02-11 Thread Ivan Delalande
different behaviors from our patches and Alin's? Or any other configuration interface than sysctls if more appropriate. Thank you, -- Ivan Delalande Arista Networks

[PATCH net-next] ipv6: raw: use IPv4 raw_sendmsg on v4-mapped IPv6 destinations

2018-01-24 Thread Ivan Delalande
Make IPv6 SOCK_RAW sockets operate like IPv6 UDP and TCP sockets with respect to IPv4 mapped addresses by calling IPv4 raw_sendmsg from rawv6_sendmsg to send those messages out. Signed-off-by: Travis Brown Signed-off-by: Ivan Delalande --- include/net/raw.h | 1 + net/ipv4/raw.c| 5

[PATCH iproute2 2/2] ss: print MD5 signature keys configured on TCP sockets

2017-10-06 Thread Ivan Delalande
These keys are reported by kernel 4.14 and later under the INET_DIAG_MD5SIG attribute, when INET_DIAG_INFO is requested (ss -i) and we have CAP_NET_ADMIN. The additional output looks like: md5keys:fe80::/64=signing_key,10.1.2.0/24=foobar,::1/128=Test Signed-off-by: Ivan Delalande

[PATCH iproute2 1/2] utils: add print_escape_buf to format and print arbitrary bytes

2017-10-06 Thread Ivan Delalande
Keep it as simple as possible for now: just escape anything that is not isprint-able, is among the "escape" parameter or '\' as an octal escape sequence. This should be pretty easy to extend if any other user needs something more complex in the future. Signed-off-by: Ivan Del

Re: [PATCH net-next v5 2/2] tcp_diag: report TCP MD5 signing keys and addresses

2017-08-31 Thread Ivan Delalande
On Fri, Sep 01, 2017 at 01:26:33AM +0200, Sabrina Dubroca wrote: > 2017-08-31, 09:59:39 -0700, Ivan Delalande wrote: > > diff --git a/net/ipv4/tcp_diag.c b/net/ipv4/tcp_diag.c > > index a748c74aa8b7..abbf0edcf6c2 100644 > > --- a/net/ipv4/tcp_diag.c > >

[PATCH net-next v5 1/2] inet_diag: allow protocols to provide additional data

2017-08-31 Thread Ivan Delalande
Extend inet_diag_handler to allow individual protocols to report additional data on INET_DIAG_INFO through idiag_get_aux. The size can be dynamic and is computed by idiag_get_aux_size. Signed-off-by: Ivan Delalande --- include/linux/inet_diag.h | 7 +++ net/ipv4/inet_diag.c | 22

[PATCH net-next v5 0/2] report TCP MD5 signing keys and addresses

2017-08-31 Thread Ivan Delalande
lanning to polish and send it if this series gets applied. Ivan Delalande (2): inet_diag: allow protocols to provide additional data tcp_diag: report TCP MD5 signing keys and addresses include/linux/inet_diag.h | 7 +++ include/uapi/linux/inet_diag.h | 1 + include/uapi/linux/tcp.h

[PATCH net-next v5 2/2] tcp_diag: report TCP MD5 signing keys and addresses

2017-08-31 Thread Ivan Delalande
Report TCP MD5 (RFC2385) signing keys, addresses and address prefixes to processes with CAP_NET_ADMIN requesting INET_DIAG_INFO. Currently it is not possible to retrieve these from the kernel once they have been configured on sockets. Signed-off-by: Ivan Delalande --- include/uapi/linux

[PATCH net-next v4 2/2] tcp_diag: report TCP MD5 signing keys and addresses

2017-08-30 Thread Ivan Delalande
Report TCP MD5 (RFC2385) signing keys, addresses and address prefixes to processes with CAP_NET_ADMIN requesting INET_DIAG_INFO. Currently it is not possible to retrieve these from the kernel once they have been configured on sockets. Signed-off-by: Ivan Delalande --- include/uapi/linux

[PATCH net-next v4 1/2] inet_diag: allow protocols to provide additional data

2017-08-30 Thread Ivan Delalande
Extend inet_diag_handler to allow individual protocols to report additional data on INET_DIAG_INFO through idiag_get_aux. The size can be dynamic and is computed by idiag_get_aux_size. Signed-off-by: Ivan Delalande --- include/linux/inet_diag.h | 7 +++ net/ipv4/inet_diag.c | 22

[PATCH net-next v4 0/2] report TCP MD5 signing keys and addresses

2017-08-30 Thread Ivan Delalande
ta on INET_DIAG_INFO, - lock socket before calling tcp_diag_put_md5sig. I also have a patch for iproute2/ss to test this change, making it print this new attribute. I'm planning to polish and send it if this series gets applied. Ivan Delalande (2): inet_diag: allow protocols to provide addit

[PATCH net-next v3 0/2] report TCP MD5 signing keys and addresses

2017-08-29 Thread Ivan Delalande
ocols to provide additional data on INET_DIAG_INFO, - lock socket before calling tcp_diag_put_md5sig. I also have a patch for iproute2/ss to test this change, making it print this new attribute. I'm planning to polish and send it if this series gets applied. Ivan Delalande (2): inet_d

[PATCH net-next v3 2/2] tcp_diag: report TCP MD5 signing keys and addresses

2017-08-29 Thread Ivan Delalande
Report TCP MD5 (RFC2385) signing keys, addresses and address prefixes to processes with CAP_NET_ADMIN requesting INET_DIAG_INFO. Currently it is not possible to retrieve these from the kernel once they have been configured on sockets. Signed-off-by: Ivan Delalande --- include/uapi/linux

[PATCH net-next v3 1/2] inet_diag: allow protocols to provide additional data

2017-08-29 Thread Ivan Delalande
Extend inet_diag_handler to allow individual protocols to report additional data on INET_DIAG_INFO through idiag_get_aux. The size can be dynamic and is computed by idiag_get_aux_size. Signed-off-by: Ivan Delalande --- include/linux/inet_diag.h | 7 +++ net/ipv4/inet_diag.c | 22

Re: [PATCH net-next v2 2/2] tcp_diag: report TCP MD5 signing keys and addresses

2017-08-25 Thread Ivan Delalande
On Fri, Aug 25, 2017 at 08:41:25PM -0700, Eric Dumazet wrote: > On Fri, 2017-08-25 at 18:53 -0700, Ivan Delalande wrote: > > Report TCP MD5 (RFC2385) signing keys, addresses and address prefixes to > > processes with CAP_NET_ADMIN requesting INET_DIAG_INFO. Currently it is >

[PATCH net-next v2 1/2] inet_diag: allow protocols to provide additional data

2017-08-25 Thread Ivan Delalande
Extend inet_diag_handler to allow individual protocols to report additional data on INET_DIAG_INFO through idiag_get_aux. The size can be dynamic and is computed by idiag_get_aux_size. Signed-off-by: Ivan Delalande --- include/linux/inet_diag.h | 7 +++ net/ipv4/inet_diag.c | 22

[PATCH net-next v2 2/2] tcp_diag: report TCP MD5 signing keys and addresses

2017-08-25 Thread Ivan Delalande
Report TCP MD5 (RFC2385) signing keys, addresses and address prefixes to processes with CAP_NET_ADMIN requesting INET_DIAG_INFO. Currently it is not possible to retrieve these from the kernel once they have been configured on sockets. Signed-off-by: Ivan Delalande --- include/uapi/linux

[PATCH net-next] inet_diag: report TCP MD5 signing keys and addresses

2017-08-23 Thread Ivan Delalande
Report TCP MD5 (RFC2385) signing keys, addresses and address prefixes to processes with CAP_NET_ADMIN requesting INET_DIAG_INFO. Currently it is not possible to retrieve these from the kernel once they have been configured on sockets. Signed-off-by: Ivan Delalande --- include/uapi/linux

[PATCH 1/2] tcp: add mode parameter to tcp_proc_register

2017-06-22 Thread Ivan Delalande
This will be used to create a proc file that regular users cannot read. Signed-off-by: Ivan Delalande --- include/net/tcp.h | 3 ++- net/ipv4/tcp_ipv4.c | 7 --- net/ipv6/tcp_ipv6.c | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/include/net/tcp.h b/include/net

[PATCH 2/2] tcp: md5: export all configured signature keys in /proc/net

2017-06-22 Thread Ivan Delalande
ts inode number, the address, prefix length and the key itself. Note that IPv4-mapped IPv6 addresses will be printed as a regular IPv4 address in the tcp6md5 file. Signed-off-by: Ani Sinha Signed-off-by: Ken Kofman Signed-off-by: Ivan Delalande --- Documentation/filesystems/proc.txt | 2 +

[PATCH v3 1/2] tcp: md5: add an address prefix for key lookup

2017-06-15 Thread Ivan Delalande
This allows the keys used for TCP MD5 signature to be used for whole range of addresses, specified with a prefix length, instead of only one address as it currently is. Signed-off-by: Bob Gilligan Signed-off-by: Eric Mowat Signed-off-by: Ivan Delalande --- include/net/tcp.h | 6 +++-- net

[PATCH v3 2/2] tcp: md5: add TCP_MD5SIG_EXT socket option to set a key address prefix

2017-06-15 Thread Ivan Delalande
tcpm_prefixlen only when the TCP_MD5SIG_FLAG_PREFIX flag is set. Signed-off-by: Bob Gilligan Signed-off-by: Eric Mowat Signed-off-by: Ivan Delalande --- include/net/tcp.h| 1 + include/uapi/linux/tcp.h | 9 +++-- net/ipv4/tcp.c | 3 ++- net/ipv4/tcp_ipv4.c | 16

Re: [PATCH v2 2/2] tcp: md5: extend the tcp_md5sig struct to specify a key address prefix

2017-06-12 Thread Ivan Delalande
On Sat, Jun 10, 2017 at 06:58:11PM -0400, David Miller wrote: > From: Ivan Delalande > Date: Fri, 9 Jun 2017 19:14:49 -0700 > > > Add a flag field and address prefix length at the end of the tcp_md5sig > > structure so users can configure an address prefix length along with

[PATCH v2 2/2] tcp: md5: extend the tcp_md5sig struct to specify a key address prefix

2017-06-09 Thread Ivan Delalande
-by: Bob Gilligan Signed-off-by: Eric Mowat Signed-off-by: Ivan Delalande --- include/uapi/linux/tcp.h | 8 net/ipv4/tcp_ipv4.c | 15 +++ net/ipv6/tcp_ipv6.c | 24 +--- 3 files changed, 36 insertions(+), 11 deletions(-) diff --git a/include

[PATCH v2 1/2] tcp: md5: add an address prefix for key lookup

2017-06-09 Thread Ivan Delalande
This allows the keys used for TCP MD5 signature to be used for whole range of addresses, specified with a prefix length, instead of only one address as it currently is. Signed-off-by: Bob Gilligan Signed-off-by: Eric Mowat Signed-off-by: Ivan Delalande --- include/net/tcp.h | 6 +++-- net

Re: [PATCH 2/2] tcp: md5: add fields to the tcp_md5sig struct to set a key address prefix

2017-06-06 Thread Ivan Delalande
On Tue, Jun 06, 2017 at 09:08:22PM -0700, Eric Dumazet wrote: > On Tue, 2017-06-06 at 17:54 -0700, Ivan Delalande wrote: >> diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h >> index 38a2b07afdff..52ac30aa0652 100644 >> --- a/include/uapi/linux/tcp.h >&g

[PATCH 1/2] tcp: md5: add an address prefix for key lookup

2017-06-06 Thread Ivan Delalande
This allows the keys used for TCP MD5 signature to be used for whole range of addresses, specified with a prefix length, instead of only one address as it currently is. Signed-off-by: Bob Gilligan Signed-off-by: Eric Mowat Signed-off-by: Ivan Delalande --- include/net/tcp.h | 6 +++-- net

[PATCH 2/2] tcp: md5: add fields to the tcp_md5sig struct to set a key address prefix

2017-06-06 Thread Ivan Delalande
Replace padding in the socket option structure tcp_md5sig with a new flag field and address prefix length so it can be specified when configuring a new key with the TCP_MD5SIG socket option. Signed-off-by: Bob Gilligan Signed-off-by: Eric Mowat Signed-off-by: Ivan Delalande --- include/uapi