On Sat, Dec 3, 2016 at 1:24 AM, Eric Dumazet wrote:
> On Fri, 2016-12-02 at 15:18 -0800, Stephen Hemminger wrote:
>> name[i] = '@';
>> >
>> > ss.c: In function 'unix_show_sock':
>> > ss.c:3128:4: error: 'for' loop initial declarations are only allowed in
>> > C
Hi David, thanks for looking at it.
On Mon, Oct 31, 2016 at 9:31 PM, David Miller wrote:
> From: Isaac Boukris
> Date: Sat, 29 Oct 2016 22:20:20 +0300
>
>> Abstract unix domain socket may embed null characters,
>> these should be translated to '@' when printed
tes of the name (instead of getting cut at the first
null occurrence).
Signed-off-by: Isaac Boukris
---
net/unix/af_unix.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
index 145082e..5d1c14a 100644
--- a/net/unix/af_unix.c
+++
On Thu, Oct 27, 2016 at 1:22 AM, Stephen Hemminger
wrote:
> Just translating all null characters to @ seems the most consistent and
> logical. Also translating other all non-printing characters to something
> (maybe '?')
> might be wise. It would be nice if all utilities output the same thing.
I
tes of the name (instead of getting cut at the first
null occurrence).
Signed-off-by: Isaac Boukris
---
net/unix/af_unix.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
index 145082e..9250b03 100644
--- a/net/unix/af_un
Abstract unix domain socket may embed null characters,
these should be translated to '@' when printed by ss the
same way the null prefix is currently being translated.
Signed-off-by: Isaac Boukris
---
misc/ss.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/m
Hi Stephen, thanks for looking into this.
On Wed, Oct 26, 2016 at 8:15 PM, Stephen Hemminger
wrote:
> On Tue, 18 Oct 2016 21:46:48 +0300
> Isaac Boukris wrote:
>
>> Hi again,
>>
>> On Sun, Oct 16, 2016 at 11:43 PM, Isaac Boukris wrote:
>> > Hello,
>>
Hi again,
On Sun, Oct 16, 2016 at 11:43 PM, Isaac Boukris wrote:
> Hello,
>
> The unix(7) man page says that null have no special meaning in
> abstract unix domain socket address (the length is specified
> therefore).
>
> However, when such name (embedding null) is used, ss
Hello,
The unix(7) man page says that null have no special meaning in
abstract unix domain socket address (the length is specified
therefore).
However, when such name (embedding null) is used, ss (and netstat)
will only show up to the first null occurrence (second technically, if
we count the nul
