separately the error case for unsupported
statistics pages
Ioana Radulescu (3):
dpaa2-eth: Minor refactoring in ethtool stats
dpaa2-eth: Add new DPNI statistics counters
dpaa2-eth: Poll Tx pending frames counter on if down
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 31
As we prepare to read more pages from the DPNI stat counters,
reorganize the code a bit to make it easier to extend.
Signed-off-by: Ioana Radulescu
---
v2: no changes
drivers/net/ethernet/freescale/dpaa2/dpaa2-ethtool.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions
Starting with firmware version MC10.18.0, a new counter for in flight
Tx frames is offered. Use it when bringing down the interface to
determine when all pending Tx frames have been processed by hardware
instead of sleeping a fixed amount of time.
Signed-off-by: Ioana Radulescu
---
v2: no
Recent firmware versions expose more DPNI counters.
Export relevant ones via ethtool -S.
Signed-off-by: Ioana Radulescu
---
v2: treat separately error case for unsupported statistics pages
.../net/ethernet/freescale/dpaa2/dpaa2-ethtool.c | 19 --
drivers/net/ethernet/freescale/dpaa2
Recent firmware versions offer access to more DPNI statistics
counters. Add the relevant ones to ethtool interface stats.
Also we can now make use of a new counter for in flight egress frames
to avoid sleeping an arbitrary amount of time in the ndo_stop routine.
Ioana Radulescu (3):
dpaa2-eth
Recent firmware versions expose more DPNI counters.
Export relevant ones via ethtool -S.
Signed-off-by: Ioana Radulescu
---
.../net/ethernet/freescale/dpaa2/dpaa2-ethtool.c | 21 ++--
drivers/net/ethernet/freescale/dpaa2/dpni.c| 2 +-
drivers/net/ethernet/freescale/dpaa2
Starting with firmware version MC10.18.0, a new counter for in flight
Tx frames is offered. Use it when bringing down the interface to
determine when all pending Tx frames have been processed by hardware
instead of sleeping a fixed amount of time.
Signed-off-by: Ioana Radulescu
---
drivers/net
As we prepare to read more pages from the DPNI stat counters,
reorganize the code a bit to make it easier to extend.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-ethtool.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a
Whenever a link state change occurs, we get notified and save
the new link settings in the device's private data. In ethtool
get_link_ksettings, use the stored state instead of interrogating
the firmware each time.
Signed-off-by: Ioana Radulescu
Reviewed-by: Andrew Lunn
---
v2: split from
We only support fixed-link for now, so there is no point in
offering users the option to change link settings via ethtool.
Functionally there is no change, since firmware prevents us from
changing link parameters anyway.
Signed-off-by: Ioana Radulescu
Reviewed-by: Andrew Lunn
---
v2: new patch
igned-off-by: Ioana Radulescu
Reviewed-by: Andrew Lunn
---
v2: split priv->link_state changes in a separate patch
always set pause->autoneg to false
return -EOPNOTSUPP if user tries to set pause->autoneg
v3: add comment in code and improve commit message to clarify how
the PAUSE
Whenever a link state change occurs, we get notified and save
the new link settings in the device's private data. In ethtool
get_link_ksettings, use the stored state instead of interrogating
the firmware each time.
Signed-off-by: Ioana Radulescu
---
v2: split from main pause frames
We only support fixed-link for now, so there is no point in
offering users the option to change link settings via ethtool.
Functionally there is no change, since firmware prevents us from
changing link parameters anyway.
Signed-off-by: Ioana Radulescu
---
v2: new patch
.../net/ethernet
ingress
frames can't keep up with the Rx rate; for large frames, the number
of buffers in the pool may never get low enough to trigger pause
frames as long as taildrop is enabled). So we set pause frame
generation and Rx FQ taildrop as mutually exclusive.
Signed-off-by: Ioana Radulescu
-
r and we only interrogate the firmware when we receive
a notification that something (flow control or other link options)
has changed.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 85 +++---
drivers/net/ethernet/freescale/dpaa2/dpaa2-
.
Signed-off-by: Ioana Radulescu
Signed-off-by: Vladimir Oltean
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 15 ++-
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h | 51
2 files changed, 65 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet
priority information
received from the stack is used to select the hardware Tx queue
on which to enqueue the frame.
Signed-off-by: Ioana Radulescu
Signed-off-by: Bogdan Purcareata
---
v2: no changes
v3: move Tx fastpath code changes to this patch, to make it
more clear how skb queue mapping is used for
Add support for adding multiple TX traffic classes with mqprio. We can have
up to one netdev queue and hardware frame queue per TC per core.
Ioana Radulescu (3):
dpaa2-eth: Refactor xps code
dpaa2-eth: Support multiple traffic classes on Tx
dpaa2-eth: Add mqprio support
drivers/net
: Ioana Radulescu
---
v3: move code changes on the Tx fastpath to patch 3/3
v2: Extra processing on the fast path happens only when TC is used
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 23 +--
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h | 7 ++-
2 files changed
Move the code configuring xps on the netdev TX queues to a
separate function. A subsequent patch will need to call
this in another context as well.
Signed-off-by: Ioana Radulescu
---
v2: no changes
v3: no changes
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 45 +---
1
assigns num_queues
to each traffic class, for a total of num_queues x num_tcs
hardware frame queues.
Signed-off-by: Ioana Radulescu
Signed-off-by: Bogdan Purcareata
---
v2: no changes
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 43
1 file changed, 43 insertions
Add support for adding multiple TX traffic classes with mqprio. We can have
up to one netdev queue and hardware frame queue per TC per core.
Ioana Radulescu (3):
dpaa2-eth: Refactor xps code
dpaa2-eth: Support multiple traffic classes on Tx
dpaa2-eth: Add mqprio support
drivers/net
Move the code configuring xps on the netdev TX queues to a
separate function. A subsequent patch will need to call
this in another context as well.
Signed-off-by: Ioana Radulescu
---
v2: no changes
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 45 +---
1 file changed
on which to enqueue the frame.
Signed-off-by: Ioana Radulescu
---
v2: Extra processing on the fast path happens only when TC is used
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 47
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h | 9 -
2 files changed, 40
on which to enqueue the frame.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 47
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h | 9 -
2 files changed, 40 insertions(+), 16 deletions(-)
diff --git a/drivers/net/ethernet
Move the code configuring xps on the netdev TX queues to a
separate function. A subsequent patch will need to call
this in another context as well.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 45 +---
1 file changed, 32 insertions
Add support for adding multiple TX traffic classes with mqprio. We have
one netdev queue and one hardware frame queue per TC.
Ioana Radulescu (3):
dpaa2-eth: Refactor xps code
dpaa2-eth: Support multiple traffic classes on Tx
dpaa2-eth: Add mqprio support
drivers/net/ethernet/freescale
assigns num_queues
to each traffic class, for a total of num_queues x num_tcs
hardware frame queues.
Signed-off-by: Ioana Radulescu
Signed-off-by: Bogdan Purcareata
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 43
1 file changed, 43 insertions(+)
diff --git a
Fix a couple of warnings reported by smatch.
Ioana Radulescu (3):
dpaa2-eth: Fix potential spectre issue
dpaa2-eth: Use PTR_ERR_OR_ZERO where appropriate
dpaa2-eth: Make constant 64-bit long
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 4 ++--
drivers/net/ethernet/freescale
Use PTR_ERR_OR_ZERO instead of PTR_ERR in cases where
zero is a valid input. Reported by smatch.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2
Function dpaa2_eth_cls_key_size() expects a 64bit argument,
but DPAA2_ETH_DIST_ALL is defined as UINT_MAX. Fix this.
Signed-off-by: Ioana Radulescu
Reported-by: Dan Carpenter
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Smatch reports a potential spectre vulnerability in the dpaa2-eth
driver, where the value of rxnfc->fs.location (which is provided
from user-space) is used as index in an array.
Add a call to array_index_nospec() to sanitize the access.
Signed-off-by: Ioana Radulescu
---
drivers/net/ether
aised.
Unfortunately there is no easy way to work around this while keeping
the performance advantages brought by QMan stashing, so disable
it altogether.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --
be processed.
Discarding the frame is also supported.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 44 +++
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h | 11 +
.../net/ethernet/freescale/dpaa2/dpaa2-ethtool.c | 331 +
drivers
, we will just mask out the unused header fields.
Since the key composition process is the same for flow
classification and hashing, reuse existing code where possible.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 99
drivers/net
e new firmware API for key config. Subsequent patches introduce
the firmware API for configuring the classification and actual
support for adding and deleting rules via ethtool.
Ioana Radulescu (4):
dpaa2-eth: Use new API for Rx flow hashing
dpaa2-eth: Rename structure
dpaa2-eth: Configure Rx
Since the array of supported header fields will be used for
Rx flow classification as well, rename it from "hash_fields" to
the more inclusive "dist_fields".
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 12 ++--
drivers/ne
of APIs for separate configuration of Rx hashing and
classification keys.
Update the Rx flow hashing support to use the new API, if available.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 73 ++--
drivers/net/ethernet/freescale/dpaa2
Error message was referencing wrong function, fix it.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
index 0d54564e
39 matches
Mail list logo