Re: [PATCH] tcp_input: move out condition check from tcp_data_queue()

2017-08-06 Thread Ilya Matveychikov
> On Aug 6, 2017, at 9:07 PM, Eric Dumazet wrote: > > On Sun, 2017-08-06 at 13:51 +0400, Ilya Matveychikov wrote: >> As tcp_data_queue() function is used just only twice it's better >> to move out the first check and wrap it with inline. It saves a >> single call

[PATCH] tcp_input: move out condition check from tcp_data_queue()

2017-08-06 Thread Ilya Matveychikov
As tcp_data_queue() function is used just only twice it's better to move out the first check and wrap it with inline. It saves a single call in case the condition evaluated as true. Signed-off-by: Ilya V. Matveychikov --- net/ipv4/tcp_input.c | 14 +- 1 file changed, 9 insertions(+),

[PATCH] tcp: remove redundant argument from tcp_rcv_established()

2017-07-24 Thread Ilya Matveychikov
The last (4th) argument of tcp_rcv_established() is redundant as it always equals to skb->len and the skb itself is always passed as 2th agrument. There is no reason to have it. Signed-off-by: Ilya V. Matveychikov --- include/net/tcp.h| 2 +- net/ipv4/tcp_input.c | 3 ++- net/ipv4/tcp_ipv4.c

Re: A couple of questions about the SKB fragments

2016-05-07 Thread Ilya Matveychikov
2016-05-05 14:13 GMT+03:00 Edward Cree : > On 05/05/16 08:40, Ilya Matveychikov wrote: > > Is there any docs except the kernel sources itself to refer to? > davem has some docs up at http://vger.kernel.org/~davem/skb.html and > http://vger.kernel.org/~davem/skb_data.html > In p

A couple of questions about the SKB fragments

2016-05-05 Thread Ilya Matveychikov
Hello folks, While working with fragmented SKBs we've got stuck with the following: - is it possible for an SKB fragment in skb_shinfo(skb)->frag_list to be fragmented too (i.e. to have SKBs in frag_list)? - do skb->len and skb->data_len contain the whole SKB length, including the length of all fr