[PATCH nf-next 5/6] netfilter-ipv4: code indentation

Use tabs instead of spaces to indent code. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv4/netfilter/ip_tables.c| 6 +++--- net/ipv4/netfilter/ipt_SYNPROXY.c | 2 +- net/ipv4/netfilter/iptable_security.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions

[PATCH nf-next 4/6] netfilter-ipv4: function definition layout

Use tabs instead of spaces to indent second line of parameters in function definitions. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv4/netfilter/arp_tables.c | 6 +++--- net/ipv4/netfilter/ip_tables.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff

[PATCH nf-next 6/6] netfilter-ipv4: whitespace around operators

This patch cleanses whitespace around arithmetical operators. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv4/netfilter/ipt_CLUSTERIP.c | 8 net/ipv4/netfilter/ipt_ah.c| 2 +- net/ipv4/netfilter/nf_nat_snmp_basic.c | 2 +- 3 files changed, 6

[PATCH nf-next 0/6] coding style improvements: netfilter-ipv4

This series of patches improves the coding style of the netfilter-ipv4 code by addressing some issues detected by checkpatch. The changes were previously submitted as part of a larger monolithic patch but on advice from Pablo, these are being re-sent in smaller, more structured batches. Ian

[PATCH nf-next 2/6] netfilter-ipv4: label placement

Whitespace cleansing: Labels should not be indented. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv4/netfilter/arp_tables.c | 2 +- net/ipv4/netfilter/ip_tables.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/netfilter/arp_tables.c b

[PATCH nf-next 1/6] netfilter-ipv4: Line layout whitespace fixes

Cleanses some whitespace issues by removing a leading space before a tab. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv4/netfilter/ipt_ECN.c | 2 +- net/ipv4/netfilter/nf_nat_pptp.c | 2 +- net/ipv4/netfilter/nf_nat_snmp_basic.c | 2 +- 3 files changed

[PATCH nf-next 3/6] netfilter-ipv4: ternary operator layout

Correct whitespace layout of ternary operators in the netfilter-ipv4 code. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv4/netfilter/arp_tables.c | 4 ++-- net/ipv4/netfilter/ip_tables.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/net/ipv4

[PATCH nf-next 0/7] coding style improvements for netfilter

This series of patches improves the coding style of the netfilter-ipv6 code by addressing some issues detected by checkpatch. The changes were previously submitted as part of a larger monolithic patch but on advice from Pablo, these are being re-sent in smaller, more structured batches. Ian

[PATCH nf-next 1/7] netfilter-ipv6: label placement

Whitespace cleansing: Labels should not be indented. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv6/netfilter/ip6_tables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c index 80e3bd7

[PATCH nf-next 3/7] netfilter-ipv6: code indentation

Use tabs instead of spaces to indent code. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv6/netfilter/ip6_tables.c | 4 ++-- net/ipv6/netfilter/ip6t_SYNPROXY.c| 2 +- net/ipv6/netfilter/nft_chain_route_ipv6.c | 6 +++--- 3 files changed, 6 insertions

[PATCH nf-next 4/7] netfilter-ipv6: whitespace around operators

This patch cleanses whitespace around arithmetical operators. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c | 4 ++-- net/ipv6/netfilter/nf_conntrack_reasm.c| 2 +- net/ipv6/netfilter/nf_reject_ipv6.c| 4 ++-- 3

[PATCH nf-next 6/7] netfilter-ipv6: improve if statements

Correct whitespace layout of if statements. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv6/netfilter/ip6_tables.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c index 80f014a

[PATCH nf-next 7/7] netfilter-ipv6: pointer cast layout

Correct whitespace layout of a pointer casting. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv6/netfilter/nf_conntrack_reasm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c b/net/ipv6/netfilter

[PATCH nf-next 5/7] netfilter-ipv6: ternary operator layout

Correct whitespace layout of ternary operators in the netfilter-ipv6 code. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv6/netfilter/ip6_tables.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter

[PATCH nf-next 2/7] netfilter-ipv6: function definition layout

Use tabs instead of spaces to indent second line of parameters in function definitions. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv6/netfilter/ip6_tables.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/ipv6/netfilter/ip6_tables.c b/net

Re: [PATCH nf-next] netfilter: Line layout whitespace fixes

On 30/09/15 23:17, Pablo Neira Ayuso wrote: On Thu, Sep 24, 2015 at 11:10:06AM +0100, Ian Morris wrote: Fixes various whitespace issues detected by checkpatch (e.g. adding spaces between operations, replacing spaces with tabs, etc) No changes detected by objdiff. These large cleanup patch

[PATCH nf-next] netfilter: Line layout whitespace fixes

Fixes various whitespace issues detected by checkpatch (e.g. adding spaces between operations, replacing spaces with tabs, etc) No changes detected by objdiff. Signed-off-by: Ian Morris --- net/bridge/netfilter/ebt_among.c | 2 +- net/ipv4/netfilter/arp_tables.c

[PATCH net-next] ipv6: remove unnecessary include

printk.h does not need to be explicitly included as we include kernel.h which already called it. Signed-off-by: Ian Morris --- net/ipv6/ip6_offload.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/ipv6/ip6_offload.c b/net/ipv6/ip6_offload.c index 08b6204..1cb2dc7 100644 --- a/net/ipv6

[PATCH net-next] ipv6: trivial whitespace fix

Change brace placement to be in line with coding standards Signed-off-by: Ian Morris --- net/ipv6/udp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c index e51fc3e..0aba654 100644 --- a/net/ipv6/udp.c +++ b/net/ipv6/udp.c @@ -1496,7

[PATCH net-next 2/6] ipv6: netfilter: whitespace in line layouts

Try to improve coding readability by adding spaces in line layouts. No changes to functionality. No changes according to objdiff. Signed-off-by: Ian Morris --- net/ipv6/netfilter/ip6_tables.c| 12 ++-- net/ipv6/netfilter/ip6t_rpfilter.c | 2 +- net/ipv6

[PATCH net-next 0/6] ipv6: netfilter - coding style improvements

This series of patches removes some style issues in the ipv6 netfilter code detected by checkpatch. There is no change to functionality and no changes to the resultant object determined by objdiff. Ian Morris (6): ipv6: netfilter: Tidy up indenting ipv6: netfilter: whitespace in line layouts

[PATCH net-next 1/6] ipv6: netfilter: Tidy up indenting

This patch cleanses some indent issues in the ipv6 netfilter code by converting spaces to tabs etc. No changes to functionality. No changes according to objdiff. Signed-off-by: Ian Morris --- net/ipv6/netfilter/ip6_tables.c | 12 ++-- net/ipv6/netfilter/nft_chain_route_ipv6.c

[PATCH net-next 3/6] ipv6: netfilter: remove unnecessary braces

Remove braces from a few if statements where not required. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv6/netfilter/ip6_tables.c | 3 +-- net/ipv6/netfilter/nf_conntrack_reasm.c | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/net/ipv6

[PATCH net-next 4/6] ipv6: netfilter: comparison for equality with NULL

The code uses a mixture of coding styles. In some instances check for NULL pointer is done as x == NULL and sometimes as !x. !x is preferred according to checkpatch and this patch makes the code consistent by adopting the latter form. No changes detected by objdiff. Signed-off-by: Ian Morris

[PATCH net-next 6/6] ipv6: netfilter: simply if-else statements

Remove "else" branch of "if" statements where a return is always done when the condition is true. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv6/netfilter/ip6_tables.c| 7 +- net/ipv6/netfilter/ip6t_hbh.c

[PATCH net-next 5/6] ipv6: netfilter: comparison for inequality with NULL

The code uses a mixture of coding styles. In some instances check for NULL pointer is done as x != NULL and sometimes as x. x is preferred according to checkpatch and this patch makes the code consistent by adopting the latter form. No changes detected by objdiff. Signed-off-by: Ian Morris