Re: FW: [PATCH net-next v3 4/4] bonding: support hardware encryption offload to slaves

2020-06-23 Thread Huy Nguyen
+#ifdef CONFIG_XFRM_OFFLOAD + struct xfrm_state *xs; We must support more than one SA right?

Re: [PATCH] xfrm: Fix double ESP trailer insertion in IPsec crypto offload

2020-06-01 Thread Huy Nguyen
PSB On 5/22/2020 7:25 PM, Saeed Mahameed wrote: On Thu, 2020-05-21 at 16:49 -0500, Huy Nguyen wrote: During IPsec performance testing, we see bad ICMP checksum. The issue is that the error packet that has duplicated ESP trailer. For example, this below ping reply skb is collected at mlx5e_xmit

[PATCH] xfrm: Fix double ESP trailer insertion in IPsec crypto offload.

2020-06-01 Thread Huy Nguyen
on to validate_xmit_skb") Signed-off-by: Huy Nguyen Reviewed-by: Boris Pismenny Reviewed-by: Raed Salem Reviewed-by: Saeed Mahameed --- include/net/xfrm.h | 1 + net/xfrm/xfrm_device.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/include/net/xfrm.h b/include/

[PATCH] xfrm: Fix double ESP trailer insertion in IPsec crypto offload

2020-05-21 Thread Huy Nguyen
on to validate_xmit_skb") Change-Id: I2bc1a189b8160cd90b66b44212b4d44bbdebcaea Signed-off-by: Huy Nguyen Reviewed-by: Boris Pismenny Reviewed-by: Raed Salem --- include/net/xfrm.h | 1 + net/xfrm/xfrm_device.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/i

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-24 Thread Huy Nguyen
On 5/23/2018 11:03 AM, John Fastabend wrote: On 05/23/2018 08:37 AM, Huy Nguyen wrote: On 5/23/2018 8:52 AM, John Fastabend wrote: It would be nice though if the API gave us some hint on max/min/stride of allowed values. Could the get API return these along with current value? Presumably the

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-24 Thread Huy Nguyen
On 5/23/2018 3:19 PM, Jakub Kicinski wrote: On Mon, 21 May 2018 14:04:57 -0700, Saeed Mahameed wrote: diff --git a/include/uapi/linux/dcbnl.h b/include/uapi/linux/dcbnl.h index 2c0c6453c3f4..1ddc0a44c172 100644 --- a/include/uapi/linux/dcbnl.h +++ b/include/uapi/linux/dcbnl.h @@ -163,6 +163,15

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-23 Thread Huy Nguyen
On 5/23/2018 8:52 AM, John Fastabend wrote: It would be nice though if the API gave us some hint on max/min/stride of allowed values. Could the get API return these along with current value? Presumably the allowed max size could change with devlink buffer changes in how the global buffer is div

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-23 Thread Huy Nguyen
On 5/23/2018 4:23 AM, Jakub Kicinski wrote: >From patch description it seems like your default setup is shared buffer split 50% (lossy)/50% (all prios) and the example you give changes that to 25% (lossy)/25%x3 prio groups. With existing devlink API could this be modelled by three ingress pool

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-23 Thread Huy Nguyen
I hope that is not true, since we (Netronome) are trying to use it for NIC configuration, too. We should generalize the API if need be. Yes, it is up to your company. devlink is static tool. DCBNL are intended to be dynamically configured by switch. In real world, not many people configure NIC'

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-22 Thread Huy Nguyen
Dear Jakub, PSB. On 5/22/2018 1:32 PM, Jakub Kicinski wrote: On Tue, 22 May 2018 10:36:17 -0500, Huy Nguyen wrote: On 5/22/2018 12:20 AM, Jakub Kicinski wrote: On Mon, 21 May 2018 14:04:57 -0700, Saeed Mahameed wrote: From: Huy Nguyen In this patch, we add dcbnl buffer attribute to allow

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-22 Thread Huy Nguyen
On 5/22/2018 12:20 AM, Jakub Kicinski wrote: On Mon, 21 May 2018 14:04:57 -0700, Saeed Mahameed wrote: From: Huy Nguyen In this patch, we add dcbnl buffer attribute to allow user change the NIC's buffer configuration such as priority to buffer mapping and buffer size of individual b

Re: [PATCH net-next 3/6] net/mlx5: Add DCBX firmware commands support

2016-09-01 Thread Huy Nguyen
t 7:29 PM, Saeed Mahameed wrote: >> From: Huy Nguyen >> >> Add set/query commands for DCBX_PARAM register >> >> Signed-off-by: Huy Nguyen >> Signed-off-by: Saeed Mahameed >> --- >> drivers/net/ethernet/mellanox/mlx5/core/port.c | 22 +