To avoid code duplication, tipc should be converted to use the helper
functions for working with libmnl in lib/mnl_utils.c
Acked-by: Jon Maloy
Signed-off-by: Hoang Le
---
tipc/bearer.c| 38 ++
tipc/cmdl.c | 2 -
tipc/link.c | 37 +
tipc/media.c
"tipc: refactor function tipc_enable_bearer()")
Cc: sta...@vger.kernel.org
Acked-by: Jon Maloy
Signed-off-by: Hoang Le
---
net/tipc/bearer.c | 46 +++---
1 file changed, 27 insertions(+), 19 deletions(-)
diff --git a/net/tipc/bearer.c b/net/tipc
k messages for bearer/media failure")
Signed-off-by: Hoang Le
---
net/tipc/bearer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
index 1090f21fcfac..d47e0b940ac9 100644
--- a/net/tipc/bearer.c
+++ b/net/tipc/bearer.c
@@ -240,6 +240,7 @@ void tipc
Add support extack in tipc to dump the netlink extack error messages
(i.e -EINVAL) sent from kernel.
Acked-by: Jon Maloy
Signed-off-by: Hoang Le
---
tipc/msg.c | 29 ++---
1 file changed, 22 insertions(+), 7 deletions(-)
diff --git a/tipc/msg.c b/tipc/msg.c
index
Add extack error messages for -EINVAL errors when enabling bearer,
getting/setting properties for a media/bearer
Acked-by: Jon Maloy
Signed-off-by: Hoang Le
---
net/tipc/bearer.c | 50 +--
1 file changed, 40 insertions(+), 10 deletions(-)
diff --git
Hi Eric,
Thanks for quick feedback.
See my inline answer.
Regards,
Hoang
-Original Message-
From: Eric Dumazet
Sent: Tuesday, October 22, 2019 9:41 AM
To: Hoang Le ; jon.ma...@ericsson.com;
ma...@donjonn.com; tipc-discuss...@lists.sourceforge.net; netdev@vger.kernel.org
Subject: Re
e node
internal packet flow by just activating tcpdump on the loopback
interface. This will be true even for this mechanism; by activating
tcpdump on the involved nodes' loopback interfaces their inter-name
space messaging can easily be tracked.
Suggested-by: Jon Maloy
Acked-by: Jon Maloy
interface name
v4: - Replace legacy SIOCGIFADDR by netlink
v5: - Fix leaky rtnl_handle
Acked-by: Ying Xue
Signed-off-by: Hoang Le
---
tipc/bearer.c | 94 ---
1 file changed, 89 insertions(+), 5 deletions(-)
diff --git a/tipc/bearer.c b/tipc/bear
.ifr_name);
This function stored an entry ll_cache in hash map table. We have to call this
function to prevent memory leaked.
Regards,
Hoang
-Original Message-
From: David Ahern
Sent: Saturday, June 22, 2019 5:50 AM
To: Hoang Le ; dsah...@gmail.com;
jon.ma...@ericsson.com; ma...@donjonn.
interface name
v4:
- Replace legacy SIOCGIFADDR using by netlink
Acked-by: Ying Xue
Signed-off-by: Hoang Le
---
tipc/bearer.c | 89 ---
1 file changed, 84 insertions(+), 5 deletions(-)
diff --git a/tipc/bearer.c b/tipc/bearer.c
index 1f
interface name
v4: - Replace legacy SIOCGIFADDR by netlink
v5: - Fix leaky rtnl_handle
Acked-by: Ying Xue
Signed-off-by: Hoang Le
---
tipc/bearer.c | 92 ---
1 file changed, 87 insertions(+), 5 deletions(-)
diff --git a/tipc/bearer.c b/tipc/bear
capabilities
which also must be reflected in the cluster capabilities field and new
feature only applicable if the cluster supports this new capability.
Acked-by: Jon Maloy
Signed-off-by: Hoang Le
---
net/tipc/core.c | 2 ++
net/tipc/core.h | 3 +++
net/tipc/node.c | 18 ++
net
implementation.
Acked-by: Jon Maloy
Signed-off-by: Hoang Le
---
include/uapi/linux/tipc_netlink.h | 2 +
net/tipc/bcast.c | 104 --
net/tipc/bcast.h | 7 ++
net/tipc/link.c | 8 +++
net/tipc/netlink.c
other link.
v2: reverse christmas tree declaration
Acked-by: Jon Maloy
Signed-off-by: Hoang Le
---
net/tipc/bcast.c | 165 +-
net/tipc/bcast.h | 5 ++
net/tipc/msg.h| 10 +++
net/tipc/socket.c | 5 ++
4 files changed, 184 insertions(+), 1
size and destination
node number
ratio SIZE- Set the AUTOSELECT criteria, percentage of
destination nodes vs cluster size
Acked-by: Jon Maloy
Signed-off-by: Hoang Le
---
include/uapi/linux/tipc_netlink.h | 2 +
tipc/link.c
"method": "AUTOSELECT"
},{
"ratio": 30
} ]
Acked-by: Jon Maloy
Signed-off-by: Hoang Le
---
tipc/link.c | 85 -
1 file changed, 84 insertions(+), 1 deletion(-)
diff --git a/tipc/link.c b/tipc/link.c
index
other link.
Acked-by: Jon Maloy
Signed-off-by: Hoang Le
---
net/tipc/bcast.c | 165 +-
net/tipc/bcast.h | 5 ++
net/tipc/msg.h| 10 +++
net/tipc/socket.c | 5 ++
4 files changed, 184 insertions(+), 1 deletion(-)
diff --git a/net/tipc/bcast.c
implementation.
Acked-by: Jon Maloy
Signed-off-by: Hoang Le
---
include/uapi/linux/tipc_netlink.h | 2 +
net/tipc/bcast.c | 104 --
net/tipc/bcast.h | 7 ++
net/tipc/link.c | 8 +++
net/tipc/netlink.c
capabilities
which also must be reflected in the cluster capabilities field and new
feature only applicable if the cluster supports this new capability.
Acked-by: Jon Maloy
Signed-off-by: Hoang Le
---
net/tipc/core.c | 2 ++
net/tipc/core.h | 3 +++
net/tipc/node.c | 18 ++
net
le changing to a 'true' boolean when skb is being free-ed.
Then, tipc_link_rcv will bypassed to subcalling tipc_link_input as above
condition.
Acked-by: Ying Xue
Acked-by: Jon Maloy
Signed-off-by: Hoang Le
---
net/tipc/link.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
: 31c4f4cc32f7 tipc: improve broadcast retransmission algorithm
Acked-by: Ying Xue
Acked-by: Jon Maloy
Signed-off-by: Hoang Le
---
net/tipc/link.c | 8
1 file changed, 8 insertions(+)
diff --git a/net/tipc/link.c b/net/tipc/link.c
index 9e265eb89726..d6a4b6ae5504 100644
--- a/net/tipc/link.c
+++ b
: 31c4f4cc32f7 tipc: improve broadcast retransmission algorithm
Acked-by: Ying Xue
Acked-by: Jon Maloy
Signed-off-by: Hoang Le
---
net/tipc/link.c | 8
1 file changed, 8 insertions(+)
diff --git a/net/tipc/link.c b/net/tipc/link.c
index 9e265eb89726..d6a4b6ae5504 100644
--- a/net/tipc/link.c
+++ b
ms at 2.3
although L2 is already not available in the system.
To fix this, we start the node interval calculation by initializing it to
a value larger than any conceivable calculated value. This way, the link
with the lowest tolerance will always determine the calculated value.
Acked-by: Jon Maloy
Upper ScopePort Node
1 1 1 node4071367628
after:
$tipc name show
Type Lower Upper ScopePort Node
1 1 1 node 4071367628
Reported-by: Jon Maloy
Acked-by: Jon Maloy
Signed-off-by: Hoang Le
syntax:
$tipc bearer enable media udp name NAME [localip IP|dev DEVICE]
Acked-by: Ying Xue
Signed-off-by: Hoang Le
---
tipc/bearer.c | 65 +++
1 file changed, 60 insertions(+), 5 deletions(-)
diff --git a/tipc/bearer.c b/tipc/bearer.c
index
25 matches
Mail list logo
