[PATCH 2/2] tbf scheduler: TSO support (update 3)

Hi, This patch is as same as the previous one. I just cleaned up some code. Thanks, Hirokazu Takahashi. Signed-off-by: Hirokazu Takahashi <[EMAIL PROTECTED]> --- linux-2.6.21/net/sched/sch_tbf.c.ORG2007-05-08 20:59:28.0 +0900 +++ linux-2.6.21/net/sched/sch_tbf.c2007

[PATCH 1/2] tbf scheduler: TSO support (update 3)

checking will be done in dev_hard_start_xmit or > device drivers. I updated the patch that a temporary index is used to calculate the transmission time if the index derived from gso_size exceeds the size of R_tab->data table. see the definition of L2T(). It is intended just to avoid causing any

Re: [PATCH 2/2] tbf scheduler: TSO support (update 2)

; on the packet which will be set if gso_segs can't be trusted. Yep, you have a point that some sanity check should be added. I think a simple check would be enough not to crash CBQ as the accurate checking will be done in dev_hard_start_xmit or device drivers. Thanks, Hirokazu Takaha

[PATCH 2/2] tbf scheduler: TSO support (update 2)

Hi, Without this patch, CBQ scheduler may cause Oops with some TSO packets because the tables passed to L2T() isn't big enough to handle such huge packets. Thanks, Hirokazu Takahashi. --- linux-2.6.21/net/sched/sch_cbq.c.ORG2007-05-14 20:53:06.0 +0900 +++ linux-2.6.2

[PATCH 1/2] tbf scheduler: TSO support (update 2)

Hi, > Hirokazu Takahashi <[EMAIL PROTECTED]> wrote: > > > > Uhh, you are right. > > skb_shinfo(skb)->gso_segs and skb_shinfo(skb)->gso_size should be used. > > Actually forget about gso_segs, it's only filled in for TCP. I realized it was really hard

Re: [PATCH] tbf scheduler: TSO support (updated)

Hi, > > > I'm now thinking I can make it just hold a TSO packet until > > > p->tokens reaches the size of the packet. I think it is > > > straightforward implementation. I'll try this. > > > > I re-implemented the patch, which is simpler than the previous one. > > > > sch->dev->mtu is used to de

[PATCH] tbf scheduler: TSO support (updated)

determine how many segments are included in a TSO packet. The point is that the value of sch->dev->mtu has to be treated possibly broken because it is set by administrators. Thanks, Hirokazu Takahashi. Signed-off-by: Hirokazu Takahashi <[EMAIL PROTECTED]> --- linux-2.6.21/net/sch

Re: [PATCH] tbf scheduler: TSO support

thinking I can make it just hold a TSO packet until p->tokens > reaches the size of the packet. I think it is straightforward > implementation. I'll try this. > > > The later would allow people to take full advantage of TSO with properly > > configured TBF,

Re: [PATCH] tbf scheduler: TSO support

ightforward implementation. I'll try this. > The later would allow people to take full advantage of TSO with properly > configured TBF, but it would still at least work with a too small mtu > value. Thanks, Hirokazu Takahashi. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] tbf scheduler: TSO support

el it's hard to determine how large TSO packets can/will be accepted that it depends on ether controllers. It would be also tough to make the tools catch up with the latest off loading features. Thank you, Hirokazu Takahashi. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] tbf scheduler: TSO support

again. I'm not sure if this approach is the best. I appreciate any comments. Thank you. Signed-off-by: Hirokazu Takahashi <[EMAIL PROTECTED]> --- linux-2.6.21/net/sched/sch_tbf.c.ORG2007-05-08 20:59:28.0 +0900 +++ linux-2.6.21/net/sched/sch_tbf.c2007-05-10 16:12:54