Re: [PATCH 3/4] net: usb: rtl8150: use usb_control_msg_recv() and usb_control_msg_send()

On Thu, Sep 24, 2020 at 5:06 PM Oliver Neukum wrote: > > Am Mittwoch, den 23.09.2020, 20:02 +0530 schrieb Himadri Pandya: > > > I meant that it was stupid to change it without properly understanding > > the significance of GFP_NOIO in this context. > > > > S

Re: [PATCH 3/4] net: usb: rtl8150: use usb_control_msg_recv() and usb_control_msg_send()

On Wed, Sep 23, 2020 at 7:51 PM Oliver Neukum wrote: > > Am Mittwoch, den 23.09.2020, 19:36 +0530 schrieb Himadri Pandya: > > On Wed, Sep 23, 2020 at 3:52 PM Oliver Neukum wrote: > > > > > > Am Mittwoch, den 23.09.2020, 14:35 +0530 schrieb Himadri Pandya: >

Re: [PATCH 4/4] net: rndis_host: use usb_control_msg_recv() and usb_control_msg_send()

On Wed, Sep 23, 2020 at 3:52 PM Greg KH wrote: > > On Wed, Sep 23, 2020 at 02:35:19PM +0530, Himadri Pandya wrote: > > The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps > > usb_control_msg() with proper error check. Hence use the wrappers >

Re: [PATCH 1/4] net: usbnet: use usb_control_msg_recv() and usb_control_msg_send()

On Wed, Sep 23, 2020 at 3:54 PM Greg KH wrote: > > On Wed, Sep 23, 2020 at 02:35:16PM +0530, Himadri Pandya wrote: > > Potential incorrect use of usb_control_msg() has resulted in new wrapper > > functions to enforce its correct usage with proper error check. Hence > &g

Re: [PATCH 3/4] net: usb: rtl8150: use usb_control_msg_recv() and usb_control_msg_send()

On Wed, Sep 23, 2020 at 3:52 PM Oliver Neukum wrote: > > Am Mittwoch, den 23.09.2020, 14:35 +0530 schrieb Himadri Pandya: > > Hi, > > > Many usage of usb_control_msg() do not have proper error check on return > > value leaving scope for bugs on short reads. New usb

[PATCH 4/4] net: rndis_host: use usb_control_msg_recv() and usb_control_msg_send()

The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps usb_control_msg() with proper error check. Hence use the wrappers instead of calling usb_control_msg() directly. Signed-off-by: Himadri Pandya --- drivers/net/usb/rndis_host.c | 44 ++-- 1

[PATCH 2/4] net: sierra_net: use usb_control_msg_recv()

The new usb api function usb_control_msg_recv() nicely wrapps usb_control_msg() with proper error check. Hence use it instead of directly calling usb_control_msg(). Signed-off-by: Himadri Pandya --- drivers/net/usb/sierra_net.c | 17 +++-- 1 file changed, 7 insertions(+), 10

[PATCH 1/4] net: usbnet: use usb_control_msg_recv() and usb_control_msg_send()

Potential incorrect use of usb_control_msg() has resulted in new wrapper functions to enforce its correct usage with proper error check. Hence use these new wrapper functions instead of calling usb_control_msg() directly. Signed-off-by: Himadri Pandya --- drivers/net/usb/usbnet.c | 46

[PATCH 0/4] net: usb: avoid using usb_control_msg() directly

. Himadri Pandya (4): net: usbnet: use usb_control_msg_recv() and usb_control_msg_send() net: sierra_net: use usb_control_msg_recv() net: usb: rtl8150: use usb_control_msg_recv() and usb_control_msg_send() net: rndis_host: use usb_control_msg_recv() and usb_control_msg_send() drivers/net

[PATCH 3/4] net: usb: rtl8150: use usb_control_msg_recv() and usb_control_msg_send()

. Signed-off-by: Himadri Pandya --- drivers/net/usb/rtl8150.c | 32 ++-- 1 file changed, 6 insertions(+), 26 deletions(-) diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c index 733f120c852b..e3002b675921 100644 --- a/drivers/net/usb/rtl8150.c +++ b

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_phy_addr()

On Thu, Aug 27, 2020 at 1:28 PM Sergei Shtylyov wrote: > > Hello! > > On 27.08.2020 9:53, Himadri Pandya wrote: > > > The buffer size is 2 Bytes and we expect to receive the same amount of > > data. But sometimes we receive less data and run into uninit-was-stored

[PATCH] net: usb: Fix uninit-was-stored issue in asix_read_phy_addr()

+a7e220df5a81d1ab4...@syzkaller.appspotmail.com Signed-off-by: Himadri Pandya --- drivers/net/usb/asix_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c index e39f41efda3e..7bc6e8f856fe 100644 --- a/drivers/net/usb

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

On Mon, Aug 24, 2020 at 11:16:55AM -0700, Jakub Kicinski wrote: > On Sun, 23 Aug 2020 13:50:42 +0530 Himadri Pandya wrote: > > Initialize the buffer before passing it to usb_read_cmd() function(s) to > > fix the uninit-was-stored issue in asix_read_cmd(). > > > > Fixes

[PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

Initialize the buffer before passing it to usb_read_cmd() function(s) to fix the uninit-was-stored issue in asix_read_cmd(). Fixes: KMSAN: kernel-infoleak in raw_ioctl Reported by: syzbot+a7e220df5a81d1ab4...@syzkaller.appspotmail.com Signed-off-by: Himadri Pandya --- drivers/net/usb

Re: [PATCH net-next] net: dsa: add missing of_node_put

On 22/02/19 8:06 PM, Andrew Lunn wrote: On Fri, Feb 22, 2019 at 04:48:18PM +0530, Himadri Pandya wrote: Decrement the reference count on port while returning out of the loop. Issue identified by Coccinelle. You and Wen Yang are both fixing the same issue. Maybe you can coordinate? Sure

[PATCH net-next] net: dsa: add missing of_node_put

Decrement the reference count on port while returning out of the loop. Issue identified by Coccinelle. Signed-off-by: Himadri Pandya --- net/dsa/dsa2.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c index a1917025e155

Re: [Outreachy kernel] [PATCH] net: dsa: add missing of_node_put

On 20/02/19 9:23 AM, Vaishali Thakkar wrote: On Wed, Feb 20, 2019 at 8:54 AM Himadri Pandya wrote: Hi Himadri, Thanks for the patch! For the scope of Outreachy, we prefer that you send patches in staging directory as Greg makes sure to pick them during the application period. Of course

[PATCH] net: dsa: add missing of_node_put

Decrement the reference count on port while returning out of the loop. Signed-off-by: Himadri Pandya --- net/dsa/dsa2.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c index a1917025e155..396e7433dd8f 100644 --- a/net/dsa/dsa2