[PATCH net-next v7 07/10] bridge: cfm: Netlink SET configuration Interface.

2020-10-27 Thread Henrik Bjoernlund
TLV value field. The type is u8. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- include/uapi/linux/if_bridge.h | 90 +++ include/uapi/linux/rtnetlink.h | 1 + net/bridge/Makefile| 2 +- net/bridge/br_cfm.c

[PATCH net-next v7 08/10] bridge: cfm: Netlink GET configuration Interface.

2020-10-27 Thread Henrik Bjoernlund
. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- include/uapi/linux/if_bridge.h | 6 ++ net/bridge/br_cfm_netlink.c| 161 + net/bridge/br_netlink.c| 29 +- net/bridge/br_private.h| 6 ++ 4

[PATCH net-next v7 02/10] bridge: cfm: Add BRIDGE_CFM to Kconfig.

2020-10-27 Thread Henrik Bjoernlund
This makes it possible to include or exclude the CFM protocol according to 802.1Q section 12.14. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- net/bridge/Kconfig | 11 +++ net/bridge/br_device.c | 3 +++ net/bridge/br_private.h

[PATCH net-next v7 03/10] bridge: uapi: cfm: Added EtherType used by the CFM protocol.

2020-10-27 Thread Henrik Bjoernlund
This EtherType is used by all CFM protocal frames transmitted according to 802.1Q section 12.14. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- include/uapi/linux/if_ether.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi

[PATCH net-next v7 09/10] bridge: cfm: Netlink GET status Interface.

2020-10-27 Thread Henrik Bjoernlund
from Peer MEP. The type is u32 (bool). When a sequence number is not one higher than previously received then it is unexpected. This is cleared after GETLINK IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked

[PATCH net-next v7 05/10] bridge: cfm: Kernel space implementation of CFM. CCM frame TX added.

2020-10-27 Thread Henrik Bjoernlund
. Must call this function before timeout to keep transmission alive. A MEP transmitting CCM can be configured with inserted RDI in PDU by br_cfm_cc_rdi_set() Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- include/uapi/linux/cfm_bridge.h | 39

[PATCH net-next v7 04/10] bridge: cfm: Kernel space implementation of CFM. MEP create/delete.

2020-10-27 Thread Henrik Bjoernlund
on each added Peer MEP. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- include/uapi/linux/cfm_bridge.h | 23 +++ net/bridge/Makefile | 2 + net/bridge/br_cfm.c | 260 net/bridge

[PATCH net-next v7 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added.

2020-10-27 Thread Henrik Bjoernlund
received with the expected interval. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- include/uapi/linux/cfm_bridge.h | 4 + net/bridge/br_cfm.c | 269 net/bridge/br_private_cfm.h | 32 3 files

[PATCH net-next v7 10/10] bridge: cfm: Netlink Notifications.

2020-10-27 Thread Henrik Bjoernlund
). When a sequence number is not one higher than previously received then it is unexpected. This is cleared after GETLINK IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- net/bridge/br_cfm.c | 48

[PATCH net-next v7 01/10] net: bridge: extend the process of special frames

2020-10-27 Thread Henrik Bjoernlund
arding. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- net/bridge/br_device.c | 1 + net/bridge/br_input.c | 33 - net/bridge/br_mrp.c | 19 +++ net/bridge/br_private.h | 19 -

[PATCH net-next v7 00/10] net: bridge: cfm: Add support for Connectivity Fault Management(CFM)

2020-10-27 Thread Henrik Bjoernlund
commit of MEP implementation (Patch 4 out of 10) Reviewed-by: Horatiu Vultur Signed-off-by: Henrik Bjoernlund Henrik Bjoernlund (10): net: bridge: extend the process of special frames bridge: cfm: Add BRIDGE_CFM to Kconfig. bridge: uapi: cfm: Added EtherType used by the CFM protocol.

Re: [PATCH net-next v6 07/10] bridge: cfm: Netlink SET configuration Interface.

2020-10-21 Thread Henrik Bjoernlund
Thank you for the review. Comments below. The 10/19/2020 09:21, Jakub Kicinski wrote:> > On Mon, 19 Oct 2020 08:51:04 + Henrik Bjoernlund wrote: > > Thank you for the review. Comments below. > > > > The 10/15/2020 10:34, Jakub Kicinski wrote: > > > > &g

Re: [PATCH net-next v6 07/10] bridge: cfm: Netlink SET configuration Interface.

2020-10-19 Thread Henrik Bjoernlund
Thank you for the review. Comments below. The 10/15/2020 10:34, Jakub Kicinski wrote: > > On Thu, 15 Oct 2020 11:54:15 + Henrik Bjoernlund wrote: > > + [IFLA_BRIDGE_CFM_MEP_CONFIG_MDLEVEL] = { > > + .type = NLA_U32, .validation_type = NLA_VALI

[PATCH net-next v6 02/10] bridge: cfm: Add BRIDGE_CFM to Kconfig.

2020-10-15 Thread Henrik Bjoernlund
This makes it possible to include or exclude the CFM protocol according to 802.1Q section 12.14. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- net/bridge/Kconfig | 11 +++ net/bridge/br_device.c | 3 +++ net/bridge/br_private.h

[PATCH net-next v6 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added.

2020-10-15 Thread Henrik Bjoernlund
received with the expected interval. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- include/uapi/linux/cfm_bridge.h | 4 + net/bridge/br_cfm.c | 269 net/bridge/br_private_cfm.h | 32 3 files

[PATCH net-next v6 01/10] net: bridge: extend the process of special frames

2020-10-15 Thread Henrik Bjoernlund
arding. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- net/bridge/br_device.c | 1 + net/bridge/br_input.c | 33 - net/bridge/br_mrp.c | 19 +++ net/bridge/br_private.h | 19 -

[PATCH net-next v6 05/10] bridge: cfm: Kernel space implementation of CFM. CCM frame TX added.

2020-10-15 Thread Henrik Bjoernlund
. Must call this function before timeout to keep transmission alive. A MEP transmitting CCM can be configured with inserted RDI in PDU by br_cfm_cc_rdi_set() Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- include/uapi/linux/cfm_bridge.h | 39

[PATCH net-next v6 03/10] bridge: uapi: cfm: Added EtherType used by the CFM protocol.

2020-10-15 Thread Henrik Bjoernlund
This EtherType is used by all CFM protocal frames transmitted according to 802.1Q section 12.14. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- include/uapi/linux/if_ether.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi

[PATCH net-next v5 00/10] net: bridge: cfm: Add support for Connectivity Fault Management(CFM)

2020-10-15 Thread Henrik Bjoernlund
was not freed during error handling return. -Removed unused struct definition. -Changed bool to u8 bitfields for space save. -Utilizing the NETLINK policy validation feature. Reviewed-by: Horatiu Vultur Signed-off-by: Henrik Bjoernlund Henrik Bjoernlund (10): net: bridge: extend the

[PATCH net-next v6 09/10] bridge: cfm: Netlink GET status Interface.

2020-10-15 Thread Henrik Bjoernlund
from Peer MEP. The type is u32 (bool). When a sequence number is not one higher than previously received then it is unexpected. This is cleared after GETLINK IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked

[PATCH net-next v6 10/10] bridge: cfm: Netlink Notifications.

2020-10-15 Thread Henrik Bjoernlund
). When a sequence number is not one higher than previously received then it is unexpected. This is cleared after GETLINK IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- net/bridge/br_cfm.c | 48

[PATCH net-next v6 08/10] bridge: cfm: Netlink GET configuration Interface.

2020-10-15 Thread Henrik Bjoernlund
. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- include/uapi/linux/if_bridge.h | 6 ++ net/bridge/br_cfm_netlink.c| 161 + net/bridge/br_netlink.c| 29 +- net/bridge/br_private.h| 6 ++ 4

[PATCH net-next v6 04/10] bridge: cfm: Kernel space implementation of CFM. MEP create/delete.

2020-10-15 Thread Henrik Bjoernlund
on each added Peer MEP. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- include/uapi/linux/cfm_bridge.h | 23 +++ net/bridge/Makefile | 2 + net/bridge/br_cfm.c | 278 net/bridge

[PATCH net-next v6 07/10] bridge: cfm: Netlink SET configuration Interface.

2020-10-15 Thread Henrik Bjoernlund
TLV value field. The type is u8. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- include/uapi/linux/if_bridge.h | 90 +++ include/uapi/linux/rtnetlink.h | 1 + net/bridge/Makefile| 2 +- net/bridge/br_cfm.c

Re: [PATCH net-next v5 00/10] net: bridge: cfm: Add support for Connectivity Fault Management(CFM)

2020-10-15 Thread Henrik Bjoernlund
Thanks for your review. Comments below. Regards Henrik The 10/14/2020 15:58, Jakub Kicinski wrote:> > On Mon, 12 Oct 2020 14:04:18 + Henrik Bjoernlund wrote: > > Connectivity Fault Management (CFM) is defined in 802.1Q section 12.14. > > > > Connectivity Fault Ma

Re: [PATCH net-next v5 05/10] bridge: cfm: Kernel space implementation of CFM. CCM frame TX added.

2020-10-15 Thread Henrik Bjoernlund
Thanks for your review. Comments below. Regards Henrik The 10/14/2020 15:59, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 12 Oct 2020 14:04:23 + Henrik Bjoernlund wrote: > > + s

Re: [PATCH net-next v5 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added.

2020-10-15 Thread Henrik Bjoernlund
Thanks for your review. Comments below. Regards Henrik The 10/14/2020 16:16, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 12 Oct 2020 14:04:24 + Henrik Bjoernlund wrote: > > +struct

Re: [PATCH net-next v5 04/10] bridge: cfm: Kernel space implementation of CFM. MEP create/delete.

2020-10-15 Thread Henrik Bjoernlund
Thanks for your review. Comments below. Regards Henrik The 10/14/2020 16:30, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 12 Oct 2020 14:04:22 + Henrik Bjoernlund wrote: > > + if (c

Re: [PATCH net-next v5 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added.

2020-10-15 Thread Henrik Bjoernlund
Thanks for your review. Comments below. Regards Henrik The 10/14/2020 16:26, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 12 Oct 2020 14:04:24 + Henrik Bjoernlund wrote: > > + /* This

Re: [PATCH net-next v5 04/10] bridge: cfm: Kernel space implementation of CFM. MEP create/delete.

2020-10-15 Thread Henrik Bjoernlund
Thanks for your review. Comments below. Regards Henrik The 10/14/2020 16:00, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 12 Oct 2020 14:04:22 + Henrik Bjoernlund wrote: > > with restricted

Re: [PATCH net-next v5 08/10] bridge: cfm: Netlink GET configuration Interface.

2020-10-15 Thread Henrik Bjoernlund
Thanks for your review. Comment below. Regards Henrik The 10/14/2020 16:33, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 12 Oct 2020 14:04:26 + Henrik Bjoernlund wrote: > > + i

[PATCH net-next v5 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added.

2020-10-12 Thread Henrik Bjoernlund
received with the expected interval. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- include/uapi/linux/cfm_bridge.h | 10 ++ net/bridge/br_cfm.c | 269 net/bridge/br_private_cfm.h | 32 3 files

[PATCH net-next v5 01/10] net: bridge: extend the process of special frames

2020-10-12 Thread Henrik Bjoernlund
arding. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur --- net/bridge/br_device.c | 1 + net/bridge/br_input.c | 33 - net/bridge/br_mrp.c | 19 +++ net/bridge/br_private.h | 19 --- 4 files changed, 60 in

[PATCH net-next v5 07/10] bridge: cfm: Netlink SET configuration Interface.

2020-10-12 Thread Henrik Bjoernlund
TLV value field. The type is u8. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- include/uapi/linux/if_bridge.h | 90 +++ include/uapi/linux/rtnetlink.h | 1 + net/bridge/Makefile| 2 +- net/bridge/br_cfm.c

[PATCH net-next v5 10/10] bridge: cfm: Netlink Notifications.

2020-10-12 Thread Henrik Bjoernlund
). When a sequence number is not one higher than previously received then it is unexpected. This is cleared after GETLINK IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- net/bridge/br_cfm.c | 48

[PATCH net-next v5 05/10] bridge: cfm: Kernel space implementation of CFM. CCM frame TX added.

2020-10-12 Thread Henrik Bjoernlund
. Must call this function before timeout to keep transmission alive. A MEP transmitting CCM can be configured with inserted RDI in PDU by br_cfm_cc_rdi_set() Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- include/uapi/linux/cfm_bridge.h | 39

[PATCH net-next v5 09/10] bridge: cfm: Netlink GET status Interface.

2020-10-12 Thread Henrik Bjoernlund
from Peer MEP. The type is u32 (bool). When a sequence number is not one higher than previously received then it is unexpected. This is cleared after GETLINK IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur

[PATCH net-next v5 00/10] net: bridge: cfm: Add support for Connectivity Fault Management(CFM)

2020-10-12 Thread Henrik Bjoernlund
list to the first cache line. Helper functions nla_get_mac() and nla_get_maid() are removed. The NLA_POLICY_NESTED() macro is used to initialize the br_cfm_policy array. Fixed reverse xmas tree. Reviewed-by: Horatiu Vultur Signed-off-by: Henrik Bjoernlund Henrik Bjoernlund (10):

[PATCH net-next v5 08/10] bridge: cfm: Netlink GET configuration Interface.

2020-10-12 Thread Henrik Bjoernlund
. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur --- include/uapi/linux/if_bridge.h | 6 ++ net/bridge/br_cfm_netlink.c| 161 + net/bridge/br_netlink.c| 29 +- net/bridge/br_private.h| 6 ++ 4 files changed, 200 insertions

[PATCH net-next v5 04/10] bridge: cfm: Kernel space implementation of CFM. MEP create/delete.

2020-10-12 Thread Henrik Bjoernlund
connectivity status on each added Peer MEP. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- include/uapi/linux/cfm_bridge.h | 23 +++ net/bridge/Makefile | 2 + net/bridge/br_cfm.c | 278 +

[PATCH net-next v5 02/10] bridge: cfm: Add BRIDGE_CFM to Kconfig.

2020-10-12 Thread Henrik Bjoernlund
This makes it possible to include or exclude the CFM protocol according to 802.1Q section 12.14. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- net/bridge/Kconfig | 11 +++ net/bridge/br_device.c | 3 +++ net/bridge/br_private.h

[PATCH net-next v5 03/10] bridge: uapi: cfm: Added EtherType used by the CFM protocol.

2020-10-12 Thread Henrik Bjoernlund
This EtherType is used by all CFM protocal frames transmitted according to 802.1Q section 12.14. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- include/uapi/linux/if_ether.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi

Re: [PATCH net-next v4 07/10] bridge: cfm: Netlink SET configuration Interface.

2020-10-12 Thread Henrik Bjoernlund
Thanks for the review. Comments below. The 10/09/2020 18:45, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 9 Oct 2020 14:35:27 + Henrik Bjoernlund wrote: > > +static inline struct mac_addr

[PATCH net-next v4 07/10] bridge: cfm: Netlink SET configuration Interface.

2020-10-09 Thread Henrik Bjoernlund
TLV value field. The type is u8. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur --- include/uapi/linux/if_bridge.h | 90 +++ include/uapi/linux/rtnetlink.h | 1 + net/bridge/Makefile| 2 +- net/bridge/br_cfm.c| 5 + net/bridge

[PATCH net-next v4 10/10] bridge: cfm: Netlink Notifications.

2020-10-09 Thread Henrik Bjoernlund
). When a sequence number is not one higher than previously received then it is unexpected. This is cleared after GETLINK IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur --- net/bridge/br_cfm.c | 48 net

[PATCH net-next v4 02/10] bridge: cfm: Add BRIDGE_CFM to Kconfig.

2020-10-09 Thread Henrik Bjoernlund
This makes it possible to include or exclude the CFM protocol according to 802.1Q section 12.14. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur --- net/bridge/Kconfig | 11 +++ net/bridge/br_device.c | 3 +++ net/bridge/br_private.h | 3 +++ 3 files changed, 17

[PATCH net-next v4 04/10] bridge: cfm: Kernel space implementation of CFM. MEP create/delete.

2020-10-09 Thread Henrik Bjoernlund
connectivity status on each added Peer MEP. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur --- include/uapi/linux/cfm_bridge.h | 23 +++ net/bridge/Makefile | 2 + net/bridge/br_cfm.c | 278 net/bridge/br_if.c

[PATCH net-next v4 00/10] net: bridge: cfm: Add support for Connectivity Fault Management(CFM)

2020-10-09 Thread Henrik Bjoernlund
NETLINK implementation split into three commits. Commit "bridge: cfm: Bridge port remove" is merged with commit "bridge: cfm: Kernel space implementation of CFM. MEP create/delete." Reviewed-by: Horatiu Vultur Signed-off-by: Henrik Bjoernlund Henrik Bjoernlund (

[PATCH net-next v4 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added.

2020-10-09 Thread Henrik Bjoernlund
received with the expected interval. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur --- include/uapi/linux/cfm_bridge.h | 10 ++ net/bridge/br_cfm.c | 269 net/bridge/br_private_cfm.h | 32 3 files changed, 311 insertions(+) diff

[PATCH net-next v4 05/10] bridge: cfm: Kernel space implementation of CFM. CCM frame TX added.

2020-10-09 Thread Henrik Bjoernlund
. Must call this function before timeout to keep transmission alive. A MEP transmitting CCM can be configured with inserted RDI in PDU by br_cfm_cc_rdi_set() Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur --- include/uapi/linux/cfm_bridge.h | 39 - net/bridge/br_cfm.c

[PATCH net-next v4 09/10] bridge: cfm: Netlink GET status Interface.

2020-10-09 Thread Henrik Bjoernlund
from Peer MEP. The type is u32 (bool). When a sequence number is not one higher than previously received then it is unexpected. This is cleared after GETLINK IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur

[PATCH net-next v4 03/10] bridge: uapi: cfm: Added EtherType used by the CFM protocol.

2020-10-09 Thread Henrik Bjoernlund
This EtherType is used by all CFM protocal frames transmitted according to 802.1Q section 12.14. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- include/uapi/linux/if_ether.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi

[PATCH net-next v4 08/10] bridge: cfm: Netlink GET configuration Interface.

2020-10-09 Thread Henrik Bjoernlund
. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur --- include/uapi/linux/if_bridge.h | 6 ++ net/bridge/br_cfm_netlink.c| 161 + net/bridge/br_netlink.c| 29 +- net/bridge/br_private.h| 6 ++ 4 files changed, 200 insertions

[PATCH net-next v4 01/10] net: bridge: extend the process of special frames

2020-10-09 Thread Henrik Bjoernlund
arding. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur --- net/bridge/br_device.c | 1 + net/bridge/br_input.c | 33 - net/bridge/br_mrp.c | 19 +++ net/bridge/br_private.h | 18 -- 4 files changed, 60 in

[PATCH net] bridge: Netlink interface fix.

2020-10-07 Thread Henrik Bjoernlund
This commit is correcting NETLINK br_fill_ifinfo() to be able to handle 'filter_mask' with multiple flags asserted. Fixes: 36a8e8e265420 ("bridge: Extend br_fill_ifinfo to return MPR status") Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Suggested-by: Nikolay

[net-next v3 7/9] bridge: cfm: Netlink Interface.

2020-10-06 Thread Henrik Bjoernlund
received then it is unexpected. This is cleared after GETLINK IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur --- include/uapi/linux/if_bridge.h | 125 ++ include/uapi/linux/rtnetlink.h | 2 + net/bridge/Makefile

[net-next v3 8/9] bridge: cfm: Netlink Notifications.

2020-10-06 Thread Henrik Bjoernlund
). When a sequence number is not one higher than previously received then it is unexpected. This is cleared after GETLINK IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur --- net/bridge/br_cfm.c | 48 net

[net-next v3 5/9] bridge: cfm: Kernel space implementation of CFM.

2020-10-06 Thread Henrik Bjoernlund
. Must call this function before timeout to keep transmission alive. A MEP transmitting CCM can be configured with inserted RDI in PDU by br_cfm_cc_rdi_set() Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur --- include/uapi/linux/cfm_bridge.h | 39 - net/bridge/br_cfm.c

[net-next v3 4/9] bridge: cfm: Kernel space implementation of CFM.

2020-10-06 Thread Henrik Bjoernlund
ceiver state machine can be enabled and disabled. According to 802.1Q section 19.2.8 A MEP can have Peer MEPs added and removed by br_cfm_cc_peer_mep_add() and br_cfm_cc_peer_mep_remove() The Continuity Check feature can maintain connectivity status on each added Peer MEP. Signed-of

[net-next v3 9/9] bridge: cfm: Bridge port remove.

2020-10-06 Thread Henrik Bjoernlund
This is addition of CFM functionality to delete MEP instances on a port that is removed from the bridge. A MEP can only exist on a port that is related to a bridge. Signed-off-by: Henrik Bjoernlund m Reviewed-by: Horatiu Vultur --- net/bridge/br_cfm.c | 13 + net/bridge

[net-next v3 0/9] net: bridge: cfm: Add support for Connectivity Fault Management(CFM)

2020-10-06 Thread Henrik Bjoernlund
//github.com/microchip-ung/cfm but it is considered to integrate this into 'iproute2'. v2 -> v3 The switchdev definition and utilization has been removed as there was no switchdev implementation. Some compiling issues are fixed as Reported-by: kernel test robot . Henrik Bjoernl

[net-next v3 6/9] bridge: cfm: Kernel space implementation of CFM.

2020-10-06 Thread Henrik Bjoernlund
received with the expected interval. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur --- include/uapi/linux/cfm_bridge.h | 10 ++ net/bridge/br_cfm.c | 269 net/bridge/br_private_cfm.h | 32 3 files changed, 311 insertions(+) diff

[net-next v3 1/9] net: bridge: extend the process of special frames

2020-10-06 Thread Henrik Bjoernlund
rmal forwarding. Reviewed-by: Horatiu Vultur Signed-off-by: Henrik Bjoernlund --- net/bridge/br_device.c | 1 + net/bridge/br_input.c | 31 ++- net/bridge/br_mrp.c | 19 +++ net/bridge/br_private.h | 18 -- 4 files changed, 58 in

[net-next v3 3/9] bridge: uapi: cfm: Added EtherType used by the CFM protocol.

2020-10-06 Thread Henrik Bjoernlund
This EtherType is used by all CFM protocal frames transmitted according to 802.1Q section 12.14. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- include/uapi/linux/if_ether.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi

[net-next v3 2/9] bridge: cfm: Add BRIDGE_CFM to Kconfig.

2020-10-06 Thread Henrik Bjoernlund
This makes it possible to include or exclude the CFM protocol according to 802.1Q section 12.14. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur --- net/bridge/Kconfig | 11 +++ net/bridge/br_device.c | 3 +++ net/bridge/br_private.h | 3 +++ 3 files changed, 17

[net-next v2 03/11] bridge: uapi: cfm: Added EtherType used by the CFM protocol.

2020-10-01 Thread Henrik Bjoernlund
This EtherType is used by all CFM protocal frames transmitted according to 802.1Q section 12.14. Acked-by: Nikolay Aleksandrov Reviewed-by: Horatiu Vultur Signed-off-by: Henrik Bjoernlund --- include/uapi/linux/if_ether.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi

[net-next v2 02/11] bridge: cfm: Add BRIDGE_CFM to Kconfig.

2020-10-01 Thread Henrik Bjoernlund
This makes it possible to include or exclude the CFM protocol according to 802.1Q section 12.14. Reviewed-by: Horatiu Vultur Signed-off-by: Henrik Bjoernlund --- net/bridge/Kconfig | 11 +++ net/bridge/br_device.c | 3 +++ net/bridge/br_private.h | 3 +++ 3 files changed, 17

[net-next v2 08/11] bridge: cfm: Netlink Notifications.

2020-10-01 Thread Henrik Bjoernlund
). When a sequence number is not one higher than previously received then it is unexpected. This is cleared after GETLINK IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO. Reviewed-by: Horatiu Vultur Signed-off-by: Henrik Bjoernlund --- net/bridge/br_cfm.c | 48 net

[net-next v2 07/11] bridge: cfm: Netlink Interface.

2020-10-01 Thread Henrik Bjoernlund
received then it is unexpected. This is cleared after GETLINK IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO. Reviewed-by: Horatiu Vultur Signed-off-by: Henrik Bjoernlund --- include/uapi/linux/if_bridge.h | 125 ++ include/uapi/linux/rtnetlink.h | 2 + net/bridge/Makefile

[net-next v2 11/11] bridge: cfm: Added CFM switchdev utilization.

2020-10-01 Thread Henrik Bjoernlund
Signed-off-by: Henrik Bjoernlund --- net/bridge/Makefile | 2 +- net/bridge/br_cfm.c | 270 ++ net/bridge/br_cfm_netlink.c | 51 +++ net/bridge/br_cfm_switchdev.c | 203 + net/bridge/br_private_cfm.h | 63

[net-next v2 09/11] bridge: cfm: Bridge port remove.

2020-10-01 Thread Henrik Bjoernlund
This is addition of CFM functionality to delete MEP instances on a port that is removed from the bridge. A MEP can only exist on a port that is related to a bridge. Reviewed-by: Horatiu Vultur Signed-off-by: Henrik Bjoernlund m --- net/bridge/br_cfm.c | 13 + net/bridge

[net-next v2 06/11] bridge: cfm: Kernel space implementation of CFM.

2020-10-01 Thread Henrik Bjoernlund
received with the expected interval. Reviewed-by: Horatiu Vultur Signed-off-by: Henrik Bjoernlund --- include/uapi/linux/cfm_bridge.h | 10 ++ net/bridge/br_cfm.c | 269 net/bridge/br_private_cfm.h | 32 3 files changed, 311 insertions(+) diff

[net-next v2 10/11] bridge: switchdev: cfm: switchdev interface implementation

2020-10-01 Thread Henrik Bjoernlund
switchdev_port_obj_get(SWITCHDEV_OBJ_ID_MEP_STATUS_CFM) Get Peer MEP status switchdev_port_obj_get(SWITCHDEV_OBJ_ID_PEER_MEP_STATUS_CFM) Reviewed-by: Horatiu Vultur Signed-off-by: Henrik Bjoernlund --- include/linux/if_bridge.h | 13 + include/net/switchdev.h | 115

[net-next v2 00/11] net: bridge: cfm: Add support for Connectivity Fault Management(CFM)

2020-10-01 Thread Henrik Bjoernlund
where required. -Shaping up on error messages. -Correction NETLINK br_fill_ifinfo() to be able to handle 'filter_mask' with multiple flags asserted. Reviewed-by: Horatiu Vultur Signed-off-by: Henrik Bjoernlund Henrik Bjoernlund (11): net: bridge: extend the pro

[net-next v2 01/11] net: bridge: extend the process of special frames

2020-10-01 Thread Henrik Bjoernlund
rmal forwarding. Reviewed-by: Horatiu Vultur Signed-off-by: Henrik Bjoernlund --- net/bridge/br_device.c | 1 + net/bridge/br_input.c | 31 ++- net/bridge/br_mrp.c | 19 +++ net/bridge/br_private.h | 18 -- 4 files changed, 58 in

[net-next v2 04/11] bridge: cfm: Kernel space implementation of CFM.

2020-10-01 Thread Henrik Bjoernlund
-by: Horatiu Vultur Signed-off-by: Henrik Bjoernlund --- include/uapi/linux/cfm_bridge.h | 23 +++ net/bridge/Makefile | 2 + net/bridge/br_cfm.c | 263 net/bridge/br_private_cfm.h | 61 4 files changed, 349 insertions(+)

[net-next v2 05/11] bridge: cfm: Kernel space implementation of CFM.

2020-10-01 Thread Henrik Bjoernlund
. Must call this function before timeout to keep transmission alive. A MEP transmitting CCM can be configured with inserted RDI in PDU by br_cfm_cc_rdi_set() Reviewed-by: Horatiu Vultur Signed-off-by: Henrik Bjoernlund --- include/uapi/linux/cfm_bridge.h | 39 - net/bridge/br_cfm.c

Re: [PATCH RFC 4/7] bridge: cfm: Kernel space implementation of CFM.

2020-09-15 Thread Henrik Bjoernlund
Thanks for the review. Comments below. The 09/04/2020 08:02, Jakub Kicinski wrote: > > On Fri, 4 Sep 2020 09:15:24 + Henrik Bjoernlund wrote: > > + rcu_read_lock(); > > + b_port = rcu_dereference(mep->b_port); > > + if (!b_port) > > +

[PATCH RFC 5/7] bridge: cfm: Netlink Interface.

2020-09-04 Thread Henrik Bjoernlund
received then it is unexpected. This is cleared after GETLINK IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO. Signed-off-by: Henrik Bjoernlund --- include/uapi/linux/if_bridge.h | 125 ++ include/uapi/linux/rtnetlink.h | 2 + net/bridge/Makefile| 2 +- net/bridge

[PATCH RFC 6/7] bridge: cfm: Netlink Notifications.

2020-09-04 Thread Henrik Bjoernlund
). When a sequence number is not one higher than previously received then it is unexpected. This is cleared after GETLINK IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO. Signed-off-by: Henrik Bjoernlund --- net/bridge/br_cfm.c | 43 + net/bridge/br_cfm_netlink.c | 24

[PATCH RFC 7/7] bridge: cfm: Bridge port remove.

2020-09-04 Thread Henrik Bjoernlund
This is addition of CFM functionality to delete MEP instances on a port that is removed from the bridge. A MEP can only exist on a port that is related to a bridge. Signed-off-by: Henrik Bjoernlund --- net/bridge/br_cfm.c | 13 + net/bridge/br_if.c | 1 + net/bridge

[PATCH RFC 0/7] net: bridge: cfm: Add support for Connectivity Fault Management(CFM)

2020-09-04 Thread Henrik Bjoernlund
and 'cfm_server' programs are standalone placed in a cfm repository https://github.com/microchip-ung/cfm but it is considered to integrate this into 'iproute2'. Reviewed-by: Horatiu Vultur Signed-off-by: Henrik Bjoernlund Henrik Bjoernlund (7): net: bridge: exten

[PATCH RFC 4/7] bridge: cfm: Kernel space implementation of CFM.

2020-09-04 Thread Henrik Bjoernlund
contain Peer MEP Continuity Check status information that can be retrieved by br_cfm_cc_peer_status_get(). Signed-off-by: Henrik Bjoernlund --- include/uapi/linux/cfm_bridge.h | 75 +++ net/bridge/Makefile | 2 + net/bridge/br_cfm.c | 880

[PATCH RFC 3/7] bridge: uapi: cfm: Added EtherType used by the CFM protocol.

2020-09-04 Thread Henrik Bjoernlund
This EtherType is used by all CFM protocal frames transmitted according to 802.1Q section 12.14. Signed-off-by: Henrik Bjoernlund --- include/uapi/linux/if_ether.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/if_ether.h b/include/uapi/linux/if_ether.h index

[PATCH RFC 1/7] net: bridge: extend the process of special frames

2020-09-04 Thread Henrik Bjoernlund
arding. Signed-off-by: Henrik Bjoernlund --- net/bridge/br_device.c | 1 + net/bridge/br_input.c | 31 ++- net/bridge/br_mrp.c | 19 +++ net/bridge/br_private.h | 18 -- 4 files changed, 58 insertions(+), 11 deletions(-) d

[PATCH RFC 2/7] bridge: cfm: Add BRIDGE_CFM to Kconfig.

2020-09-04 Thread Henrik Bjoernlund
This makes it possible to include or exclude the CFM protocol according to 802.1Q section 12.14. Signed-off-by: Henrik Bjoernlund --- net/bridge/Kconfig | 11 +++ net/bridge/br_device.c | 3 +++ net/bridge/br_private.h | 3 +++ 3 files changed, 17 insertions(+) diff --git a