Re: [PATCH -next] net: macb: fix missing unlock on error in macb_start_xmit()

2016-09-12 Thread Helmut Buchsbaum
On 09/10/2016 01:17 PM, Wei Yongjun wrote: From: Wei Yongjun Fix missing unlock before return from function macb_start_xmit() in the error handling case. Fixes: 007e4ba3ee13 ("net: macb: initialize checksum when using checksum offloading") Signed-off-by: Wei Yongjun --- drivers/net/ethernet/

[PATCH v3] net: macb: initialize checksum when using checksum offloading

2016-09-04 Thread Helmut Buchsbaum
>8 -- MACB/GEM needs the checksum field initialized to 0 to get correct results on transmit in all cases, e.g. on Zynq, UDP packets with payload <= 2 otherwise contain a wrong checksums. Signed-off-by: Helmut Buchsbaum --- drivers/net/ethernet/cadence/macb.c | 23 +++ 1

[PATCH v2 0/1] net: macb: initialize checksum when using checksum

2016-08-29 Thread Helmut Buchsbaum
itialize checksum similar to net/ethernet/freescale/fec_main.c Helmut Buchsbaum (1): net: macb: initialize checksum when using checksum offloading drivers/net/ethernet/cadence/macb.c | 15 +++ 1 file changed, 15 insertions(+) -- 2.1.4

[PATCH v2 1/1] net: macb: initialize checksum when using checksum offloading

2016-08-29 Thread Helmut Buchsbaum
MACB/GEM needs the checksum field initialized to 0 to get correct results on transmit in all cases, e.g. on Zynq, UDP packets with payload <= 2 otherwise contain a wrong checksums. Signed-off-by: Helmut Buchsbaum --- drivers/net/ethernet/cadence/macb.c | 15 +++ 1 file changed,

Re: [PATCH 0/1] HW checksum offload problem on Xilinx Zynq GEM

2016-08-22 Thread Helmut Buchsbaum
On 08/19/2016 10:00 PM, Tom Herbert wrote: On Fri, Aug 19, 2016 at 12:28 PM, David Miller wrote: From: Helmut Buchsbaum Date: Fri, 19 Aug 2016 15:04:57 +0200 When working on upgrading the v3.x kernels of our embedded devices to more recent 4.x kernels we noticed some of our proprietary

[PATCH 1/1] net: macb: disable HW checksum offload for Xilinx Zynq

2016-08-19 Thread Helmut Buchsbaum
When sending UDP packets with data payload size <= 2, Zynq's GEM implementation for HW checksum offloading calculates wrong checksums. Adding a MACB_CAPS_NO_CSUM_OFFLOAD capability and turning off HW checksum offloading for Zynq solves it. Signed-off-by: Helmut Buchsbaum --- dri

[PATCH 0/1] HW checksum offload problem on Xilinx Zynq GEM

2016-08-19 Thread Helmut Buchsbaum
using Cadence MACB/GEM implementations. Since I cannot verify this due to lack of hardware, this solution is restricted to Xilinx Zynq7000. Helmut Buchsbaum (1): net: macb: disable hardware checksum offload for Xilinx Zynq drivers/net/ethernet/cadence/macb.c | 6 -- drivers/net/ethernet/cadence/macb.h | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) -- 2.1.4

Re: [PATCH] net: phy: spi_ks8995: add dependency on GPIO

2016-02-12 Thread Helmut Buchsbaum
eclaration of function 'gpio_to_desc' GPIO is now used to reset the switch so we should have a dependency on GPIOLIB. Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO") Cc: Helmut Buchsbaum Signed-off-by: Sudip Mukherjee --- drivers/n

[PATCH v3 5/6] net: phy: spi_ks8995: add support for MICREL KSZ8795CLX

2016-02-09 Thread Helmut Buchsbaum
Add support for MICREL KSZ8795CLX Integrated 5-Port, 10-/100-Managed Ethernet Switch with Gigabit GMII/RGMII and MII/RMII interfaces. Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/net

[PATCH v3 2/6] net: phy: spi_ks8995: verify chip and determine revision

2016-02-09 Thread Helmut Buchsbaum
Since the chip variant is now determined by spi_device_id, verify family and chip id and determine the revision id. Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 118 +-- 1 file changed, 80 insertions(+), 38 deletions(-) diff --git a

[PATCH v3 3/6] net: phy: spi_ks8995: add support for resetting switch using GPIO

2016-02-09 Thread Helmut Buchsbaum
eset-gpios = <&gpio0 46 GPIO_ACTIVE_LOW> Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 71 ++-- 1 file changed, 62 insertions(+), 9 deletions(-) diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c index 2803c8e..

[PATCH v3 4/6] net: phy: spi_ks8995: generalize creation of SPI commands

2016-02-09 Thread Helmut Buchsbaum
reation chip variant dependent. Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 46 +--- 1 file changed, 35 insertions(+), 11 deletions(-) diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c index 04d468f..f866786 100644 --

[PATCH v3 6/6] dt-bindings: net: ks8995: add bindings documentation for ks8995

2016-02-09 Thread Helmut Buchsbaum
Signed-off-by: Helmut Buchsbaum --- .../devicetree/bindings/net/micrel-ks8995.txt| 20 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/micrel-ks8995.txt diff --git a/Documentation/devicetree/bindings/net/micrel-ks8995.txt

[PATCH v3 0/6] Add support for MICREL KSZ8795CLX 5-port switch

2016-02-09 Thread Helmut Buchsbaum
name in example, thanks to Sergei for pointing out Changes since v1: - removed initializing registers from Device Tree following Florian's advice - fixed GPIO handling for reset according to Andrew's remark. Helmut Buchsbaum (6): net: phy: spi_ks8995: introduce spi_device_id t

[PATCH v3 1/6] net: phy: spi_ks8995: introduce spi_device_id table

2016-02-09 Thread Helmut Buchsbaum
Refactor to use spi_device_id table to facilitate easy extendability. Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 42 -- 1 file changed, 40 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy

Re: [PATCH v2 6/6] dt-bindings: net: ks8995: add bindings documentation for ks8995

2016-02-09 Thread Helmut Buchsbaum
On 02/08/2016 07:44 PM, Sergei Shtylyov wrote: Hello. On 02/08/2016 08:35 PM, Helmut Buchsbaum wrote: Signed-off-by: Helmut Buchsbaum --- .../devicetree/bindings/net/micrel-ks8995.txt| 20 1 file changed, 20 insertions(+) create mode 100644 Documentation

[PATCH v2 1/6] net: phy: spi_ks8995: introduce spi_device_id table

2016-02-08 Thread Helmut Buchsbaum
Refactor to use spi_device_id table to facilitate easy extendability. Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 42 -- 1 file changed, 40 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy

[PATCH v2 3/6] net: phy: spi_ks8995: add support for resetting switch using GPIO

2016-02-08 Thread Helmut Buchsbaum
eset-gpios = <&gpio0 46 1> Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 71 ++-- 1 file changed, 62 insertions(+), 9 deletions(-) diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c index 2803c8e..04d468f 1006

[PATCH v2 5/6] net: phy: spi_ks8995: add support for MICREL KSZ8795CLX

2016-02-08 Thread Helmut Buchsbaum
Add support for MICREL KSZ8795CLX Integrated 5-Port, 10-/100-Managed Ethernet Switch with Gigabit GMII/RGMII and MII/RMII interfaces. Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/net

[PATCH v2 4/6] net: phy: spi_ks8995: generalize creation of SPI commands

2016-02-08 Thread Helmut Buchsbaum
reation chip variant dependent. Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 46 +--- 1 file changed, 35 insertions(+), 11 deletions(-) diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c index 04d468f..f866786 100644 --

[PATCH v2 6/6] dt-bindings: net: ks8995: add bindings documentation for ks8995

2016-02-08 Thread Helmut Buchsbaum
Signed-off-by: Helmut Buchsbaum --- .../devicetree/bindings/net/micrel-ks8995.txt| 20 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/micrel-ks8995.txt diff --git a/Documentation/devicetree/bindings/net/micrel-ks8995.txt

[PATCH v2 0/6] Add support for MICREL KSZ8795CLX 5-port switch

2016-02-08 Thread Helmut Buchsbaum
dvice - fixed GPIO handling for reset according to Andrew's remark. Helmut Buchsbaum (6): net: phy: spi_ks8995: introduce spi_device_id table net: phy: spi_ks8995: verify chip and determine revision net: phy: spi_ks8995: add support for resetting switch using GPIO net: phy: spi_ks8995:

[PATCH v2 2/6] net: phy: spi_ks8995: verify chip and determine revision

2016-02-08 Thread Helmut Buchsbaum
Since the chip variant is now determined by spi_device_id, verify family and chip id and determine the revision id. Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 118 +-- 1 file changed, 80 insertions(+), 38 deletions(-) diff --git a

Re: [PATCH 3/7] net: phy: spi_ks8995: add register initialization

2016-02-08 Thread Helmut Buchsbaum
On 02/08/2016 05:38 AM, Florian Fainelli wrote: On 07/02/2016 14:39, Helmut Buchsbaum wrote: Since several use cases need to setup at least some basic control registers add the ability to configure an array containing such register initialization values within the platform data of the switch

[PATCH 4/7] net: phy: spi_ks8995: add support for resetting switch using GPIO

2016-02-07 Thread Helmut Buchsbaum
eset-gpios = <&gpio0 46 1> Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c index d50f091..60479c4 100644 --- a/drivers/

[PATCH 3/7] net: phy: spi_ks8995: add register initialization

2016-02-07 Thread Helmut Buchsbaum
27; to the SPI node of the ks8985 driver, which is a list of triple values (register, value, mask), e.g.: settings = <0x4D 0x08 0x08 0x5D 0x08 0x08>; to power down port 3 and 4 of a KSZ8864RMN. Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/sp

[PATCH 6/7] net: phy: spi_ks8995: add support for MICREL KSZ8795CLX

2016-02-07 Thread Helmut Buchsbaum
Add support for MICREL KSZ8795CLX Integrated 5-Port, 10-/100-Managed Ethernet Switch with Gigabit GMII/RGMII and MII/RMII interfaces. Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/net

[PATCH 5/7] net: phy: spi_ks8995: generalize creation of SPI commands

2016-02-07 Thread Helmut Buchsbaum
reation chip variant dependent. Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 46 +--- 1 file changed, 35 insertions(+), 11 deletions(-) diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c index 60479c4..6d6f984 100644 --

[PATCH 7/7] dt-bindings: net: ks8995: add bindings documentation for ks8995

2016-02-07 Thread Helmut Buchsbaum
Signed-off-by: Helmut Buchsbaum --- .../devicetree/bindings/net/micrel-ks8995.txt | 27 ++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/micrel-ks8995.txt diff --git a/Documentation/devicetree/bindings/net/micrel-ks8995.txt

[PATCH 2/7] net: phy: spi_ks8995: verify chip and determine revision

2016-02-07 Thread Helmut Buchsbaum
Since the chip variant is now determined by spi_device_id, verify family and chip id and determine the revision id. Conflicts: drivers/net/phy/spi_ks8995.c Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 118 +-- 1 file changed

[PATCH 0/7] Add support for MICREL KSZ8795CLX 5-port switch

2016-02-07 Thread Helmut Buchsbaum
This patch series refactors the spi-ks8995 driver to finally add support for the MICREL KSZ8795CLX. Additionally support for setting initial register values as well as controlling a GPIO line for resetting the switch is added. Helmut Buchsbaum (7): net: phy: spi_ks8995: introduce spi_device_id

[PATCH 1/7] net: phy: spi_ks8995: introduce spi_device_id table

2016-02-07 Thread Helmut Buchsbaum
Refactor to use spi_device_id table to facilitate easy extendability. Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 42 -- 1 file changed, 40 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy