[PATCH 1/1] cxgb4: fix cxgb4_uld_in_use() not used error

) | ^~~~ Guard cxgb4_uld_in_use() with #ifdef CONFIG_CHELSIO_TLS_DEVICE. Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c b/drivers/net/ethernet/chelsio

Re: [RFC net-next 11/15] net: lora: Add IMST WiMOD

On 7/1/18 1:08 PM, Andreas Färber wrote: > The IMST WiMOD uses a SLIP based binary UART protocol. Two separate > firmwares are available. By default it ships with a LoRaWAN firmware. > The alternative firmware is a custom P2P addressing mode based on LoRa. > > Cc: Jon Ortego > Signed-off-by: Andr

[PATCH 1/1] Doc: net: dsa: b53: update location of referenced dsa.txt

The referenced file dsa.txt is located at Documentation/devicetree/bindings/net/dsa/dsa.txt Reviewed-by: Florian Fainelli Signed-off-by: Heinrich Schuchardt --- Resent due to missing Cc: netdev@vger.kernel.org --- Documentation/devicetree/bindings/net/dsa/b53.txt | 2 +- 1 file changed, 1

Re: net: stmmac: Meson GXBB: attempting to execute userspace memory

On 11/26/2016 10:08 AM, Martin Blumenstingl wrote: > Hello Heinrich, > > On Sat, Nov 26, 2016 at 8:53 AM, Heinrich Schuchardt > wrote: >> For Odroid C2 I have compiled kernel >> 4.9.0-rc6-next-20161124-1-gbf7e142 >> with one additional patch >> https://git

net: stmmac: Meson GXBB: attempting to execute userspace memory

For Odroid C2 I have compiled kernel 4.9.0-rc6-next-20161124-1-gbf7e142 with one additional patch https://github.com/xypron/kernel-odroid-c2/blob/master/patch/0001-stmmac-RTL8211F-Meson-GXBB-TX-throughput-problems.patch I repeatedly see faults like the one below: [ 2557.400796] Unhandled faul

Re: [PATCH 03/15] net: bcm63xx_enet: Utilize phy_ethtool_nway_reset

On 11/15/2016 07:06 PM, Florian Fainelli wrote: > Signed-off-by: Florian Fainelli Each patch of your patch series should have a commit message. You can add the missing commit messages with git rebase -i HEAD~15 choosing reword. Please, add a cover letter message describing the patch series usin

[PATCH 1/1 v3] net: i40e: use matching format identifiers

i is defined as int but output as %u several times. Adjust the format identifiers. Signed-off-by: Heinrich Schuchardt --- v3: fix typos in title, old title: net: i10e: use matching format indentifiers v2: Keep definition of i as int. drivers/net/ethernet/intel/i40e

[PATCH 1/1 v2] rtlwifi: remove superfluous condition

If sta == NULL, the changed line will not be reached. So no need to check that sta != NULL here. v2: fix typo Signed-off-by: Heinrich Schuchardt Acked-by: Larry Finger --- drivers/net/wireless/realtek/rtlwifi/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 1/1 v2] net: i10e: use matching format indentifiers

i is defined as int but output as %u several times. Adjust the format identifiers. v2: Keep definition of i as int. David indicated that this is the preferable way to define loop variables. Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/intel/i40e

[PATCH 1/1] mwifiex: key_material_v2 remove superfluous condition

We are using mac as source address in a memcpy. In the lines below we can assume mac is not NULL. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/marvell

[PATCH 1/1 v2] dsa: b53: remove redundant if

For pdata == null the code leaves with an error. There is no need to check the condition again. Signed-off-by: Heinrich Schuchardt --- drivers/net/dsa/b53/b53_mmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/dsa/b53/b53_mmap.c b/drivers/net/dsa/b53

[PATCH 1/1] qed: do not use unitialized variable

Do not write random bytes from the kernel stack when calling qed_wr. Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/qlogic/qed/qed_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev.c b/drivers/net/ethernet/qlogic/qed

[PATCH 1/1] wan/fsl_ucc_hdlc: avoid possible NULL pointer dereference

All assignments to components of priv should only occur after the check if prif is NULL. Signed-off-by: Heinrich Schuchardt --- drivers/net/wan/fsl_ucc_hdlc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c

[PATCH 1/1] mwifiex: remove superfluous condition (2)

We are using mac as source address in a memcpy. In the lines below we can assume mac is not NULL. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/marvell

[PATCH 1/1] mwifiex: remove superfluous condition

for_each_property_of_node is only executed if the property prop is not NULL. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c b/drivers/net

[PATCH 1/1] rtlwifi: remove superfluous condition

If sta == NULL, the changed line will not be reached. So no need to check if stat == NULL here. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/realtek/rtlwifi/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b

[PATCH 1/1] net: qlge: remove superfluous statement

Variable length is not used after the deleted line. Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/qlogic/qlge/qlge_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_main.c b/drivers/net/ethernet/qlogic/qlge/qlge_main.c index fd5d1c9

[PATCH 1/1] net: qlcnic: avoid superfluous assignement

Assigning NULL to parmeter dcb has no effect outside of the inlined function. Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.h b/drivers/net/ethernet/qlogic

[PATCH 1/1] net: s2io: simplify logical constraint

(!A || (A && B)) is equivalent to (!A || B) Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/neterion/s2io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/neterion/s2io.c b/drivers/net/ethernet/neterion/s2io.c index 2874dff..eaa37c

[PATCH 1/1] net: i10e: use matching format indentifiers

i is defined as int but output as %u several times. Change the definition to unsigned. Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b

[PATCH 1/1] net: e1000: do not use uninitalized variable.

phy_data has to be set to zero to avoid undefined behavior. Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/intel/e1000/e1000_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.c b/drivers/net/ethernet/intel/e1000

[PATCH 1/1] net: enic: use correct type specifier

i is defined as unsigned. So print it with %u. Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/cisco/enic/enic_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c

[PATCH 1/1] net: bna: use correct type specifier (2)

add and val are read with sscanf(kern_buf, "%x:%x", &addr, &val); and used as arguments for bna_reg_offset_check and writel so they have to be unsigned. Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 3 ++- 1 file changed, 2 inserti

[PATCH 1/1] net: bna: use correct type specifications

addr and len are read with sscanf(kern_buf, "%x:%x", &addr, &len); and used as arguments for bna_reg_offset_check. So they have to be unsigned. Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH 1/1] net: bcm63xx: avoid possible null pointer dereference

If dev_get_platdata has failed pd is null. Do not dereference a null pointer. Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/broadcom/bcm63xx_enet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net

[PATCH 1/1] net: amd-xgbe: use correct format specifier

i has been defined as unsigned int. So use %u for output. Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c

[PATCH 1/1] net: ethernet: ax88796: avoid null pointer dereference

If platform_get_resource fails, mem2 is null. Do not dereference null. Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/8390/ax88796.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/8390/ax88796.c b/drivers/net/ethernet/8390/ax88796.c

[PATCH 1/1] dsa: b53: remove redundant if

For pdata == null the code leaves with an error. There is need to check the condition again. Signed-off-by: Heinrich Schuchardt --- drivers/net/dsa/b53/b53_mmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/dsa/b53/b53_mmap.c b/drivers/net/dsa/b53

[PATCH 1/1] net: caif: use correct format specifier

%u is the wrong format specifier for int. size_t cannot be converted to int without possible loss of information. So leave the result as size_t and use %zu as format specifier. cf. Documentation/printk-formats.txt Signed-off-by: Heinrich Schuchardt --- drivers/net/caif/caif_spi.c | 4 ++-- 1

Re: [RFC] Handle error writing UINT_MAX to u32 fields

On 06/10/2016 04:40 AM, Subash Abhinov Kasiviswanathan wrote: > We have scripts which write to certain fields on 3.18 kernels but > this seems to be failing on 4.4 kernels. > An entry which we write to here is xfrm_aevent_rseqth which is u32. > > echo 4294967295 > /proc/sys/net/core/xfrm_aevent

Re: [RFC] Handle error writing UINT_MAX to u32 fields

#x27;s call it proc_doint64vec_minmax) which uses fields extra1 and extra2 of ctl_table as min and max. Then set xfrm_table[].extra1 = 0 and xfrm_table[].extra2 = UINT_MAX if you need a result in the u32 range. Best regards Heinrich Schuchardt

[PATCH v2 1/1] net: hns: avoid null pointer dereference

In the statement assert(priv || priv->ae_handle); the right side of || is only evaluated if priv is null. v2: As suggested by David Leight and David Miller the assert statements are removed. Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/hisilicon/

[PATCH 1/1] net: pegasus: simplify logical constraint

If !count is true, count < 4 is also true. Signed-off-by: Heinrich Schuchardt --- drivers/net/usb/pegasus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c index 36cd7f0..9bbe0161 100644 --- a/drivers/net/usb/pegasu

[PATCH 1/1] brcm80211: simplify assignment

Simplify assignment in wlc_phy_rxcal_gainctrl_nphy_rev5. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c b

[PATCH 1/1] rtlwifi: rtl8192ee: simplify coding

Simplify _rtl92ee_phy_path_adda_on. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c b/drivers/net/wireless/realtek

[PATCH] wifi: ath6kl: simplify logical condition

x <= 7 implies x < 8. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/ath/ath6kl/wmi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/wmi.c b/drivers/net/wireless/ath/ath6kl/wmi.c index 631c3a0..b8cf04d 100644 --- a/drive

[PATCH 1/1] net: pegasus: remove dead coding

(!count || count < 4) is always true. So let's remove the coding which is dead at least since 2005. Signed-off-by: Heinrich Schuchardt --- drivers/net/usb/pegasus.c | 53 --- 1 file changed, 53 deletions(-) diff --git a/drivers/net/usb/peg

[PATCH] net: au1000 eth: simplify logical expression

(a && a > 0) is equivalent to (a > 0). Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/amd/au1000_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amd/au1000_eth.c b/drivers/net/ethernet/amd/au1000_eth.c index 9af309e..

[PATCH 1/1] iwlwifi: rs: remove superfluous check

If we dereference a variable anyway in other parts of the code, there is no need to check against NULL in a single place. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless

[PATCH 1/1] mwiflex: avoid possible null pointer dereference

Do not dereference card before checking against NULL value. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/marvell/mwifiex/pcie.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell

[PATCH 1/1] mwifiex: illegal assignment

Variable adapter is incorrectly initialized. Fixes: bf00dc22bc7a ("mwifiex: AMSDU Rx frame handling in AP mode") Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/marvell/mwifiex/uap_txrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ne

[PATCH 1/1] rtlwifi: rtl8723be: avoid undefined behavior

Do not return undefined value for transmission power if the rate is invalid. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c b

[PATCH 1/1] net: rsi: eliminate superfluous NULL check

msg is dereferenced before checking against NULL, e.g. when assigning pad_bytes. Remove the superfluous check in function rsi_mgmt_pkt_to_core. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/rsi/rsi_91x_mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 1/1] net: irda: avoid null pointer dereference

Only dereference variable self after checking it is not NULL. Signed-off-by: Heinrich Schuchardt --- drivers/net/irda/nsc-ircc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/irda/nsc-ircc.c b/drivers/net/irda/nsc-ircc.c index 9ef13d8..aaecc3b 100644 --- a

[PATCH 1/1] net: ieee802154/adf7242: syntax error ifdef DEBUG

If DEBUG is defined, a superfluous closing brace is introduced. Signed-off-by: Heinrich Schuchardt --- drivers/net/ieee802154/adf7242.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c index b82e39d..9fa7ac9 100644 --- a

Re: [PATCH 1/1] net: thunderx: avoid null pointer dereference

On 05/17/2016 10:21 PM, David Daney wrote: > On 05/17/2016 12:40 PM, Heinrich Schuchardt wrote: >> In function bgx_lmac_handler only use a member of >> lmac after checking it is not null. >> > > Were you seeing and actual OOPs, or is this only a theoretical proble

[PATCH 1/1] net: i40e: avoid null pointer dereference

In function i40e_debug_aq parameter desc is assumed to be possibly NULL. Do not dereference it before checking the value. Fixes: f905dd62be88 ("i40e/i40evf: add max buf len to aq debug print helper") Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/intel/i40e/i40e_co

[PATCH 1/1] net: ehea: avoid null pointer dereference

ehea_get_port may return NULL. Do not dereference NULL value. Fixes: 8c4877a4128e ("ehea: Use the standard logging functions") Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/ibm/ehea/ehea_main.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git

[PATCH 1/1] net: hns: avoid null pointer dereference

In the statement assert(priv || priv->ae_handle); the right side of || is only evaluated if priv is null. Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ether

[PATCH 1/1] net: thunderx: avoid null pointer dereference

In function bgx_lmac_handler only use a member of lmac after checking it is not null. Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c

[PATCH 1/1] net: thunderx: avoid exposing kernel stack

Reserved fields should be set to zero to avoid exposing bits from the kernel stack. Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c b/drivers/net

[PATCH 1/1 v2] include/uapi/linux/sockios.h: mark SIOCRTMSG unused

IOCTL SIOCRTMSG does nothing but return EINVAL. So comment it as unused. SIOCRTMSG is only used in: * net/ipv4/af_inet.c * include/uapi/linux/sockios.h inet_ioctl calls ip_rt_ioctl. ip_rt_ioctl only handles SIOCADDRT and SIOCDELRT and returns -EINVAL otherwise. Signed-off-by: Heinrich

Re: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused

On 12/30/2015 11:56 AM, Michael Kerrisk (man-pages) wrote: > Hi Heinrich, > > On 12/29/2015 11:22 PM, Heinrich Schuchardt wrote: >> IOCTL SIOCRTMSG does nothing but return EINVAL. >> >> So comment it as unused. > > Can you say something about how you confi

[PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused

IOCTL SIOCRTMSG does nothing but return EINVAL. So comment it as unused. Signed-off-by: Heinrich Schuchardt --- include/uapi/linux/sockios.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/sockios.h b/include/uapi/linux/sockios.h index e888b1a..8e7890b