[PATCH v2 1/2] net, can, ifi: fix "write buffer full" error

2018-02-07 Thread Heiko Schocher
ever sends any Tx data, and buffers to userspace run over. Fixed this: clear only the bits in the IRQpending register, the driver had read. Signed-off-by: Heiko Schocher Reviewed-by: Marek Vasut --- Changes in v2: - add Reviewed-by from Marek drivers/net/can/ifi_canfd/ifi_canfd.c | 2 +- 1 fi

[PATCH v2 2/2] net, can, ifi: loopback Tx message in IFI block

2018-02-07 Thread Heiko Schocher
IFI block loopsback itself the Tx message when sended correctly on the canfd bus. Only the IFI block can insert the Tx message in the correct place. The linux driver now needs only to free the skb, when the Tx message was sended correctly. Signed-off-by: Heiko Schocher Reviewed-by: Marek Vasut

[PATCH 2/2] net, can, ifi: loopback Tx message in IFI block

2018-02-06 Thread Heiko Schocher
IFI block loopsback itself the Tx message when sended correctly on the canfd bus. Only the IFI block can insert the Tx message in the correct place. The linux driver now needs only to free the skb, when the Tx message was sended correctly. Signed-off-by: Heiko Schocher --- drivers/net/can

[PATCH 1/2] net, can, ifi: fix "write buffer full" error

2018-02-06 Thread Heiko Schocher
ever sends any Tx data, and buffers to userspace run over. Fixed this: clear only the bits in the IRQpending register, the driver had read. Signed-off-by: Heiko Schocher --- drivers/net/can/ifi_canfd/ifi_canfd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can

Re: [PATCH] Make EN2 pin optional in the TRF7970A driver

2017-03-27 Thread Heiko Schocher
Hello all, Am 21.02.2017 um 17:43 schrieb Rob Herring: On Sun, Feb 19, 2017 at 11:19 PM, Heiko Schocher wrote: Hello all, Am 13.02.2017 um 22:31 schrieb Rob Herring: On Mon, Feb 13, 2017 at 12:38 AM, Heiko Schocher wrote: Hello Rob, Am 10.02.2017 um 16:51 schrieb Rob Herring: On

Re: [PATCH] Make EN2 pin optional in the TRF7970A driver

2017-02-19 Thread Heiko Schocher
Hello all, Am 13.02.2017 um 22:31 schrieb Rob Herring: On Mon, Feb 13, 2017 at 12:38 AM, Heiko Schocher wrote: Hello Rob, Am 10.02.2017 um 16:51 schrieb Rob Herring: On Tue, Feb 07, 2017 at 06:22:04AM +0100, Heiko Schocher wrote: From: Guan Ben Make the EN2 pin optional. This is

Re: [PATCH] Make EN2 pin optional in the TRF7970A driver

2017-02-12 Thread Heiko Schocher
Hello Rob, Am 10.02.2017 um 16:51 schrieb Rob Herring: On Tue, Feb 07, 2017 at 06:22:04AM +0100, Heiko Schocher wrote: From: Guan Ben Make the EN2 pin optional. This is useful for boards, which have this pin fix wired, for example to ground. Signed-off-by: Guan Ben Signed-off-by: Mark

Re: [net, v3, 1/3] net: phy: Fix PHY module checks and NULL deref in phy_attach_direct()

2017-02-08 Thread Heiko Schocher
Hello Florian, Am 09.02.2017 um 08:13 schrieb Florian Fainelli: On 02/08/2017 10:58 PM, Heiko Schocher wrote: Hello Florian, Am 09.02.2017 um 01:13 schrieb Florian Fainelli: The Generic PHY drivers gets assigned after we checked that the current PHY driver is NULL, so we need to check a

Re: [net, v3, 1/3] net: phy: Fix PHY module checks and NULL deref in phy_attach_direct()

2017-02-08 Thread Heiko Schocher
Hello Florian, Am 09.02.2017 um 01:13 schrieb Florian Fainelli: The Generic PHY drivers gets assigned after we checked that the current PHY driver is NULL, so we need to check a few things before we can safely dereference d->driver. This would be causing a NULL deference to occur when a system b

[PATCH] Make EN2 pin optional in the TRF7970A driver

2017-02-06 Thread Heiko Schocher
From: Guan Ben Make the EN2 pin optional. This is useful for boards, which have this pin fix wired, for example to ground. Signed-off-by: Guan Ben Signed-off-by: Mark Jonas Signed-off-by: Heiko Schocher --- .../devicetree/bindings/net/nfc/trf7970a.txt | 4 ++-- drivers/nfc

Re: [PATCH] net, can, ti_hecc: add DT support for the ti,hecc controller

2015-10-19 Thread Heiko Schocher
Hello Marc, Am 19.10.2015 um 08:58 schrieb Marc Kleine-Budde: On 10/19/2015 08:39 AM, Heiko Schocher wrote: add DT support for the ti hecc controller, used on am3517 SoCs. A similar patch was posted a few days ago, see http://comments.gmane.org/gmane.linux.can/8616 and my comments. Uh

Re: [PATCH] net, can, ti_hecc: fix a run time warn_on.

2015-10-18 Thread Heiko Schocher
Hello Marc, Am 19.10.2015 um 08:34 schrieb Marc Kleine-Budde: On 10/19/2015 08:22 AM, Heiko Schocher wrote: This patch fixes a warning in clk_enable by calling clk_prepare_enable instead. What about the corresponding clk_disable_unprepare()? Yes, that should be fixed too, do this in a v2

[PATCH] net, can, ti_hecc: add DT support for the ti,hecc controller

2015-10-18 Thread Heiko Schocher
add DT support for the ti hecc controller, used on am3517 SoCs. Signed-off-by: Heiko Schocher --- .../devicetree/bindings/net/can/ti_hecc-can.txt| 20 ++ arch/arm/boot/dts/am3517.dtsi | 13 +++ drivers/net/can/ti_hecc.c | 45

[PATCH] net, can, ti_hecc: fix a run time warn_on.

2015-10-18 Thread Heiko Schocher
This patch fixes a warning in clk_enable by calling clk_prepare_enable instead. Signed-off-by: Heiko Schocher --- drivers/net/can/ti_hecc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c index cf345cb..c08e8ea 100644

[PATCH v2 1/2] drivers: net: cpsw: add phy-handle parsing

2015-10-16 Thread Heiko Schocher
add the ability to parse "phy-handle". This is needed for phys, which have a DT node, and need to parse DT properties. Signed-off-by: Heiko Schocher --- Changes in v2: None Documentation/devicetree/bindings/net/cpsw.txt | 1 + drivers/net/ethernet/ti/cpsw.c

[PATCH v2 2/2] net: phy: smsc: disable energy detect mode

2015-10-16 Thread Heiko Schocher
On some boards the energy enable detect mode leads in trouble with some switches, so make the enabling of this mode configurable through DT. Signed-off-by: Heiko Schocher --- Changes in v2: - add comments from Florian Fainelli - I did not change disable property name into enable because I

[PATCH v2 0/2] net, phy, smsc: add posibility to disable energy detect mode

2015-10-16 Thread Heiko Schocher
OF and use __maybe_unused - introduce "phy-handle" ability into ti,cpsw driver, so I can remove bogus: if (!of_node && dev->parent->of_node) of_node = dev->parent->of_node; construct. Therefore new patch for the ti,cpsw driver is necessary. Heiko Sch

Re: [PATCH] net: phy: smsc: disable energy detect mode

2015-10-16 Thread Heiko Schocher
Hello Florian, Am 16.10.2015 um 18:27 schrieb Florian Fainelli: 2015-10-13 21:17 GMT-07:00 Heiko Schocher : Hello Florian, Am 13.10.2015 um 21:26 schrieb Florian Fainelli: On 12/10/15 22:13, Heiko Schocher wrote: On some boards the energy enable detect mode leads in trouble with some

Re: [PATCH] net: phy: smsc: disable energy detect mode

2015-10-15 Thread Heiko Schocher
Hello Florian, Am 14.10.2015 um 06:17 schrieb Heiko Schocher: Hello Florian, Am 13.10.2015 um 21:26 schrieb Florian Fainelli: On 12/10/15 22:13, Heiko Schocher wrote: On some boards the energy enable detect mode leads in trouble with some switches, so make the enabling of this mode

Re: [PATCH] net: phy: smsc: disable energy detect mode

2015-10-13 Thread Heiko Schocher
Hello Florian, Am 13.10.2015 um 21:26 schrieb Florian Fainelli: On 12/10/15 22:13, Heiko Schocher wrote: On some boards the energy enable detect mode leads in trouble with some switches, so make the enabling of this mode configurable through DT. Signed-off-by: Heiko Schocher

[PATCH] net: phy: smsc: disable energy detect mode

2015-10-12 Thread Heiko Schocher
On some boards the energy enable detect mode leads in trouble with some switches, so make the enabling of this mode configurable through DT. Signed-off-by: Heiko Schocher --- .../devicetree/bindings/net/smsc-lan87xx.txt | 19 + drivers/net/phy/smsc.c