Hi,
On 3/22/21 5:02 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> gcc-11 warns that intel_dp_check_mst_status() has a local array of
> fourteen bytes and passes the last four bytes into a function that
> expects a six-byte array:
>
> drivers/gpu/drm/i915/display/intel_dp.c: In function
>
Hi,
On 1/25/21 1:40 PM, Johannes Berg wrote:
> Hi,
>
>>> I don't have that much sympathy for a staging driver that's clearly
>>> doing things differently than it was intended (the documentation states
>>> that the function should be called only before wiphy_register(), not
>>> during ndo_open). :
Hi,
On 1/25/21 10:47 AM, Johannes Berg wrote:
> Hi,
>
> Sorry, apparently we have two threads.
>
>> Great, thank you for looking into this. Let me know if you have a patch
>> which you want me to test on a RTL8723BS adapter.
>
> Could you test this instead?
>
> https://p.sipsolutions.net/235c3
Hi,
On 1/24/21 10:12 AM, Peer, Ilan wrote:
>> -Original Message-
>> From: Johannes Berg
>> Sent: Sunday, January 24, 2021 00:16
>> To: Hans de Goede ; netdev@vger.kernel.org
>> Cc: linux-wirel...@vger.kernel.org; Peer, Ilan ;
>> Coelho, Luciano
&g
On 1/18/21 9:47 PM, Johannes Berg wrote:
> Hi,
>
> New try, dropped the 160 MHz CSA patch for now that has the sparse
> issue since people are waiting for the kernel-doc fixes.
>
> Please pull and let me know if there's any problem.
>
> Thanks,
> johannes
>
>
>
> The following changes sinc
Hi,
On 1/5/21 10:24 AM, Peer, Ilan wrote:
> Hi,
>
>> -Original Message-----
>> From: Hans de Goede
>> Sent: Monday, January 04, 2021 19:07
>> To: Johannes Berg ; David S . Miller
>> ; Jakub Kicinski ; Rojewski,
>> Cezary ; Pierre-Louis Bossart >
eps the
2 calls, to allow drivers to call wiphy_apply_custom_regulatory more then
once if necessary.
Cc: Ilan Peer
Fixes: beee24695157 ("cfg80211: Save the regulatory domain when setting custom
regulator")
Signed-off-by: Hans de Goede
---
net/wireless/reg.c | 5 +++--
1 file changed, 3 insertions(+), 2
systems")
> Reviewed-by: Alexander Duyck
> Signed-off-by: Mario Limonciello
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/net/ethernet/intel/e1000e/netdev.c | 45 +-
> 1 file changed, 2 insertions(+), 43 del
ake more than 1 second
> but less than 2.5 seconds and emit a warning on resume for those
> scenarios.
>
> Suggested-by: Aaron Ma
> Suggested-by: Sasha Netfin
> Suggested-by: Hans de Goede
> CC: Mark Pearson
> Fixes: f15bb6dde738cc8fa0 ("e1000e: Add support for S0ix&
r.
> - Increase ULP timeout to 2.5 seconds, but show a warning after 1 second.
Thank you. I've given v5 a test on a Lenovo X1 Carbon 8th gen (AMT capable)
and things work fine there with v5:
Tested-by: Hans de Goede
Regards,
Hans
> Changes from v3 to v4:
> - Drop patch 1 for p
adjust it until the kernel could have your
> configuration in a disallow list.
>
> Signed-off-by: Mario Limonciello
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/net/ethernet/intel/e1000e/e1000.h | 1 +
> drivers/ne
Hi,
On 12/14/20 8:36 PM, Limonciello, Mario wrote:
>> Hi All,
>>
>> Sasha (and the other intel-wired-lan folks), thank you for investigating this
>> further and for coming up with a better solution.
>>
>> Mario, thank you for implementing the new scheme.
>>
>
> Sure.
>
>> I've tested this patch
Hi,
On 12/14/20 4:34 PM, Mario Limonciello wrote:
> This flag can be used by an end user to disable S0ix flows on a
> buggy system or by an OEM for development purposes.
>
> If you need this flag to be persisted across reboots, it's suggested
> to use a udev rule to call adjust it until the kerne
Hi All,
Sasha (and the other intel-wired-lan folks), thank you for investigating this
further and for coming up with a better solution.
Mario, thank you for implementing the new scheme.
I've tested this patch set on a Lenovo X1C8 with vPRO and AMT enabled in the
BIOS
(the previous issues were s
Hi,
On 12/8/20 5:14 PM, Alexander Duyck wrote:
> On Tue, Dec 8, 2020 at 1:30 AM Hans de Goede wrote:
>>
>> Hi,
>>
>> On 12/8/20 6:08 AM, Neftin, Sasha wrote:
>>> On 12/7/2020 17:41, Limonciello, Mario wrote:
>>>>> First of all thank you for wo
Hi,
On 12/8/20 6:08 AM, Neftin, Sasha wrote:
> On 12/7/2020 17:41, Limonciello, Mario wrote:
>>> First of all thank you for working on this.
>>>
>>> I must say though that I don't like the approach taken here very
>>> much.
>>>
>>> This is not so much a criticism of this series as it is a criticis
Hi,
On 12/4/20 9:09 PM, Mario Limonciello wrote:
> commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME
> systems")
> disabled s0ix flows for systems that have various incarnations of the
> i219-LM ethernet controller. This was done because of some regressions
> caused by an ea
>
> ---
>
> Changes in v3:
> Use only two more generic wildcards.
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
>
> Changes in v2:
> In comparison to first version [0] we use wildcards to enumerate the
> firmware configuration files. Wi
Hi,
On 11/20/20 12:11 PM, Matthias Brugger wrote:
>
>
> On 20/11/2020 11:05, Dmitry Osipenko wrote:
>> 20.11.2020 12:52, matthias@kernel.org пишет:
>>> From: Matthias Brugger
>>>
>>> Apart from a firmware binary the chip needs a config file used by the
>>> FW. Add the config files to modinf
Hi Tom,
Quick self intro: I have take over drivers/platform/x86
maintainership from Andy.
On 10/17/20 6:09 PM, t...@redhat.com wrote:
> From: Tom Rix
>
> This is a upcoming change to clean up a new warning treewide.
> I am wondering if the change could be one mega patch (see below) or
> normal
y: Petr Tesarik
Tested-by: Petr Tesarik
Signed-off-by: Heiner Kallweit
Thank you.
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/net/ethernet/realtek/r8169_main.c | 32 ++-
1 file changed, 19 insertions(+), 13 deletions(-)
diff --gi
Hi,
On 9/29/20 10:35 PM, Heiner Kallweit wrote:
On 29.09.2020 22:08, Hans de Goede wrote:
Also some remarks about this while I'm being a bit grumpy about
all this anyways (sorry):
1. 9f0b54cd167219 ("r8169: move switching optional clock on/off
to pll power functions") c
p.s.
On 9/29/20 10:08 PM, Hans de Goede wrote:
So I believe that the proper fix for this is to revert
commit 9f0b54cd167219
("r8169: move switching optional clock on/off to pll power functions")
Heiner, assuming you agree that reverting this commit is
the best way to fix thi
Hi,
On 9/29/20 9:07 PM, Petr Tesarik wrote:
Hi Heiner (and now also Hans)!
@Hans: I'm adding you to this conversation, because you're the author
of commit b1e3454d39f99, which seems to break the r8169 driver on a
laptop of mine.
Erm, no, as you bi-sected yourself already commit 9f0b54cd167219
Hi,
On 7/3/20 4:01 PM, Matthias Brugger wrote:
On 02/07/2020 20:00, Hans de Goede wrote:
Hi,
On 7/1/20 5:46 PM, Matthias Brugger wrote:
Hi Hans,
On 01/07/2020 17:38, Hans de Goede wrote:
Hi,
On 7/1/20 5:31 PM, matthias@kernel.org wrote:
From: Matthias Brugger
Apart from a
Hi,
On 7/1/20 5:46 PM, Matthias Brugger wrote:
Hi Hans,
On 01/07/2020 17:38, Hans de Goede wrote:
Hi,
On 7/1/20 5:31 PM, matthias@kernel.org wrote:
From: Matthias Brugger
Apart from a firmware binary the chip needs a config file used by the
FW. Add the config files to modinfo so that
Hi,
On 7/1/20 5:31 PM, matthias@kernel.org wrote:
From: Matthias Brugger
Apart from a firmware binary the chip needs a config file used by the
FW. Add the config files to modinfo so that they can be read by
userspace.
The configfile firmware filename is dynamically generated, just adding
hat we will
still be able to load the config file, even when the compatible has a
'/'. This fixes explicitly the firmware loading for
"solidrun,cubox-i/q".
Signed-off-by: Matthias Brugger
---
Changes in v3:
- use len variable to store length of string (Hans de Goede)
- fix f
o that we will
still be able to load the config file, even when the compatible has a
'/'. This fixes explicitly the firmware loading for
"solidrun,cubox-i/q".
Signed-off-by: Matthias Brugger
---
Changes in v2:
- use strscpy instead of strncpy (Hans de Goede)
- use strlen(tmp) +
Hi,
On 6/25/20 6:07 PM, matthias@kernel.org wrote:
From: Matthias Brugger
The driver relies on the compatible string from DT to determine which
FW configuration file it should load. The DTS spec allows for '/' as
part of the compatible string. We change this to '-' so that we will
still be
ed]
Mark it 'inline' to force gcc to understand this.
Fixes: ce2e6db554fa ("brcmfmac: Add support for getting nvram contents from EFI
variables")
Signed-off-by: Arnd Bergmann
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/net/w
Disable the clk during suspend to save power. Note that tp->clk may be
NULL, the clk core functions handle this without problems.
Reviewed-by: Andy Shevchenko
Tested-by: Carlo Caione
Signed-off-by: Hans de Goede
---
drivers/net/ethernet/realtek/r8169.c | 5 +
1 file changed, 5 inserti
Hi,
On 27-08-18 21:14, Stephen Boyd wrote:
Quoting Hans de Goede (2018-08-27 11:53:19)
On 27-08-18 20:47, Stephen Boyd wrote:
How would you know that a clk device driver hasn't probed yet and isn't
the driver that's actually providing the clk to this device on x86
systems? Wit
Hi,
On 29-08-18 18:31, Andy Shevchenko wrote:
On Mon, Aug 27, 2018 at 04:31:56PM +0200, Hans de Goede wrote:
Hi All,
This series has as goal to revert commit d31fd43c0f9a ("clk: x86: Do not gate
clocks enabled by the firmware"), because that commit causes almost all
Cherry Trail
Hi,
On 27-08-18 20:47, Stephen Boyd wrote:
Quoting Hans de Goede (2018-08-27 07:31:58)
On some boards a platform clock is used as clock for the r8169 chip,
this commit adds support for getting and enabling this clock (assuming
it has an "ether_clk" alias set on it).
This is related
Disable the clk during suspend to save power. Note that tp->clk may be
NULL, the clk core functions handle this without problems.
Signed-off-by: Hans de Goede
---
drivers/net/ethernet/realtek/r8169.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/realtek/r8169.c
annes Stezenbach
Cc: Carlo Caione
Signed-off-by: Hans de Goede
---
drivers/clk/x86/clk-pmc-atom.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/clk/x86/clk-pmc-atom.c b/drivers/clk/x86/clk-pmc-atom.c
index 75151901ff7d..d977193842df 100644
--- a/drivers/clk/x86/clk-pmc-atom.c
+
nd enable it when
it needs it.
Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=193891#c102
Cc: Johannes Stezenbach
Cc: Carlo Caione
Signed-off-by: Hans de Goede
---
drivers/net/ethernet/realtek/r8169.c | 33
1 file changed, 33 insertions(+)
diff --git a/
t.
This commit uses clkdev_hw_create() to create the alias, mirroring the code
for the already existing "mclk" alias for pmc_plt_clk_3.
Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=193891#c102
Cc: Johannes Stezenbach
Cc: Carlo Caione
Signed-off-by: Hans de Goede
---
drive
Hi All,
This series has as goal to revert commit d31fd43c0f9a ("clk: x86: Do not gate
clocks enabled by the firmware"), because that commit causes almost all
Cherry Trail devices to not use the S0i3 powerstate when suspending, leading
to them quickly draining their battery when suspended.
This co
Hi,
On 09-04-17 10:01, Marcel Holtmann wrote:
Hi Hans,
The OBDA8723 ACPI HID is used on quite a few Bay Trail based tablets
for bluetooth rfkill functionality.
Tested-by: russianneuroman...@ya.ru
Signed-off-by: Hans de Goede
---
net/rfkill/rfkill-gpio.c | 1 +
1 file changed, 1 insertion
The OBDA8723 ACPI HID is used on quite a few Bay Trail based tablets
for bluetooth rfkill functionality.
Tested-by: russianneuroman...@ya.ru
Signed-off-by: Hans de Goede
---
net/rfkill/rfkill-gpio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill
On my home network rtl8xxxu is spamming the log with
IEEE80211_AMPDU_RX_START / IEEE80211_AMPDU_RX_STOP every few seconds
turn these messages into debug messages.
Signed-off-by: Hans de Goede
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 10 +-
1 file changed, 5 insertions
Hi,
On 15-07-16 22:42, Arnd Bergmann wrote:
On Wednesday, July 13, 2016 12:20:04 PM CEST Hans de Goede wrote:
+&mmc1 {
+ non-removable;
+ status = "okay";
+
+ sdio_wifi: sdio_wifi@1 {
+ compatible = "generic,ethernet"
Hi,
On 15-07-16 19:51, David Miller wrote:
From: Hans de Goede
Date: Fri, 15 Jul 2016 08:40:00 +0200
Hi,
On 15-07-16 01:17, David Miller wrote:
From: Hans de Goede
Date: Wed, 13 Jul 2016 12:20:04 +0200
On some boards (android tablets) different batches use different sdio
wifi modules
Hi,
On 15-07-16 08:40, Hans de Goede wrote:
Hi,
On 15-07-16 01:17, David Miller wrote:
From: Hans de Goede
Date: Wed, 13 Jul 2016 12:20:04 +0200
On some boards (android tablets) different batches use different sdio
wifi modules. This is not a problem since sdio is a discoverable bus,
so we
Hi,
On 15-07-16 01:17, David Miller wrote:
From: Hans de Goede
Date: Wed, 13 Jul 2016 12:20:04 +0200
On some boards (android tablets) different batches use different sdio
wifi modules. This is not a problem since sdio is a discoverable bus,
so we only need to describe and activate the mmc
unknown (differs per batch) we cannot use
a wifi-chip specific compatible. This commit adds a new
"generic,ethernet" binding for use in dt-nodes describing such an
unknown ethernet device.
Cc: Maxime Ripard
Signed-off-by: Hans de Goede
---
Documentation/devicetree/bindings/net/generic.txt |
angepi-one. You can add my:
Tested-by: Hans de Goede
For the next version of this series.
Attached is a dts patch for adding support
for the emac one that one (to be applied on top of this patch-set).
I've a Orange PI Plus and a Orange PI 2 as well, both of which use an external
phy, I wou
Hi,
On 07-05-16 07:30, Chen-Yu Tsai wrote:
Hi,
On Tue, Apr 12, 2016 at 9:38 AM, Chen-Yu Tsai wrote:
On Tue, Apr 12, 2016 at 3:23 AM, Florian Fainelli wrote:
On 04/04/16 09:22, Chen-Yu Tsai wrote:
The Allwinner H3 SoC incorporates an Ethernet PHY. This is enabled and
configured through a me
Hi,
On 20-10-15 13:17, David Miller wrote:
From: Hans de Goede
Date: Tue, 20 Oct 2015 10:42:23 +0200
IIRC you said you would pick this up, but I'm not seeing it in
net-next, hence this resend.
If it's not in my tree, and it's not active on patchwork, you really
have to rese
Hi Davem,
IIRC you said you would pick this up, but I'm not seeing it in net-next,
hence this resend.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-
.
Signed-off-by: Hans de Goede
---
drivers/net/ethernet/allwinner/sun4i-emac.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/allwinner/sun4i-emac.c
b/drivers/net/ethernet/allwinner/sun4i-emac.c
index 48ce83e..8d50314 100644
--- a
.
Signed-off-by: Hans de Goede
---
drivers/net/ethernet/allwinner/sun4i-emac.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/allwinner/sun4i-emac.c
b/drivers/net/ethernet/allwinner/sun4i-emac.c
index 48ce83e..8d50314 100644
--- a
Hi,
On 24-08-15 09:46, Maxime Ripard wrote:
Hi Hans,
On Sun, Aug 23, 2015 at 08:31:38PM +0200, Hans de Goede wrote:
Claim the emac sram ourselves, rather then relying on the bootloader
having mapped the sram to the emac controller during boot.
Signed-off-by: Hans de Goede
---
drivers/net
Claim the emac sram ourselves, rather then relying on the bootloader
having mapped the sram to the emac controller during boot.
Signed-off-by: Hans de Goede
---
drivers/net/ethernet/allwinner/sun4i-emac.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers
56 matches
Mail list logo
