Re: [PATCH 13/19] net: split out functions related to registering inflight socket files

2019-02-09 Thread Hannes Reinecke
| 71 +--- net/unix/scm.c| 146 ++ net/unix/scm.h| 10 +++ 7 files changed, 168 insertions(+), 130 deletions(-) create mode 100644 net/unix/scm.c create mode 100644 net/unix/scm.h Reviewed-by: Hannes Reinecke Cheers, Hannes

Re: [PATCH 00/16] remove eight obsolete architectures

2018-03-15 Thread Hannes Reinecke
On 03/15/2018 10:42 AM, David Howells wrote: > Do we have anything left that still implements NOMMU? > RISC-V ? (evil grin :-) Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE

Re: [lldp-devel] Fwd: [PATCH RESEND] Fix segfault on "lldptool -t -i eth2 -V PFC -c enabled"

2017-11-07 Thread Hannes Reinecke
_ take fixes for it. Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)

Re: [PATCH V3 2/2] qedf: Add QLogic FastLinQ offload FCoE driver framework.

2017-02-06 Thread Hannes Reinecke
lport; > + > + orig_io_req = cb_arg->aborted_io_req; > + > + if (!orig_io_req) > + goto out_free; > + > + if (rec_req->event != QEDF_IOREQ_EV_ELS_TMO && > + rec_req->event != QEDF_IOREQ_EV_ELS_ERR_DETECT) > + cancel_delayed_work_sync(&orig

Re: [PATCH V2 2/2] qedf: Add QLogic FastLinQ offload FCoE driver framework.

2017-02-01 Thread Hannes Reinecke
On 01/31/2017 06:08 PM, Chad Dupuis wrote: On Mon, 30 Jan 2017, 10:34am -, Hannes Reinecke wrote: On 01/25/2017 09:33 PM, Dupuis, Chad wrote: From: "Dupuis, Chad" [ .. ] + if (opcode == ELS_LS_RJT) { + rjt = fc_frame_payload_get(fp, s

Re: [PATCH V2 2/2] qedf: Add QLogic FastLinQ offload FCoE driver framework.

2017-01-30 Thread Hannes Reinecke
qedf) > +{ > + int i, rc, cpu; > + > + cpu = cpumask_first(cpu_online_mask); > + for (i = 0; i < qedf->num_queues; i++) { > + rc = request_irq(qedf->int_info.msix[i].vector, > + qedf_msix_handler, 0, "qedf", &qedf->fp_array[i]); > + > + if (rc) { > + QEDF_WARN(&(qedf->dbg_ctx), "request_irq failed.\n"); > + qedf_sync_free_irqs(qedf); > + return rc; > + } > + > + qedf->int_info.used_cnt++; > + rc = irq_set_affinity_hint(qedf->int_info.msix[i].vector, > + get_cpu_mask(cpu)); > + cpu = cpumask_next(cpu, cpu_online_mask); > + } > + > + return 0; > +} > + Please use pci_alloc_irq_vectors() here; that avoid you having to do SMP affinity setting yourself. Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)

Re: [PATCH V2 net-next 1/2] qed: Add support for hardware offloaded FCoE.

2017-01-30 Thread Hannes Reinecke
f CONFIG_DCB > struct qed_dcbx_set set; > -#endif > + struct qed_dcbx_get get; > u8 dcbx_cap; > }; > Why did you remove the dependency on 'CONFIG_DCB'? Other than that: Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke

Re: [Open-FCoE] [PATCH 2/2] qedf: Add QLogic FastLinQ offload FCoE driver framework.

2017-01-18 Thread Hannes Reinecke
rrent_state(TASK_INTERRUPTIBLE); > + } > + > + __set_current_state(TASK_RUNNING); > + return 0; > +} > + Please: don't. The RT folks are trying to get rid of kthreads altogether as it's a nightmare to get it to work with cpu hotplugging. Please convert to wor

Re: [Open-FCoE] [PATCH 1/2] qed: Add support for hardware offloaded FCoE.

2017-01-18 Thread Hannes Reinecke
; > Signed-off-by: Arun Easi > Signed-off-by: Yuval Mintz > --- Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409

Re: [Open-FCoE] [PATCH RFC 5/5] qedf: Add FIP request handling

2017-01-09 Thread Hannes Reinecke
On 01/09/2017 05:47 PM, Chad Dupuis wrote: > > On Wed, 28 Dec 2016, 9:11am -, Hannes Reinecke wrote: > >> On 12/23/2016 08:17 PM, Dupuis, Chad wrote: >>> From: "Dupuis, Chad" >>> >>> This patch adds handling for FIP requests and responses

Re: [Open-FCoE] [PATCH RFC 2/5] qedf: Add QLogic FastLinQ offload FCoE driver framework.

2017-01-09 Thread Hannes Reinecke
On 01/09/2017 05:45 PM, Chad Dupuis wrote: > > On Wed, 28 Dec 2016, 9:00am -, Hannes Reinecke wrote: > >> On 12/23/2016 08:17 PM, Dupuis, Chad wrote: >>> From: "Dupuis, Chad" >>> >>> The QLogic FastLinQ Driver for FCoE (qedf) is the

Re: [Open-FCoE] [PATCH RFC 5/5] qedf: Add FIP request handling

2016-12-28 Thread Hannes Reinecke
_FIP_ALL_FCF_MACS((__u8[6]) { 1, 0x10, 0x18, 1, 0, 2 }) > + static u8 my_fcoe_all_fcfs[ETH_ALEN] = MY_FIP_ALL_FCF_MACS; Do you support VN2VN, too? Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)

Re: [Open-FCoE] [PATCH RFC 4/5] qedf: Add offload ELS request handling.

2016-12-28 Thread Hannes Reinecke
rav Kashyap > Signed-off-by: Chad Dupuis > --- > drivers/scsi/qedf/qedf_els.c | 984 > +++ > 1 file changed, 984 insertions(+) > create mode 100644 drivers/scsi/qedf/qedf_els.c > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr

Re: [Open-FCoE] [PATCH RFC 3/5] qedf: Add offloaded I/O request functions.

2016-12-28 Thread Hannes Reinecke
scsi_block_requests(qedf->lport->host); > + Typically, EH commands will be executed after the scsi host is stopped and no commands are outstanding. So there's no point in issuing 'scsi_block_requests()' here. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)

Re: [Open-FCoE] [PATCH RFC 2/5] qedf: Add QLogic FastLinQ offload FCoE driver framework.

2016-12-28 Thread Hannes Reinecke
t; + > + /* Save producer index */ > + que->cq_prod_idx = prod_idx; > + > + while (new_cqes) { > + fp->completions++; > + num_handled++; > + cqe = &que->cq[que->cq_cons_idx]; > + > +

Re: [Open-FCoE] [PATCH RFC net-next 1/5] qed: Add support for hardware offloaded FCoE.

2016-12-28 Thread Hannes Reinecke
On 12/23/2016 08:17 PM, Dupuis, Chad wrote: > From: Arun Easi > > This adds the backbone required for the various HW initalizations > which are necessary for the FCoE driver (qedf) for QLogic FastLinQ > 4 line of adapters - FW notification, resource initializations, etc. > > Signed-off-by: A

Re: [PATCH v2 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-11-14 Thread Hannes Reinecke
On 11/15/2016 07:14 AM, Rangankar, Manish wrote: > Hi Hannes, > > Please find the response below, > > On 11/11/16 10:13 PM, "Hannes Reinecke" wrote: > [ .. ] >> Please use the irq-affinity rework from Christoph here; that'll save you >> the addition

Re: [PATCH v2 5/6] qedi: Add support for iSCSI session management.

2016-11-11 Thread Hannes Reinecke
/qedi_iscsi.h Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)

Re: [PATCH v2 6/6] qedi: Add support for data path.

2016-11-11 Thread Hannes Reinecke
--- drivers/scsi/qedi/qedi_fw.c| 1272 drivers/scsi/qedi/qedi_gbl.h |6 + drivers/scsi/qedi/qedi_iscsi.c | 13 + drivers/scsi/qedi/qedi_main.c |4 + 4 files changed, 1295 insertions(+) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes

Re: [PATCH v2 4/6] qedi: Add LL2 iSCSI interface for offload iSCSI.

2016-11-11 Thread Hannes Reinecke
: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)

Re: [PATCH v2 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-11-11 Thread Hannes Reinecke
On 11/08/2016 07:57 AM, Manish Rangankar wrote: The QLogic FastLinQ Driver for iSCSI (qedi) is the iSCSI specific module for 41000 Series Converged Network Adapters by QLogic. This patch consists of following changes: - MAINTAINERS Makefile and Kconfig changes for qedi, - PCI driver registra

Re: [PATCH v2 2/6] qed: Add iSCSI out of order packet handling.

2016-11-11 Thread Hannes Reinecke
/net/ethernet/qlogic/qed/qed_ooo.c create mode 100644 drivers/net/ethernet/qlogic/qed/qed_ooo.h Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldst

Re: [PATCH v2 1/6] qed: Add support for hardware offloaded iSCSI.

2016-11-11 Thread Hannes Reinecke
*firmware; u32 rdma_max_sge; 10 connections? Only? Hmm. Other than that: Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90

Re: [RFC 2/6] qed: Add iSCSI out of order packet handling.

2016-10-19 Thread Hannes Reinecke
On 10/19/2016 07:01 AM, manish.rangan...@cavium.com wrote: > From: Yuval Mintz > > This patch adds out of order packet handling for hardware offloaded > iSCSI. Out of order packet handling requires driver buffer allocation > and assistance. > > Signed-off-by: Arun Easi > Signed-off-by: Yuval Mi

Re: [RFC 1/6] qed: Add support for hardware offloaded iSCSI.

2016-10-19 Thread Hannes Reinecke
On 10/19/2016 07:01 AM, manish.rangan...@cavium.com wrote: > From: Yuval Mintz > > This adds the backbone required for the various HW initalizations > which are necessary for the iSCSI driver (qedi) for QLogic FastLinQ > 4 line of adapters - FW notification, resource initializations, etc. >

Re: [RFC 6/6] qedi: Add support for data path.

2016-10-19 Thread Hannes Reinecke
On 10/19/2016 07:01 AM, manish.rangan...@cavium.com wrote: > From: Manish Rangankar > > This patch adds support for data path and TMF handling. > > Signed-off-by: Nilesh Javali > Signed-off-by: Adheer Chandravanshi > Signed-off-by: Chad Dupuis > Signed-off-by: Saurav Kashyap > Signed-off-by:

Re: [RFC 5/6] qedi: Add support for iSCSI session management.

2016-10-19 Thread Hannes Reinecke
On 10/19/2016 07:01 AM, manish.rangan...@cavium.com wrote: > From: Manish Rangankar > > This patch adds support for iscsi_transport LLD Login, > Logout, NOP-IN/NOP-OUT, Async, Reject PDU processing > and Firmware async event handling support. > > Signed-off-by: Nilesh Javali > Signed-off-by: Ad

Re: [RFC 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-10-19 Thread Hannes Reinecke
On 10/19/2016 07:01 AM, manish.rangan...@cavium.com wrote: > From: Manish Rangankar > > The QLogic FastLinQ Driver for iSCSI (qedi) is the iSCSI specific module > for 41000 Series Converged Network Adapters by QLogic. > > This patch consists of following changes: > - MAINTAINERS Makefile and K

Re: [RFC 4/6] qedi: Add LL2 iSCSI interface for offload iSCSI.

2016-10-19 Thread Hannes Reinecke
Dupuis > Signed-off-by: Saurav Kashyap > Signed-off-by: Arun Easi > Signed-off-by: Manish Rangankar > --- > drivers/scsi/qedi/qedi.h | 73 + > drivers/scsi/qedi/qedi_main.c | 357 > ++ > 2 files changed, 430 insert

Re: [PATCHv2 3/4] pci: Determine actual VPD size on first access

2016-08-10 Thread Hannes Reinecke
On 08/09/2016 08:12 PM, Alexander Duyck wrote: > On Tue, Aug 9, 2016 at 5:54 AM, Alexey Kardashevskiy wrote: >> On 10/02/16 08:04, Bjorn Helgaas wrote: >>> On Wed, Jan 13, 2016 at 12:25:34PM +0100, Hannes Reinecke wrote: >>>> PCI-2.2 VPD entries have a maximum s

[PATCH] fddi: Fixup potential uninitialized bars

2016-01-25 Thread Hannes Reinecke
, and adds a WARN_ON check if that should no be the case. And I've made some minor code reshuffles to keep checkpatch happy. Signed-off-by: Hannes Reinecke --- drivers/net/fddi/defxx.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/driver

Re: [RFC PATCH 0/4] Make iSCSI network namespace aware

2015-05-21 Thread Hannes Reinecke
could trivially run open-iscsi in containers and stufflike; currently it'll be hard as there really is only one iscsid expected to be running in a system. Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Hannes Reinecke
oo busy, sorry). If someone else confirms it does it's job then Acked-by: Hannes Reinecke <[EMAIL PROTECTED]> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage [EMAIL PROTECTED] +49 911 74053 688 SUSE LINUX Products GmbH, Maxfe

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-09-25 Thread Hannes Reinecke
e a new strucutre (something like struct io_restrictions). then > somehow we could link the new structure with request_queue and device > strucutres. > I'd prefer the latter. These struct io_restrictions could then be used by dm (which has it's own version right now) to merge que