Re: [PATCH] macb: Fix speed setting

2008-02-21 Thread Haavard Skinnemoen
On Fri, 22 Feb 2008 00:07:31 +0900 (JST) Atsushi Nemoto <[EMAIL PROTECTED]> wrote: > > I'm willing to take your word for it, but some documentation would be > > really nice... > > Well, simple grepping drivers/net/phy enlighten us ;) Yeah, the patch certainly looks correct as far as I can tell

Re: [PATCH] macb: Fix speed setting

2008-02-21 Thread Haavard Skinnemoen
On Thu, 21 Feb 2008 22:50:54 +0900 (JST) Atsushi Nemoto <[EMAIL PROTECTED]> wrote: > Fix NCFGR.SPD setting on 10Mbps. This bug was introduced by > conversion to generic PHY layer in kernel 2.6.23. > > Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]> > --- > diff --git a/drivers/net/macb.c b/dri

Re: BUG: 2.6.25-rc1: iptables postrouting setup causes oops

2008-02-13 Thread Haavard Skinnemoen
On Wed, 13 Feb 2008 08:42:15 -0800 "Andrew G. Morgan" <[EMAIL PROTECTED]> wrote: > However, it is a warning and, for any existing app that doesn't care > about newly added capabilities, the warning is benign. Ok, I see. Thanks for explaining. Haavard -- To unsubscribe from this list: send the li

Re: BUG: 2.6.25-rc1: iptables postrouting setup causes oops

2008-02-13 Thread Haavard Skinnemoen
On Wed, 13 Feb 2008 10:10:24 +0100 Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > > > ip_tables: (C) 2000-2006 Netfilter Core Team > > > nf_conntrack version 0.5.0 (1024 buckets, 4096 max) > > > Unable to handle kernel paging request at virtual address d

Re: BUG: 2.6.25-rc1: iptables postrouting setup causes oops

2008-02-13 Thread Haavard Skinnemoen
On Wed, 13 Feb 2008 00:48:29 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Tue, 12 Feb 2008 22:46:01 +1100 Ben Nizette <[EMAIL PROTECTED]> wrote: > > > > > On an AVR32, root over NFS, config attached, running (from a startup > > script): > > > > iptables -t nat -A POSTROUTING -o eth0 -j M

[PATCH] macb: Fix section mismatch and shrink runtime footprint

2008-01-31 Thread Haavard Skinnemoen
tion after the driver has loaded. This also fixes a section mismatch due to macb_probe(), defined as __devinit, calling macb_get_hwaddr, defined as __init. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- drivers/net/macb.c |9 - 1 files changed, 4 insertions(+), 5 de

Re: [PATCH] PHYLIB: Locking fixes for PHY I/O potentially sleeping

2008-01-29 Thread Haavard Skinnemoen
On Tue, 29 Jan 2008 10:05:09 -0600 Nate Case <[EMAIL PROTECTED]> wrote: > +/* PHY timer which schedules the state machine work */ > +static void phy_timer(unsigned long data) > +{ > + struct phy_device *phydev = (struct phy_device *)data; > + > + /* > + * PHY I/O operations can potent

[PATCH] MACB: clear transmit buffers properly on transmit underrun

2007-12-19 Thread Haavard Skinnemoen
upper layer. Signed-off-by: Gregory CLEMENT <[EMAIL PROTECTED]> Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- drivers/net/macb.c | 25 - 1 files changed, 24 insertions(+), 1 deletions(-) diff --git a/drivers/net/macb.c b/drivers/net/macb.c inde

Re: [PATCH] MACB: clear transmit buffers properly on TX Underrun

2007-12-18 Thread Haavard Skinnemoen
On Sun, 16 Dec 2007 12:37:25 +0100 Gregory CLEMENT <[EMAIL PROTECTED]> wrote: > Haavard Skinnemoen a écrit : > > But the patch is a bit mangled, so I don't think it will apply. Please > > have a look in Documentation/email-clients.txt for information on how > > to

Re: [PATCH] MACB: clear transmit buffers properly on TX Underrun

2007-12-13 Thread Haavard Skinnemoen
On Thu, 13 Dec 2007 08:51:57 +0100 Gregory CLEMENT <[EMAIL PROTECTED]> wrote: > Hi, > I generated this patch for linux 2.6.24-rc5 and test it on AT91SAM9263 > with iperf. > > From: Gregory CLEMENT <[EMAIL PROTECTED]> > Date: Wed, 12 Dec 2007 18:10:14 +0100 > Subject: [PATCH] MACB: clear transmit

[PATCH 2.6.23-rc8-mm2] Fix a compile problem in macb.c

2007-10-02 Thread Haavard Skinnemoen
PROTECTED]> Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- drivers/net/macb.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/macb.c b/drivers/net/macb.c index c28a0a4..047ea7b 100644 --- a/drivers/net/macb.c +++ b/drivers/net/macb.c @@ -492,

[PATCH] macb: Use generic PHY layer

2007-07-12 Thread Haavard Skinnemoen
From: frederic RODO <[EMAIL PROTECTED]> Convert the macb driver to use the generic PHY layer in drivers/net/phy. Signed-off-by: Frederic RODO <[EMAIL PROTECTED]> Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- drivers/net/Kconfig |2 +-

[PATCH] macb: Add multicast capability

2007-07-12 Thread Haavard Skinnemoen
From: Patrice Vilchez <[EMAIL PROTECTED]> Add multicast capability to Atmel ethernet macb driver. Signed-off-by: Patrice Vilchez <[EMAIL PROTECTED]> Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- drivers/net/macb.c | 120 +++

[PATCH] macb: Remove inappropriate spinlocks around mii calls

2007-02-16 Thread Haavard Skinnemoen
Remove spin_lock_irqsave() around mii_ethtool_gset, mii_ethtool_sset and generic_mii_ioctl. These are unnecessary and harmful because the mii calls may call back into the mdio functions, which may sleep. Pointed out by David Brownell. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTEC

[PATCH] AT91: MACB support

2007-02-07 Thread Haavard Skinnemoen
le bit. Original patch from Patrice Vilchez. Signed-off-by: Andrew Victor <[EMAIL PROTECTED]> Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- drivers/net/Kconfig |2 +- drivers/net/macb.c | 25 +++-- drivers/net/macb.h |8 +++- 3 files changed, 3

[PATCH] MACB: Use __raw register access

2006-12-08 Thread Haavard Skinnemoen
Since macb is a chip-internal device, use __raw_readl and __raw_writel instead of readl/writel. This will perform native-endian accesses, which is the right thing to do on both AVR32 and ARM devices. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- drivers/net/macb.c |2 +- d

[PATCH] MACB: Use struct delayed_work instead of struct work_struct

2006-12-08 Thread Haavard Skinnemoen
The macb driver calls schedule_delayed_work() and friends, so we need to use a struct delayed_work along with it. The conversion was explained by David Howells on lkml Dec 5 2006: http://lkml.org/lkml/2006/12/5/269 Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- drivers/net/

[PATCH take 2] Atmel MACB ethernet driver

2006-11-09 Thread Haavard Skinnemoen
of depending on platform_data. * Set MII/RMII mode correctly. These changes are mostly about making the driver more compatible with the at91 infrastructure. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- MAINTAINERS |7 + drivers/net/Kconfig | 11 + drivers/net/Make